)]}'
{"id":"openocd~master~I7e007addbb5c6e90303e4e8c110c7d27810fbe9c","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001651":{"account":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"last_update":"2021-09-25 13:11:41.000000000","reason":"Change was submitted"},"1001824":{"account":{"_account_id":1001824,"name":"Sylvain Chouleur","email":"sylvain.chouleur@gmail.com","username":"schouleu"},"last_update":"2021-09-25 13:11:41.000000000","reason":"Change was submitted"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2021-09-25 13:11:41.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-09-16 13:11:13.000000000","reason":"Antonio Borneo replied on the change"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-09-25 13:11:41.000000000","reason":"Change was submitted"},"1001726":{"account":{"_account_id":1001726,"name":"Kevin Burke","email":"kevinb@os.amperecomputing.com","username":"kburke-ampere"},"last_update":"2021-09-25 13:11:41.000000000","reason":"Change was submitted"},"1001661":{"account":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"last_update":"2021-09-08 20:26:00.000000000","reason":"Daniel Goehring replied on the change"}},"hashtags":[],"change_id":"I7e007addbb5c6e90303e4e8c110c7d27810fbe9c","subject":"arm_adi_v5: drop ANY_ID from table dap_part_nums","status":"MERGED","created":"2021-08-22 22:44:18.000000000","updated":"2021-09-25 13:11:41.000000000","submitted":"2021-09-25 13:11:41.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6454","meta_rev_id":"52e7eb97e19b421fbdc7bccc6555324ad10216ad","_number":6454,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-25 13:11:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-25 13:11:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-25 13:11:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},{"_account_id":1001824,"name":"Sylvain Chouleur","email":"sylvain.chouleur@gmail.com","username":"schouleu"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001726,"name":"Kevin Burke","email":"kevinb@os.amperecomputing.com","username":"kburke-ampere"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},{"_account_id":1001726,"name":"Kevin Burke","email":"kevinb@os.amperecomputing.com","username":"kburke-ampere"},{"_account_id":1001824,"name":"Sylvain Chouleur","email":"sylvain.chouleur@gmail.com","username":"schouleu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-22 22:44:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001824,"name":"Sylvain Chouleur","email":"sylvain.chouleur@gmail.com","username":"schouleu"},"state":"REVIEWER"},{"updated":"2021-08-22 22:44:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2021-08-22 22:44:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2021-08-22 22:44:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001651,"name":"Florian Fainelli","email":"f.fainelli@gmail.com","username":"ffainelli"},"state":"REVIEWER"},{"updated":"2021-08-22 22:44:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"state":"REVIEWER"},{"updated":"2021-08-22 22:44:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001726,"name":"Kevin Burke","email":"kevinb@os.amperecomputing.com","username":"kburke-ampere"},"state":"REVIEWER"},{"updated":"2021-08-23 01:43:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"46ca13b0227b89a7dff44898d2c486031aba6052","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-22 22:44:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"03bb29ca110c149dbb3cd853c7b3b55e4e3811f2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-23 01:43:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15092/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14319/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a1d60fbcd4989ac49d9fe76ac02254d3305ba45d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-23 10:27:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e2d47c104b8817d77c43fa3c99e5319e99f7ccb5","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2021-09-08 20:26:00.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"039f297cfd614a209b0e9f7030fb5716bf505dd8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-15 22:05:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8088b34e7617dbe4671ad69b1defcbb8d03ad626","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-16 00:19:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15239/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14463/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5231aff3ab8a2dc320a6493286272c2084055638","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2021-09-16 00:54:25.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"42346232bc556e578917868a72bc8cab5a170722","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-16 13:11:13.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"a8e68745d0b41db2f01b069a8b89d4b20f022924","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-25 13:11:38.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"52e7eb97e19b421fbdc7bccc6555324ad10216ad","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-25 13:11:41.000000000","message":"Change has been successfully cherry-picked as 2a43137619e384bee38ea58d817a0d15876d2473","accounts_in_message":[],"_revision_number":3}],"current_revision":"2a43137619e384bee38ea58d817a0d15876d2473","revisions":{"da1d8e1a67c36c479a37560e9e8689a64033b8a4":{"kind":"REWORK","_number":2,"created":"2021-09-15 22:05:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/6454/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/6454/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/2 \u0026\u0026 git checkout -b change-6454 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/6454/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb1102fdd074eee6e7b5c07caffa4ec8f16a5567","subject":"arm_adi_v5: add arm Neoverse N2 part numbers"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-20 22:35:32.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-15 22:02:45.000000000","tz":120},"subject":"arm_adi_v5: drop ANY_ID from table dap_part_nums","message":"arm_adi_v5: drop ANY_ID from table dap_part_nums\n\nThe initial version of the table dap_part_nums contains only the\npart number of the device and not the manufacturer ID.\nThis causes collisions between devices with same part number but\nfrom different manufacturer.\nThe table has been extended to include the manufacturer JEDEC code\nin commit 2f131d3c3004 (\"ARM ADIv5: CoreSight ROM decode part\nnumber and designer id\").\nFor two old/legacy table\u0027s entries reported without manufacturer\ncode it was defined a special ANY_ID manufacturer, meaning skip\nthe check for manufacturer!\nThe two legacy entries report the comment \"from OMAP3 memmap\", and\nthanks to the associated string has been possible through Google\nto identify a Master Report [1] about using OpenOCD with the OMAP3\nin a BeagleBoard. The ROM table is printed with OpenOCD command\n\"dap info 1\" at page 8 and reports the Peripheral ID required to\nextract the manufacturer ID that, out of any surprise, belong to\nTexas Instruments.\n\nSet the two missing manufacturer ID to Texas Instruments JEDEC\ncode.\n\nRemove the now redundant definition and use of ANY_ID.\n\nWhile revisiting this old code, remove also the useless comment\n\"0x113: what?\". It was introduced in commit ddade10d4a93 (\"ARM\nADIv5: \"dap info\" gets more readable\") and from the same dump in\n[1] it\u0027s clearly another element in OMAP3. It is listed as entry\n0x8 in the ROM table and there is no further info available.\nOpenOCD will anyway list it as:\n\tDesigner is 0x017, Texas Instruments\n\tPart is 0x113, Unrecognized\nAnother link https://elinux.org/BeagleBoardOpenOCD reports the\ntext \"Part number 0x113: This is ????\", which sounds familiar!\nNo public document from Texas Instruments reports what is this\ndevice at address 0x54012000.\n\n[1] Warren Clay Grant - University of Texas at Austin\n    \"Implementation of an Open Source JTAG Debugging Development\n    Chain for the BeagleBoard ARM® Cortex A-8\" - May 2012\nLink: https://repositories.lib.utexas.edu/bitstream/handle/2152/ETD-UT-2012-05-5478/GRANT-MASTERS-REPORT.pdf\n\nChange-Id: I7e007addbb5c6e90303e4e8c110c7d27810fbe9c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"2a43137619e384bee38ea58d817a0d15876d2473":{"kind":"REWORK","_number":3,"created":"2021-09-25 13:11:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/6454/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/6454/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/3 \u0026\u0026 git checkout -b change-6454 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/6454/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"122f36ed7b6bb0ddbf72cd6cf4c1058afc32a837","subject":"arm_adi_v5: add arm Neoverse N2 part numbers"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-20 22:35:32.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-25 13:11:41.000000000","tz":0},"subject":"arm_adi_v5: drop ANY_ID from table dap_part_nums","message":"arm_adi_v5: drop ANY_ID from table dap_part_nums\n\nThe initial version of the table dap_part_nums contains only the\npart number of the device and not the manufacturer ID.\nThis causes collisions between devices with same part number but\nfrom different manufacturer.\nThe table has been extended to include the manufacturer JEDEC code\nin commit 2f131d3c3004 (\"ARM ADIv5: CoreSight ROM decode part\nnumber and designer id\").\nFor two old/legacy table\u0027s entries reported without manufacturer\ncode it was defined a special ANY_ID manufacturer, meaning skip\nthe check for manufacturer!\nThe two legacy entries report the comment \"from OMAP3 memmap\", and\nthanks to the associated string has been possible through Google\nto identify a Master Report [1] about using OpenOCD with the OMAP3\nin a BeagleBoard. The ROM table is printed with OpenOCD command\n\"dap info 1\" at page 8 and reports the Peripheral ID required to\nextract the manufacturer ID that, out of any surprise, belong to\nTexas Instruments.\n\nSet the two missing manufacturer ID to Texas Instruments JEDEC\ncode.\n\nRemove the now redundant definition and use of ANY_ID.\n\nWhile revisiting this old code, remove also the useless comment\n\"0x113: what?\". It was introduced in commit ddade10d4a93 (\"ARM\nADIv5: \"dap info\" gets more readable\") and from the same dump in\n[1] it\u0027s clearly another element in OMAP3. It is listed as entry\n0x8 in the ROM table and there is no further info available.\nOpenOCD will anyway list it as:\n\tDesigner is 0x017, Texas Instruments\n\tPart is 0x113, Unrecognized\nAnother link https://elinux.org/BeagleBoardOpenOCD reports the\ntext \"Part number 0x113: This is ????\", which sounds familiar!\nNo public document from Texas Instruments reports what is this\ndevice at address 0x54012000.\n\n[1] Warren Clay Grant - University of Texas at Austin\n    \"Implementation of an Open Source JTAG Debugging Development\n    Chain for the BeagleBoard ARM® Cortex A-8\" - May 2012\nLink: https://repositories.lib.utexas.edu/bitstream/handle/2152/ETD-UT-2012-05-5478/GRANT-MASTERS-REPORT.pdf\n\nChange-Id: I7e007addbb5c6e90303e4e8c110c7d27810fbe9c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6454\nTested-by: jenkins\nReviewed-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\n"}},"62a78aa56d445c587db1f4d26b08bc8741fd424a":{"kind":"REWORK","_number":1,"created":"2021-08-22 22:44:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/6454/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/6454/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/1 \u0026\u0026 git checkout -b change-6454 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/6454/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/6454/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"809c0ea40fc6b5e7dbfa430ef29eafc1f482630f","subject":"arm_adi_v5: add arm Neoverse N2 part numbers"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-20 22:35:32.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-22 22:40:40.000000000","tz":120},"subject":"arm_adi_v5: drop ANY_ID from table dap_partnums","message":"arm_adi_v5: drop ANY_ID from table dap_partnums\n\nThe initial version of the table dap_partnums contains only the\npart number of the device and not the manufacturer ID.\nThis causes collisions between devices with same part number but\nfrom different manufacturer.\nThe table has been extended to include the manufacturer JEDEC code\nin commit 2f131d3c3004 (\"ARM ADIv5: CoreSight ROM decode part\nnumber and designer id\").\nFor two old/legacy table\u0027s entries reported without manufacturer\ncode it was defined a special ANY_ID manufacturer, meaning skip\nthe check for manufacturer!\nThe two legacy entries report the comment \"from OMAP3 memmap\", and\nthanks to the associated string has been possible through Google\nto identify a Master Report [1] about using OpenOCD with the OMAP3\nin a BeagleBoard. The ROM table is printed with OpenOCD command\n\"dap info 1\" at page 8 and reports the Peripheral ID required to\nextract the manufacturer ID that, out of any surprise, belong to\nTexas Instruments.\n\nSet the two missing manufacturer ID to Texas Instruments JEDEC\ncode.\n\nRemove the now redundant definition and use of ANY_ID.\n\nWhile revisiting this old code, remove also the useless comment\n\"0x113: what?\". It was introduced in commit ddade10d4a93 (\"ARM\nADIv5: \"dap info\" gets more readable\") and from the same dump in\n[1] it\u0027s clearly another element in OMAP3. It is listed as entry\n0x8 in the ROM table and there is no further info available.\nOpenOCD will anyway list it as:\n\tDesigner is 0x017, Texas Instruments\n\tPart is 0x113, Unrecognized\nAnother link https://elinux.org/BeagleBoardOpenOCD reports the\ntext \"Part number 0x113: This is ????\", which sounds familiar!\nNo public document from Texas Instruments reports what is this\ndevice at address 0x54012000.\n\n[1] Warren Clay Grant - University of Texas at Austin\n    \"Implementation of an Open Source JTAG Debugging Development\n    Chain for the BeagleBoard ARM® Cortex A-8\" - May 2012\nLink: https://repositories.lib.utexas.edu/bitstream/handle/2152/ETD-UT-2012-05-5478/GRANT-MASTERS-REPORT.pdf\n\nChange-Id: I7e007addbb5c6e90303e4e8c110c7d27810fbe9c\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}