)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"4de9358a6527536c2de15c40598f18aaada76357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cab2cbfc_73f79f1f","updated":"2021-10-08 20:53:44.000000000","message":"A few more comments to address issues that came up during testing.","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"7418ae750f851af6f9a5a262d6ddd7cf087bfccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d34b7c1_f2e6fd87","updated":"2021-10-06 22:59:25.000000000","message":"Initial review comments...","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf1829b1_9884885d","updated":"2021-10-12 22:00:10.000000000","message":"Thank for the review. I will send a v2","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"e35ed892a92bc90f86f78da9e16842afcb7908fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"52f84aeb_cf7dc9bf","updated":"2022-06-13 21:05:48.000000000","message":"Resolving remaining comments.","commit_id":"76ff6d5bf81e2898d74794dbd1317b894844e649"}],"doc/openocd.texi":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"7418ae750f851af6f9a5a262d6ddd7cf087bfccb","unresolved":true,"context_lines":[{"line_number":4404,"context_line":"@deffn {Command} {dap info} [num]"},{"line_number":4405,"context_line":"Displays the ROM table for MEM-AP @var{num},"},{"line_number":4406,"context_line":"defaulting to the currently selected AP of the currently selected target."},{"line_number":4407,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4408,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4409,"context_line":"@end deffn"},{"line_number":4410,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"9a6a939c_dd7ac1c4","line":4407,"range":{"start_line":4407,"start_character":18,"end_line":4407,"end_character":21},"updated":"2021-10-06 22:59:25.000000000","message":"num?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":4404,"context_line":"@deffn {Command} {dap info} [num]"},{"line_number":4405,"context_line":"Displays the ROM table for MEM-AP @var{num},"},{"line_number":4406,"context_line":"defaulting to the currently selected AP of the currently selected target."},{"line_number":4407,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4408,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4409,"context_line":"@end deffn"},{"line_number":4410,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"715ab8bf_e57ed13f","line":4407,"range":{"start_line":4407,"start_character":18,"end_line":4407,"end_character":21},"in_reply_to":"9a6a939c_dd7ac1c4","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"7418ae750f851af6f9a5a262d6ddd7cf087bfccb","unresolved":true,"context_lines":[{"line_number":4419,"context_line":"@deffn {Command} {$dap_name info} [num]"},{"line_number":4420,"context_line":"Displays the ROM table for MEM-AP @var{num},"},{"line_number":4421,"context_line":"defaulting to the currently selected AP."},{"line_number":4422,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4423,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4424,"context_line":"@end deffn"},{"line_number":4425,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"d7203315_ad0740e4","line":4422,"range":{"start_line":4422,"start_character":18,"end_line":4422,"end_character":21},"updated":"2021-10-06 22:59:25.000000000","message":"num?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":4419,"context_line":"@deffn {Command} {$dap_name info} [num]"},{"line_number":4420,"context_line":"Displays the ROM table for MEM-AP @var{num},"},{"line_number":4421,"context_line":"defaulting to the currently selected AP."},{"line_number":4422,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4423,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4424,"context_line":"@end deffn"},{"line_number":4425,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"a33c0415_50995bad","line":4422,"range":{"start_line":4422,"start_character":18,"end_line":4422,"end_character":21},"in_reply_to":"d7203315_ad0740e4","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"7418ae750f851af6f9a5a262d6ddd7cf087bfccb","unresolved":true,"context_lines":[{"line_number":4425,"context_line":""},{"line_number":4426,"context_line":"@deffn {Command} {$dap_name apid} [num]"},{"line_number":4427,"context_line":"Displays ID register from AP @var{num}, defaulting to the currently selected AP."},{"line_number":4428,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4429,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4430,"context_line":"@end deffn"},{"line_number":4431,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"5e37ec86_d2c047bb","line":4428,"range":{"start_line":4428,"start_character":18,"end_line":4428,"end_character":21},"updated":"2021-10-06 22:59:25.000000000","message":"num?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":4425,"context_line":""},{"line_number":4426,"context_line":"@deffn {Command} {$dap_name apid} [num]"},{"line_number":4427,"context_line":"Displays ID register from AP @var{num}, defaulting to the currently selected AP."},{"line_number":4428,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4429,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4430,"context_line":"@end deffn"},{"line_number":4431,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"393527a0_2a71a3a1","line":4428,"range":{"start_line":4428,"start_character":18,"end_line":4428,"end_character":21},"in_reply_to":"5e37ec86_d2c047bb","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"7418ae750f851af6f9a5a262d6ddd7cf087bfccb","unresolved":true,"context_lines":[{"line_number":4433,"context_line":"@deffn {Command} {$dap_name apreg} ap_num reg [value]"},{"line_number":4434,"context_line":"Displays content of a register @var{reg} from AP @var{ap_num}"},{"line_number":4435,"context_line":"or set a new value @var{value}."},{"line_number":4436,"context_line":"On ADIv5 DAP @var{ap_nun} is the numeric index of the AP."},{"line_number":4437,"context_line":"On ADIv6 DAP @var{ap_num} is the base address of the AP."},{"line_number":4438,"context_line":"@var{reg} is byte address of a word register, 0, 4, 8 ... 0xfc."},{"line_number":4439,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"5722b8a5_2eb2860c","line":4436,"range":{"start_line":4436,"start_character":18,"end_line":4436,"end_character":24},"updated":"2021-10-06 22:59:25.000000000","message":"ap_num?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":4433,"context_line":"@deffn {Command} {$dap_name apreg} ap_num reg [value]"},{"line_number":4434,"context_line":"Displays content of a register @var{reg} from AP @var{ap_num}"},{"line_number":4435,"context_line":"or set a new value @var{value}."},{"line_number":4436,"context_line":"On ADIv5 DAP @var{ap_nun} is the numeric index of the AP."},{"line_number":4437,"context_line":"On ADIv6 DAP @var{ap_num} is the base address of the AP."},{"line_number":4438,"context_line":"@var{reg} is byte address of a word register, 0, 4, 8 ... 0xfc."},{"line_number":4439,"context_line":"@end deffn"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"4f239d53_36b7af38","line":4436,"range":{"start_line":4436,"start_character":18,"end_line":4436,"end_character":24},"in_reply_to":"5722b8a5_2eb2860c","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"7418ae750f851af6f9a5a262d6ddd7cf087bfccb","unresolved":true,"context_lines":[{"line_number":4440,"context_line":""},{"line_number":4441,"context_line":"@deffn {Command} {$dap_name apsel} [num]"},{"line_number":4442,"context_line":"Select AP @var{num}, defaulting to 0."},{"line_number":4443,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4444,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4445,"context_line":"@end deffn"},{"line_number":4446,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"62a112c6_2ec37d90","line":4443,"range":{"start_line":4443,"start_character":18,"end_line":4443,"end_character":21},"updated":"2021-10-06 22:59:25.000000000","message":"num?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":4440,"context_line":""},{"line_number":4441,"context_line":"@deffn {Command} {$dap_name apsel} [num]"},{"line_number":4442,"context_line":"Select AP @var{num}, defaulting to 0."},{"line_number":4443,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4444,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4445,"context_line":"@end deffn"},{"line_number":4446,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"d9026aa0_e5e1f917","line":4443,"range":{"start_line":4443,"start_character":18,"end_line":4443,"end_character":21},"in_reply_to":"62a112c6_2ec37d90","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"7418ae750f851af6f9a5a262d6ddd7cf087bfccb","unresolved":true,"context_lines":[{"line_number":4459,"context_line":"@deffn {Command} {$dap_name baseaddr} [num]"},{"line_number":4460,"context_line":"Displays debug base address from MEM-AP @var{num},"},{"line_number":4461,"context_line":"defaulting to the currently selected AP."},{"line_number":4462,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4463,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4464,"context_line":"@end deffn"},{"line_number":4465,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"c2b2ebe0_b3144cd9","line":4462,"range":{"start_line":4462,"start_character":18,"end_line":4462,"end_character":21},"updated":"2021-10-06 22:59:25.000000000","message":"num?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":4459,"context_line":"@deffn {Command} {$dap_name baseaddr} [num]"},{"line_number":4460,"context_line":"Displays debug base address from MEM-AP @var{num},"},{"line_number":4461,"context_line":"defaulting to the currently selected AP."},{"line_number":4462,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4463,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4464,"context_line":"@end deffn"},{"line_number":4465,"context_line":""}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"b0d629f8_1f2f03a5","line":4462,"range":{"start_line":4462,"start_character":18,"end_line":4462,"end_character":21},"in_reply_to":"c2b2ebe0_b3144cd9","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"}],"src/target/arm_adi_v5.c":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"7418ae750f851af6f9a5a262d6ddd7cf087bfccb","unresolved":true,"context_lines":[{"line_number":995,"context_line":"\t\treturn NULL;"},{"line_number":996,"context_line":"\t}"},{"line_number":997,"context_line":"\tif (is_adiv6(dap)) {"},{"line_number":998,"context_line":"\t\tfor (unsigned int i \u003d 0; i \u003c\u003d DP_APSEL_MAX; i++) {"},{"line_number":999,"context_line":"\t\t\tstruct adiv5_ap *ap \u003d \u0026dap-\u003eap[i];"},{"line_number":1000,"context_line":"\t\t\tif (ap-\u003erefcount \u0026\u0026 ap-\u003eap_num \u003d\u003d ap_num) {"},{"line_number":1001,"context_line":"\t\t\t\tap-\u003erefcount +\u003d 2;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"13c44a96_0297458d","line":998,"range":{"start_line":998,"start_character":32,"end_line":998,"end_character":44},"updated":"2021-10-06 22:59:25.000000000","message":"Does there need to be a distinction between the DP_APSEL_MAX value used for ADIv6 and ADIv5? For example, in the future if the AP array size needs to be increased for ADIv6 usage, the DP_APSEL_MAX value would increase to match the desired array size. But for ADIv5, DP_APSEL_MAX needs to be kept at 255.\n\nIf you want to leave it as is and worry about it later if the situation ever arises, that is fine with me.","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"e35ed892a92bc90f86f78da9e16842afcb7908fb","unresolved":false,"context_lines":[{"line_number":995,"context_line":"\t\treturn NULL;"},{"line_number":996,"context_line":"\t}"},{"line_number":997,"context_line":"\tif (is_adiv6(dap)) {"},{"line_number":998,"context_line":"\t\tfor (unsigned int i \u003d 0; i \u003c\u003d DP_APSEL_MAX; i++) {"},{"line_number":999,"context_line":"\t\t\tstruct adiv5_ap *ap \u003d \u0026dap-\u003eap[i];"},{"line_number":1000,"context_line":"\t\t\tif (ap-\u003erefcount \u0026\u0026 ap-\u003eap_num \u003d\u003d ap_num) {"},{"line_number":1001,"context_line":"\t\t\t\tap-\u003erefcount +\u003d 2;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f0f75266_2617a1d6","line":998,"range":{"start_line":998,"start_character":32,"end_line":998,"end_character":44},"in_reply_to":"122791bc_8dbead30","updated":"2022-06-13 21:05:48.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":true,"context_lines":[{"line_number":995,"context_line":"\t\treturn NULL;"},{"line_number":996,"context_line":"\t}"},{"line_number":997,"context_line":"\tif (is_adiv6(dap)) {"},{"line_number":998,"context_line":"\t\tfor (unsigned int i \u003d 0; i \u003c\u003d DP_APSEL_MAX; i++) {"},{"line_number":999,"context_line":"\t\t\tstruct adiv5_ap *ap \u003d \u0026dap-\u003eap[i];"},{"line_number":1000,"context_line":"\t\t\tif (ap-\u003erefcount \u0026\u0026 ap-\u003eap_num \u003d\u003d ap_num) {"},{"line_number":1001,"context_line":"\t\t\t\tap-\u003erefcount +\u003d 2;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"122791bc_8dbead30","line":998,"range":{"start_line":998,"start_character":32,"end_line":998,"end_character":44},"in_reply_to":"13c44a96_0297458d","updated":"2021-10-12 22:00:10.000000000","message":"Maybe can stay like this until we would need to manage more than 256 APs. Anyway I prefer keeping it for the moment.\nI would give priority to replace all the ap_num and \"AP number\"","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"7418ae750f851af6f9a5a262d6ddd7cf087bfccb","unresolved":true,"context_lines":[{"line_number":1002,"context_line":"\t\t\t\treturn ap;"},{"line_number":1003,"context_line":"\t\t\t}"},{"line_number":1004,"context_line":"\t\t}"},{"line_number":1005,"context_line":"\t\tfor (unsigned int i \u003d 0; i \u003c\u003d DP_APSEL_MAX; i++) {"},{"line_number":1006,"context_line":"\t\t\tstruct adiv5_ap *ap \u003d \u0026dap-\u003eap[i];"},{"line_number":1007,"context_line":"\t\t\tif (ap-\u003erefcount \u003d\u003d 0) {"},{"line_number":1008,"context_line":"\t\t\t\tap-\u003eap_num \u003d ap_num;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ddd8c5f7_3f5c6111","line":1005,"range":{"start_line":1005,"start_character":32,"end_line":1005,"end_character":44},"updated":"2021-10-06 22:59:25.000000000","message":"same here.","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"e35ed892a92bc90f86f78da9e16842afcb7908fb","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"\t\t\t\treturn ap;"},{"line_number":1003,"context_line":"\t\t\t}"},{"line_number":1004,"context_line":"\t\t}"},{"line_number":1005,"context_line":"\t\tfor (unsigned int i \u003d 0; i \u003c\u003d DP_APSEL_MAX; i++) {"},{"line_number":1006,"context_line":"\t\t\tstruct adiv5_ap *ap \u003d \u0026dap-\u003eap[i];"},{"line_number":1007,"context_line":"\t\t\tif (ap-\u003erefcount \u003d\u003d 0) {"},{"line_number":1008,"context_line":"\t\t\t\tap-\u003eap_num \u003d ap_num;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1db6c528_fcb922c7","line":1005,"range":{"start_line":1005,"start_character":32,"end_line":1005,"end_character":44},"in_reply_to":"ddd8c5f7_3f5c6111","updated":"2022-06-13 21:05:48.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"4de9358a6527536c2de15c40598f18aaada76357","unresolved":true,"context_lines":[{"line_number":1967,"context_line":"COMMAND_HANDLER(dap_apsel_command)"},{"line_number":1968,"context_line":"{"},{"line_number":1969,"context_line":"\tstruct adiv5_dap *dap \u003d adiv5_get_dap(CMD_DATA);"},{"line_number":1970,"context_line":"\tuint32_t apsel;"},{"line_number":1971,"context_line":""},{"line_number":1972,"context_line":"\tswitch (CMD_ARGC) {"},{"line_number":1973,"context_line":"\tcase 0:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ee944398_5e9c5cf1","line":1970,"range":{"start_line":1970,"start_character":1,"end_line":1970,"end_character":9},"updated":"2021-10-08 20:53:44.000000000","message":"uint64_t since apsel now represents a 64-bit address?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":1967,"context_line":"COMMAND_HANDLER(dap_apsel_command)"},{"line_number":1968,"context_line":"{"},{"line_number":1969,"context_line":"\tstruct adiv5_dap *dap \u003d adiv5_get_dap(CMD_DATA);"},{"line_number":1970,"context_line":"\tuint32_t apsel;"},{"line_number":1971,"context_line":""},{"line_number":1972,"context_line":"\tswitch (CMD_ARGC) {"},{"line_number":1973,"context_line":"\tcase 0:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4645a468_9c9313e7","line":1970,"range":{"start_line":1970,"start_character":1,"end_line":1970,"end_character":9},"in_reply_to":"ee944398_5e9c5cf1","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"4de9358a6527536c2de15c40598f18aaada76357","unresolved":true,"context_lines":[{"line_number":1971,"context_line":""},{"line_number":1972,"context_line":"\tswitch (CMD_ARGC) {"},{"line_number":1973,"context_line":"\tcase 0:"},{"line_number":1974,"context_line":"\t\tcommand_print(CMD, \"%\" PRIu32, dap-\u003eapsel);"},{"line_number":1975,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1976,"context_line":"\tcase 1:"},{"line_number":1977,"context_line":"\t\tCOMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], apsel);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3954f08c_878b71fa","line":1974,"range":{"start_line":1974,"start_character":21,"end_line":1974,"end_character":31},"updated":"2021-10-08 20:53:44.000000000","message":"\"0x%\" PRIx64 ?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":1971,"context_line":""},{"line_number":1972,"context_line":"\tswitch (CMD_ARGC) {"},{"line_number":1973,"context_line":"\tcase 0:"},{"line_number":1974,"context_line":"\t\tcommand_print(CMD, \"%\" PRIu32, dap-\u003eapsel);"},{"line_number":1975,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1976,"context_line":"\tcase 1:"},{"line_number":1977,"context_line":"\t\tCOMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], apsel);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"93a71f97_cf80b2d6","line":1974,"range":{"start_line":1974,"start_character":21,"end_line":1974,"end_character":31},"in_reply_to":"3954f08c_878b71fa","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"4de9358a6527536c2de15c40598f18aaada76357","unresolved":true,"context_lines":[{"line_number":1974,"context_line":"\t\tcommand_print(CMD, \"%\" PRIu32, dap-\u003eapsel);"},{"line_number":1975,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1976,"context_line":"\tcase 1:"},{"line_number":1977,"context_line":"\t\tCOMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], apsel);"},{"line_number":1978,"context_line":"\t\t/* AP address is in bits 31:24 of DP_SELECT */"},{"line_number":1979,"context_line":"\t\tif (apsel \u003e DP_APSEL_MAX) {"},{"line_number":1980,"context_line":"\t\t\tcommand_print(CMD, \"Invalid AP number\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"07c4f94e_bfbed9d2","line":1977,"range":{"start_line":1977,"start_character":23,"end_line":1977,"end_character":26},"updated":"2021-10-08 20:53:44.000000000","message":"u64 ?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":1974,"context_line":"\t\tcommand_print(CMD, \"%\" PRIu32, dap-\u003eapsel);"},{"line_number":1975,"context_line":"\t\treturn ERROR_OK;"},{"line_number":1976,"context_line":"\tcase 1:"},{"line_number":1977,"context_line":"\t\tCOMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], apsel);"},{"line_number":1978,"context_line":"\t\t/* AP address is in bits 31:24 of DP_SELECT */"},{"line_number":1979,"context_line":"\t\tif (apsel \u003e DP_APSEL_MAX) {"},{"line_number":1980,"context_line":"\t\t\tcommand_print(CMD, \"Invalid AP number\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3c321412_dc47ecc7","line":1977,"range":{"start_line":1977,"start_character":23,"end_line":1977,"end_character":26},"in_reply_to":"07c4f94e_bfbed9d2","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"4de9358a6527536c2de15c40598f18aaada76357","unresolved":true,"context_lines":[{"line_number":1976,"context_line":"\tcase 1:"},{"line_number":1977,"context_line":"\t\tCOMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], apsel);"},{"line_number":1978,"context_line":"\t\t/* AP address is in bits 31:24 of DP_SELECT */"},{"line_number":1979,"context_line":"\t\tif (apsel \u003e DP_APSEL_MAX) {"},{"line_number":1980,"context_line":"\t\t\tcommand_print(CMD, \"Invalid AP number\");"},{"line_number":1981,"context_line":"\t\t\treturn ERROR_COMMAND_ARGUMENT_INVALID;"},{"line_number":1982,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c54d1b6b_37ebd619","line":1979,"range":{"start_line":1979,"start_character":2,"end_line":1979,"end_character":29},"updated":"2021-10-08 20:53:44.000000000","message":"if (!is_ap_num_valid(dap, apsel)) {","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":1976,"context_line":"\tcase 1:"},{"line_number":1977,"context_line":"\t\tCOMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], apsel);"},{"line_number":1978,"context_line":"\t\t/* AP address is in bits 31:24 of DP_SELECT */"},{"line_number":1979,"context_line":"\t\tif (apsel \u003e DP_APSEL_MAX) {"},{"line_number":1980,"context_line":"\t\t\tcommand_print(CMD, \"Invalid AP number\");"},{"line_number":1981,"context_line":"\t\t\treturn ERROR_COMMAND_ARGUMENT_INVALID;"},{"line_number":1982,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9d41e725_642e3570","line":1979,"range":{"start_line":1979,"start_character":2,"end_line":1979,"end_character":29},"in_reply_to":"c54d1b6b_37ebd619","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"4de9358a6527536c2de15c40598f18aaada76357","unresolved":true,"context_lines":[{"line_number":2002,"context_line":"\t\t\tcommand_print(CMD, \"Cannot get AP\");"},{"line_number":2003,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2004,"context_line":"\t\t}"},{"line_number":2005,"context_line":"\t\tcommand_print(CMD, \"ap %\" PRIu32 \" selected, csw 0x%8.8\" PRIx32,"},{"line_number":2006,"context_line":"\t\t\tdap-\u003eapsel, ap-\u003ecsw_default);"},{"line_number":2007,"context_line":"\t\tbreak;"},{"line_number":2008,"context_line":"\tcase 1:"},{"line_number":2009,"context_line":"\t\tif (strcmp(CMD_ARGV[0], \"default\") \u003d\u003d 0)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3f363e41_95822848","line":2006,"range":{"start_line":2005,"start_character":0,"end_line":2006,"end_character":32},"updated":"2021-10-08 20:53:44.000000000","message":"For ADIv6 AP addresses to print nicer, maybe something like the following...\n\ncommand_print(CMD, \"ap 0x%\" PRIx64 \" selected, csw 0x%8.8\" PRIx32, dap-\u003eapsel, ap-\u003ecsw_default);","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":2002,"context_line":"\t\t\tcommand_print(CMD, \"Cannot get AP\");"},{"line_number":2003,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2004,"context_line":"\t\t}"},{"line_number":2005,"context_line":"\t\tcommand_print(CMD, \"ap %\" PRIu32 \" selected, csw 0x%8.8\" PRIx32,"},{"line_number":2006,"context_line":"\t\t\tdap-\u003eapsel, ap-\u003ecsw_default);"},{"line_number":2007,"context_line":"\t\tbreak;"},{"line_number":2008,"context_line":"\tcase 1:"},{"line_number":2009,"context_line":"\t\tif (strcmp(CMD_ARGV[0], \"default\") \u003d\u003d 0)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"84444e71_7e1d66ef","line":2006,"range":{"start_line":2005,"start_character":0,"end_line":2006,"end_character":32},"in_reply_to":"3f363e41_95822848","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"}],"src/target/arm_adi_v5.h":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"4de9358a6527536c2de15c40598f18aaada76357","unresolved":true,"context_lines":[{"line_number":331,"context_line":"\tstruct adiv5_ap ap[DP_APSEL_MAX + 1];"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"\t/* The current manually selected AP by the \"dap apsel\" command */"},{"line_number":334,"context_line":"\tuint32_t apsel;"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"\t/**"},{"line_number":337,"context_line":"\t * Cache for DP_SELECT register. A value of DP_SELECT_INVALID"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e8d5b65d_ee0758ef","line":334,"range":{"start_line":334,"start_character":1,"end_line":334,"end_character":9},"updated":"2021-10-08 20:53:44.000000000","message":"uint64_t since apnum now represents a 64-bit address?","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3f176b2a2b76e3e3abd4efd9c713c1866306fe0d","unresolved":false,"context_lines":[{"line_number":331,"context_line":"\tstruct adiv5_ap ap[DP_APSEL_MAX + 1];"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"\t/* The current manually selected AP by the \"dap apsel\" command */"},{"line_number":334,"context_line":"\tuint32_t apsel;"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"\t/**"},{"line_number":337,"context_line":"\t * Cache for DP_SELECT register. A value of DP_SELECT_INVALID"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5bb769a5_9592f0b7","line":334,"range":{"start_line":334,"start_character":1,"end_line":334,"end_character":9},"in_reply_to":"e8d5b65d_ee0758ef","updated":"2021-10-12 22:00:10.000000000","message":"Ack","commit_id":"66fc6db81ce5360ee24ca2d1171789c70b09b7bd"}]}