)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"76e6bc30d3fa809b3eaba14466d8874c3c6ce7ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80640444_7c35998d","updated":"2021-10-13 14:47:26.000000000","message":"Code reviewed all files and everything looks good. Tested the updates on silicon and they look good. Just a couple minor comments for consideration.","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"168e8847b05537de3de7831444b4660fe1f14aff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"64680f4c_4ad17578","updated":"2021-10-18 15:20:53.000000000","message":"Comments below...","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"}],"doc/openocd.texi":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"a482883c37060c50d4f38bd23a222f4f49df3936","unresolved":true,"context_lines":[{"line_number":4406,"context_line":"defaulting to the currently selected AP of the currently selected target."},{"line_number":4407,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4408,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4409,"context_line":"With ADIv6 only, @option{root} specifies the root ROM table."},{"line_number":4410,"context_line":"@end deffn"},{"line_number":4411,"context_line":""},{"line_number":4412,"context_line":"@deffn {Command} {dap init}"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"626c0c11_2cda4ac0","line":4409,"range":{"start_line":4409,"start_character":0,"end_line":4409,"end_character":60},"updated":"2021-10-13 15:28:49.000000000","message":"[1]","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"24c2a5ce7d44e3f1a0484cd567e6a907966bc894","unresolved":false,"context_lines":[{"line_number":4406,"context_line":"defaulting to the currently selected AP of the currently selected target."},{"line_number":4407,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4408,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4409,"context_line":"With ADIv6 only, @option{root} specifies the root ROM table."},{"line_number":4410,"context_line":"@end deffn"},{"line_number":4411,"context_line":""},{"line_number":4412,"context_line":"@deffn {Command} {dap init}"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"279acd96_6d105f87","line":4409,"range":{"start_line":4409,"start_character":0,"end_line":4409,"end_character":60},"in_reply_to":"626c0c11_2cda4ac0","updated":"2021-11-10 10:14:24.000000000","message":"Ack","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"a482883c37060c50d4f38bd23a222f4f49df3936","unresolved":true,"context_lines":[{"line_number":4422,"context_line":"defaulting to the currently selected AP."},{"line_number":4423,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4424,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4425,"context_line":"With ADIv6 only, @option{root} specifies the root ROM table."},{"line_number":4426,"context_line":"@end deffn"},{"line_number":4427,"context_line":""},{"line_number":4428,"context_line":"@deffn {Command} {$dap_name apid} [num]"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"5a640e5c_30be37c3","line":4425,"range":{"start_line":4425,"start_character":0,"end_line":4425,"end_character":60},"updated":"2021-10-13 15:28:49.000000000","message":"[2]","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"24c2a5ce7d44e3f1a0484cd567e6a907966bc894","unresolved":false,"context_lines":[{"line_number":4422,"context_line":"defaulting to the currently selected AP."},{"line_number":4423,"context_line":"On ADIv5 DAP @var{nun} is the numeric index of the AP."},{"line_number":4424,"context_line":"On ADIv6 DAP @var{num} is the base address of the AP."},{"line_number":4425,"context_line":"With ADIv6 only, @option{root} specifies the root ROM table."},{"line_number":4426,"context_line":"@end deffn"},{"line_number":4427,"context_line":""},{"line_number":4428,"context_line":"@deffn {Command} {$dap_name apid} [num]"}],"source_content_type":"text/x-texinfo","patch_set":1,"id":"f28a60d4_a7c2684f","line":4425,"range":{"start_line":4425,"start_character":0,"end_line":4425,"end_character":60},"in_reply_to":"5a640e5c_30be37c3","updated":"2021-11-10 10:14:24.000000000","message":"Ack","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"}],"src/target/arm_adi_v5.c":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"76e6bc30d3fa809b3eaba14466d8874c3c6ce7ae","unresolved":true,"context_lines":[{"line_number":2255,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2256,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP \""},{"line_number":2257,"context_line":"\t\t\t\"(default currently selected AP)\","},{"line_number":2258,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":2259,"context_line":"\t},"},{"line_number":2260,"context_line":"\t{"},{"line_number":2261,"context_line":"\t\t.name \u003d \"apsel\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b0000987_7a44bd5a","line":2258,"range":{"start_line":2258,"start_character":22,"end_line":2258,"end_character":28},"updated":"2021-10-13 14:47:26.000000000","message":"May want to mention in \".help\" that the \u0027root\u0027 option is not available for ADIv5.","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5853d00db34a31156d2bfb3a9628d2c38a6b5b66","unresolved":true,"context_lines":[{"line_number":2255,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2256,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP \""},{"line_number":2257,"context_line":"\t\t\t\"(default currently selected AP)\","},{"line_number":2258,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":2259,"context_line":"\t},"},{"line_number":2260,"context_line":"\t{"},{"line_number":2261,"context_line":"\t\t.name \u003d \"apsel\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e07b3fa4_56642ed0","line":2258,"range":{"start_line":2258,"start_character":22,"end_line":2258,"end_character":28},"in_reply_to":"21d5e699_3db93221","updated":"2021-10-13 21:01:13.000000000","message":"What about:\n\"display the ROM table for specified MEM-AP (default currently selected AP) or the ADIv6 root ROM table\"","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"e0b42b5988da811a6387e3be0bca00f85ce9e612","unresolved":true,"context_lines":[{"line_number":2255,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2256,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP \""},{"line_number":2257,"context_line":"\t\t\t\"(default currently selected AP)\","},{"line_number":2258,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":2259,"context_line":"\t},"},{"line_number":2260,"context_line":"\t{"},{"line_number":2261,"context_line":"\t\t.name \u003d \"apsel\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"21d5e699_3db93221","line":2258,"range":{"start_line":2258,"start_character":22,"end_line":2258,"end_character":28},"in_reply_to":"6985ed87_a0a4b809","updated":"2021-10-13 16:55:33.000000000","message":"While it\u0027s mentioned in the user guide/documentation, I thought it would be nice to include it in the application help section as well.","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"24c2a5ce7d44e3f1a0484cd567e6a907966bc894","unresolved":false,"context_lines":[{"line_number":2255,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2256,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP \""},{"line_number":2257,"context_line":"\t\t\t\"(default currently selected AP)\","},{"line_number":2258,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":2259,"context_line":"\t},"},{"line_number":2260,"context_line":"\t{"},{"line_number":2261,"context_line":"\t\t.name \u003d \"apsel\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b588dcf7_f1e0353d","line":2258,"range":{"start_line":2258,"start_character":22,"end_line":2258,"end_character":28},"in_reply_to":"8ad60abf_c7d60ec8","updated":"2021-11-10 10:14:24.000000000","message":"Done","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"a482883c37060c50d4f38bd23a222f4f49df3936","unresolved":true,"context_lines":[{"line_number":2255,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2256,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP \""},{"line_number":2257,"context_line":"\t\t\t\"(default currently selected AP)\","},{"line_number":2258,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":2259,"context_line":"\t},"},{"line_number":2260,"context_line":"\t{"},{"line_number":2261,"context_line":"\t\t.name \u003d \"apsel\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6985ed87_a0a4b809","line":2258,"range":{"start_line":2258,"start_character":22,"end_line":2258,"end_character":28},"in_reply_to":"b0000987_7a44bd5a","updated":"2021-10-13 15:28:49.000000000","message":"please check [2]","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"168e8847b05537de3de7831444b4660fe1f14aff","unresolved":true,"context_lines":[{"line_number":2255,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":2256,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP \""},{"line_number":2257,"context_line":"\t\t\t\"(default currently selected AP)\","},{"line_number":2258,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":2259,"context_line":"\t},"},{"line_number":2260,"context_line":"\t{"},{"line_number":2261,"context_line":"\t\t.name \u003d \"apsel\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8ad60abf_c7d60ec8","line":2258,"range":{"start_line":2258,"start_character":22,"end_line":2258,"end_character":28},"in_reply_to":"e07b3fa4_56642ed0","updated":"2021-10-18 15:20:53.000000000","message":"Yes, this update works for me.","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"}],"src/target/arm_dap.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5853d00db34a31156d2bfb3a9628d2c38a6b5b66","unresolved":true,"context_lines":[{"line_number":365,"context_line":"\t\t\tapsel \u003d dap-\u003eapsel;"},{"line_number":366,"context_line":"\t\t\tbreak;"},{"line_number":367,"context_line":"\t\tcase 1:"},{"line_number":368,"context_line":"\t\t\tif (is_adiv6(dap) \u0026\u0026 !strcmp(CMD_ARGV[0], \"root\")) {"},{"line_number":369,"context_line":"\t\t\t\tint retval \u003d adiv6_dap_read_baseptr(CMD, dap, \u0026apsel);"},{"line_number":370,"context_line":"\t\t\t\tif (retval !\u003d ERROR_OK) {"},{"line_number":371,"context_line":"\t\t\t\t\tcommand_print(CMD, \"Failed reading DAP baseptr\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e1187706_2adc6694","line":368,"updated":"2021-10-13 21:01:13.000000000","message":"Maybe the code should be changed to always accept \"root\", but log error if \"root\" is used on adiv5","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"24c2a5ce7d44e3f1a0484cd567e6a907966bc894","unresolved":false,"context_lines":[{"line_number":365,"context_line":"\t\t\tapsel \u003d dap-\u003eapsel;"},{"line_number":366,"context_line":"\t\t\tbreak;"},{"line_number":367,"context_line":"\t\tcase 1:"},{"line_number":368,"context_line":"\t\t\tif (is_adiv6(dap) \u0026\u0026 !strcmp(CMD_ARGV[0], \"root\")) {"},{"line_number":369,"context_line":"\t\t\t\tint retval \u003d adiv6_dap_read_baseptr(CMD, dap, \u0026apsel);"},{"line_number":370,"context_line":"\t\t\t\tif (retval !\u003d ERROR_OK) {"},{"line_number":371,"context_line":"\t\t\t\t\tcommand_print(CMD, \"Failed reading DAP baseptr\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0d8d4d52_17a56b38","line":368,"in_reply_to":"480a53bb_087de67d","updated":"2021-11-10 10:14:24.000000000","message":"Done","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"168e8847b05537de3de7831444b4660fe1f14aff","unresolved":true,"context_lines":[{"line_number":365,"context_line":"\t\t\tapsel \u003d dap-\u003eapsel;"},{"line_number":366,"context_line":"\t\t\tbreak;"},{"line_number":367,"context_line":"\t\tcase 1:"},{"line_number":368,"context_line":"\t\t\tif (is_adiv6(dap) \u0026\u0026 !strcmp(CMD_ARGV[0], \"root\")) {"},{"line_number":369,"context_line":"\t\t\t\tint retval \u003d adiv6_dap_read_baseptr(CMD, dap, \u0026apsel);"},{"line_number":370,"context_line":"\t\t\t\tif (retval !\u003d ERROR_OK) {"},{"line_number":371,"context_line":"\t\t\t\t\tcommand_print(CMD, \"Failed reading DAP baseptr\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"480a53bb_087de67d","line":368,"in_reply_to":"e1187706_2adc6694","updated":"2021-10-18 15:20:53.000000000","message":"Yes, I think that makes it clearer to the user as to why the error occurred.\n\nFor example, the following commands executed on an ADIv5 DAP show the confusion I want to avoid...\n\n\u003e\u003e help dap info\n  dap info [ap_num | \u0027root\u0027]\n        display ROM table for MEM-AP of current target (default currently\n        selected AP)\n\n\u003e\u003e dap info root\n  Invalid command argument\n  apsel option value (\u0027root\u0027) is not valid\n\nWhen \"dap info root\" is executed and the selected DAP is ADIv5, the \"dap info\" command treats the \"root\" argument as the ap_num/apsel option value.","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"76e6bc30d3fa809b3eaba14466d8874c3c6ce7ae","unresolved":true,"context_lines":[{"line_number":419,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":420,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP of current target \""},{"line_number":421,"context_line":"\t\t\"(default currently selected AP)\","},{"line_number":422,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":423,"context_line":"\t},"},{"line_number":424,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":425,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3a30fe16_3942b0fe","line":422,"range":{"start_line":422,"start_character":22,"end_line":422,"end_character":28},"updated":"2021-10-13 14:47:26.000000000","message":"May want to mention in \".help\" that the \u0027root\u0027 option is not available for ADIv5.","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"a482883c37060c50d4f38bd23a222f4f49df3936","unresolved":true,"context_lines":[{"line_number":419,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":420,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP of current target \""},{"line_number":421,"context_line":"\t\t\"(default currently selected AP)\","},{"line_number":422,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":423,"context_line":"\t},"},{"line_number":424,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":425,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ffbed146_aeb7a0e0","line":422,"range":{"start_line":422,"start_character":22,"end_line":422,"end_character":28},"in_reply_to":"3a30fe16_3942b0fe","updated":"2021-10-13 15:28:49.000000000","message":"please check [1]","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"24c2a5ce7d44e3f1a0484cd567e6a907966bc894","unresolved":false,"context_lines":[{"line_number":419,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":420,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP of current target \""},{"line_number":421,"context_line":"\t\t\"(default currently selected AP)\","},{"line_number":422,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":423,"context_line":"\t},"},{"line_number":424,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":425,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"91355682_6d6da292","line":422,"range":{"start_line":422,"start_character":22,"end_line":422,"end_character":28},"in_reply_to":"fba7cd57_0148e308","updated":"2021-11-10 10:14:24.000000000","message":"Done","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"},{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"e0b42b5988da811a6387e3be0bca00f85ce9e612","unresolved":true,"context_lines":[{"line_number":419,"context_line":"\t\t.mode \u003d COMMAND_EXEC,"},{"line_number":420,"context_line":"\t\t.help \u003d \"display ROM table for MEM-AP of current target \""},{"line_number":421,"context_line":"\t\t\"(default currently selected AP)\","},{"line_number":422,"context_line":"\t\t.usage \u003d \"[ap_num | \u0027root\u0027]\","},{"line_number":423,"context_line":"\t},"},{"line_number":424,"context_line":"\tCOMMAND_REGISTRATION_DONE"},{"line_number":425,"context_line":"};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fba7cd57_0148e308","line":422,"range":{"start_line":422,"start_character":22,"end_line":422,"end_character":28},"in_reply_to":"ffbed146_aeb7a0e0","updated":"2021-10-13 16:55:33.000000000","message":"While it\u0027s mentioned in the user guide/documentation, I thought it would be nice to include it in the application help section as well.","commit_id":"66713b1ce53a86d61ec8ae547163db5d6caacaae"}]}