)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"81b5d28ebb1d7b911deb55a4db8e573c0eb4d3de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"01a5e028_5c9b8c0b","updated":"2021-09-07 08:15:34.000000000","message":"I feel that the reason for this dependencies is that `struct armv7m_common` has too many stuff in it.  And having local declarations to reduce dependencies isn\u0027t best way to fix it.\n\nFor rtos/*.c, they just want to check `fp_feature`. So, providing `target_fp_feature()` should reduce dependencies for them.\n\nMost of arch related code in target/*.c are actually using ap. So, they need not only the struct but function declarations as well.  Thus, this change doesn\u0027t help.\n\nThe other users are flash/nor/*.c.  Except for psoc6 and stm32l4x, they are just checking the target is v7 or not.  For stm32l4x, it\u0027s checking ap_num to select register address?\n\nI was gonna suggest to make `struct adiv5_dap` and `adiv5_ap` opaque structs by moving the struct definition into `arm_adi_v5.c` but I found out that adi_v5_jtag uses with list_head, which requires to access the struct member, cmd_pool.  Just to test it, I\u0027ve moved adi_v5_jtag.c into adiv5_dap.c and I successfully compiled with all other accessors for members.  With this change, all you have in arm_adi_v5.h is `struct adiv5_dap;` and related function declarations.\n\nI\u0027m not expert on how the dap code are working closely, but it might be a worth mentioning.","commit_id":"5fcfb37a73e136d59d52e175d8a3dd1e7bdf5dcf"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"3c42679118877f3ce62dc9a9863d1f403a6176d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7204b0ee_d4592d9f","updated":"2021-09-07 11:37:44.000000000","message":"I wasn\u0027t aware of the patchset.  I still need to learn how all core structures are related before proposing deeper changes.  Thank you for letting me know about it.","commit_id":"5fcfb37a73e136d59d52e175d8a3dd1e7bdf5dcf"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"947bfd5565e5d7ca48c22eafae35530741f15cc5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e0627ab_d78391c5","in_reply_to":"01a5e028_5c9b8c0b","updated":"2021-09-07 09:00:39.000000000","message":"This patch was related with my work on ADIv6 https://review.openocd.org/q/topic:adiv6 where working on only 2 files trigger a recompile of almost all openocd. With this patch I saved plenty of compile time.\n\nBut a wider review all the .h files is needed.\nThis patch doesn\u0027t address systematically the problem. If you prefer, we can drop it.\n\nSplit .h in private and public declarations is correct, with the private part that can either be in the C file, or in a .h shared between a small amount of C files.","commit_id":"5fcfb37a73e136d59d52e175d8a3dd1e7bdf5dcf"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"3c42679118877f3ce62dc9a9863d1f403a6176d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10fcc5c1_966a03e3","in_reply_to":"2e0627ab_d78391c5","updated":"2021-09-07 11:37:44.000000000","message":"No, if it helps, please don\u0027t drop it.","commit_id":"5fcfb37a73e136d59d52e175d8a3dd1e7bdf5dcf"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"6edcb94b9964f9a06bdd3b725f0fe50b725bf364","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d10600e1_a6e804ad","updated":"2021-09-16 02:47:00.000000000","message":"LGTM","commit_id":"8eea0ea99819784618820899bdd2917bfeb0d4d3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d49a9658b6039f7d8e93bb47910fa47d2d609948","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"598d61f8_ebead35f","updated":"2021-09-15 22:08:58.000000000","message":"Rebased after https://review.openocd.org/6050/","commit_id":"8eea0ea99819784618820899bdd2917bfeb0d4d3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"19a884e2c96da084a15e398a79d7d0336acae015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ef56401_ea5e29f1","updated":"2021-09-16 22:46:28.000000000","message":"Cannot find any valid reason for using jtag.h.\nFixed.\nThanks for spotting it.","commit_id":"a18cbd5b85267e4f0796ca91425ca64684f1b458"}],"src/flash/nor/bluenrg-x.c":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"6755bac24a108a03d3d2c9cf6c98d929809becaa","unresolved":true,"context_lines":[{"line_number":21,"context_line":"#endif"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#include \"helper/types.h\""},{"line_number":24,"context_line":"#include \u003cjtag/jtag.h\u003e"},{"line_number":25,"context_line":"#include \u003ctarget/algorithm.h\u003e"},{"line_number":26,"context_line":"#include \u003ctarget/armv7m.h\u003e"},{"line_number":27,"context_line":"#include \u003ctarget/cortex_m.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ebf3532c_0547ef4a","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":22},"updated":"2021-09-16 21:03:04.000000000","message":"For a smaller scope, in my build environment \"#include \u003chelper/binarybuffer.h\u003e\" also works. But jtag/jtag.h covers it as well.","commit_id":"8eea0ea99819784618820899bdd2917bfeb0d4d3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"19a884e2c96da084a15e398a79d7d0336acae015","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#endif"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#include \"helper/types.h\""},{"line_number":24,"context_line":"#include \u003cjtag/jtag.h\u003e"},{"line_number":25,"context_line":"#include \u003ctarget/algorithm.h\u003e"},{"line_number":26,"context_line":"#include \u003ctarget/armv7m.h\u003e"},{"line_number":27,"context_line":"#include \u003ctarget/cortex_m.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"dd3c014f_9b738442","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":22},"in_reply_to":"be9ad4a1_0f1af753","updated":"2021-09-16 22:46:28.000000000","message":"Done","commit_id":"8eea0ea99819784618820899bdd2917bfeb0d4d3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a64d062bbe9003c584265664e950ec2c82c76dac","unresolved":true,"context_lines":[{"line_number":21,"context_line":"#endif"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"#include \"helper/types.h\""},{"line_number":24,"context_line":"#include \u003cjtag/jtag.h\u003e"},{"line_number":25,"context_line":"#include \u003ctarget/algorithm.h\u003e"},{"line_number":26,"context_line":"#include \u003ctarget/armv7m.h\u003e"},{"line_number":27,"context_line":"#include \u003ctarget/cortex_m.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"be9ad4a1_0f1af753","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":22},"in_reply_to":"ebf3532c_0547ef4a","updated":"2021-09-16 22:32:49.000000000","message":"Yes, you are right. The missing symbols is buf_set_u32() from binarybuffer.h!\nI have developed this patch inside the adiv6 series, then moved it independently.\nI don\u0027t understand why I used jtag.h here. Will check it better.","commit_id":"8eea0ea99819784618820899bdd2917bfeb0d4d3"}],"src/flash/nor/cc3220sf.c":[{"author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"change_message_id":"6755bac24a108a03d3d2c9cf6c98d929809becaa","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#include \"imp.h\""},{"line_number":23,"context_line":"#include \"cc3220sf.h\""},{"line_number":24,"context_line":"#include \u003cjtag/jtag.h\u003e"},{"line_number":25,"context_line":"#include \u003chelper/time_support.h\u003e"},{"line_number":26,"context_line":"#include \u003ctarget/algorithm.h\u003e"},{"line_number":27,"context_line":"#include \u003ctarget/armv7m.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"327a5581_2b7cdde5","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":22},"updated":"2021-09-16 21:03:04.000000000","message":"For a smaller scope, in my build environment \"#include \u003chelper/binarybuffer.h\u003e\" also works.  But jtag/jtag.h covers it as well.","commit_id":"8eea0ea99819784618820899bdd2917bfeb0d4d3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"19a884e2c96da084a15e398a79d7d0336acae015","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#include \"imp.h\""},{"line_number":23,"context_line":"#include \"cc3220sf.h\""},{"line_number":24,"context_line":"#include \u003cjtag/jtag.h\u003e"},{"line_number":25,"context_line":"#include \u003chelper/time_support.h\u003e"},{"line_number":26,"context_line":"#include \u003ctarget/algorithm.h\u003e"},{"line_number":27,"context_line":"#include \u003ctarget/armv7m.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"0e27959d_a96c202c","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":22},"in_reply_to":"16aa6efa_13f3d242","updated":"2021-09-16 22:46:28.000000000","message":"Done","commit_id":"8eea0ea99819784618820899bdd2917bfeb0d4d3"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a64d062bbe9003c584265664e950ec2c82c76dac","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#include \"imp.h\""},{"line_number":23,"context_line":"#include \"cc3220sf.h\""},{"line_number":24,"context_line":"#include \u003cjtag/jtag.h\u003e"},{"line_number":25,"context_line":"#include \u003chelper/time_support.h\u003e"},{"line_number":26,"context_line":"#include \u003ctarget/algorithm.h\u003e"},{"line_number":27,"context_line":"#include \u003ctarget/armv7m.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"16aa6efa_13f3d242","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":22},"in_reply_to":"327a5581_2b7cdde5","updated":"2021-09-16 22:32:49.000000000","message":"here too!","commit_id":"8eea0ea99819784618820899bdd2917bfeb0d4d3"}]}