)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"46559a9ec4cbf634b99ac43846b2fc53be9e59c5","unresolved":true,"context_lines":[{"line_number":16,"context_line":"This is because we specify both \"src/\" and \"src/helper/\" directories"},{"line_number":17,"context_line":"as include directories.  Some files name under \"src/helper/\", such as"},{"line_number":18,"context_line":"types.h, log.h, and util.h are too generic and could be ambiguous"},{"line_number":19,"context_line":"depending on the search path."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This commit remove \"src/helper/\" from our include dir and make C files"},{"line_number":22,"context_line":"include explicitly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fecaa48_c7d403cb","line":19,"updated":"2021-08-31 23:04:28.000000000","message":"Did you found some conflict? Should we rename some of these files?","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"a6c099c276b4f994c72d2eafdbec96fb917a0b2a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"This is because we specify both \"src/\" and \"src/helper/\" directories"},{"line_number":17,"context_line":"as include directories.  Some files name under \"src/helper/\", such as"},{"line_number":18,"context_line":"types.h, log.h, and util.h are too generic and could be ambiguous"},{"line_number":19,"context_line":"depending on the search path."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This commit remove \"src/helper/\" from our include dir and make C files"},{"line_number":22,"context_line":"include explicitly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2fead9bf_c65082e6","line":19,"in_reply_to":"1fecaa48_c7d403cb","updated":"2021-09-01 01:32:50.000000000","message":"I was playing with the Meson build system with OpenOCD and missed a few defines or include dirs.  And I don\u0027t recall precisely but some .c files loaded a wrong header file and failed to be built.\n\nCould be this: /usr/share/mingw-w64/include/bits.h","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"46559a9ec4cbf634b99ac43846b2fc53be9e59c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3dcabbf6_012eafd1","updated":"2021-08-31 23:04:28.000000000","message":"Agree on the idea behind this patch.","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"a6c099c276b4f994c72d2eafdbec96fb917a0b2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6974a2d6_6c72241f","updated":"2021-09-01 01:32:50.000000000","message":"Fixed all of you comments, thanks!\n\nI\u0027ve added a few questions regarding header file coding style.  I\u0027ve checked doc/manual/style.txt but it seems like we don\u0027t have any about header style.","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"83e97f6979c067510a95f63771bbb05343e36558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ec3ba15e_83dc4ba0","updated":"2021-09-06 05:17:48.000000000","message":"As commented, I\u0027ve created another PR for include files.  If there is not objection, we can merge this, and discuss include files in the PR.","commit_id":"16374c56872995407c631d383c0c1fb6907cf486"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"264cccf9f428539d6fee9a33530de65b2186930e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"507fc9b0_fda63600","updated":"2021-09-29 08:13:14.000000000","message":"sorry, after merging http://review.openocd.org/6468 this does not merge anymore.\nWould you mind rebasing it?\nThe conflict is only in src/flash/nor/psoc6.c and gerrit cannot fix it automatically","commit_id":"16374c56872995407c631d383c0c1fb6907cf486"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ad640df636105b1dfca5cbe953951ac55d684720","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6d78997e_641d5b74","updated":"2021-09-29 13:30:41.000000000","message":"Thanks for the rebase. If no further comments I will merge it next week-end","commit_id":"8a27e42e2a64b973aa0b26043960447bca812922"}],"src/flash/nor/psoc6.c":[{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"a6c099c276b4f994c72d2eafdbec96fb917a0b2a","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#include \"imp.h\""},{"line_number":27,"context_line":"#include \u003chelper/time_support.h\u003e"},{"line_number":28,"context_line":"#include \"target/target.h\""},{"line_number":29,"context_line":"#include \"target/cortex_m.h\""},{"line_number":30,"context_line":"#include \"target/breakpoints.h\""},{"line_number":31,"context_line":"#include \"target/target_type.h\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9ffa010a_62af58c6","line":28,"updated":"2021-09-01 01:32:50.000000000","message":"Antonio, do you have any preferences for include syntax, \"\" vs \u003c\u003e?","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d1dd06d8172d759ddb2bad045afbda1c20f7e85f","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#include \"imp.h\""},{"line_number":27,"context_line":"#include \u003chelper/time_support.h\u003e"},{"line_number":28,"context_line":"#include \"target/target.h\""},{"line_number":29,"context_line":"#include \"target/cortex_m.h\""},{"line_number":30,"context_line":"#include \"target/breakpoints.h\""},{"line_number":31,"context_line":"#include \"target/target_type.h\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"acb633ed_17ea4c36","line":28,"in_reply_to":"9ffa010a_62af58c6","updated":"2021-09-04 08:29:26.000000000","message":"In openocd coding style there no hint, so today there is a kind of anarchy.\nThe way openocd is built is through libraries for each folder. It could make sense to use \u0027\"\u0027 for files in the same folder and probably the subfolders, and \u0027\u003c\u003e\u0027 for the other cases.\nSuggestions are welcome.","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"83e97f6979c067510a95f63771bbb05343e36558","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#include \"imp.h\""},{"line_number":27,"context_line":"#include \u003chelper/time_support.h\u003e"},{"line_number":28,"context_line":"#include \"target/target.h\""},{"line_number":29,"context_line":"#include \"target/cortex_m.h\""},{"line_number":30,"context_line":"#include \"target/breakpoints.h\""},{"line_number":31,"context_line":"#include \"target/target_type.h\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9c38b1ea_cb04d5a4","line":28,"in_reply_to":"acb633ed_17ea4c36","updated":"2021-09-06 05:17:48.000000000","message":"\u003e It could make sense to use \u0027\"\u0027 for files in the same folder and probably the subfolders, and \u0027\u003c\u003e\u0027 for the other cases.\n\nI like it.  I\u0027ve prepared a PR at https://review.openocd.org/c/openocd/+/6542","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"}],"src/flash/nor/stm32l4x.c":[{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"a6c099c276b4f994c72d2eafdbec96fb917a0b2a","unresolved":true,"context_lines":[{"line_number":29,"context_line":"#include \u003chelper/bits.h\u003e"},{"line_number":30,"context_line":"#include \u003ctarget/algorithm.h\u003e"},{"line_number":31,"context_line":"#include \u003ctarget/cortex_m.h\u003e"},{"line_number":32,"context_line":"#include \"stm32l4x.h\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"/* STM32L4xxx series for reference."},{"line_number":35,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7edb79d7_2d1ea997","line":32,"updated":"2021-09-01 01:32:50.000000000","message":"How about this one.  Some coding standard prefer to include its own header first.  ref. https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d1dd06d8172d759ddb2bad045afbda1c20f7e85f","unresolved":true,"context_lines":[{"line_number":29,"context_line":"#include \u003chelper/bits.h\u003e"},{"line_number":30,"context_line":"#include \u003ctarget/algorithm.h\u003e"},{"line_number":31,"context_line":"#include \u003ctarget/cortex_m.h\u003e"},{"line_number":32,"context_line":"#include \"stm32l4x.h\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"/* STM32L4xxx series for reference."},{"line_number":35,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e1ce16e2_bd9960b9","line":32,"in_reply_to":"7edb79d7_2d1ea997","updated":"2021-09-04 08:29:26.000000000","message":"usually these includes are for exporting functions defined in the same C file, so the C file itself doesn\u0027t need to include its H. But it\u0027s common the include the H file from the same C to verify the prototype matching between H and C.\nIt could be moved as first to mark this special purpose and avoid it get removed later on.","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"83e97f6979c067510a95f63771bbb05343e36558","unresolved":true,"context_lines":[{"line_number":29,"context_line":"#include \u003chelper/bits.h\u003e"},{"line_number":30,"context_line":"#include \u003ctarget/algorithm.h\u003e"},{"line_number":31,"context_line":"#include \u003ctarget/cortex_m.h\u003e"},{"line_number":32,"context_line":"#include \"stm32l4x.h\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"/* STM32L4xxx series for reference."},{"line_number":35,"context_line":" *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6e339259_4c39e516","line":32,"in_reply_to":"e1ce16e2_bd9960b9","updated":"2021-09-06 05:17:48.000000000","message":"Let\u0027s talk about it at https://review.openocd.org/c/openocd/+/6542\n\nAndreas, if you have any suggestion, please comment it in the above PR.","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"}],"src/helper/command.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"46559a9ec4cbf634b99ac43846b2fc53be9e59c5","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"#include \u003chelper/list.h\u003e"},{"line_number":29,"context_line":"#include \u003chelper/types.h\u003e"},{"line_number":30,"context_line":"#include \u003chelper/jim-nvp.h\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"/* To achieve C99 printf compatibility in MinGW, gnu_printf should be"},{"line_number":33,"context_line":" * used for __attribute__((format( ... ))), with GCC v4.4 or later"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"71b5569f_e5bab740","line":30,"updated":"2021-08-31 23:04:28.000000000","message":"please add it in alphabetic order","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"a6c099c276b4f994c72d2eafdbec96fb917a0b2a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"#include \u003chelper/list.h\u003e"},{"line_number":29,"context_line":"#include \u003chelper/types.h\u003e"},{"line_number":30,"context_line":"#include \u003chelper/jim-nvp.h\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"/* To achieve C99 printf compatibility in MinGW, gnu_printf should be"},{"line_number":33,"context_line":" * used for __attribute__((format( ... ))), with GCC v4.4 or later"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"07bb2fcf_b9ed7df7","line":30,"in_reply_to":"71b5569f_e5bab740","updated":"2021-09-01 01:32:50.000000000","message":"Done","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"}],"src/helper/jim-nvp.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"46559a9ec4cbf634b99ac43846b2fc53be9e59c5","unresolved":true,"context_lines":[{"line_number":42,"context_line":" */"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#include \"jim-nvp.h\""},{"line_number":45,"context_line":"#include \u003chelper/types.h\u003e"},{"line_number":46,"context_line":"#include \u003cstring.h\u003e"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"int jim_get_nvp(Jim_Interp *interp,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a20c7384_1448a4f6","line":45,"updated":"2021-08-31 23:04:28.000000000","message":"why adding one more include?","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"a6c099c276b4f994c72d2eafdbec96fb917a0b2a","unresolved":false,"context_lines":[{"line_number":42,"context_line":" */"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"#include \"jim-nvp.h\""},{"line_number":45,"context_line":"#include \u003chelper/types.h\u003e"},{"line_number":46,"context_line":"#include \u003cstring.h\u003e"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"int jim_get_nvp(Jim_Interp *interp,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1b4d7e33_eb10c7c0","line":45,"in_reply_to":"a20c7384_1448a4f6","updated":"2021-09-01 01:32:50.000000000","message":"Oops.  That\u0027s a leftover from my experiment.  Removed.","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"}],"src/target/armv7m_trace.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"46559a9ec4cbf634b99ac43846b2fc53be9e59c5","unresolved":true,"context_lines":[{"line_number":19,"context_line":"#define OPENOCD_TARGET_ARMV7M_TRACE_H"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"#include \u003ctarget/target.h\u003e"},{"line_number":22,"context_line":"#include \u003chelper/command.h\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"/**"},{"line_number":25,"context_line":" * @file"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ed1198ec_1a0a1058","line":22,"updated":"2021-08-31 23:04:28.000000000","message":"please, in alphabetic order","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"},{"author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"change_message_id":"a6c099c276b4f994c72d2eafdbec96fb917a0b2a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#define OPENOCD_TARGET_ARMV7M_TRACE_H"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"#include \u003ctarget/target.h\u003e"},{"line_number":22,"context_line":"#include \u003chelper/command.h\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"/**"},{"line_number":25,"context_line":" * @file"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3cf6212f_442883e6","line":22,"in_reply_to":"ed1198ec_1a0a1058","updated":"2021-09-01 01:32:50.000000000","message":"Done","commit_id":"2db9b867739d2320dee22cb9e0c1410c875c01b9"}]}