)]}'
{"id":"openocd~master~I38fc9b96ba01a513d4a72757d40007e21b502f25","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"last_update":"2021-10-02 13:18:15.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-09-29 08:13:14.000000000","reason":"Antonio Borneo replied on the change"},"1001851":{"account":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"last_update":"2021-10-02 13:18:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I38fc9b96ba01a513d4a72757d40007e21b502f25","subject":"helper: Remove src/helper from include dirs","status":"MERGED","created":"2021-08-30 06:20:55.000000000","updated":"2021-10-02 13:18:15.000000000","submitted":"2021-10-02 13:18:15.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":19,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"6507","meta_rev_id":"98f6362722d7e735d182ced6946d35affc9795c5","_number":6507,"owner":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-02 13:18:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-10-02 13:18:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"}],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-30 07:10:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-31 23:04:28.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-09-04 08:30:01.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"}],"messages":[{"id":"f45f46a2416aebffaca563bb46f3656d260379ee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"real_author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"date":"2021-08-30 06:20:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"db2509833776129f893b4fc594e3c30d92a20628","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-08-30 07:10:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15149/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14374/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"46559a9ec4cbf634b99ac43846b2fc53be9e59c5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-08-31 23:04:28.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"6f23cadcadb284c21ee2e21b14111ea2f174bd65","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"real_author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"date":"2021-09-01 01:30:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a6c099c276b4f994c72d2eafdbec96fb917a0b2a","author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"real_author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"date":"2021-09-01 01:32:50.000000000","message":"Patch Set 1:\n\n(7 comments)","accounts_in_message":[],"_revision_number":1},{"id":"942021da11ed28cbb254906989b36cbc0ae579ac","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-01 02:14:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15161/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14386/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d1dd06d8172d759ddb2bad045afbda1c20f7e85f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-04 08:29:26.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"83e97f6979c067510a95f63771bbb05343e36558","author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"real_author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"date":"2021-09-06 05:17:48.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"264cccf9f428539d6fee9a33530de65b2186930e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-29 08:13:14.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2652550d8ba2bd313934c07a2f3ef03e97168326","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"real_author":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"date":"2021-09-29 10:45:21.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f371dd6380ee06575c16ccdb54736f6055a5ec71","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-29 11:36:31.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15335/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14559/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"ad640df636105b1dfca5cbe953951ac55d684720","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-29 13:30:41.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"de91aafecf268dd4d050a4de2cebd9e9bc5e56e9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-02 13:18:09.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"98f6362722d7e735d182ced6946d35affc9795c5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-02 13:18:15.000000000","message":"Change has been successfully cherry-picked as 05752557dd0dcab76250ab12377d59435b74204d","accounts_in_message":[],"_revision_number":4}],"current_revision":"05752557dd0dcab76250ab12377d59435b74204d","revisions":{"2db9b867739d2320dee22cb9e0c1410c875c01b9":{"kind":"REWORK","_number":1,"created":"2021-08-30 06:20:55.000000000","uploader":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"ref":"refs/changes/07/6507/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6507/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/1 \u0026\u0026 git checkout -b change-6507 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6507/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6c1e1a212a8c044ae778c526851fe909bf219e90","subject":"flash/stm32l4x: add support of STM32WL5x dual core"}],"author":{"name":"Yasushi SHOJI","email":"yashi@spacecubics.com","date":"2021-08-29 09:18:01.000000000","tz":540},"committer":{"name":"Yasushi SHOJI","email":"yashi@spacecubics.com","date":"2021-08-30 06:20:31.000000000","tz":540},"subject":"helper: Remove src/helper from include dirs","message":"helper: Remove src/helper from include dirs\n\nThe header files under src/helper/ can currently be included with\neither\n\n    #include \u003cbits.h\u003e\n    or\n    #include \u003chelper/bits.h\u003e\n\nThis is because we specify both \"src/\" and \"src/helper/\" directories\nas include directories.  Some files name under \"src/helper/\", such as\ntypes.h, log.h, and util.h are too generic and could be ambiguous\ndepending on the search path.\n\nThis commit remove \"src/helper/\" from our include dir and make C files\ninclude explicitly.\n\nChange-Id: I38fc9b96ba01a513d4a72757d40007e21b502f25\nSigned-off-by: Yasushi SHOJI \u003cyashi@spacecubics.com\u003e\n"}},"16374c56872995407c631d383c0c1fb6907cf486":{"kind":"REWORK","_number":2,"created":"2021-09-01 01:30:10.000000000","uploader":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"ref":"refs/changes/07/6507/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6507/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/2 \u0026\u0026 git checkout -b change-6507 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6507/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6c1e1a212a8c044ae778c526851fe909bf219e90","subject":"flash/stm32l4x: add support of STM32WL5x dual core"}],"author":{"name":"Yasushi SHOJI","email":"yashi@spacecubics.com","date":"2021-08-29 09:18:01.000000000","tz":540},"committer":{"name":"Yasushi SHOJI","email":"yashi@spacecubics.com","date":"2021-09-01 00:47:44.000000000","tz":540},"subject":"helper: Remove src/helper from include dirs","message":"helper: Remove src/helper from include dirs\n\nThe header files under src/helper/ can currently be included with\neither\n\n    #include \u003cbits.h\u003e\n    or\n    #include \u003chelper/bits.h\u003e\n\nThis is because we specify both \"src/\" and \"src/helper/\" directories\nas include directories.  Some files name under \"src/helper/\", such as\ntypes.h, log.h, and util.h are too generic and could be ambiguous\ndepending on the search path.\n\nThis commit remove \"src/helper/\" from our include dir and make C files\ninclude explicitly.\n\nChange-Id: I38fc9b96ba01a513d4a72757d40007e21b502f25\nSigned-off-by: Yasushi SHOJI \u003cyashi@spacecubics.com\u003e\n"}},"8a27e42e2a64b973aa0b26043960447bca812922":{"kind":"REWORK","_number":3,"created":"2021-09-29 10:45:21.000000000","uploader":{"_account_id":1001851,"name":"Yasushi SHOJI","email":"yasushi.shoji@gmail.com","username":"yashi"},"ref":"refs/changes/07/6507/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6507/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/3 \u0026\u0026 git checkout -b change-6507 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6507/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3993d3188da5976a64f47d4cbf4d7e5b63f0c8d","subject":"tcl/stm32wlx.cfg: comply with new jimtcl expr syntax"}],"author":{"name":"Yasushi SHOJI","email":"yashi@spacecubics.com","date":"2021-08-29 09:18:01.000000000","tz":540},"committer":{"name":"Yasushi SHOJI","email":"yashi@spacecubics.com","date":"2021-09-29 10:17:09.000000000","tz":540},"subject":"helper: Remove src/helper from include dirs","message":"helper: Remove src/helper from include dirs\n\nThe header files under src/helper/ can currently be included with\neither\n\n    #include \u003cbits.h\u003e\n    or\n    #include \u003chelper/bits.h\u003e\n\nThis is because we specify both \"src/\" and \"src/helper/\" directories\nas include directories.  Some files name under \"src/helper/\", such as\ntypes.h, log.h, and util.h are too generic and could be ambiguous\ndepending on the search path.\n\nThis commit remove \"src/helper/\" from our include dir and make C files\ninclude explicitly.\n\nChange-Id: I38fc9b96ba01a513d4a72757d40007e21b502f25\nSigned-off-by: Yasushi SHOJI \u003cyashi@spacecubics.com\u003e\n"}},"05752557dd0dcab76250ab12377d59435b74204d":{"kind":"REWORK","_number":4,"created":"2021-10-02 13:18:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/6507/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6507/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/4 \u0026\u0026 git checkout -b change-6507 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6507/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6507/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e4872054108a3a18dc651b45dea679696e14ee7f","subject":"uint64_t-\u003etarget_addr_t for stack pointers."}],"author":{"name":"Yasushi SHOJI","email":"yashi@spacecubics.com","date":"2021-08-29 09:18:01.000000000","tz":540},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-02 13:18:15.000000000","tz":0},"subject":"helper: Remove src/helper from include dirs","message":"helper: Remove src/helper from include dirs\n\nThe header files under src/helper/ can currently be included with\neither\n\n    #include \u003cbits.h\u003e\n    or\n    #include \u003chelper/bits.h\u003e\n\nThis is because we specify both \"src/\" and \"src/helper/\" directories\nas include directories.  Some files name under \"src/helper/\", such as\ntypes.h, log.h, and util.h are too generic and could be ambiguous\ndepending on the search path.\n\nThis commit remove \"src/helper/\" from our include dir and make C files\ninclude explicitly.\n\nChange-Id: I38fc9b96ba01a513d4a72757d40007e21b502f25\nSigned-off-by: Yasushi SHOJI \u003cyashi@spacecubics.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6507\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}