)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"cd7cf6e13d81a858c1d23ad7a36ca8651ca6d7eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0351d4e3_88c2efd4","updated":"2021-09-02 05:02:12.000000000","message":"I do not see any reasons, why this code drops should have different rules compared to other companies. Please, split it reviewable, bisectable patches.","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"79ebaf74251a678a4db8490e2f38daa2239f9702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3715af02_0ab841b8","updated":"2021-09-03 04:37:49.000000000","message":"Let\u0027s assume, I have a regression which is pointing to this patch. I read commit message and the huge diff and WTF?!. Ok, then my next steps would be, go the the provided link and search, may be there is usable commit history, and .... can\u0027t find any thing usable. So, this patch provides code drop which already break all rules of community projects, and at the end it provides zero usable information to help developers.\n\nAs reviewer i see same argumentation a lot. Every developer, including my self, has the right to do the same. So, we need to decide as community project, do we apply this rule to all or just to you? And if there should be exception of the rule, then why? How can I review other drops provided by other developers? Every one will point to this patch and say: there are patches and it is ok!! Are you hate me in some special way!?\n\nAnd there are patch authors who already use nearly the same argumentation.\n\nDo sifive is making same kind of patches for the kernel? I doubt:\nhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?h\u003dv5.14\u0026qt\u003dauthor\u0026q\u003dsifive.com\n\n","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"7a6bac56a0d7b53f725c250e443807efec2b0f9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b496b40_7a02ce9a","updated":"2021-09-03 18:10:36.000000000","message":"Ok, I\u0027ll not block it, but i\u0027ll not review it too.\nMixed patch of this size adds overhead which i\u0027m not willing to pay with my free time.","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bbbbda6e_f1c31fee","updated":"2021-09-18 20:19:34.000000000","message":"very quick check with the new checkpatch under test.\nriscv code uses extensively \u0027unsigned\u0027 instead of \u0027unsigned int\u0027. Here I\u0027m checking only the code added by this patch; the rest would be fixed separately.\nI share most of the comments from Oleksij. Upstreaming such a big chunk with no log of what it contains nor why, loosing all the history and no acknowledge of the authors. This was already done once, so let\u0027s do again, but I hope it\u0027s the last time.\nNote for me: the automatically generated file \u0027debug_define.h\u0027 should be skipped by checkpatch. Need a flag to skip some specific file!","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"369e6192d6a487540225315181689e97f7bf6c7f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"06f11be1_76e92499","in_reply_to":"0351d4e3_88c2efd4","updated":"2021-09-02 17:58:16.000000000","message":"I agree that reviewable patches are better, and for target-independent stuff that is what I am doing. Creating reviewable patches is a significant amount of work, and in the interest of getting riscv-openocd and mainline closer more quickly, I think that in this case the shortcut is warranted.\n\nHere\u0027s why this change is special:\n1. riscv-openocd is the OpenOCD version to use if you\u0027re debugging RISC-V cores. If you come to me with OpenOCD questions, I\u0027ll first make sure you\u0027re using that version. So the RISC-V code in riscv-openocd is better tested and more complete than what has made it into mainline so far.\n2. I have written 99% of the RISC-V code existing in mainline. I\u0027m not making large changes to code somebody else wrote. (This is a little misleading. Due to the way this project tracks changes, the original author gets lost in git history. In riscv-openocd I\u0027ve written 81% of the code.)\n3. This change cannot possibly affect anything but RISC-V.\n4. A similar change was accepted last year: https://review.openocd.org/c/openocd/+/5821\n\n(Aside: What is the best way to create reviewable patches? git does not track which changes are merged into mainline because gerrit seems to do things completely differently, so I\u0027m reduced to manually reading and splitting up diffs.)","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"bad19ac4f407268ef14d7081785d06fa6d9711b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"806c59c9_6a2c91f6","in_reply_to":"3715af02_0ab841b8","updated":"2021-09-03 17:11:18.000000000","message":"\u003e Let\u0027s assume, I have a regression which is pointing to this patch.\n\nThis must be a regression in RISC-V support. RISC-V support in mainline is still incomplete, so somebody (likely me) will point you at the riscv-openocd fork. There either the issue is not present, or I will help get it fixed.\n\nYou don\u0027t have to convince me of the benefits of small patches. I believe in them, and riscv-openocd is run exactly that way too. But sometimes it\u0027s in everybody\u0027s interest to bend the rules a little.\n\nThe kernel is a separate issue. There is not a separate RISC-V kernel fork that is more complete. It is unfortunate that riscv-openocd even exists as a separate fork, but until I am able to catch up in upstreaming it will continue to exist. And the more barriers there are to upstreaming code, the longer that will take.","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"5dee701da63f583ddcd448e0200b49da8f8131eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ceaf54d_a95841fc","in_reply_to":"4b496b40_7a02ce9a","updated":"2021-09-07 18:33:28.000000000","message":"That\u0027s fair. I\u0027ll reach out to some other reviewers to see if I can take the shortcut or if I\u0027ll end up breaking up the PR.","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1fb65ff_890f5c40","in_reply_to":"bbbbda6e_f1c31fee","updated":"2021-09-20 22:32:13.000000000","message":"\u003e I share most of the comments from Oleksij. Upstreaming such a big chunk with no log of what it contains nor why, loosing all the history and no acknowledge of the authors. This was already done once, so let\u0027s do again, but I hope it\u0027s the last time.\n\nI hope it is the last time as well. This change should at least get RISC-V-specific code to a point that every time I merge something into riscv-openocd, I can create a pull request here for the same change.","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"13ee9ead_3b5bbbb1","updated":"2021-09-22 10:37:02.000000000","message":"Completed my \u0027dumb mode\u0027 review, without entering in the functionality\nJust few more comments","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3fb8337bb83f9ee0c248e67eac0b12509fc6c1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"739073aa_27ee7f9c","updated":"2021-09-22 13:26:16.000000000","message":"two more ...","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"afc4dc5c32b61d473e5cae3cf0d1c6e481c40e4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9b716490_10480161","updated":"2021-09-22 20:57:55.000000000","message":"I don\u0027t expect to enter more inside this patch, so far no more comments.\nI will let it stay here for 2 weeks, wishing someone can find time to review it again.","commit_id":"b94cb6b8b136408066b1779f2de854ffff9c710f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"dd4183fb851225e8a0fc835c2c4980fe1eb13abd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a959967d_cbedbba8","updated":"2021-10-17 12:49:29.000000000","message":"I will merge this next weekend, if nobody has concerns","commit_id":"b94cb6b8b136408066b1779f2de854ffff9c710f"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"934942eaf46276e7b1d9d7ee7327c3dbece651ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ded60c86_4c8bba91","in_reply_to":"9b716490_10480161","updated":"2021-10-11 16:52:08.000000000","message":"Thanks. It\u0027s been two weeks. If you merge it, I can start on upstreaming changes that I\u0027ve made in riscv-openocd since this change.","commit_id":"b94cb6b8b136408066b1779f2de854ffff9c710f"}],"src/target/riscv/opcodes.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":44,"context_line":"static uint32_t imm_s(uint32_t imm) __attribute__ ((unused));"},{"line_number":45,"context_line":"static uint32_t imm_s(uint32_t imm)"},{"line_number":46,"context_line":"{"},{"line_number":47,"context_line":"\treturn (bits(imm, 4, 0) \u003c\u003c 7) | (bits(imm, 11 , 5) \u003c\u003c 25);"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"static uint32_t imm_b(uint32_t imm) __attribute__ ((unused));"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e24d5196_f8f1eb1f","line":47,"updated":"2021-09-18 20:19:34.000000000","message":"no space between \u002711\u0027 and \u0027,\u0027","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"static uint32_t imm_s(uint32_t imm) __attribute__ ((unused));"},{"line_number":45,"context_line":"static uint32_t imm_s(uint32_t imm)"},{"line_number":46,"context_line":"{"},{"line_number":47,"context_line":"\treturn (bits(imm, 4, 0) \u003c\u003c 7) | (bits(imm, 11 , 5) \u003c\u003c 25);"},{"line_number":48,"context_line":"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"static uint32_t imm_b(uint32_t imm) __attribute__ ((unused));"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7a5a44d9_aadc75ee","line":47,"in_reply_to":"e24d5196_f8f1eb1f","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"}],"src/target/riscv/riscv-011.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2333,"context_line":"\treturn ERROR_OK;"},{"line_number":2334,"context_line":"}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"static int riscv011_authdata_read(struct target *target, uint32_t *value, unsigned index)"},{"line_number":2337,"context_line":"{"},{"line_number":2338,"context_line":"\tif (index \u003e 1) {"},{"line_number":2339,"context_line":"\t\tLOG_ERROR(\"Spec 0.11 only has a two authdata registers.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8ec265dc_dd686125","line":2336,"updated":"2021-09-18 20:19:34.000000000","message":"\u0027unsigned int\u0027 is preferred to \u0027unsigned\u0027","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2333,"context_line":"\treturn ERROR_OK;"},{"line_number":2334,"context_line":"}"},{"line_number":2335,"context_line":""},{"line_number":2336,"context_line":"static int riscv011_authdata_read(struct target *target, uint32_t *value, unsigned index)"},{"line_number":2337,"context_line":"{"},{"line_number":2338,"context_line":"\tif (index \u003e 1) {"},{"line_number":2339,"context_line":"\t\tLOG_ERROR(\"Spec 0.11 only has a two authdata registers.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aa9ab898_7b9fc47c","line":2336,"in_reply_to":"8ec265dc_dd686125","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2349,"context_line":"\treturn ERROR_OK;"},{"line_number":2350,"context_line":"}"},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"static int riscv011_authdata_write(struct target *target, uint32_t value, unsigned index)"},{"line_number":2353,"context_line":"{"},{"line_number":2354,"context_line":"\tif (index \u003e 1) {"},{"line_number":2355,"context_line":"\t\tLOG_ERROR(\"Spec 0.11 only has a two authdata registers.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a6815bbc_eb33ce33","line":2352,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2349,"context_line":"\treturn ERROR_OK;"},{"line_number":2350,"context_line":"}"},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"static int riscv011_authdata_write(struct target *target, uint32_t value, unsigned index)"},{"line_number":2353,"context_line":"{"},{"line_number":2354,"context_line":"\tif (index \u003e 1) {"},{"line_number":2355,"context_line":"\t\tLOG_ERROR(\"Spec 0.11 only has a two authdata registers.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3193caa0_d0fbae18","line":2352,"in_reply_to":"a6815bbc_eb33ce33","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"}],"src/target/riscv/riscv-013.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":1783,"context_line":"\treturn ERROR_OK;"},{"line_number":1784,"context_line":"}"},{"line_number":1785,"context_line":""},{"line_number":1786,"context_line":"static int riscv013_authdata_read(struct target *target, uint32_t *value, unsigned index)"},{"line_number":1787,"context_line":"{"},{"line_number":1788,"context_line":"\tif (index \u003e 0) {"},{"line_number":1789,"context_line":"\t\tLOG_ERROR(\"Spec 0.13 only has a single authdata register.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c2a7a24c_5a6922e8","line":1786,"updated":"2021-09-18 20:19:34.000000000","message":"\u0027unsigned int\u0027 instead of \u0027unsigned\u0027","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":1783,"context_line":"\treturn ERROR_OK;"},{"line_number":1784,"context_line":"}"},{"line_number":1785,"context_line":""},{"line_number":1786,"context_line":"static int riscv013_authdata_read(struct target *target, uint32_t *value, unsigned index)"},{"line_number":1787,"context_line":"{"},{"line_number":1788,"context_line":"\tif (index \u003e 0) {"},{"line_number":1789,"context_line":"\t\tLOG_ERROR(\"Spec 0.13 only has a single authdata register.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"df4e6cc4_ed87ec0a","line":1786,"in_reply_to":"c2a7a24c_5a6922e8","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":1796,"context_line":"\treturn dmi_read(target, value, DM_AUTHDATA);"},{"line_number":1797,"context_line":"}"},{"line_number":1798,"context_line":""},{"line_number":1799,"context_line":"static int riscv013_authdata_write(struct target *target, uint32_t value, unsigned index)"},{"line_number":1800,"context_line":"{"},{"line_number":1801,"context_line":"\tif (index \u003e 0) {"},{"line_number":1802,"context_line":"\t\tLOG_ERROR(\"Spec 0.13 only has a single authdata register.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fc62a6ee_a359ca27","line":1799,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":1796,"context_line":"\treturn dmi_read(target, value, DM_AUTHDATA);"},{"line_number":1797,"context_line":"}"},{"line_number":1798,"context_line":""},{"line_number":1799,"context_line":"static int riscv013_authdata_write(struct target *target, uint32_t value, unsigned index)"},{"line_number":1800,"context_line":"{"},{"line_number":1801,"context_line":"\tif (index \u003e 0) {"},{"line_number":1802,"context_line":"\t\tLOG_ERROR(\"Spec 0.13 only has a single authdata register.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d78860b0_fa546fa0","line":1799,"in_reply_to":"fc62a6ee_a359ca27","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":1843,"context_line":"\tRISCV013_INFO(info);"},{"line_number":1844,"context_line":"\tRISCV_INFO(r);"},{"line_number":1845,"context_line":""},{"line_number":1846,"context_line":"\tfor (unsigned i \u003d 0; i \u003c RISCV_NUM_MEM_ACCESS_METHODS; i++) {"},{"line_number":1847,"context_line":"\t\tint method \u003d r-\u003emem_access_methods[i];"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":"\t\tif (method \u003d\u003d RISCV_MEM_ACCESS_PROGBUF) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3db3a208_0995cad6","line":1846,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":1843,"context_line":"\tRISCV013_INFO(info);"},{"line_number":1844,"context_line":"\tRISCV_INFO(r);"},{"line_number":1845,"context_line":""},{"line_number":1846,"context_line":"\tfor (unsigned i \u003d 0; i \u003c RISCV_NUM_MEM_ACCESS_METHODS; i++) {"},{"line_number":1847,"context_line":"\t\tint method \u003d r-\u003emem_access_methods[i];"},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":"\t\tif (method \u003d\u003d RISCV_MEM_ACCESS_PROGBUF) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"77e7e80d_ca807780","line":1846,"in_reply_to":"3db3a208_0995cad6","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2059,"context_line":"\treturn result;"},{"line_number":2060,"context_line":"}"},{"line_number":2061,"context_line":""},{"line_number":2062,"context_line":"static uint32_t sb_sbaccess(unsigned size_bytes)"},{"line_number":2063,"context_line":"{"},{"line_number":2064,"context_line":"\tswitch (size_bytes) {"},{"line_number":2065,"context_line":"\t\tcase 1:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e9426917_ef9149ee","line":2062,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2059,"context_line":"\treturn result;"},{"line_number":2060,"context_line":"}"},{"line_number":2061,"context_line":""},{"line_number":2062,"context_line":"static uint32_t sb_sbaccess(unsigned size_bytes)"},{"line_number":2063,"context_line":"{"},{"line_number":2064,"context_line":"\tswitch (size_bytes) {"},{"line_number":2065,"context_line":"\t\tcase 1:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bd6793cd_175f3be1","line":2062,"in_reply_to":"e9426917_ef9149ee","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2081,"context_line":"\t\t\t\t\t\t\tbool ensure_success)"},{"line_number":2082,"context_line":"{"},{"line_number":2083,"context_line":"\tRISCV013_INFO(info);"},{"line_number":2084,"context_line":"\tunsigned sbasize \u003d get_field(info-\u003esbcs, DM_SBCS_SBASIZE);"},{"line_number":2085,"context_line":"\t/* There currently is no support for \u003e64-bit addresses in OpenOCD. */"},{"line_number":2086,"context_line":"\tif (sbasize \u003e 96)"},{"line_number":2087,"context_line":"\t\tdmi_op(target, NULL, NULL, DMI_OP_WRITE, DM_SBADDRESS3, 0, false, false);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9c036c41_9738645a","line":2084,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2081,"context_line":"\t\t\t\t\t\t\tbool ensure_success)"},{"line_number":2082,"context_line":"{"},{"line_number":2083,"context_line":"\tRISCV013_INFO(info);"},{"line_number":2084,"context_line":"\tunsigned sbasize \u003d get_field(info-\u003esbcs, DM_SBCS_SBASIZE);"},{"line_number":2085,"context_line":"\t/* There currently is no support for \u003e64-bit addresses in OpenOCD. */"},{"line_number":2086,"context_line":"\tif (sbasize \u003e 96)"},{"line_number":2087,"context_line":"\t\tdmi_op(target, NULL, NULL, DMI_OP_WRITE, DM_SBADDRESS3, 0, false, false);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"af7ed8ec_0a8e39ce","line":2084,"in_reply_to":"9c036c41_9738645a","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2108,"context_line":"\treturn riscv_batch_run(batch);"},{"line_number":2109,"context_line":"}"},{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"static int sba_supports_access(struct target *target, unsigned size_bytes)"},{"line_number":2112,"context_line":"{"},{"line_number":2113,"context_line":"\tRISCV013_INFO(info);"},{"line_number":2114,"context_line":"\tswitch (size_bytes) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"473ea3c8_5addaa88","line":2111,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2108,"context_line":"\treturn riscv_batch_run(batch);"},{"line_number":2109,"context_line":"}"},{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"static int sba_supports_access(struct target *target, unsigned size_bytes)"},{"line_number":2112,"context_line":"{"},{"line_number":2113,"context_line":"\tRISCV013_INFO(info);"},{"line_number":2114,"context_line":"\tswitch (size_bytes) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0cea46f0_63ebbc20","line":2111,"in_reply_to":"473ea3c8_5addaa88","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2133,"context_line":"\t\t\t\t\t\t\t\tint64_t until_ms)"},{"line_number":2134,"context_line":"{"},{"line_number":2135,"context_line":"\tRISCV013_INFO(info);"},{"line_number":2136,"context_line":"\tunsigned sbasize \u003d get_field(info-\u003esbcs, DM_SBCS_SBASIZE);"},{"line_number":2137,"context_line":"\tif (sbasize \u003e 64) {"},{"line_number":2138,"context_line":"\t\tLOG_ERROR(\"Memory sampling is only implemented for sbasize \u003c\u003d 64.\");"},{"line_number":2139,"context_line":"\t\treturn ERROR_NOT_IMPLEMENTED;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"29d05dd1_0fef9954","line":2136,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2133,"context_line":"\t\t\t\t\t\t\t\tint64_t until_ms)"},{"line_number":2134,"context_line":"{"},{"line_number":2135,"context_line":"\tRISCV013_INFO(info);"},{"line_number":2136,"context_line":"\tunsigned sbasize \u003d get_field(info-\u003esbcs, DM_SBCS_SBASIZE);"},{"line_number":2137,"context_line":"\tif (sbasize \u003e 64) {"},{"line_number":2138,"context_line":"\t\tLOG_ERROR(\"Memory sampling is only implemented for sbasize \u003c\u003d 64.\");"},{"line_number":2139,"context_line":"\t\treturn ERROR_NOT_IMPLEMENTED;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"245f9b91_db7699b4","line":2136,"in_reply_to":"29d05dd1_0fef9954","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2153,"context_line":"\tbool sbaddress1_valid \u003d false;"},{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"\t/* How often to read each value in a batch. */"},{"line_number":2156,"context_line":"\tconst unsigned repeat \u003d 5;"},{"line_number":2157,"context_line":""},{"line_number":2158,"context_line":"\tunsigned enabled_count \u003d 0;"},{"line_number":2159,"context_line":"\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(config-\u003ebucket); i++) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d0d9c52e_08c62f09","line":2156,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int, also in the next two lines","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2153,"context_line":"\tbool sbaddress1_valid \u003d false;"},{"line_number":2154,"context_line":""},{"line_number":2155,"context_line":"\t/* How often to read each value in a batch. */"},{"line_number":2156,"context_line":"\tconst unsigned repeat \u003d 5;"},{"line_number":2157,"context_line":""},{"line_number":2158,"context_line":"\tunsigned enabled_count \u003d 0;"},{"line_number":2159,"context_line":"\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(config-\u003ebucket); i++) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e7f326c2_5984eab7","line":2156,"in_reply_to":"d0d9c52e_08c62f09","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2171,"context_line":"\t\t\ttarget, 1 + enabled_count * 5 * repeat,"},{"line_number":2172,"context_line":"\t\t\tinfo-\u003edmi_busy_delay + info-\u003ebus_master_read_delay);"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"\t\tunsigned result_bytes \u003d 0;"},{"line_number":2175,"context_line":"\t\tfor (unsigned n \u003d 0; n \u003c repeat; n++) {"},{"line_number":2176,"context_line":"\t\t\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(config-\u003ebucket); i++) {"},{"line_number":2177,"context_line":"\t\t\t\tif (config-\u003ebucket[i].enabled) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f5adbd7c_6f58a8c6","line":2174,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int, also in the next two lines","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2171,"context_line":"\t\t\ttarget, 1 + enabled_count * 5 * repeat,"},{"line_number":2172,"context_line":"\t\t\tinfo-\u003edmi_busy_delay + info-\u003ebus_master_read_delay);"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"\t\tunsigned result_bytes \u003d 0;"},{"line_number":2175,"context_line":"\t\tfor (unsigned n \u003d 0; n \u003c repeat; n++) {"},{"line_number":2176,"context_line":"\t\t\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(config-\u003ebucket); i++) {"},{"line_number":2177,"context_line":"\t\t\t\tif (config-\u003ebucket[i].enabled) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a38b4aea_3f5faa56","line":2174,"in_reply_to":"f5adbd7c_6f58a8c6","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2239,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2240,"context_line":"\t\t}"},{"line_number":2241,"context_line":""},{"line_number":2242,"context_line":"\t\tunsigned read \u003d 0;"},{"line_number":2243,"context_line":"\t\tfor (unsigned n \u003d 0; n \u003c repeat; n++) {"},{"line_number":2244,"context_line":"\t\t\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(config-\u003ebucket); i++) {"},{"line_number":2245,"context_line":"\t\t\t\tif (config-\u003ebucket[i].enabled) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"68dafb14_f13a97fd","line":2242,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int, also next two lines","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2239,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2240,"context_line":"\t\t}"},{"line_number":2241,"context_line":""},{"line_number":2242,"context_line":"\t\tunsigned read \u003d 0;"},{"line_number":2243,"context_line":"\t\tfor (unsigned n \u003d 0; n \u003c repeat; n++) {"},{"line_number":2244,"context_line":"\t\t\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(config-\u003ebucket); i++) {"},{"line_number":2245,"context_line":"\t\t\t\tif (config-\u003ebucket[i].enabled) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ca19d822_665a5ef3","line":2242,"in_reply_to":"68dafb14_f13a97fd","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2246,"context_line":"\t\t\t\t\tassert(i \u003c RISCV_SAMPLE_BUF_TIMESTAMP_BEFORE);"},{"line_number":2247,"context_line":"\t\t\t\t\tuint64_t value \u003d 0;"},{"line_number":2248,"context_line":"\t\t\t\t\tif (config-\u003ebucket[i].size_bytes \u003e 4)"},{"line_number":2249,"context_line":"\t\t\t\t\t\tvalue \u003d ((uint64_t) riscv_batch_get_dmi_read_data(batch, read++)) \u003c\u003c 32;"},{"line_number":2250,"context_line":"\t\t\t\t\tvalue |\u003d riscv_batch_get_dmi_read_data(batch, read++);"},{"line_number":2251,"context_line":""},{"line_number":2252,"context_line":"\t\t\t\t\tbuf-\u003ebuf[buf-\u003eused] \u003d i;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"98619b55_98ff88d5","line":2249,"updated":"2021-09-18 20:19:34.000000000","message":"no space after cast","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2246,"context_line":"\t\t\t\t\tassert(i \u003c RISCV_SAMPLE_BUF_TIMESTAMP_BEFORE);"},{"line_number":2247,"context_line":"\t\t\t\t\tuint64_t value \u003d 0;"},{"line_number":2248,"context_line":"\t\t\t\t\tif (config-\u003ebucket[i].size_bytes \u003e 4)"},{"line_number":2249,"context_line":"\t\t\t\t\t\tvalue \u003d ((uint64_t) riscv_batch_get_dmi_read_data(batch, read++)) \u003c\u003c 32;"},{"line_number":2250,"context_line":"\t\t\t\t\tvalue |\u003d riscv_batch_get_dmi_read_data(batch, read++);"},{"line_number":2251,"context_line":""},{"line_number":2252,"context_line":"\t\t\t\t\tbuf-\u003ebuf[buf-\u003eused] \u003d i;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1dce516d_5023cea3","line":2249,"in_reply_to":"98619b55_98ff88d5","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2897,"context_line":"\t\t*skip_reason \u003d \"skipped (unsupported size)\";"},{"line_number":2898,"context_line":"\t\treturn true;"},{"line_number":2899,"context_line":"\t}"},{"line_number":2900,"context_line":"\tunsigned sbasize \u003d get_field(info-\u003esbcs, DM_SBCS_SBASIZE);"},{"line_number":2901,"context_line":"\tif ((sizeof(address) * 8 \u003e sbasize) \u0026\u0026 (address \u003e\u003e sbasize)) {"},{"line_number":2902,"context_line":"\t\tLOG_DEBUG(\"Skipping mem %s via system bus - sba only supports %u-bit address.\","},{"line_number":2903,"context_line":"\t\t\t\tread ? \"read\" : \"write\", sbasize);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dc8b7881_e8a39470","line":2900,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2897,"context_line":"\t\t*skip_reason \u003d \"skipped (unsupported size)\";"},{"line_number":2898,"context_line":"\t\treturn true;"},{"line_number":2899,"context_line":"\t}"},{"line_number":2900,"context_line":"\tunsigned sbasize \u003d get_field(info-\u003esbcs, DM_SBCS_SBASIZE);"},{"line_number":2901,"context_line":"\tif ((sizeof(address) * 8 \u003e sbasize) \u0026\u0026 (address \u003e\u003e sbasize)) {"},{"line_number":2902,"context_line":"\t\tLOG_DEBUG(\"Skipping mem %s via system bus - sba only supports %u-bit address.\","},{"line_number":2903,"context_line":"\t\t\t\tread ? \"read\" : \"write\", sbasize);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"22991dec_1a8e0ca3","line":2900,"in_reply_to":"dc8b7881_e8a39470","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2970,"context_line":"\t/* Execute the reads */"},{"line_number":2971,"context_line":"\tuint8_t *p \u003d buffer;"},{"line_number":2972,"context_line":"\tbool updateaddr \u003d true;"},{"line_number":2973,"context_line":"\tunsigned width32 \u003d (width \u003c 32) ? 32 : width;"},{"line_number":2974,"context_line":"\tfor (uint32_t c \u003d 0; c \u003c count; c++) {"},{"line_number":2975,"context_line":"\t\t/* Update the address if it is the first time or aampostincrement is not supported by the target. */"},{"line_number":2976,"context_line":"\t\tif (updateaddr) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"371aa36a_75f39c5a","line":2973,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2970,"context_line":"\t/* Execute the reads */"},{"line_number":2971,"context_line":"\tuint8_t *p \u003d buffer;"},{"line_number":2972,"context_line":"\tbool updateaddr \u003d true;"},{"line_number":2973,"context_line":"\tunsigned width32 \u003d (width \u003c 32) ? 32 : width;"},{"line_number":2974,"context_line":"\tfor (uint32_t c \u003d 0; c \u003c count; c++) {"},{"line_number":2975,"context_line":"\t\t/* Update the address if it is the first time or aampostincrement is not supported by the target. */"},{"line_number":2976,"context_line":"\t\tif (updateaddr) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"35c3c9c0_3eba68ec","line":2973,"in_reply_to":"371aa36a_75f39c5a","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":3551,"context_line":"\tchar *sysbus_result \u003d \"disabled\";"},{"line_number":3552,"context_line":"\tchar *abstract_result \u003d \"disabled\";"},{"line_number":3553,"context_line":""},{"line_number":3554,"context_line":"\tfor (unsigned i \u003d 0; i \u003c RISCV_NUM_MEM_ACCESS_METHODS; i++) {"},{"line_number":3555,"context_line":"\t\tint method \u003d r-\u003emem_access_methods[i];"},{"line_number":3556,"context_line":""},{"line_number":3557,"context_line":"\t\tif (method \u003d\u003d RISCV_MEM_ACCESS_PROGBUF) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"99a02b8f_b33b2f65","line":3554,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":3551,"context_line":"\tchar *sysbus_result \u003d \"disabled\";"},{"line_number":3552,"context_line":"\tchar *abstract_result \u003d \"disabled\";"},{"line_number":3553,"context_line":""},{"line_number":3554,"context_line":"\tfor (unsigned i \u003d 0; i \u003c RISCV_NUM_MEM_ACCESS_METHODS; i++) {"},{"line_number":3555,"context_line":"\t\tint method \u003d r-\u003emem_access_methods[i];"},{"line_number":3556,"context_line":""},{"line_number":3557,"context_line":"\t\tif (method \u003d\u003d RISCV_MEM_ACCESS_PROGBUF) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6f73afb4_08b3819f","line":3554,"in_reply_to":"99a02b8f_b33b2f65","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":3764,"context_line":"\t\t\tcontinue;"},{"line_number":3765,"context_line":"\t\t}"},{"line_number":3766,"context_line":""},{"line_number":3767,"context_line":"\t\tunsigned sberror \u003d get_field(sbcs, DM_SBCS_SBERROR);"},{"line_number":3768,"context_line":"\t\tif (sberror !\u003d 0) {"},{"line_number":3769,"context_line":"\t\t\t/* Sberror indicates the bus access failed, but not because we issued the writes"},{"line_number":3770,"context_line":"\t\t\t * too fast. Cannot recover. Sbaddress holds the address where the error occurred"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b8937ce6_dd63546a","line":3767,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":3764,"context_line":"\t\t\tcontinue;"},{"line_number":3765,"context_line":"\t\t}"},{"line_number":3766,"context_line":""},{"line_number":3767,"context_line":"\t\tunsigned sberror \u003d get_field(sbcs, DM_SBCS_SBERROR);"},{"line_number":3768,"context_line":"\t\tif (sberror !\u003d 0) {"},{"line_number":3769,"context_line":"\t\t\t/* Sberror indicates the bus access failed, but not because we issued the writes"},{"line_number":3770,"context_line":"\t\t\t * too fast. Cannot recover. Sbaddress holds the address where the error occurred"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a32a01a2_2b399356","line":3767,"in_reply_to":"b8937ce6_dd63546a","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":3997,"context_line":"\tchar *sysbus_result \u003d \"disabled\";"},{"line_number":3998,"context_line":"\tchar *abstract_result \u003d \"disabled\";"},{"line_number":3999,"context_line":""},{"line_number":4000,"context_line":"\tfor (unsigned i \u003d 0; i \u003c RISCV_NUM_MEM_ACCESS_METHODS; i++) {"},{"line_number":4001,"context_line":"\t\tint method \u003d r-\u003emem_access_methods[i];"},{"line_number":4002,"context_line":""},{"line_number":4003,"context_line":"\t\tif (method \u003d\u003d RISCV_MEM_ACCESS_PROGBUF) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ecf72f38_367a7221","line":4000,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":3997,"context_line":"\tchar *sysbus_result \u003d \"disabled\";"},{"line_number":3998,"context_line":"\tchar *abstract_result \u003d \"disabled\";"},{"line_number":3999,"context_line":""},{"line_number":4000,"context_line":"\tfor (unsigned i \u003d 0; i \u003c RISCV_NUM_MEM_ACCESS_METHODS; i++) {"},{"line_number":4001,"context_line":"\t\tint method \u003d r-\u003emem_access_methods[i];"},{"line_number":4002,"context_line":""},{"line_number":4003,"context_line":"\t\tif (method \u003d\u003d RISCV_MEM_ACCESS_PROGBUF) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c4af7510_c965b3d1","line":4000,"in_reply_to":"ecf72f38_367a7221","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"afe612915d403bad606e05eb95d2bcd2083e5870","unresolved":true,"context_lines":[{"line_number":4344,"context_line":"\t\treturn RISCV_HALT_GROUP;"},{"line_number":4345,"context_line":"\t}"},{"line_number":4346,"context_line":""},{"line_number":4347,"context_line":"\tLOG_ERROR(\"Unknown DCSR cause field: 0x%x\", (unsigned int)get_field(dcsr, CSR_DCSR_CAUSE));"},{"line_number":4348,"context_line":"\tLOG_ERROR(\"  dcsr\u003d0x%016lx\", (long)dcsr);"},{"line_number":4349,"context_line":"\treturn RISCV_HALT_UNKNOWN;"},{"line_number":4350,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0bf6ba35_dba1994e","line":4347,"updated":"2021-09-18 20:56:29.000000000","message":"also here no cast and PRIx64","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"388492b875ed834674ffc53ed226a4664446fbad","unresolved":false,"context_lines":[{"line_number":4344,"context_line":"\t\treturn RISCV_HALT_GROUP;"},{"line_number":4345,"context_line":"\t}"},{"line_number":4346,"context_line":""},{"line_number":4347,"context_line":"\tLOG_ERROR(\"Unknown DCSR cause field: 0x%x\", (unsigned int)get_field(dcsr, CSR_DCSR_CAUSE));"},{"line_number":4348,"context_line":"\tLOG_ERROR(\"  dcsr\u003d0x%016lx\", (long)dcsr);"},{"line_number":4349,"context_line":"\treturn RISCV_HALT_UNKNOWN;"},{"line_number":4350,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1bee1be6_b26158c9","line":4347,"in_reply_to":"0bf6ba35_dba1994e","updated":"2021-09-20 22:41:01.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"afe612915d403bad606e05eb95d2bcd2083e5870","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"302a24a6_bd34ad22","line":4863,"updated":"2021-09-18 20:56:29.000000000","message":"Not clear if it remains an empty line at the end of the file. In case, remove it","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"388492b875ed834674ffc53ed226a4664446fbad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5ad22c9_a8a758d9","line":4863,"in_reply_to":"302a24a6_bd34ad22","updated":"2021-09-20 22:41:01.000000000","message":"There is no empty line according to vim.","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":2074,"context_line":"\t\t\treturn set_field(0, DM_SBCS_SBACCESS, 4);"},{"line_number":2075,"context_line":"\t}"},{"line_number":2076,"context_line":"\tassert(0);"},{"line_number":2077,"context_line":"\treturn 0;\t/* Make mingw happy. */"},{"line_number":2078,"context_line":"}"},{"line_number":2079,"context_line":""},{"line_number":2080,"context_line":"static int sb_write_address(struct target *target, target_addr_t address,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"809b326d_eb131f0b","line":2077,"updated":"2021-09-22 10:37:02.000000000","message":"In fact assert is not supposed to always crash the program. If you define NDEBUG then assert does nothing, even not printing an error message","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":2074,"context_line":"\t\t\treturn set_field(0, DM_SBCS_SBACCESS, 4);"},{"line_number":2075,"context_line":"\t}"},{"line_number":2076,"context_line":"\tassert(0);"},{"line_number":2077,"context_line":"\treturn 0;\t/* Make mingw happy. */"},{"line_number":2078,"context_line":"}"},{"line_number":2079,"context_line":""},{"line_number":2080,"context_line":"static int sb_write_address(struct target *target, target_addr_t address,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"08da2d4d_10d68082","line":2077,"in_reply_to":"809b326d_eb131f0b","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3fb8337bb83f9ee0c248e67eac0b12509fc6c1e","unresolved":true,"context_lines":[{"line_number":2167,"context_line":"\t\t * batch over and over. So we create a new one every time through the"},{"line_number":2168,"context_line":"\t\t * loop."},{"line_number":2169,"context_line":"\t\t */"},{"line_number":2170,"context_line":"\t\tstruct riscv_batch *batch \u003d riscv_batch_alloc("},{"line_number":2171,"context_line":"\t\t\ttarget, 1 + enabled_count * 5 * repeat,"},{"line_number":2172,"context_line":"\t\t\tinfo-\u003edmi_busy_delay + info-\u003ebus_master_read_delay);"},{"line_number":2173,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1a3e2973_f6312a35","line":2170,"updated":"2021-09-22 13:26:16.000000000","message":"risc_batch_alloc() can return NULL!\nDo you need to check and quit?\nEventually, the \"Out of memory\" errors should be printed inside risc_batch_alloc(), not here","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":2167,"context_line":"\t\t * batch over and over. So we create a new one every time through the"},{"line_number":2168,"context_line":"\t\t * loop."},{"line_number":2169,"context_line":"\t\t */"},{"line_number":2170,"context_line":"\t\tstruct riscv_batch *batch \u003d riscv_batch_alloc("},{"line_number":2171,"context_line":"\t\t\ttarget, 1 + enabled_count * 5 * repeat,"},{"line_number":2172,"context_line":"\t\t\tinfo-\u003edmi_busy_delay + info-\u003ebus_master_read_delay);"},{"line_number":2173,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7ef11110_bca9b1e8","line":2170,"in_reply_to":"1a3e2973_f6312a35","updated":"2021-09-22 16:09:04.000000000","message":"Added code to log errors in riscv_batch_alloc(), and also check for NULL here.","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":2171,"context_line":"\t\t\ttarget, 1 + enabled_count * 5 * repeat,"},{"line_number":2172,"context_line":"\t\t\tinfo-\u003edmi_busy_delay + info-\u003ebus_master_read_delay);"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"\t\tunsigned result_bytes \u003d 0;"},{"line_number":2175,"context_line":"\t\tfor (unsigned n \u003d 0; n \u003c repeat; n++) {"},{"line_number":2176,"context_line":"\t\t\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(config-\u003ebucket); i++) {"},{"line_number":2177,"context_line":"\t\t\t\tif (config-\u003ebucket[i].enabled) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"37da3169_205734a1","line":2174,"updated":"2021-09-22 10:37:02.000000000","message":"unsigned int\nalso in next two lines","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":2171,"context_line":"\t\t\ttarget, 1 + enabled_count * 5 * repeat,"},{"line_number":2172,"context_line":"\t\t\tinfo-\u003edmi_busy_delay + info-\u003ebus_master_read_delay);"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"\t\tunsigned result_bytes \u003d 0;"},{"line_number":2175,"context_line":"\t\tfor (unsigned n \u003d 0; n \u003c repeat; n++) {"},{"line_number":2176,"context_line":"\t\t\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(config-\u003ebucket); i++) {"},{"line_number":2177,"context_line":"\t\t\t\tif (config-\u003ebucket[i].enabled) {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d7544003_7ed32dce","line":2174,"in_reply_to":"37da3169_205734a1","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":4323,"context_line":"\tif (result !\u003d ERROR_OK)"},{"line_number":4324,"context_line":"\t\treturn RISCV_HALT_UNKNOWN;"},{"line_number":4325,"context_line":""},{"line_number":4326,"context_line":"\tLOG_DEBUG(\"dcsr.cause: 0x%x\", (unsigned int)get_field(dcsr, CSR_DCSR_CAUSE));"},{"line_number":4327,"context_line":""},{"line_number":4328,"context_line":"\tswitch (get_field(dcsr, CSR_DCSR_CAUSE)) {"},{"line_number":4329,"context_line":"\tcase CSR_DCSR_CAUSE_SWBP:"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1a788c81_7a471489","line":4326,"updated":"2021-09-22 10:37:02.000000000","message":"should be PRIx64 without cast?","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":4323,"context_line":"\tif (result !\u003d ERROR_OK)"},{"line_number":4324,"context_line":"\t\treturn RISCV_HALT_UNKNOWN;"},{"line_number":4325,"context_line":""},{"line_number":4326,"context_line":"\tLOG_DEBUG(\"dcsr.cause: 0x%x\", (unsigned int)get_field(dcsr, CSR_DCSR_CAUSE));"},{"line_number":4327,"context_line":""},{"line_number":4328,"context_line":"\tswitch (get_field(dcsr, CSR_DCSR_CAUSE)) {"},{"line_number":4329,"context_line":"\tcase CSR_DCSR_CAUSE_SWBP:"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5c182b2e_a8cc40df","line":4326,"in_reply_to":"1a788c81_7a471489","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"}],"src/target/riscv/riscv.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":483,"context_line":"{"},{"line_number":484,"context_line":"\tLOG_DEBUG(\"riscv_deinit_target()\");"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"\triscv_info_t *info \u003d (riscv_info_t *) target-\u003earch_info;"},{"line_number":487,"context_line":"\tstruct target_type *tt \u003d get_target_type(target);"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"\tif (tt \u0026\u0026 info-\u003eversion_specific)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"91ddef24_b00b7a1a","line":486,"updated":"2021-09-18 20:19:34.000000000","message":"no space after cast","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":483,"context_line":"{"},{"line_number":484,"context_line":"\tLOG_DEBUG(\"riscv_deinit_target()\");"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"\triscv_info_t *info \u003d (riscv_info_t *) target-\u003earch_info;"},{"line_number":487,"context_line":"\tstruct target_type *tt \u003d get_target_type(target);"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"\tif (tt \u0026\u0026 info-\u003eversion_specific)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8012a809_16e2baba","line":486,"in_reply_to":"91ddef24_b00b7a1a","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":749,"context_line":"\t\t/* Can do the memory access directly without a helper buffer. */"},{"line_number":750,"context_line":"\t\treturn target_write_memory(target, address, access_size, size / access_size, buffer);"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"\tunsigned offset_head \u003d address % access_size;"},{"line_number":753,"context_line":"\tunsigned n_blocks \u003d ((size + offset_head) \u003c\u003d access_size) ? 1 : 2;"},{"line_number":754,"context_line":"\tuint8_t helper_buf[n_blocks * access_size];"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"\t/* Read from memory */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7467947a_172f07ce","line":753,"range":{"start_line":752,"start_character":1,"end_line":753,"end_character":9},"updated":"2021-09-18 20:19:34.000000000","message":"\u0027unsigned int\u0027 is preferred to \u0027unsigned\u0027","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":749,"context_line":"\t\t/* Can do the memory access directly without a helper buffer. */"},{"line_number":750,"context_line":"\t\treturn target_write_memory(target, address, access_size, size / access_size, buffer);"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"\tunsigned offset_head \u003d address % access_size;"},{"line_number":753,"context_line":"\tunsigned n_blocks \u003d ((size + offset_head) \u003c\u003d access_size) ? 1 : 2;"},{"line_number":754,"context_line":"\tuint8_t helper_buf[n_blocks * access_size];"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"\t/* Read from memory */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"af38bc73_2dbfae6f","line":753,"range":{"start_line":752,"start_character":1,"end_line":753,"end_character":9},"in_reply_to":"7467947a_172f07ce","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":776,"context_line":"\t\t/* Can do the memory access directly without a helper buffer. */"},{"line_number":777,"context_line":"\t\treturn target_read_memory(target, address, access_size, size / access_size, buffer);"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"\tunsigned offset_head \u003d address % access_size;"},{"line_number":780,"context_line":"\tunsigned n_blocks \u003d ((size + offset_head) \u003c\u003d access_size) ? 1 : 2;"},{"line_number":781,"context_line":"\tuint8_t helper_buf[n_blocks * access_size];"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"\t/* Read from memory */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"743cbf84_63abb11c","line":780,"range":{"start_line":779,"start_character":1,"end_line":780,"end_character":9},"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":776,"context_line":"\t\t/* Can do the memory access directly without a helper buffer. */"},{"line_number":777,"context_line":"\t\treturn target_read_memory(target, address, access_size, size / access_size, buffer);"},{"line_number":778,"context_line":""},{"line_number":779,"context_line":"\tunsigned offset_head \u003d address % access_size;"},{"line_number":780,"context_line":"\tunsigned n_blocks \u003d ((size + offset_head) \u003c\u003d access_size) ? 1 : 2;"},{"line_number":781,"context_line":"\tuint8_t helper_buf[n_blocks * access_size];"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"\t/* Read from memory */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9abafb25_efcdb428","line":780,"range":{"start_line":779,"start_character":1,"end_line":780,"end_character":9},"in_reply_to":"743cbf84_63abb11c","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":798,"context_line":"\tassert(size \u003d\u003d 1 || size \u003d\u003d 2 ||  size \u003d\u003d 4 || size \u003d\u003d 8);"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"\t/* Find access size that correspond to data size and the alignment. */"},{"line_number":801,"context_line":"\tunsigned preferred_size \u003d size;"},{"line_number":802,"context_line":"\twhile (address % preferred_size !\u003d 0)"},{"line_number":803,"context_line":"\t\tpreferred_size /\u003d 2;"},{"line_number":804,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cf084b4e_2a1c13a1","line":801,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":798,"context_line":"\tassert(size \u003d\u003d 1 || size \u003d\u003d 2 ||  size \u003d\u003d 4 || size \u003d\u003d 8);"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"\t/* Find access size that correspond to data size and the alignment. */"},{"line_number":801,"context_line":"\tunsigned preferred_size \u003d size;"},{"line_number":802,"context_line":"\twhile (address % preferred_size !\u003d 0)"},{"line_number":803,"context_line":"\t\tpreferred_size /\u003d 2;"},{"line_number":804,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"09472dfe_33648edf","line":801,"in_reply_to":"cf084b4e_2a1c13a1","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":808,"context_line":""},{"line_number":809,"context_line":"\t/* On failure, try other access sizes."},{"line_number":810,"context_line":"\t   Minimize the number of accesses by trying first the largest size. */"},{"line_number":811,"context_line":"\tfor (unsigned access_size \u003d 8; access_size \u003e 0; access_size /\u003d 2) {"},{"line_number":812,"context_line":"\t\tif (access_size \u003d\u003d preferred_size)"},{"line_number":813,"context_line":"\t\t\t/* Already tried this size. */"},{"line_number":814,"context_line":"\t\t\tcontinue;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"692c3794_9341fbea","line":811,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":808,"context_line":""},{"line_number":809,"context_line":"\t/* On failure, try other access sizes."},{"line_number":810,"context_line":"\t   Minimize the number of accesses by trying first the largest size. */"},{"line_number":811,"context_line":"\tfor (unsigned access_size \u003d 8; access_size \u003e 0; access_size /\u003d 2) {"},{"line_number":812,"context_line":"\t\tif (access_size \u003d\u003d preferred_size)"},{"line_number":813,"context_line":"\t\t\t/* Already tried this size. */"},{"line_number":814,"context_line":"\t\t\tcontinue;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d3165d63_7387dae7","line":811,"in_reply_to":"692c3794_9341fbea","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":830,"context_line":"\tassert(size \u003d\u003d 1 || size \u003d\u003d 2 ||  size \u003d\u003d 4 || size \u003d\u003d 8);"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"\t/* Find access size that correspond to data size and the alignment. */"},{"line_number":833,"context_line":"\tunsigned preferred_size \u003d size;"},{"line_number":834,"context_line":"\twhile (address % preferred_size !\u003d 0)"},{"line_number":835,"context_line":"\t\tpreferred_size /\u003d 2;"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"997a62a8_75ee31fd","line":833,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":830,"context_line":"\tassert(size \u003d\u003d 1 || size \u003d\u003d 2 ||  size \u003d\u003d 4 || size \u003d\u003d 8);"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"\t/* Find access size that correspond to data size and the alignment. */"},{"line_number":833,"context_line":"\tunsigned preferred_size \u003d size;"},{"line_number":834,"context_line":"\twhile (address % preferred_size !\u003d 0)"},{"line_number":835,"context_line":"\t\tpreferred_size /\u003d 2;"},{"line_number":836,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9aaf63f6_b817c8f1","line":833,"in_reply_to":"997a62a8_75ee31fd","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":840,"context_line":""},{"line_number":841,"context_line":"\t/* On failure, try other access sizes."},{"line_number":842,"context_line":"\t   Minimize the number of accesses by trying first the largest size. */"},{"line_number":843,"context_line":"\tfor (unsigned access_size \u003d 8; access_size \u003e 0; access_size /\u003d 2) {"},{"line_number":844,"context_line":"\t\tif (access_size \u003d\u003d preferred_size)"},{"line_number":845,"context_line":"\t\t\t/* Already tried this size. */"},{"line_number":846,"context_line":"\t\t\tcontinue;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ebe4f8ba_81315604","line":843,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":840,"context_line":""},{"line_number":841,"context_line":"\t/* On failure, try other access sizes."},{"line_number":842,"context_line":"\t   Minimize the number of accesses by trying first the largest size. */"},{"line_number":843,"context_line":"\tfor (unsigned access_size \u003d 8; access_size \u003e 0; access_size /\u003d 2) {"},{"line_number":844,"context_line":"\t\tif (access_size \u003d\u003d preferred_size)"},{"line_number":845,"context_line":"\t\t\t/* Already tried this size. */"},{"line_number":846,"context_line":"\t\t\tcontinue;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b3b74101_5690b522","line":843,"in_reply_to":"ebe4f8ba_81315604","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":1311,"context_line":"\t\triscv_reg_t tselect;"},{"line_number":1312,"context_line":"\t\tif (riscv_get_register(target, \u0026tselect, GDB_REGNO_TSELECT) !\u003d ERROR_OK)"},{"line_number":1313,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":1314,"context_line":"\t\tfor (unsigned t \u003d 0; t \u003c r-\u003etrigger_count; t++) {"},{"line_number":1315,"context_line":"\t\t\tif (riscv_set_register(target, GDB_REGNO_TSELECT, t) !\u003d ERROR_OK)"},{"line_number":1316,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":1317,"context_line":"\t\t\triscv_reg_t tdata1;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"767e43df_4066a6d0","line":1314,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":1311,"context_line":"\t\triscv_reg_t tselect;"},{"line_number":1312,"context_line":"\t\tif (riscv_get_register(target, \u0026tselect, GDB_REGNO_TSELECT) !\u003d ERROR_OK)"},{"line_number":1313,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":1314,"context_line":"\t\tfor (unsigned t \u003d 0; t \u003c r-\u003etrigger_count; t++) {"},{"line_number":1315,"context_line":"\t\t\tif (riscv_set_register(target, GDB_REGNO_TSELECT, t) !\u003d ERROR_OK)"},{"line_number":1316,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":1317,"context_line":"\t\t\triscv_reg_t tdata1;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"69876171_41a95db6","line":1314,"in_reply_to":"767e43df_4066a6d0","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":1354,"context_line":"\t\triscv_reg_t tselect;"},{"line_number":1355,"context_line":"\t\tif (riscv_get_register(target, \u0026tselect, GDB_REGNO_TSELECT) !\u003d ERROR_OK)"},{"line_number":1356,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":1357,"context_line":"\t\tfor (unsigned t \u003d 0; t \u003c r-\u003etrigger_count; t++) {"},{"line_number":1358,"context_line":"\t\t\tif (state[t] !\u003d 0) {"},{"line_number":1359,"context_line":"\t\t\t\tif (riscv_set_register(target, GDB_REGNO_TSELECT, t) !\u003d ERROR_OK)"},{"line_number":1360,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3389770a_124df701","line":1357,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"\t\triscv_reg_t tselect;"},{"line_number":1355,"context_line":"\t\tif (riscv_get_register(target, \u0026tselect, GDB_REGNO_TSELECT) !\u003d ERROR_OK)"},{"line_number":1356,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":1357,"context_line":"\t\tfor (unsigned t \u003d 0; t \u003c r-\u003etrigger_count; t++) {"},{"line_number":1358,"context_line":"\t\t\tif (state[t] !\u003d 0) {"},{"line_number":1359,"context_line":"\t\t\t\tif (riscv_set_register(target, GDB_REGNO_TSELECT, t) !\u003d ERROR_OK)"},{"line_number":1360,"context_line":"\t\t\t\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a4dc2878_c8b261ec","line":1357,"in_reply_to":"3389770a_124df701","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"\t/* Default slow path. */"},{"line_number":2141,"context_line":"\twhile (timeval_ms() - start \u003c TARGET_DEFAULT_POLLING_INTERVAL) {"},{"line_number":2142,"context_line":"\t\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(r-\u003esample_config.bucket); i++) {"},{"line_number":2143,"context_line":"\t\t\tif (r-\u003esample_config.bucket[i].enabled \u0026\u0026"},{"line_number":2144,"context_line":"\t\t\t\t\tr-\u003esample_buf.used + 1 + r-\u003esample_config.bucket[i].size_bytes \u003c r-\u003esample_buf.size) {"},{"line_number":2145,"context_line":"\t\t\t\tassert(i \u003c RISCV_SAMPLE_BUF_TIMESTAMP_BEFORE);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9195c589_7d4391c0","line":2142,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"\t/* Default slow path. */"},{"line_number":2141,"context_line":"\twhile (timeval_ms() - start \u003c TARGET_DEFAULT_POLLING_INTERVAL) {"},{"line_number":2142,"context_line":"\t\tfor (unsigned i \u003d 0; i \u003c ARRAY_SIZE(r-\u003esample_config.bucket); i++) {"},{"line_number":2143,"context_line":"\t\t\tif (r-\u003esample_config.bucket[i].enabled \u0026\u0026"},{"line_number":2144,"context_line":"\t\t\t\t\tr-\u003esample_buf.used + 1 + r-\u003esample_config.bucket[i].size_bytes \u003c r-\u003esample_buf.size) {"},{"line_number":2145,"context_line":"\t\t\t\tassert(i \u003c RISCV_SAMPLE_BUF_TIMESTAMP_BEFORE);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"883d32b9_44045137","line":2142,"in_reply_to":"9195c589_7d4391c0","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"afe612915d403bad606e05eb95d2bcd2083e5870","unresolved":true,"context_lines":[{"line_number":2237,"context_line":"\t\t}"},{"line_number":2238,"context_line":""},{"line_number":2239,"context_line":"\t\t/* Sample memory if any target is running. */"},{"line_number":2240,"context_line":"\t\tfor (struct target_list *list \u003d target-\u003ehead; list !\u003d NULL;"},{"line_number":2241,"context_line":"\t\t\t\tlist \u003d list-\u003enext, i++) {"},{"line_number":2242,"context_line":"\t\t\tstruct target *t \u003d list-\u003etarget;"},{"line_number":2243,"context_line":"\t\t\tif (t-\u003estate \u003d\u003d TARGET_RUNNING) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f5c4e32b_99f49a63","line":2240,"updated":"2021-09-18 20:56:29.000000000","message":"no NULL comparison. write the test as\n; list;","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"388492b875ed834674ffc53ed226a4664446fbad","unresolved":false,"context_lines":[{"line_number":2237,"context_line":"\t\t}"},{"line_number":2238,"context_line":""},{"line_number":2239,"context_line":"\t\t/* Sample memory if any target is running. */"},{"line_number":2240,"context_line":"\t\tfor (struct target_list *list \u003d target-\u003ehead; list !\u003d NULL;"},{"line_number":2241,"context_line":"\t\t\t\tlist \u003d list-\u003enext, i++) {"},{"line_number":2242,"context_line":"\t\t\tstruct target *t \u003d list-\u003etarget;"},{"line_number":2243,"context_line":"\t\t\tif (t-\u003estate \u003d\u003d TARGET_RUNNING) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5d4ac242_1dd893f7","line":2240,"in_reply_to":"f5c4e32b_99f49a63","updated":"2021-09-20 22:41:01.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2256,"context_line":"\t\t\t\tsample_memory(target);"},{"line_number":2257,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":2258,"context_line":"\t\t}"},{"line_number":2259,"context_line":"\t\telse if (out \u003d\u003d RPH_ERROR)"},{"line_number":2260,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2261,"context_line":""},{"line_number":2262,"context_line":"\t\thalted_hart \u003d riscv_current_hartid(target);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1fa5a8c4_bf5b11a7","line":2259,"updated":"2021-09-18 20:19:34.000000000","message":"put \u0027} else if (...)\u0027 in the same line\nCoding stile requires that all the branches of if/else if/else must have {} or all without. So this \u0027else if\u0027 should enclose in {} the return statement on next line","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2256,"context_line":"\t\t\t\tsample_memory(target);"},{"line_number":2257,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":2258,"context_line":"\t\t}"},{"line_number":2259,"context_line":"\t\telse if (out \u003d\u003d RPH_ERROR)"},{"line_number":2260,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2261,"context_line":""},{"line_number":2262,"context_line":"\t\thalted_hart \u003d riscv_current_hartid(target);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fc102707_d816113a","line":2259,"in_reply_to":"1fa5a8c4_bf5b11a7","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2399,"context_line":"\t}"},{"line_number":2400,"context_line":""},{"line_number":2401,"context_line":"\t/* Check argument validity */"},{"line_number":2402,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++) {"},{"line_number":2403,"context_line":"\t\tif (strcmp(\"progbuf\", CMD_ARGV[i]) \u003d\u003d 0)"},{"line_number":2404,"context_line":"\t\t\tprogbuf_cnt++;"},{"line_number":2405,"context_line":"\t\telse if (strcmp(\"sysbus\", CMD_ARGV[i]) \u003d\u003d 0)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ab5d81c9_7bb1ceb6","line":2402,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2399,"context_line":"\t}"},{"line_number":2400,"context_line":""},{"line_number":2401,"context_line":"\t/* Check argument validity */"},{"line_number":2402,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++) {"},{"line_number":2403,"context_line":"\t\tif (strcmp(\"progbuf\", CMD_ARGV[i]) \u003d\u003d 0)"},{"line_number":2404,"context_line":"\t\t\tprogbuf_cnt++;"},{"line_number":2405,"context_line":"\t\telse if (strcmp(\"sysbus\", CMD_ARGV[i]) \u003d\u003d 0)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e6c57e0a_eb6ba983","line":2402,"in_reply_to":"ab5d81c9_7bb1ceb6","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2406,"context_line":"\t\t\tsysbus_cnt++;"},{"line_number":2407,"context_line":"\t\telse if (strcmp(\"abstract\", CMD_ARGV[i]) \u003d\u003d 0)"},{"line_number":2408,"context_line":"\t\t\tabstract_cnt++;"},{"line_number":2409,"context_line":"\t\telse {"},{"line_number":2410,"context_line":"\t\t\tLOG_ERROR(\"Unknown argument \u0027%s\u0027. \""},{"line_number":2411,"context_line":"\t\t\t\t\"Must be one of: \u0027progbuf\u0027, \u0027sysbus\u0027 or \u0027abstract\u0027.\", CMD_ARGV[i]);"},{"line_number":2412,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"05fed149_0ccb5302","line":2409,"updated":"2021-09-18 20:19:34.000000000","message":"this last else requires {}, so add {} to all the branches above","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2406,"context_line":"\t\t\tsysbus_cnt++;"},{"line_number":2407,"context_line":"\t\telse if (strcmp(\"abstract\", CMD_ARGV[i]) \u003d\u003d 0)"},{"line_number":2408,"context_line":"\t\t\tabstract_cnt++;"},{"line_number":2409,"context_line":"\t\telse {"},{"line_number":2410,"context_line":"\t\t\tLOG_ERROR(\"Unknown argument \u0027%s\u0027. \""},{"line_number":2411,"context_line":"\t\t\t\t\"Must be one of: \u0027progbuf\u0027, \u0027sysbus\u0027 or \u0027abstract\u0027.\", CMD_ARGV[i]);"},{"line_number":2412,"context_line":"\t\t\treturn ERROR_COMMAND_SYNTAX_ERROR;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"83818e6f_26fa0593","line":2409,"in_reply_to":"05fed149_0ccb5302","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2418,"context_line":"\t}"},{"line_number":2419,"context_line":""},{"line_number":2420,"context_line":"\t/* Args are valid, store them */"},{"line_number":2421,"context_line":"\tfor (unsigned i \u003d 0; i \u003c RISCV_NUM_MEM_ACCESS_METHODS; i++)"},{"line_number":2422,"context_line":"\t\tr-\u003emem_access_methods[i] \u003d RISCV_MEM_ACCESS_UNSPECIFIED;"},{"line_number":2423,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++) {"},{"line_number":2424,"context_line":"\t\tif (strcmp(\"progbuf\", CMD_ARGV[i]) \u003d\u003d 0)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d9d201e6_ee036b3a","line":2421,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int, also next \u0027for\u0027","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2418,"context_line":"\t}"},{"line_number":2419,"context_line":""},{"line_number":2420,"context_line":"\t/* Args are valid, store them */"},{"line_number":2421,"context_line":"\tfor (unsigned i \u003d 0; i \u003c RISCV_NUM_MEM_ACCESS_METHODS; i++)"},{"line_number":2422,"context_line":"\t\tr-\u003emem_access_methods[i] \u003d RISCV_MEM_ACCESS_UNSPECIFIED;"},{"line_number":2423,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++) {"},{"line_number":2424,"context_line":"\t\tif (strcmp(\"progbuf\", CMD_ARGV[i]) \u003d\u003d 0)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9f4b6a4e_50a84cef","line":2421,"in_reply_to":"d9d201e6_ee036b3a","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2447,"context_line":"\treturn ERROR_OK;"},{"line_number":2448,"context_line":"}"},{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"int parse_ranges(struct list_head *ranges, const char *tcl_arg, const char *reg_type, unsigned max_val)"},{"line_number":2451,"context_line":"{"},{"line_number":2452,"context_line":"\tchar *args \u003d strdup(tcl_arg);"},{"line_number":2453,"context_line":"\tif (!args)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7a4e6f2f_f732de68","line":2450,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2447,"context_line":"\treturn ERROR_OK;"},{"line_number":2448,"context_line":"}"},{"line_number":2449,"context_line":""},{"line_number":2450,"context_line":"int parse_ranges(struct list_head *ranges, const char *tcl_arg, const char *reg_type, unsigned max_val)"},{"line_number":2451,"context_line":"{"},{"line_number":2452,"context_line":"\tchar *args \u003d strdup(tcl_arg);"},{"line_number":2453,"context_line":"\tif (!args)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"220fa0f3_597e9349","line":2450,"in_reply_to":"7a4e6f2f_f732de68","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2462,"context_line":""},{"line_number":2463,"context_line":"\t\tchar *dash \u003d strchr(arg, \u0027-\u0027);"},{"line_number":2464,"context_line":"\t\tchar *equals \u003d strchr(arg, \u0027\u003d\u0027);"},{"line_number":2465,"context_line":"\t\tunsigned pos;"},{"line_number":2466,"context_line":""},{"line_number":2467,"context_line":"\t\tif (!dash \u0026\u0026 !equals) {"},{"line_number":2468,"context_line":"\t\t\t/* Expecting single register number. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"07d313af_3b9ae54e","line":2465,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2462,"context_line":""},{"line_number":2463,"context_line":"\t\tchar *dash \u003d strchr(arg, \u0027-\u0027);"},{"line_number":2464,"context_line":"\t\tchar *equals \u003d strchr(arg, \u0027\u003d\u0027);"},{"line_number":2465,"context_line":"\t\tunsigned pos;"},{"line_number":2466,"context_line":""},{"line_number":2467,"context_line":"\t\tif (!dash \u0026\u0026 !equals) {"},{"line_number":2468,"context_line":"\t\t\t/* Expecting single register number. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9f6261de_13e031aa","line":2465,"in_reply_to":"07d313af_3b9ae54e","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2581,"context_line":"\tRISCV_INFO(info);"},{"line_number":2582,"context_line":"\tint ret \u003d ERROR_OK;"},{"line_number":2583,"context_line":""},{"line_number":2584,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++) {"},{"line_number":2585,"context_line":"\t\tret \u003d parse_ranges(\u0026info-\u003eexpose_csr, CMD_ARGV[i], \"csr\", 0xfff);"},{"line_number":2586,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":2587,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"71ded881_601aca6d","line":2584,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2581,"context_line":"\tRISCV_INFO(info);"},{"line_number":2582,"context_line":"\tint ret \u003d ERROR_OK;"},{"line_number":2583,"context_line":""},{"line_number":2584,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++) {"},{"line_number":2585,"context_line":"\t\tret \u003d parse_ranges(\u0026info-\u003eexpose_csr, CMD_ARGV[i], \"csr\", 0xfff);"},{"line_number":2586,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":2587,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"da7deedf_77a9ea96","line":2584,"in_reply_to":"71ded881_601aca6d","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2601,"context_line":"\tRISCV_INFO(info);"},{"line_number":2602,"context_line":"\tint ret \u003d ERROR_OK;"},{"line_number":2603,"context_line":""},{"line_number":2604,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++) {"},{"line_number":2605,"context_line":"\t\tret \u003d parse_ranges(\u0026info-\u003eexpose_custom, CMD_ARGV[i], \"custom\", 0x3fff);"},{"line_number":2606,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":2607,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"653638eb_6fbbdc87","line":2604,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2601,"context_line":"\tRISCV_INFO(info);"},{"line_number":2602,"context_line":"\tint ret \u003d ERROR_OK;"},{"line_number":2603,"context_line":""},{"line_number":2604,"context_line":"\tfor (unsigned i \u003d 0; i \u003c CMD_ARGC; i++) {"},{"line_number":2605,"context_line":"\t\tret \u003d parse_ranges(\u0026info-\u003eexpose_custom, CMD_ARGV[i], \"custom\", 0x3fff);"},{"line_number":2606,"context_line":"\t\tif (ret !\u003d ERROR_OK)"},{"line_number":2607,"context_line":"\t\t\tbreak;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5719c343_e28cf2a7","line":2604,"in_reply_to":"653638eb_6fbbdc87","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2612,"context_line":""},{"line_number":2613,"context_line":"COMMAND_HANDLER(riscv_authdata_read)"},{"line_number":2614,"context_line":"{"},{"line_number":2615,"context_line":"\tunsigned index \u003d 0;"},{"line_number":2616,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":2617,"context_line":"\t\t/* nop */"},{"line_number":2618,"context_line":"\t} else if (CMD_ARGC \u003d\u003d 1) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"50080f3a_ab1910cc","line":2615,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2612,"context_line":""},{"line_number":2613,"context_line":"COMMAND_HANDLER(riscv_authdata_read)"},{"line_number":2614,"context_line":"{"},{"line_number":2615,"context_line":"\tunsigned index \u003d 0;"},{"line_number":2616,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":2617,"context_line":"\t\t/* nop */"},{"line_number":2618,"context_line":"\t} else if (CMD_ARGC \u003d\u003d 1) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fb175dd6_df6ca76b","line":2615,"in_reply_to":"50080f3a_ab1910cc","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":2884,"context_line":"}"},{"line_number":2885,"context_line":""},{"line_number":2886,"context_line":"COMMAND_HELPER(riscv_print_info_line, const char *section, const char *key,"},{"line_number":2887,"context_line":"\t\t\t   unsigned value)"},{"line_number":2888,"context_line":"{"},{"line_number":2889,"context_line":"\tchar full_key[80];"},{"line_number":2890,"context_line":"\tsnprintf(full_key, sizeof(full_key), \"%s.%s\", section, key);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ea64b938_27ef8501","line":2887,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":2884,"context_line":"}"},{"line_number":2885,"context_line":""},{"line_number":2886,"context_line":"COMMAND_HELPER(riscv_print_info_line, const char *section, const char *key,"},{"line_number":2887,"context_line":"\t\t\t   unsigned value)"},{"line_number":2888,"context_line":"{"},{"line_number":2889,"context_line":"\tchar full_key[80];"},{"line_number":2890,"context_line":"\tsnprintf(full_key, sizeof(full_key), \"%s.%s\", section, key);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"03524731_bfb95f92","line":2887,"in_reply_to":"ea64b938_27ef8501","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"afe612915d403bad606e05eb95d2bcd2083e5870","unresolved":true,"context_lines":[{"line_number":2915,"context_line":"\t\t.name \u003d \"info\","},{"line_number":2916,"context_line":"\t\t.handler \u003d handle_info,"},{"line_number":2917,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":2918,"context_line":"\t\t.usage \u003d \"riscv info\","},{"line_number":2919,"context_line":"\t\t.help \u003d \"Displays some information OpenOCD detected about the target.\""},{"line_number":2920,"context_line":"\t},"},{"line_number":2921,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5f47d6cf_eaa48807","line":2918,"updated":"2021-09-18 20:56:29.000000000","message":"usage should be \"\" because there is no extra parameter","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"388492b875ed834674ffc53ed226a4664446fbad","unresolved":false,"context_lines":[{"line_number":2915,"context_line":"\t\t.name \u003d \"info\","},{"line_number":2916,"context_line":"\t\t.handler \u003d handle_info,"},{"line_number":2917,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":2918,"context_line":"\t\t.usage \u003d \"riscv info\","},{"line_number":2919,"context_line":"\t\t.help \u003d \"Displays some information OpenOCD detected about the target.\""},{"line_number":2920,"context_line":"\t},"},{"line_number":2921,"context_line":"\t{"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bde6c443_b7269088","line":2918,"in_reply_to":"5f47d6cf_eaa48807","updated":"2021-09-20 22:41:01.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":3531,"context_line":"\t\treturn ERROR_OK;"},{"line_number":3532,"context_line":"\t}"},{"line_number":3533,"context_line":""},{"line_number":3534,"context_line":"\tfor (unsigned t \u003d 0; t \u003c RISCV_MAX_TRIGGERS; ++t) {"},{"line_number":3535,"context_line":"\t\tr-\u003etrigger_count \u003d t;"},{"line_number":3536,"context_line":""},{"line_number":3537,"context_line":"\t\t/* If we can\u0027t write tselect, then this hart does not support triggers. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d452d10e_16e5de83","line":3534,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":3531,"context_line":"\t\treturn ERROR_OK;"},{"line_number":3532,"context_line":"\t}"},{"line_number":3533,"context_line":""},{"line_number":3534,"context_line":"\tfor (unsigned t \u003d 0; t \u003c RISCV_MAX_TRIGGERS; ++t) {"},{"line_number":3535,"context_line":"\t\tr-\u003etrigger_count \u003d t;"},{"line_number":3536,"context_line":""},{"line_number":3537,"context_line":"\t\t/* If we can\u0027t write tselect, then this hart does not support triggers. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0c0b58e0_a6427f63","line":3534,"in_reply_to":"d452d10e_16e5de83","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":3543,"context_line":"\t\t\treturn result;"},{"line_number":3544,"context_line":"\t\t/* Mask off the top bit, which is used as tdrmode in old"},{"line_number":3545,"context_line":"\t\t\t* implementations. */"},{"line_number":3546,"context_line":"\t\ttselect_rb \u0026\u003d ~(1ULL \u003c\u003c (riscv_xlen(target)-1));"},{"line_number":3547,"context_line":"\t\tif (tselect_rb !\u003d t)"},{"line_number":3548,"context_line":"\t\t\tbreak;"},{"line_number":3549,"context_line":"\t\tuint64_t tdata1;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1abe6998_a476b25b","line":3546,"updated":"2021-09-18 20:19:34.000000000","message":"add space around \u0027-\u0027","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":3543,"context_line":"\t\t\treturn result;"},{"line_number":3544,"context_line":"\t\t/* Mask off the top bit, which is used as tdrmode in old"},{"line_number":3545,"context_line":"\t\t\t* implementations. */"},{"line_number":3546,"context_line":"\t\ttselect_rb \u0026\u003d ~(1ULL \u003c\u003c (riscv_xlen(target)-1));"},{"line_number":3547,"context_line":"\t\tif (tselect_rb !\u003d t)"},{"line_number":3548,"context_line":"\t\t\tbreak;"},{"line_number":3549,"context_line":"\t\tuint64_t tdata1;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7146b941_95642aff","line":3546,"in_reply_to":"1abe6998_a476b25b","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":426,"context_line":"\tLOG_DEBUG(\"riscv_create_target()\");"},{"line_number":427,"context_line":"\ttarget-\u003earch_info \u003d calloc(1, sizeof(riscv_info_t));"},{"line_number":428,"context_line":"\tif (!target-\u003earch_info)"},{"line_number":429,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":430,"context_line":"\triscv_info_init(target, target-\u003earch_info);"},{"line_number":431,"context_line":"\treturn ERROR_OK;"},{"line_number":432,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7e44da35_0747460e","line":429,"updated":"2021-09-22 10:37:02.000000000","message":"add LOG_ERROR(\"Out of memory\")","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":426,"context_line":"\tLOG_DEBUG(\"riscv_create_target()\");"},{"line_number":427,"context_line":"\ttarget-\u003earch_info \u003d calloc(1, sizeof(riscv_info_t));"},{"line_number":428,"context_line":"\tif (!target-\u003earch_info)"},{"line_number":429,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":430,"context_line":"\triscv_info_init(target, target-\u003earch_info);"},{"line_number":431,"context_line":"\treturn ERROR_OK;"},{"line_number":432,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ae4c9592_6fd774e7","line":429,"in_reply_to":"7e44da35_0747460e","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":448,"context_line":"\t\tir_user4[0] \u003d (uint8_t)ir_user4_raw;"},{"line_number":449,"context_line":"\t\tir_user4[1] \u003d (uint8_t)(ir_user4_raw \u003e\u003e\u003d 8);"},{"line_number":450,"context_line":"\t\tir_user4[2] \u003d (uint8_t)(ir_user4_raw \u003e\u003e\u003d 8);"},{"line_number":451,"context_line":"\t\tir_user4[3] \u003d (uint8_t)(ir_user4_raw \u003e\u003e\u003d 8);"},{"line_number":452,"context_line":"\t\tselect_user4.num_bits \u003d target-\u003etap-\u003eir_length;"},{"line_number":453,"context_line":"\t\tbscan_tunneled_ir_width[0] \u003d bscan_tunnel_ir_width;"},{"line_number":454,"context_line":"\t\tif (bscan_tunnel_type \u003d\u003d BSCAN_TUNNEL_DATA_REGISTER)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a42703f4_6dbe9080","line":451,"updated":"2021-09-22 10:37:02.000000000","message":"mumbling ... not sure this is more efficient nor more readable than shift the initial value by 8, 16 and 24. The way this is written creates dependencies of each line from the previous, but maybe compiler is smart enough!\nNo need to change it","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":448,"context_line":"\t\tir_user4[0] \u003d (uint8_t)ir_user4_raw;"},{"line_number":449,"context_line":"\t\tir_user4[1] \u003d (uint8_t)(ir_user4_raw \u003e\u003e\u003d 8);"},{"line_number":450,"context_line":"\t\tir_user4[2] \u003d (uint8_t)(ir_user4_raw \u003e\u003e\u003d 8);"},{"line_number":451,"context_line":"\t\tir_user4[3] \u003d (uint8_t)(ir_user4_raw \u003e\u003e\u003d 8);"},{"line_number":452,"context_line":"\t\tselect_user4.num_bits \u003d target-\u003etap-\u003eir_length;"},{"line_number":453,"context_line":"\t\tbscan_tunneled_ir_width[0] \u003d bscan_tunnel_ir_width;"},{"line_number":454,"context_line":"\t\tif (bscan_tunnel_type \u003d\u003d BSCAN_TUNNEL_DATA_REGISTER)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"66d20c05_fba62265","line":451,"in_reply_to":"a42703f4_6dbe9080","updated":"2021-09-22 16:09:04.000000000","message":"Ack","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":483,"context_line":"{"},{"line_number":484,"context_line":"\tLOG_DEBUG(\"riscv_deinit_target()\");"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"\triscv_info_t *info \u003d (riscv_info_t *)target-\u003earch_info;"},{"line_number":487,"context_line":"\tstruct target_type *tt \u003d get_target_type(target);"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"\tif (tt \u0026\u0026 info-\u003eversion_specific)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4b58a3dc_07a0837e","line":486,"updated":"2021-09-22 10:37:02.000000000","message":"no need for cast. arch_info is void*","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":483,"context_line":"{"},{"line_number":484,"context_line":"\tLOG_DEBUG(\"riscv_deinit_target()\");"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"\triscv_info_t *info \u003d (riscv_info_t *)target-\u003earch_info;"},{"line_number":487,"context_line":"\tstruct target_type *tt \u003d get_target_type(target);"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"\tif (tt \u0026\u0026 info-\u003eversion_specific)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a86e317b_c5bfb23e","line":486,"in_reply_to":"4b58a3dc_07a0837e","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":545,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_w, trigger-\u003ewrite);"},{"line_number":546,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_x, trigger-\u003eexecute);"},{"line_number":547,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_u,"},{"line_number":548,"context_line":"\t\t\t!!(r-\u003emisa \u0026 (1 \u003c\u003c (\u0027U\u0027 - \u0027A\u0027))));"},{"line_number":549,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_s,"},{"line_number":550,"context_line":"\t\t\t!!(r-\u003emisa \u0026 (1 \u003c\u003c (\u0027S\u0027 - \u0027A\u0027))));"},{"line_number":551,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_h,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b9bcae2a_bdd6f154","line":548,"updated":"2021-09-22 10:37:02.000000000","message":"can this be BIT(\u0027U\u0027 - \u0027A\u0027) ? also few other places below","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":545,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_w, trigger-\u003ewrite);"},{"line_number":546,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_x, trigger-\u003eexecute);"},{"line_number":547,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_u,"},{"line_number":548,"context_line":"\t\t\t!!(r-\u003emisa \u0026 (1 \u003c\u003c (\u0027U\u0027 - \u0027A\u0027))));"},{"line_number":549,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_s,"},{"line_number":550,"context_line":"\t\t\t!!(r-\u003emisa \u0026 (1 \u003c\u003c (\u0027S\u0027 - \u0027A\u0027))));"},{"line_number":551,"context_line":"\ttdata1 \u003d set_field(tdata1, bpcontrol_h,"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"044a1042_6b9ed4c0","line":548,"in_reply_to":"b9bcae2a_bdd6f154","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"\t/* First try the preferred (most natural) access size. */"},{"line_number":838,"context_line":"\tif (read_by_given_size(target, address, size, buffer, preferred_size) \u003d\u003d ERROR_OK)"},{"line_number":839,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"\t/* On failure, try other access sizes."},{"line_number":842,"context_line":"\t   Minimize the number of accesses by trying first the largest size. */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"cf9122cc_08c9b8b2","line":839,"updated":"2021-09-22 10:37:02.000000000","message":"remove the extra indentation, one TAB is enough","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"\t/* First try the preferred (most natural) access size. */"},{"line_number":838,"context_line":"\tif (read_by_given_size(target, address, size, buffer, preferred_size) \u003d\u003d ERROR_OK)"},{"line_number":839,"context_line":"\t\t\treturn ERROR_OK;"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"\t/* On failure, try other access sizes."},{"line_number":842,"context_line":"\t   Minimize the number of accesses by trying first the largest size. */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"433acadc_d3560f7e","line":839,"in_reply_to":"cf9122cc_08c9b8b2","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c3fb8337bb83f9ee0c248e67eac0b12509fc6c1e","unresolved":true,"context_lines":[{"line_number":2502,"context_line":""},{"line_number":2503,"context_line":"\t\t\tname \u003d calloc(1, strlen(equals) + strlen(reg_type) + 2);"},{"line_number":2504,"context_line":"\t\t\tif (!name) {"},{"line_number":2505,"context_line":"\t\t\t\tfree(args);"},{"line_number":2506,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":2507,"context_line":"\t\t\t}"},{"line_number":2508,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1e9441e9_879b5123","line":2505,"updated":"2021-09-22 13:26:16.000000000","message":"add LOG_ERROR(\"Out of memory\")","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":2502,"context_line":""},{"line_number":2503,"context_line":"\t\t\tname \u003d calloc(1, strlen(equals) + strlen(reg_type) + 2);"},{"line_number":2504,"context_line":"\t\t\tif (!name) {"},{"line_number":2505,"context_line":"\t\t\t\tfree(args);"},{"line_number":2506,"context_line":"\t\t\t\treturn ERROR_FAIL;"},{"line_number":2507,"context_line":"\t\t\t}"},{"line_number":2508,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9638c044_ac0ea0e4","line":2505,"in_reply_to":"1e9441e9_879b5123","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":2553,"context_line":""},{"line_number":2554,"context_line":"\t\trange_list_t *range \u003d calloc(1, sizeof(range_list_t));"},{"line_number":2555,"context_line":"\t\tif (!range) {"},{"line_number":2556,"context_line":"\t\t\tfree(name);"},{"line_number":2557,"context_line":"\t\t\tfree(args);"},{"line_number":2558,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2559,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"fca673a6_7aa62ba2","line":2556,"updated":"2021-09-22 10:37:02.000000000","message":"add LOG_ERROR(\"Out of memory\");","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":2553,"context_line":""},{"line_number":2554,"context_line":"\t\trange_list_t *range \u003d calloc(1, sizeof(range_list_t));"},{"line_number":2555,"context_line":"\t\tif (!range) {"},{"line_number":2556,"context_line":"\t\t\tfree(name);"},{"line_number":2557,"context_line":"\t\t\tfree(args);"},{"line_number":2558,"context_line":"\t\t\treturn ERROR_FAIL;"},{"line_number":2559,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"6a9499ca_4546eb0d","line":2556,"in_reply_to":"fca673a6_7aa62ba2","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":2649,"context_line":"COMMAND_HANDLER(riscv_authdata_write)"},{"line_number":2650,"context_line":"{"},{"line_number":2651,"context_line":"\tuint32_t value;"},{"line_number":2652,"context_line":"\tunsigned index \u003d 0;"},{"line_number":2653,"context_line":""},{"line_number":2654,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":2655,"context_line":"\t\t/* nop */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"63a5cdb8_e53b8165","line":2652,"updated":"2021-09-22 10:37:02.000000000","message":"unsigned int","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":2649,"context_line":"COMMAND_HANDLER(riscv_authdata_write)"},{"line_number":2650,"context_line":"{"},{"line_number":2651,"context_line":"\tuint32_t value;"},{"line_number":2652,"context_line":"\tunsigned index \u003d 0;"},{"line_number":2653,"context_line":""},{"line_number":2654,"context_line":"\tif (CMD_ARGC \u003d\u003d 0) {"},{"line_number":2655,"context_line":"\t\t/* nop */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e226e11f_dbaa8030","line":2652,"in_reply_to":"63a5cdb8_e53b8165","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":2914,"context_line":"\t{"},{"line_number":2915,"context_line":"\t\t.name \u003d \"info\","},{"line_number":2916,"context_line":"\t\t.handler \u003d handle_info,"},{"line_number":2917,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":2918,"context_line":"\t\t.usage \u003d \"\","},{"line_number":2919,"context_line":"\t\t.help \u003d \"Displays some information OpenOCD detected about the target.\""},{"line_number":2920,"context_line":"\t},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4b0d5872_fb1b4dfa","line":2917,"updated":"2021-09-22 10:37:02.000000000","message":"COMMAND_ANY means you can execute it before \u0027init\u0027. From where does it get the target info? Form config script only or also analizyng the target?","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":2914,"context_line":"\t{"},{"line_number":2915,"context_line":"\t\t.name \u003d \"info\","},{"line_number":2916,"context_line":"\t\t.handler \u003d handle_info,"},{"line_number":2917,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":2918,"context_line":"\t\t.usage \u003d \"\","},{"line_number":2919,"context_line":"\t\t.help \u003d \"Displays some information OpenOCD detected about the target.\""},{"line_number":2920,"context_line":"\t},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a4a8b2ab_15a74f3d","line":2917,"in_reply_to":"4b0d5872_fb1b4dfa","updated":"2021-09-22 16:09:04.000000000","message":"I\u0027ll change it to COMMAND_EXEC. Where is that documented? I\u0027d love to see comments that explain this in command.h where the enum is defined.","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c2744150eb55b57b18067f8cd5b6241c71fac231","unresolved":false,"context_lines":[{"line_number":2914,"context_line":"\t{"},{"line_number":2915,"context_line":"\t\t.name \u003d \"info\","},{"line_number":2916,"context_line":"\t\t.handler \u003d handle_info,"},{"line_number":2917,"context_line":"\t\t.mode \u003d COMMAND_ANY,"},{"line_number":2918,"context_line":"\t\t.usage \u003d \"\","},{"line_number":2919,"context_line":"\t\t.help \u003d \"Displays some information OpenOCD detected about the target.\""},{"line_number":2920,"context_line":"\t},"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1782756a_9b35687b","line":2917,"in_reply_to":"a4a8b2ab_15a74f3d","updated":"2021-09-22 21:06:24.000000000","message":"You are right, not documented!\nLet me try to add something in command.h","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":3264,"context_line":"\t\tnum \u003d letter - \u0027A\u0027;"},{"line_number":3265,"context_line":"\telse"},{"line_number":3266,"context_line":"\t\treturn false;"},{"line_number":3267,"context_line":"\treturn r-\u003emisa \u0026 (1 \u003c\u003c num);"},{"line_number":3268,"context_line":"}"},{"line_number":3269,"context_line":""},{"line_number":3270,"context_line":"unsigned riscv_xlen(const struct target *target)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ec3dffe6_6f51aee7","line":3267,"updated":"2021-09-22 10:37:02.000000000","message":"BIT(num) ?","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":3264,"context_line":"\t\tnum \u003d letter - \u0027A\u0027;"},{"line_number":3265,"context_line":"\telse"},{"line_number":3266,"context_line":"\t\treturn false;"},{"line_number":3267,"context_line":"\treturn r-\u003emisa \u0026 (1 \u003c\u003c num);"},{"line_number":3268,"context_line":"}"},{"line_number":3269,"context_line":""},{"line_number":3270,"context_line":"unsigned riscv_xlen(const struct target *target)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"50a19b65_3d6821f6","line":3267,"in_reply_to":"ec3dffe6_6f51aee7","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"}],"src/target/riscv/riscv.h":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"afe612915d403bad606e05eb95d2bcd2083e5870","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"#define RISCV_SAMPLE_BUF_TIMESTAMP_BEFORE\t0x80"},{"line_number":65,"context_line":"#define RISCV_SAMPLE_BUF_TIMESTAMP_AFTER\t0x81"},{"line_number":66,"context_line":"typedef struct {"},{"line_number":67,"context_line":"\tuint8_t *buf;"},{"line_number":68,"context_line":"\tunsigned used;"},{"line_number":69,"context_line":"\tunsigned size;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a703825c_4fbd70a8","line":66,"updated":"2021-09-18 20:56:29.000000000","message":"User\u0027s typedef are not allowed. All the existing typedef in this file will be reverted shortly.\nThis line should be\nstruct riscv_sample_buf {...};\nWhat do you prefer about the new typedef added in this patch? Remove them now or later together to the existing ones?","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"388492b875ed834674ffc53ed226a4664446fbad","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"#define RISCV_SAMPLE_BUF_TIMESTAMP_BEFORE\t0x80"},{"line_number":65,"context_line":"#define RISCV_SAMPLE_BUF_TIMESTAMP_AFTER\t0x81"},{"line_number":66,"context_line":"typedef struct {"},{"line_number":67,"context_line":"\tuint8_t *buf;"},{"line_number":68,"context_line":"\tunsigned used;"},{"line_number":69,"context_line":"\tunsigned size;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e9a8f42d_0db03f55","line":66,"in_reply_to":"a703825c_4fbd70a8","updated":"2021-09-20 22:41:01.000000000","message":"I didn\u0027t realize typedefs weren\u0027t allowed. I\u0027ll change this one now, and others later.","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"#define RISCV_SAMPLE_BUF_TIMESTAMP_BEFORE\t0x80"},{"line_number":65,"context_line":"#define RISCV_SAMPLE_BUF_TIMESTAMP_AFTER\t0x81"},{"line_number":66,"context_line":"typedef struct {"},{"line_number":67,"context_line":"\tuint8_t *buf;"},{"line_number":68,"context_line":"\tunsigned used;"},{"line_number":69,"context_line":"\tunsigned size;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"73820385_4853bcb3","line":66,"in_reply_to":"e9a8f42d_0db03f55","updated":"2021-09-22 10:37:02.000000000","message":"Thanks. There are still 2 typedefs after this one, but should be ok to run a full cleanup later on.","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":65,"context_line":"#define RISCV_SAMPLE_BUF_TIMESTAMP_AFTER\t0x81"},{"line_number":66,"context_line":"typedef struct {"},{"line_number":67,"context_line":"\tuint8_t *buf;"},{"line_number":68,"context_line":"\tunsigned used;"},{"line_number":69,"context_line":"\tunsigned size;"},{"line_number":70,"context_line":"} riscv_sample_buf_t;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"typedef struct {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"040b293f_862390b0","line":69,"range":{"start_line":68,"start_character":2,"end_line":69,"end_character":7},"updated":"2021-09-18 20:19:34.000000000","message":"\u0027unsigned int\u0027 is preferred to \u0027unsigned\u0027","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"#define RISCV_SAMPLE_BUF_TIMESTAMP_AFTER\t0x81"},{"line_number":66,"context_line":"typedef struct {"},{"line_number":67,"context_line":"\tuint8_t *buf;"},{"line_number":68,"context_line":"\tunsigned used;"},{"line_number":69,"context_line":"\tunsigned size;"},{"line_number":70,"context_line":"} riscv_sample_buf_t;"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"typedef struct {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"074d24e3_8c0bfbb3","line":69,"range":{"start_line":68,"start_character":2,"end_line":69,"end_character":7},"in_reply_to":"040b293f_862390b0","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":109,"context_line":"\tint xlen;"},{"line_number":110,"context_line":"\triscv_reg_t misa;"},{"line_number":111,"context_line":"\t/* Cached value of vlenb. 0 if vlenb is not readable for some reason. */"},{"line_number":112,"context_line":"\tunsigned vlenb;"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"\t/* The number of triggers per hart. */"},{"line_number":115,"context_line":"\tunsigned trigger_count;"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"\t/* For each physical trigger, contains -1 if the hwbp is available, or the"},{"line_number":118,"context_line":"\t * unique_id of the breakpoint/watchpoint that is using it."}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9640f4af_2dc11e8c","line":115,"range":{"start_line":112,"start_character":5,"end_line":115,"end_character":8},"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":109,"context_line":"\tint xlen;"},{"line_number":110,"context_line":"\triscv_reg_t misa;"},{"line_number":111,"context_line":"\t/* Cached value of vlenb. 0 if vlenb is not readable for some reason. */"},{"line_number":112,"context_line":"\tunsigned vlenb;"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"\t/* The number of triggers per hart. */"},{"line_number":115,"context_line":"\tunsigned trigger_count;"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"\t/* For each physical trigger, contains -1 if the hwbp is available, or the"},{"line_number":118,"context_line":"\t * unique_id of the breakpoint/watchpoint that is using it."}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f3d025f5_c9123d11","line":115,"range":{"start_line":112,"start_character":5,"end_line":115,"end_character":8},"in_reply_to":"9640f4af_2dc11e8c","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":171,"context_line":"\tvoid (*fill_dmi_read_u64)(struct target *target, char *buf, int a);"},{"line_number":172,"context_line":"\tvoid (*fill_dmi_nop_u64)(struct target *target, char *buf);"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"\tint (*authdata_read)(struct target *target, uint32_t *value, unsigned index);"},{"line_number":175,"context_line":"\tint (*authdata_write)(struct target *target, uint32_t value, unsigned index);"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"\tint (*dmi_read)(struct target *target, uint32_t *value, uint32_t address);"},{"line_number":178,"context_line":"\tint (*dmi_write)(struct target *target, uint32_t address, uint32_t value);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c408194a_3d97d662","line":175,"range":{"start_line":174,"start_character":62,"end_line":175,"end_character":70},"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"\tvoid (*fill_dmi_read_u64)(struct target *target, char *buf, int a);"},{"line_number":172,"context_line":"\tvoid (*fill_dmi_nop_u64)(struct target *target, char *buf);"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"\tint (*authdata_read)(struct target *target, uint32_t *value, unsigned index);"},{"line_number":175,"context_line":"\tint (*authdata_write)(struct target *target, uint32_t value, unsigned index);"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"\tint (*dmi_read)(struct target *target, uint32_t *value, uint32_t address);"},{"line_number":178,"context_line":"\tint (*dmi_write)(struct target *target, uint32_t address, uint32_t value);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0c31162a_562c0f14","line":175,"range":{"start_line":174,"start_character":62,"end_line":175,"end_character":70},"in_reply_to":"c408194a_3d97d662","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"68fd305779ef6dde419d9562c3691f65a4e44b5c","unresolved":true,"context_lines":[{"line_number":235,"context_line":"} riscv_info_t;"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"COMMAND_HELPER(riscv_print_info_line, const char *section, const char *key,"},{"line_number":238,"context_line":"\t\t\t   unsigned value);"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"typedef struct {"},{"line_number":241,"context_line":"\tuint8_t tunneled_dr_width;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d57d9dfb_35dc6f6b","line":238,"updated":"2021-09-18 20:19:34.000000000","message":"unsigned int","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"675fbe6b0ca7941e9beffb1827e64969f4dbb1b4","unresolved":false,"context_lines":[{"line_number":235,"context_line":"} riscv_info_t;"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"COMMAND_HELPER(riscv_print_info_line, const char *section, const char *key,"},{"line_number":238,"context_line":"\t\t\t   unsigned value);"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"typedef struct {"},{"line_number":241,"context_line":"\tuint8_t tunneled_dr_width;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d8ba1616_55d8921f","line":238,"in_reply_to":"d57d9dfb_35dc6f6b","updated":"2021-09-20 22:32:13.000000000","message":"Done","commit_id":"5ccf6d92fcb3c18f6d44a9bcfb11153590f05dde"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"#include \"gdb_regs.h\""},{"line_number":11,"context_line":"#include \"jtag/jtag.h\""},{"line_number":12,"context_line":"#include \"target/register.h\""},{"line_number":13,"context_line":"#include \"command.h\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"/* The register cache is statically allocated. */"},{"line_number":16,"context_line":"#define RISCV_MAX_HARTS 1024"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c0bdec7f_ff3d42fc","line":13,"updated":"2021-09-22 10:37:02.000000000","message":"command.h is in \u0027helper\u0027 folder, and change 6507 will make this a compile error.\nUse, for this line only:\n#include \u003chelper/command.h\u003e","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#include \"gdb_regs.h\""},{"line_number":11,"context_line":"#include \"jtag/jtag.h\""},{"line_number":12,"context_line":"#include \"target/register.h\""},{"line_number":13,"context_line":"#include \"command.h\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"/* The register cache is statically allocated. */"},{"line_number":16,"context_line":"#define RISCV_MAX_HARTS 1024"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"042b9417_97abbaf5","line":13,"in_reply_to":"c0bdec7f_ff3d42fc","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"76e97821813b330c20f4318a2e8202993e6f3ee3","unresolved":true,"context_lines":[{"line_number":109,"context_line":"\tint xlen;"},{"line_number":110,"context_line":"\triscv_reg_t misa;"},{"line_number":111,"context_line":"\t/* Cached value of vlenb. 0 if vlenb is not readable for some reason. */"},{"line_number":112,"context_line":"\tunsigned vlenb;"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"\t/* The number of triggers per hart. */"},{"line_number":115,"context_line":"\tunsigned int trigger_count;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9a1bdf1b_96e0531b","line":112,"updated":"2021-09-22 10:37:02.000000000","message":"unsigned int","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"47a8892b7ef21150c14d796d17b306f7a8b522d2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"\tint xlen;"},{"line_number":110,"context_line":"\triscv_reg_t misa;"},{"line_number":111,"context_line":"\t/* Cached value of vlenb. 0 if vlenb is not readable for some reason. */"},{"line_number":112,"context_line":"\tunsigned vlenb;"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"\t/* The number of triggers per hart. */"},{"line_number":115,"context_line":"\tunsigned int trigger_count;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d79b4e79_c8f89682","line":112,"in_reply_to":"9a1bdf1b_96e0531b","updated":"2021-09-22 16:09:04.000000000","message":"Done","commit_id":"0ae1893f05c70984062b6f2fac9eecfd584789ab"}]}