)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"e183ca21c287dbe1f5298a954698eb4897dcf513","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de10163a_6daf8c0c","updated":"2021-09-03 06:37:03.000000000","message":"I have already reviewed the code downstream at riscv-openocd (https://github.com/riscv/riscv-openocd) and it is all right. I have no further suggestions.","commit_id":"ff8531ce2cc2248c130242cda37bdb0b99c92b14"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9eb8188e3e60c16a34af1e5aee5bffe124570860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51f7e656_e4a6692b","updated":"2021-09-05 10:40:50.000000000","message":"only few style comments. Not tested","commit_id":"ff8531ce2cc2248c130242cda37bdb0b99c92b14"}],"src/jtag/drivers/remote_bitbang.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9eb8188e3e60c16a34af1e5aee5bffe124570860","unresolved":true,"context_lines":[{"line_number":94,"context_line":"typedef enum {"},{"line_number":95,"context_line":"\tNO_BLOCK,"},{"line_number":96,"context_line":"\tBLOCK"},{"line_number":97,"context_line":"} block_bool_t;"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"/* Read any incoming data, placing it into the buffer. */"},{"line_number":100,"context_line":"static int remote_bitbang_fill_buf(block_bool_t block)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3551abe8_644303fe","line":97,"updated":"2021-09-05 10:40:50.000000000","message":"No new typedef, please.\nUse something like:\nenum block_bool {\n  NO_BLOCK,\n  BLOCK\n};","commit_id":"ff8531ce2cc2248c130242cda37bdb0b99c92b14"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"bdbc46dc8c7a3c11cbb04cb92696427540d5176e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"typedef enum {"},{"line_number":95,"context_line":"\tNO_BLOCK,"},{"line_number":96,"context_line":"\tBLOCK"},{"line_number":97,"context_line":"} block_bool_t;"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"/* Read any incoming data, placing it into the buffer. */"},{"line_number":100,"context_line":"static int remote_bitbang_fill_buf(block_bool_t block)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"afe7db05_fdd431f6","line":97,"in_reply_to":"3551abe8_644303fe","updated":"2021-09-07 18:01:10.000000000","message":"Done","commit_id":"ff8531ce2cc2248c130242cda37bdb0b99c92b14"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9eb8188e3e60c16a34af1e5aee5bffe124570860","unresolved":true,"context_lines":[{"line_number":97,"context_line":"} block_bool_t;"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"/* Read any incoming data, placing it into the buffer. */"},{"line_number":100,"context_line":"static int remote_bitbang_fill_buf(block_bool_t block)"},{"line_number":101,"context_line":"{"},{"line_number":102,"context_line":"\tif (remote_bitbang_recv_buf_empty()) {"},{"line_number":103,"context_line":"\t\t/* If the buffer is empty, reset it to 0 so we get more"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ffe9fe54_90d52c90","line":100,"updated":"2021-09-05 10:40:50.000000000","message":"and here the parameter becomes \u0027enum block_bool block\u0027","commit_id":"ff8531ce2cc2248c130242cda37bdb0b99c92b14"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"bdbc46dc8c7a3c11cbb04cb92696427540d5176e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"} block_bool_t;"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"/* Read any incoming data, placing it into the buffer. */"},{"line_number":100,"context_line":"static int remote_bitbang_fill_buf(block_bool_t block)"},{"line_number":101,"context_line":"{"},{"line_number":102,"context_line":"\tif (remote_bitbang_recv_buf_empty()) {"},{"line_number":103,"context_line":"\t\t/* If the buffer is empty, reset it to 0 so we get more"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f63186cb_e72997d8","line":100,"in_reply_to":"ffe9fe54_90d52c90","updated":"2021-09-07 18:01:10.000000000","message":"Done","commit_id":"ff8531ce2cc2248c130242cda37bdb0b99c92b14"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"9eb8188e3e60c16a34af1e5aee5bffe124570860","unresolved":true,"context_lines":[{"line_number":277,"context_line":"\t * connection as fast as possible. */"},{"line_number":278,"context_line":"\tint one \u003d 1;"},{"line_number":279,"context_line":"\t/* On Windows optval has to be a const char *. */"},{"line_number":280,"context_line":"\tsetsockopt(fd, IPPROTO_TCP, TCP_NODELAY, (const char *) \u0026one, sizeof(one));"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"\tfreeaddrinfo(result); /* No longer needed */"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"981d1fef_a7c32d15","line":280,"updated":"2021-09-05 10:40:50.000000000","message":"no space between \u0027(const char *)\u0027 and \u0027\u0026one\u0027","commit_id":"ff8531ce2cc2248c130242cda37bdb0b99c92b14"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"bdbc46dc8c7a3c11cbb04cb92696427540d5176e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"\t * connection as fast as possible. */"},{"line_number":278,"context_line":"\tint one \u003d 1;"},{"line_number":279,"context_line":"\t/* On Windows optval has to be a const char *. */"},{"line_number":280,"context_line":"\tsetsockopt(fd, IPPROTO_TCP, TCP_NODELAY, (const char *) \u0026one, sizeof(one));"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"\tfreeaddrinfo(result); /* No longer needed */"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8b2bef89_482af3a2","line":280,"in_reply_to":"981d1fef_a7c32d15","updated":"2021-09-07 18:01:10.000000000","message":"Done","commit_id":"ff8531ce2cc2248c130242cda37bdb0b99c92b14"}]}