)]}'
{"id":"openocd~master~I415db5746d55374a14564b1973b81e3517f5cb67","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-09-08 21:19:06.000000000","reason":"Antonio Borneo replied on the change"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2021-09-17 20:33:49.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I415db5746d55374a14564b1973b81e3517f5cb67","subject":"Speed up remote bitbang.","status":"MERGED","created":"2021-09-02 18:14:27.000000000","updated":"2021-09-25 13:13:59.000000000","submitted":"2021-09-25 13:13:59.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6534","meta_rev_id":"d4f01e98a6defd03ac485bc9b9095d6ff56f7164","_number":6534,"owner":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-25 13:13:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-25 13:13:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-25 13:13:59.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-25 13:13:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-02 18:27:14.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-03 06:37:03.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2021-09-05 10:40:50.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"cdf3f0e75797515439766ce737e9a281bf0e32d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-09-02 18:14:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e68911442bc6297ac6581507b337c728e4ceb848","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-02 18:27:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15172/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14397/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e183ca21c287dbe1f5298a954698eb4897dcf513","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-09-03 06:37:03.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9eb8188e3e60c16a34af1e5aee5bffe124570860","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-05 10:40:50.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bdbc46dc8c7a3c11cbb04cb92696427540d5176e","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-09-07 18:01:10.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ac58763360ae88aea0032fd1e2bc035f1d87642e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-09-07 18:01:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e3cfbfab9bf2a7b331dd915568294bcb95f0737c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-07 18:13:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15202/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14427/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"8b1afe886e959603f830e1eda94527355e0eb55a","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-09-08 06:12:06.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e68d65d32182f1c153bead9c6bf7fc435d0fef9c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-08 21:19:06.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e4d269065f75ec1a9907a8cbb682a44f36224441","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-09-17 20:33:49.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d4f01e98a6defd03ac485bc9b9095d6ff56f7164","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-25 13:13:59.000000000","message":"Change has been successfully cherry-picked as 5765a0ce14485aadc6b74c6e2b4f15b73df14603","accounts_in_message":[],"_revision_number":3}],"current_revision":"5765a0ce14485aadc6b74c6e2b4f15b73df14603","revisions":{"5765a0ce14485aadc6b74c6e2b4f15b73df14603":{"kind":"REWORK","_number":3,"created":"2021-09-25 13:13:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/34/6534/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/6534/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/3 \u0026\u0026 git checkout -b change-6534 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/6534/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e48093b395808692145bf320e6d206561670107c","subject":"openocd: prevent jimtcl error message while testing commands"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-02 18:11:30.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-25 13:13:59.000000000","tz":0},"subject":"Speed up remote bitbang.","message":"Speed up remote bitbang.\n\n1. Use TCP_NODELAY, which makes things twice as fast.\n2. Get rid of a bunch of unnecessary socket block/non-block calls, which\nimproves speed another 10% or so.\n\nChange-Id: I415db5746d55374a14564b1973b81e3517f5cb67\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6534\nTested-by: jenkins\nReviewed-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"7dafc4f973769535fff854276832f7d387c52f73":{"kind":"REWORK","_number":2,"created":"2021-09-07 18:01:22.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/34/6534/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/6534/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/2 \u0026\u0026 git checkout -b change-6534 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/6534/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a098816a6557e5882bf088ab12a06b94934f30ce","subject":"server/telnet: add variables auto-completion"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-02 18:11:30.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-07 18:01:17.000000000","tz":-420},"subject":"Speed up remote bitbang.","message":"Speed up remote bitbang.\n\n1. Use TCP_NODELAY, which makes things twice as fast.\n2. Get rid of a bunch of unnecessary socket block/non-block calls, which\nimproves speed another 10% or so.\n\nChange-Id: I415db5746d55374a14564b1973b81e3517f5cb67\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"ff8531ce2cc2248c130242cda37bdb0b99c92b14":{"kind":"REWORK","_number":1,"created":"2021-09-02 18:14:27.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/34/6534/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/34/6534/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/1 \u0026\u0026 git checkout -b change-6534 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/34/6534/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/34/6534/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a098816a6557e5882bf088ab12a06b94934f30ce","subject":"server/telnet: add variables auto-completion"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-02 18:11:30.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-02 18:14:12.000000000","tz":-420},"subject":"Speed up remote bitbang.","message":"Speed up remote bitbang.\n\n1. Use TCP_NODELAY, which makes things twice as fast.\n2. Get rid of a bunch of unnecessary socket block/non-block calls, which\nimproves speed another 10% or so.\n\nChange-Id: I415db5746d55374a14564b1973b81e3517f5cb67\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}