)]}'
{"src/flash/nor/stm32l4x.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"cd983e2878721d39d562f425a819cead2516db74","unresolved":true,"context_lines":[{"line_number":1962,"context_line":"\t\t/* CPU2 (Cortex-M0+) is supported only with non-hla adapters because it is located on AP1."},{"line_number":1963,"context_line":"\t\t * Then check if the \"cortex_m\" target is not overridden with \"hla_target\","},{"line_number":1964,"context_line":"\t\t * otherwise armv7m-\u003edebug_ap is null and will cause a Segmentation fault */"},{"line_number":1965,"context_line":"\t\tif (!armv7m-\u003eis_hla_target \u0026\u0026 armv7m-\u003edebug_ap-\u003eap_num \u003d\u003d 1)"},{"line_number":1966,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs \u003d stm32wl_cpu2_flash_regs;"},{"line_number":1967,"context_line":"\t\tbreak;"},{"line_number":1968,"context_line":"\tdefault:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d016cb1b_a91341c6","line":1965,"range":{"start_line":1965,"start_character":6,"end_line":1965,"end_character":28},"updated":"2021-09-03 03:34:39.000000000","message":"In case of ap_num \u003d\u003d 1 on hla, shouldn\u0027t we return error as flash_regs are\nnot accessed on selected CPU?","commit_id":"fff092de1e9559c314ed2edf5a77ce4655c04173"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a4651c3791391a4f8f8bc06503c21f9ae7782315","unresolved":false,"context_lines":[{"line_number":1962,"context_line":"\t\t/* CPU2 (Cortex-M0+) is supported only with non-hla adapters because it is located on AP1."},{"line_number":1963,"context_line":"\t\t * Then check if the \"cortex_m\" target is not overridden with \"hla_target\","},{"line_number":1964,"context_line":"\t\t * otherwise armv7m-\u003edebug_ap is null and will cause a Segmentation fault */"},{"line_number":1965,"context_line":"\t\tif (!armv7m-\u003eis_hla_target \u0026\u0026 armv7m-\u003edebug_ap-\u003eap_num \u003d\u003d 1)"},{"line_number":1966,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs \u003d stm32wl_cpu2_flash_regs;"},{"line_number":1967,"context_line":"\t\tbreak;"},{"line_number":1968,"context_line":"\tdefault:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f5059229_48f24298","line":1965,"range":{"start_line":1965,"start_character":6,"end_line":1965,"end_character":28},"in_reply_to":"758ee05f_23272862","updated":"2021-09-06 09:13:16.000000000","message":"Oh yes, ap_num just does not exist on hla. Checking debug_ap looks good.","commit_id":"fff092de1e9559c314ed2edf5a77ce4655c04173"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"bdb1420aad3a4f9d942e45a0052e9cc14063d036","unresolved":true,"context_lines":[{"line_number":1962,"context_line":"\t\t/* CPU2 (Cortex-M0+) is supported only with non-hla adapters because it is located on AP1."},{"line_number":1963,"context_line":"\t\t * Then check if the \"cortex_m\" target is not overridden with \"hla_target\","},{"line_number":1964,"context_line":"\t\t * otherwise armv7m-\u003edebug_ap is null and will cause a Segmentation fault */"},{"line_number":1965,"context_line":"\t\tif (!armv7m-\u003eis_hla_target \u0026\u0026 armv7m-\u003edebug_ap-\u003eap_num \u003d\u003d 1)"},{"line_number":1966,"context_line":"\t\t\tstm32l4_info-\u003eflash_regs \u003d stm32wl_cpu2_flash_regs;"},{"line_number":1967,"context_line":"\t\tbreak;"},{"line_number":1968,"context_line":"\tdefault:"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"758ee05f_23272862","line":1965,"range":{"start_line":1965,"start_character":6,"end_line":1965,"end_character":28},"in_reply_to":"d016cb1b_a91341c6","updated":"2021-09-05 22:14:33.000000000","message":"correct, but in hla even if the ap_num is 0 the debug_ap is null which causes the segfault.\n\ncould it better if I just check if debug_ap is not null instead if checking if we are in hla ? (this is already suggested by Paul Fertser)","commit_id":"fff092de1e9559c314ed2edf5a77ce4655c04173"}]}