)]}'
{"id":"openocd~master~I501f5b69e629aa8d2836b5194063d74d5bfddb12","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-09-11 12:03:02.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-09-06 09:13:16.000000000","reason":"Tom V replied on the change"}},"hashtags":[],"change_id":"I501f5b69e629aa8d2836b5194063d74d5bfddb12","subject":"flash/stm32l4x: fix segmentation fault with HLA adapters and STM32WLx devices","status":"MERGED","created":"2021-09-02 20:38:04.000000000","updated":"2021-09-11 12:03:02.000000000","submitted":"2021-09-11 12:03:02.000000000","submitter":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6535","meta_rev_id":"a1a2feb7137cede624e25b1da83e4d734336ce0d","_number":6535,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-11 12:03:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-11 12:03:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-11 12:03:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-02 21:03:48.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-03 03:34:39.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2021-09-09 08:05:23.000000000","updated_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"}],"messages":[{"id":"182a5d5aa1ae48fc2f282a36984364e55b8f359f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-02 20:38:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"57fb97ccae74c00172d78c43e7d490ef7de4c55d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-02 21:03:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15174/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14399/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cd983e2878721d39d562f425a819cead2516db74","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-09-03 03:34:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bdb1420aad3a4f9d942e45a0052e9cc14063d036","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-05 22:14:33.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a4651c3791391a4f8f8bc06503c21f9ae7782315","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-09-06 09:13:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9827ad23ee58ce0bb64d0243ddc0cf9ec4e89522","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-06 12:27:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ec9999a905ad7de17f1530d53c5b7dfca5b78402","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-06 12:39:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15188/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14413/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"146965df45a43da0e0651ec8e454debb0497b2dc","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-08 10:46:13.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"fbf6dfd0bfe54b0443b70e03f888d877533ef96f","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-09-09 08:05:23.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a1a2feb7137cede624e25b1da83e4d734336ce0d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-09-11 12:03:02.000000000","message":"Change has been successfully cherry-picked as cdb6ea4f9ff6f61dc4eeadab4dd3edd5d49ab88e","accounts_in_message":[],"_revision_number":3}],"current_revision":"cdb6ea4f9ff6f61dc4eeadab4dd3edd5d49ab88e","revisions":{"fff092de1e9559c314ed2edf5a77ce4655c04173":{"kind":"REWORK","_number":1,"created":"2021-09-02 20:38:04.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/35/6535/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/6535/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/1 \u0026\u0026 git checkout -b change-6535 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/6535/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"48f267d4adea3e582d5287080f947b0e696d4f22","subject":"flash/stm32l4x: avoid using magic numbers for device ids"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-29 15:33:55.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-09-02 20:37:51.000000000","tz":60},"subject":"flash/stm32l4x: fix segmentation fault with HLA adapters and STM32WLx devices","message":"flash/stm32l4x: fix segmentation fault with HLA adapters and STM32WLx devices\n\nCPU2 (Cortex-M0+) is supported only with non-hla adapters because it is located\non AP1. Then check if the target is not overridden with \"hla_target\",\notherwise cortex_m-\u003earmv7m.debug_ap is null and will cause a Segmentation fault.\n\nChange-Id: I501f5b69e629aa8d2836b5194063d74d5bfddb12\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nFixes: https://github.com/STMicroelectronics/OpenOCD/issues/6\n"}},"cdb6ea4f9ff6f61dc4eeadab4dd3edd5d49ab88e":{"kind":"REWORK","_number":3,"created":"2021-09-11 12:03:02.000000000","uploader":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"ref":"refs/changes/35/6535/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/6535/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/3 \u0026\u0026 git checkout -b change-6535 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/6535/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-29 15:33:55.000000000","tz":60},"committer":{"name":"Oleksij Rempel","email":"linux@rempel-privat.de","date":"2021-09-11 12:03:02.000000000","tz":0},"subject":"flash/stm32l4x: fix segmentation fault with HLA adapters and STM32WLx devices","message":"flash/stm32l4x: fix segmentation fault with HLA adapters and STM32WLx devices\n\nCPU2 (Cortex-M0+) is supported only with non-hla adapters because it is on AP1.\nUsing HLA adapters armv7m.debug_ap is null, and checking ap_num triggers\na segfault.\n\nChange-Id: I501f5b69e629aa8d2836b5194063d74d5bfddb12\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nFixes: https://github.com/STMicroelectronics/OpenOCD/issues/6\nReviewed-on: https://review.openocd.org/c/openocd/+/6535\nTested-by: jenkins\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\n"}},"34bffff79ffc22e67b4c0c117a26c2bb3d162806":{"kind":"REWORK","_number":2,"created":"2021-09-06 12:27:16.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/35/6535/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/35/6535/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/2 \u0026\u0026 git checkout -b change-6535 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/35/6535/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/35/6535/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"48f267d4adea3e582d5287080f947b0e696d4f22","subject":"flash/stm32l4x: avoid using magic numbers for device ids"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-29 15:33:55.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-09-06 12:26:39.000000000","tz":60},"subject":"flash/stm32l4x: fix segmentation fault with HLA adapters and STM32WLx devices","message":"flash/stm32l4x: fix segmentation fault with HLA adapters and STM32WLx devices\n\nCPU2 (Cortex-M0+) is supported only with non-hla adapters because it is on AP1.\nUsing HLA adapters armv7m.debug_ap is null, and checking ap_num triggers\na segfault.\n\nChange-Id: I501f5b69e629aa8d2836b5194063d74d5bfddb12\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nFixes: https://github.com/STMicroelectronics/OpenOCD/issues/6\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}