)]}'
{"id":"openocd~master~I27211e7d44b48f65546e31710ec6ae129acb416f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000410":{"account":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"last_update":"2021-09-09 08:39:48.000000000","reason":"removed on reply"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-09-11 12:06:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I27211e7d44b48f65546e31710ec6ae129acb416f","subject":"flash/stm32l4x: do not use magic number for dual bank option bits","status":"MERGED","created":"2021-09-02 20:38:04.000000000","updated":"2021-09-11 12:06:42.000000000","submitted":"2021-09-11 12:06:42.000000000","submitter":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6537","meta_rev_id":"12bb1e9287f5ee3b8b300ed4ecad799738ededc0","_number":6537,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-11 12:06:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-11 12:06:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-11 12:06:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-02 20:52:00.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"state":"REVIEWER"},{"updated":"2021-09-02 21:14:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3884be19a8a3d1355da69c977c58f1d63b71bd7f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-02 20:38:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a72f324fa722967b5be43edcd8132e029048f972","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-02 20:52:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a60868c235d6b6f3d9a794de4d5c0fa498506547","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-02 21:14:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15175/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14400/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a00751280921e7f294accde57dfabef19ac50d73","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-06 12:40:12.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"791144cede35deccf508964617c0125c4354e0a0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-06 13:07:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15189/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14415/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"261400f4675f516a617d0eb66dc890ad9c3a84e8","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-08 10:46:50.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"7d09e64856a1bc12d117bf4ff50a7280d60efa89","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-09-09 08:39:48.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"12bb1e9287f5ee3b8b300ed4ecad799738ededc0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"real_author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"date":"2021-09-11 12:06:42.000000000","message":"Change has been successfully cherry-picked as e63297045b252fedb748bb6557823417590cd879","accounts_in_message":[],"_revision_number":3}],"current_revision":"e63297045b252fedb748bb6557823417590cd879","revisions":{"a41a6d3a6ee8e5ea66d658effef6cea08036cd4d":{"kind":"REWORK","_number":1,"created":"2021-09-02 20:38:04.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/37/6537/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/6537/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/1 \u0026\u0026 git checkout -b change-6537 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/6537/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4b8d28283101b8e3218b1135f9fc966069144462","subject":"flash/stm32l4x: introduce is_max_flash_size and use it"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-29 20:48:49.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-09-02 20:37:51.000000000","tz":60},"subject":"flash/stm32l4x: do not use magic number for dual bank option bits","message":"flash/stm32l4x: do not use magic number for dual bank option bits\n\nChange-Id: I27211e7d44b48f65546e31710ec6ae129acb416f\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"994795c517f69840b1af0b4aaee487d0e5eee91d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-09-06 12:40:12.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/37/6537/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/6537/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/2 \u0026\u0026 git checkout -b change-6537 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/6537/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a4df675f04d127a2f8b678c2698e0c666982ee24","subject":"flash/stm32l4x: introduce is_max_flash_size and use it"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-29 20:48:49.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-09-06 12:32:38.000000000","tz":60},"subject":"flash/stm32l4x: do not use magic number for dual bank option bits","message":"flash/stm32l4x: do not use magic number for dual bank option bits\n\nChange-Id: I27211e7d44b48f65546e31710ec6ae129acb416f\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"e63297045b252fedb748bb6557823417590cd879":{"kind":"REWORK","_number":3,"created":"2021-09-11 12:06:42.000000000","uploader":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"ref":"refs/changes/37/6537/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/37/6537/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/3 \u0026\u0026 git checkout -b change-6537 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/37/6537/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/37/6537/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5070425d6a5457cb83ebf01b59746a66ccbe4e93","subject":"flash/stm32l4x: introduce is_max_flash_size and use it"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-08-29 20:48:49.000000000","tz":60},"committer":{"name":"Oleksij Rempel","email":"linux@rempel-privat.de","date":"2021-09-11 12:06:42.000000000","tz":0},"subject":"flash/stm32l4x: do not use magic number for dual bank option bits","message":"flash/stm32l4x: do not use magic number for dual bank option bits\n\nChange-Id: I27211e7d44b48f65546e31710ec6ae129acb416f\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6537\nTested-by: jenkins\nReviewed-by: Oleksij Rempel \u003clinux@rempel-privat.de\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}