)]}'
{"id":"openocd~master~Ia7406122e07ef56ef311579ab0ee7ddb22c8e4b5","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2021-09-18 15:22:30.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-09-18 15:22:22.000000000","reason":"removed on reply"},"1001885":{"account":{"_account_id":1001885,"name":"Xiang W","email":"wxjstz@126.com","username":"wxjstz"},"last_update":"2021-09-18 15:22:30.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia7406122e07ef56ef311579ab0ee7ddb22c8e4b5","subject":"openocd: remove last NULL comparisons","status":"MERGED","created":"2021-09-04 21:16:56.000000000","updated":"2021-09-18 15:22:30.000000000","submitted":"2021-09-18 15:22:30.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6539","meta_rev_id":"2884a429c1e5774b71447aa9f348b7c17253ef67","_number":6539,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-18 15:22:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-18 15:22:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-18 15:22:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1001885,"name":"Xiang W","email":"wxjstz@126.com","username":"wxjstz"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001885,"name":"Xiang W","email":"wxjstz@126.com","username":"wxjstz"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-04 21:16:56.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2021-09-04 21:16:56.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001885,"name":"Xiang W","email":"wxjstz@126.com","username":"wxjstz"},"state":"REVIEWER"},{"updated":"2021-09-04 22:06:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-05 21:58:56.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"8ae4b3afd7d03aacc138d09655cea31c6ae6820f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-04 21:16:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d05deb24d03ba9307d6a2c635efd0b94473a054e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-04 22:06:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15178/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14403/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3ba6da8f47877db9e3d1e869c2ed8e6880c9f61a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-05 10:10:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"13ffc0b1904b09923f729e37a79bdedf6d515c83","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-05 21:58:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4b217f3cd2de6e2878152980d5605c432b6fcc4e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-18 15:22:22.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2884a429c1e5774b71447aa9f348b7c17253ef67","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-18 15:22:30.000000000","message":"Change has been successfully cherry-picked as 79800db98a985bcd601e8a892aed76d96548a51b","accounts_in_message":[],"_revision_number":2}],"current_revision":"79800db98a985bcd601e8a892aed76d96548a51b","revisions":{"bed671d274408c4347facda48840b25a63b8f51a":{"kind":"REWORK","_number":1,"created":"2021-09-04 21:16:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/6539/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/6539/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/1 \u0026\u0026 git checkout -b change-6539 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/6539/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-04 21:01:09.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-04 21:09:36.000000000","tz":120},"subject":"openocd: remove last NULL comparisons","message":"openocd: remove last NULL comparisons\n\nThe NULL pointers preceded by cast where not detected by the\nscripting tools looking for NULL pointer comparison.\n\nRemove them and, while there, further simplify the code and apply\nthe other coding style rules.\n\nChange-Id: Ia7406122e07ef56ef311579ab0ee7ddb22c8e4b5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"79800db98a985bcd601e8a892aed76d96548a51b":{"kind":"REWORK","_number":2,"created":"2021-09-18 15:22:30.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/6539/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/6539/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/2 \u0026\u0026 git checkout -b change-6539 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/6539/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/6539/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea562985b5eff536feea022b074122b21c3610ea","subject":"gerrit url: update the gerrit server address to https://review.openocd.org"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-04 21:01:09.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-18 15:22:30.000000000","tz":0},"subject":"openocd: remove last NULL comparisons","message":"openocd: remove last NULL comparisons\n\nThe NULL pointers preceded by cast where not detected by the\nscripting tools looking for NULL pointer comparison.\n\nRemove them and, while there, further simplify the code and apply\nthe other coding style rules.\n\nChange-Id: Ia7406122e07ef56ef311579ab0ee7ddb22c8e4b5\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6539\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}