)]}'
{"id":"openocd~master~Ib847a9c702604cdda60477d50ca8e9e13d6c1f6e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001874":{"account":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"last_update":"2021-10-04 07:36:35.000000000","reason":"Andrzej Sierżęga replied on the change"},"1000843":{"account":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"last_update":"2023-11-17 06:33:20.000000000","reason":"Change was abandoned"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"last_update":"2023-11-17 06:33:20.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ib847a9c702604cdda60477d50ca8e9e13d6c1f6e","subject":"add GigaDevice GD32Exxx flash driver","status":"ABANDONED","created":"2021-09-05 20:18:15.000000000","updated":"2023-11-17 06:33:20.000000000","total_comment_count":36,"unresolved_comment_count":4,"has_review_started":true,"meta_rev_id":"81156e2438ce5cd5446bf6beac735181fede26ba","_number":6543,"owner":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},{"value":1,"date":"2021-10-03 15:32:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"}],"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-05 20:33:02.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-06 20:00:47.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"CC"},{"updated":"2021-09-07 11:19:38.000000000","updated_by":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"reviewer":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"state":"CC"},{"updated":"2021-09-16 18:51:21.000000000","updated_by":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"reviewer":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"state":"REVIEWER"}],"messages":[{"id":"6ec2e985a35d41f13244d0590c16f79259c031e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-09-05 20:18:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9a4b9f2a0f225474bf689f940502f66b9d1a8c74","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-05 20:33:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15184/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14408/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"6c9d8c5b3ea3d03753d44b08b63adde3a99435c5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-09-05 20:48:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f58bcfc08ff1449568dfb60ff16012218d4065e3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-05 21:03:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15185/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14410/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4134e793f0293a147838559f6f2600774db91368","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2021-09-06 20:00:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"add2598810c6300b6ab331a8d5e2d464dcb9fa7d","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-09-07 08:11:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7054fb084da2a8f1a1014cdf8cdab7beeb5ca61c","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-09-07 11:19:38.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"294063daf4eb2e3ce7e580a38b4859e90e5e9ca7","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-09-07 18:57:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"19a34550455ad2d42f47fdd59adc5f514890b457","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-09-14 13:10:11.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"c9249a14f82936d562c645400e4610dd10c72751","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-09-14 13:18:30.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"cc668ff0d13709e12e2f6f9f89fefa789bd551a3","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-09-15 10:22:33.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"41fdc54ba45fc3e400da0030f6709e8a495a7dbb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-09-15 19:12:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5e76140a9b4496a76787f1207f4ef098a5f36e10","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-15 19:26:31.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15225/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14449/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"c8e2ed5fdfe9870518a770672536906032faaf3f","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-09-15 19:44:08.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2cfb9cdd4a15196e9336a050a73c5810e8cd4972","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-09-15 21:42:30.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"23992ea9b89af58c6a3eed43d2b3cd68aac9d495","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-15 22:08:12.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15228/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14453/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"cadfc4150650a65ea9739808553f42e1583bffbf","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-09-16 05:49:48.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"4591b2d65431428334ee423bf2a1f74496fc6c96","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-09-16 18:51:21.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"e178bed51f066181ec1d444b5b30c38955cbc759","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2021-09-17 14:13:54.000000000","message":"Patch Set 4:\n\n(5 comments)","accounts_in_message":[],"_revision_number":4},{"id":"2bd906b0af1a61152afae536d5d322940d489d3a","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-09-18 08:10:45.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"e856e8e8d60637a59d06f7080ef06bef5997c5b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-10-03 15:17:27.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"c043f93c3b76beea23660b9b5e421cc4ae6234ba","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-10-03 15:18:17.000000000","message":"Patch Set 4:\n\n(5 comments)","accounts_in_message":[],"_revision_number":4},{"id":"f134c738b31991c140dd0fce01c1e64189b9db5c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-03 15:32:38.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15370/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14588/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"52ba3abbebc48582df0a95a78ca501be0c82e850","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-10-04 07:36:35.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"e0dcec9960d5f15e0636cf7f71fe1563bb731b2b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2021-11-05 23:31:06.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"70be425bd6048ba476d3f5a13f732961c1865647","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-11-07 12:28:22.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"c29a9e32a1c3ab1a273dcb085400b68ebe54593a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2021-11-08 06:27:58.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"7832194b7bbf669c98b96bb2c2d939cd34419b24","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-11-08 10:53:06.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"305224f92eca3211b7d7341b3e12693a5594c68c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2021-11-30 20:54:14.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"cc9b09ce924c6ed7700e9f3ec52cae71a7b6dfd7","author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"real_author":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"date":"2021-12-01 09:41:59.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"eb8c02014b6296e737b3874710e6658988149ab1","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-12-01 10:06:41.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"81156e2438ce5cd5446bf6beac735181fede26ba","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2023-11-17 06:33:20.000000000","message":"Abandoned\n\nSuperseded by 6527: flash/nor/stm32f1x: Add support for GD32E23x | https://review.openocd.org/c/openocd/+/6527","accounts_in_message":[],"_revision_number":5}],"current_revision":"bcf2e838893106b76c7238ec86d7f29377bbfee5","revisions":{"60f95c1fda108a4882bef1cb60ba239c74992c1d":{"kind":"REWORK","_number":3,"created":"2021-09-15 19:12:45.000000000","uploader":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"ref":"refs/changes/43/6543/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/6543/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/3 \u0026\u0026 git checkout -b change-6543 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/6543/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-09-05 18:33:38.000000000","tz":120},"committer":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-09-15 18:37:30.000000000","tz":120},"subject":"add GigaDevice GD32Exxx flash driver","message":"add GigaDevice GD32Exxx flash driver\n\nGigaDevice parts are quite similar to STM32, so they can use most of the\nSTM32F1 flash driver unmodified.  However, even when GD32 uses different\ncores (CM23 on GD32E230) and core revisions for now, collisions in device\nIDs are inevitable (as seen on GD32F1x0).  Since auto-detection is not\npossible, the best way is to add that knowledge to the config files by\nadding a GD32 flash driver that knows about the GD32 parts.\n\nPatch: split STM32F1 driver into a common core and a thin wrapper for STM32\nand GD32 variants.  This makes it possible to separate device IDs used for\nflash size detection without risking collisions between STM32 and GD32\nparts.\n\nThe current GD32F1x0/GD32F3x0 quick-hack is left as-is in the STM32 driver,\nas I don\u0027t have hardware to test those parts.\n\nSigned-off-by: Michael Schwingen \u003cmichael@schwingen.org\u003e\nChange-Id: Ib847a9c702604cdda60477d50ca8e9e13d6c1f6e\n"}},"a3d066ab94637caed5cbff908890c0b81b36ec45":{"kind":"REWORK","_number":2,"created":"2021-09-05 20:48:34.000000000","uploader":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"ref":"refs/changes/43/6543/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/6543/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/2 \u0026\u0026 git checkout -b change-6543 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/6543/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-09-05 18:33:38.000000000","tz":120},"committer":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-09-05 20:48:03.000000000","tz":120},"subject":"add GigaDevice GD32Exxx flash driver","message":"add GigaDevice GD32Exxx flash driver\n\nGigaDevice parts are quite similar to STM32, so they can use most of the\nSTM32F1 flash driver unmodified.  However, even when GD32 uses different\ncores (CM23 on GD32E230) and core revisions for now, collisions in device\nIDs are inevitable (as seen on GD32F1x0).  Since auto-detection is not\npossible, the best way is to add that knowledge to the config files by\nadding a GD32 flash driver that knows about the GD32 parts.\n\nPatch: split STM32F1 driver into a common core and a thin wrapper for STM32\nand GD32 variants.  This makes it possible to separate device IDs used for\nflash size detection without risking collisions between STM32 and GD32\nparts.\n\nThe current GD32F1x0/GD32F3x0 quick-hack is left as-is in the STM32 driver,\nas I don\u0027t have hardware to test those parts.\n\nSigned-off-by: Michael Schwingen \u003cmichael@schwingen.org\u003e\nChange-Id: Ib847a9c702604cdda60477d50ca8e9e13d6c1f6e\n"}},"88c3b55d30f2cbf4dbb05b6ba8a2187c3e1a6d55":{"kind":"REWORK","_number":1,"created":"2021-09-05 20:18:15.000000000","uploader":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"ref":"refs/changes/43/6543/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/6543/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/1 \u0026\u0026 git checkout -b change-6543 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/6543/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-09-05 18:33:38.000000000","tz":120},"committer":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-09-05 20:16:52.000000000","tz":120},"subject":"add GigaDevice GD32Exxx flash driver","message":"add GigaDevice GD32Exxx flash driver\n\nGigaDevice parts are quite similar to STM32, so they can use most of the\nSTM32F1 flash driver unmodified.  However, even when GD32 uses different\ncores (CM23 on GD32E230) and core revisions for now, collisions in device\nIDs are inevitable (as seen on GD32F1x0).  Since auto-detection is not\npossible, the best way is to add that knowledge to the config files by\nadding a GD32 flash driver that knows about the GD32 parts.\n\nPatch: split STM32F1 driver into a common core and a thin wrapper for STM32\nand GD32 variants.  This makes it possible to separate device IDs used for\nflash size detection without risking collisions between STM32 and GD32\nparts.\n\nThe current GD32F1x0/GD32F3x0 quick-hack is left as-is in the STM32 driver,\nas I don\u0027t have hardware to test those parts.\n\nSigned-off-by: Michael Schwingen \u003cmichael@schwingen.org\u003e\nChange-Id: Ib847a9c702604cdda60477d50ca8e9e13d6c1f6e\n"}},"bcf2e838893106b76c7238ec86d7f29377bbfee5":{"kind":"REWORK","_number":5,"created":"2021-10-03 15:17:27.000000000","uploader":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"ref":"refs/changes/43/6543/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/6543/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/5 \u0026\u0026 git checkout -b change-6543 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/6543/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-09-05 18:33:38.000000000","tz":120},"committer":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-10-03 15:14:51.000000000","tz":120},"subject":"add GigaDevice GD32Exxx flash driver","message":"add GigaDevice GD32Exxx flash driver\n\nGigaDevice parts are quite similar to STM32, so they can use most of the\nSTM32F1 flash driver unmodified.  However, even when GD32 uses different\ncores (CM23 on GD32E230) and core revisions for now, collisions in device\nIDs are inevitable (as seen on GD32F1x0).  Since auto-detection is not\npossible, the best way is to add that knowledge to the config files by\nadding a GD32 flash driver that knows about the GD32 parts.\n\nPatch: split STM32F1 driver into a common core and a thin wrapper for STM32\nand GD32 variants.  This makes it possible to separate device IDs used for\nflash size detection without risking collisions between STM32 and GD32\nparts.\n\nThe current GD32F1x0/GD32F3x0 quick-hack is left as-is in the STM32 driver,\nas I don\u0027t have hardware to test those parts.\n\nSigned-off-by: Michael Schwingen \u003cmichael@schwingen.org\u003e\nChange-Id: Ib847a9c702604cdda60477d50ca8e9e13d6c1f6e\n"}},"135e0850ee7242fd546dea4156e5ebcb1624a02b":{"kind":"REWORK","_number":4,"created":"2021-09-15 21:42:30.000000000","uploader":{"_account_id":1000843,"name":"Michael Schwingen","email":"michael@schwingen.org","username":"mschwingen2"},"ref":"refs/changes/43/6543/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/43/6543/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/4 \u0026\u0026 git checkout -b change-6543 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/43/6543/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/43/6543/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-09-05 18:33:38.000000000","tz":120},"committer":{"name":"Michael Schwingen","email":"michael@schwingen.org","date":"2021-09-15 21:40:33.000000000","tz":120},"subject":"add GigaDevice GD32Exxx flash driver","message":"add GigaDevice GD32Exxx flash driver\n\nGigaDevice parts are quite similar to STM32, so they can use most of the\nSTM32F1 flash driver unmodified.  However, even when GD32 uses different\ncores (CM23 on GD32E230) and core revisions for now, collisions in device\nIDs are inevitable (as seen on GD32F1x0).  Since auto-detection is not\npossible, the best way is to add that knowledge to the config files by\nadding a GD32 flash driver that knows about the GD32 parts.\n\nPatch: split STM32F1 driver into a common core and a thin wrapper for STM32\nand GD32 variants.  This makes it possible to separate device IDs used for\nflash size detection without risking collisions between STM32 and GD32\nparts.\n\nThe current GD32F1x0/GD32F3x0 quick-hack is left as-is in the STM32 driver,\nas I don\u0027t have hardware to test those parts.\n\nSigned-off-by: Michael Schwingen \u003cmichael@schwingen.org\u003e\nChange-Id: Ib847a9c702604cdda60477d50ca8e9e13d6c1f6e\n"}}},"requirements":[],"submit_records":[],"submit_requirements":[]}