)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"de954a6812954d8ce560e7ea9f718d909aa94596","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a7ce5311_22d28c1f","updated":"2021-11-11 14:48:15.000000000","message":"The change does more harm then good. shutdowns are really cruel and fire even if the device is in RDP 0.5 and therefore does not stop in secure mode.\nI tested with STLINK V2J37M27 in hla, STM32L552 with TZ enabled and RDP 0.5 and then 0\nI eliminated both shutdowns (replaced the one in stm32x5x_ahb_ap_secure_access by return) and debugging seems just fine in RDP 0.5 (debugging possible only in nonsec). Even in RDP 0 and secure mode is possible at least stop at bp and continue. However I didn\u0027t test all memory types and flash programming.\nWhy is config so crippled?","commit_id":"ded48a6a03c17aa9815a738ef97807c7e86724b9"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"b1d7aad7e989c5ee24dc72f5a6f4da6ec2f9fa7b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ab06407a_a52273ff","in_reply_to":"a7ce5311_22d28c1f","updated":"2022-02-25 14:21:17.000000000","message":"crippled, I confirm.\nbut I cannot choose to invest more time on HLA adapters.\n\nas the commit subject indicates: this change supports HLA adapters in non-secure mode only.\n\nsupporting other combination is possible, but should be validated extensively.\nSo I have decided to limit this change to non-sec only.\n\nAnd this could be considered as enhancement, since HLA was causing crash before this commit (ref https://sourceforge.net/p/openocd/tickets/317/#8ad6)","commit_id":"ded48a6a03c17aa9815a738ef97807c7e86724b9"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a9873fd0b548f07320be3c944bd368368712b33e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fb06f2f9_cffc9e36","in_reply_to":"ab06407a_a52273ff","updated":"2022-03-02 15:49:33.000000000","message":"\u003e And this could be considered as enhancement, since HLA was causing crash before this commit (ref https://sourceforge.net/p/openocd/tickets/317/#8ad6)\n\nThe flash algo problem you referred happened when\n\n Info : TZEN \u003d 0 : TrustZone disabled by option bytes\n Info : RDP level 0 (0xAA)\n\nSo I see no relation to this. Am I missing something?\n\nIf you want put even more emphasis to the warnings.\nHowever take me seriously: no code crippling, no shutdowns!","commit_id":"ded48a6a03c17aa9815a738ef97807c7e86724b9"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"f500cc6e8b4177ef92e496704a5bfd03b6326cdb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"02277c62_ca22ac8c","in_reply_to":"fb06f2f9_cffc9e36","updated":"2022-03-02 17:26:52.000000000","message":"\u003e So I see no relation to this. Am I missing something?\n\nyes in the 3rd comment by Patrik (2021-09-04), he shared a log containing :\n\n\u003e Info : The selected transport took over low-level target control.\n\u003e The results might differ compared to plain JTAG/SWD\n\nso he is using HLA\n\u003e Error executing event halted on target stm32l5x.cpu:\n\u003e ../tcl/target/stm32l5x.cfg:116: Error: \n\u003e in procedure \u0027ocd_process_reset\u0027 \n\u003e in procedure \u0027ocd_process_reset_inner\u0027 called at file \"embedded:startup.tcl\", line 788\n\u003e in procedure \u0027ahb_ap_non_secure_access\u0027 called at file \"../tcl/target/stm32l5x.cfg\", line 152\n\u003e at file \"../tcl/target/stm32l5x.cfg\", line 116\n\nthis was caused by the apcsw command\n\nNow regarding this:\n\u003e However take me seriously: no code crippling, no shutdowns!\nagreed, no more shutdowns ;)","commit_id":"ded48a6a03c17aa9815a738ef97807c7e86724b9"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"5e22a8f59e37d1796ecd43fbd11f17a72c5f9d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7e899842_6947d4f4","updated":"2022-10-19 08:50:11.000000000","message":"Any Chance to get this fix merged ?","commit_id":"fdf93ef8fd24a9df4f6178194bc7df42ff89d5d7"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"a372d4eb7836a8cf023f7abeaf8df8f46381d4ce","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"eb06cb57_171f3c71","in_reply_to":"01331668_c85e2c74","updated":"2022-10-21 21:39:05.000000000","message":"not in my knowledge\nbut there is a stack vulnerability related to stack described here \nhttps://developer.arm.com/Arm%20Security%20Center/Armv8-M%20Stack%20Sealing%20Vulnerability","commit_id":"fdf93ef8fd24a9df4f6178194bc7df42ff89d5d7"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"1c25226fef02c48d687a0d891de4baba5bc58c56","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"01331668_c85e2c74","in_reply_to":"7e899842_6947d4f4","updated":"2022-10-19 09:20:02.000000000","message":"Looks good now. Sorry, I missed the last update.\n\nBTW: I had to disable CSW setting in stm32x5x_ahb_ap_non_secure_access\nto be able to test the new gdb code with s/ns stack unwinding.\nActually I don\u0027t know if some memory area can be protected from secure access\nand readable from ns. Is it possible?","commit_id":"fdf93ef8fd24a9df4f6178194bc7df42ff89d5d7"}],"tcl/target/stm32l5x.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"abbcda5b3a2a343c9343db890c890a7ca8aa0f03","unresolved":true,"context_lines":[{"line_number":73,"context_line":"reset_config srst_nogate"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"if {[using_hla]} {"},{"line_number":76,"context_line":"\techo \"Warn : The selected transport do not support debbuging this device in secure mode\""},{"line_number":77,"context_line":"} else {"},{"line_number":78,"context_line":"\t# if srst is not fitted use SYSRESETREQ to"},{"line_number":79,"context_line":"\t# perform a soft reset"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"3688e225_035920c1","line":76,"updated":"2021-09-19 19:48:27.000000000","message":"typo s/debbuging/debugging/","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"6e15558265e516857405999c39793d302373cdb2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"reset_config srst_nogate"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"if {[using_hla]} {"},{"line_number":76,"context_line":"\techo \"Warn : The selected transport do not support debbuging this device in secure mode\""},{"line_number":77,"context_line":"} else {"},{"line_number":78,"context_line":"\t# if srst is not fitted use SYSRESETREQ to"},{"line_number":79,"context_line":"\t# perform a soft reset"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"22e3db3d_326b0369","line":76,"in_reply_to":"3688e225_035920c1","updated":"2021-09-24 19:33:10.000000000","message":"Done","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"fb7358f284f8ec6953e6b90f30cf92b72caa1235","unresolved":true,"context_lines":[{"line_number":85,"context_line":"\tset DSCSR [mrw 0xE000EE08]"},{"line_number":86,"context_line":"\tset secure [expr {($DSCSR \u0026 (1 \u003c\u003c 16)) !\u003d 0}]"},{"line_number":87,"context_line":"\tif {$secure \u0026\u0026 [using_hla]} {"},{"line_number":88,"context_line":"\t\techo \"Error: The selected transport do not support debbuging this device in secure mode\""},{"line_number":89,"context_line":"\t\tshutdown"},{"line_number":90,"context_line":"\t}"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"7a7f9778_bdd45990","line":88,"updated":"2021-09-17 05:53:09.000000000","message":"debugging","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"6e15558265e516857405999c39793d302373cdb2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"\tset DSCSR [mrw 0xE000EE08]"},{"line_number":86,"context_line":"\tset secure [expr {($DSCSR \u0026 (1 \u003c\u003c 16)) !\u003d 0}]"},{"line_number":87,"context_line":"\tif {$secure \u0026\u0026 [using_hla]} {"},{"line_number":88,"context_line":"\t\techo \"Error: The selected transport do not support debbuging this device in secure mode\""},{"line_number":89,"context_line":"\t\tshutdown"},{"line_number":90,"context_line":"\t}"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"4a178b29_63e765c7","line":88,"in_reply_to":"3163137d_a614ba43","updated":"2021-09-24 19:33:10.000000000","message":"Done","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"abbcda5b3a2a343c9343db890c890a7ca8aa0f03","unresolved":true,"context_lines":[{"line_number":85,"context_line":"\tset DSCSR [mrw 0xE000EE08]"},{"line_number":86,"context_line":"\tset secure [expr {($DSCSR \u0026 (1 \u003c\u003c 16)) !\u003d 0}]"},{"line_number":87,"context_line":"\tif {$secure \u0026\u0026 [using_hla]} {"},{"line_number":88,"context_line":"\t\techo \"Error: The selected transport do not support debbuging this device in secure mode\""},{"line_number":89,"context_line":"\t\tshutdown"},{"line_number":90,"context_line":"\t}"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"3163137d_a614ba43","line":88,"in_reply_to":"7a7f9778_bdd45990","updated":"2021-09-19 19:48:27.000000000","message":"yep","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"abbcda5b3a2a343c9343db890c890a7ca8aa0f03","unresolved":true,"context_lines":[{"line_number":120,"context_line":"}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"proc ahb_ap_non_secure_access {} {"},{"line_number":123,"context_line":"\t# in HLA mode, non-secure debugging is possible without changing the AP CSW"},{"line_number":124,"context_line":"\tif {![using_hla]} {"},{"line_number":125,"context_line":"\t\t# SPROT\u003d1\u003dNon Secure access, Priv\u003d1"},{"line_number":126,"context_line":"\t\t[[target current] cget -dap] apcsw 0x4B000000 0x4F000000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"31dde5ae_3f54faf7","line":123,"updated":"2021-09-19 19:48:27.000000000","message":"typo s/debbuging/debugging/","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"6e15558265e516857405999c39793d302373cdb2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"}"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"proc ahb_ap_non_secure_access {} {"},{"line_number":123,"context_line":"\t# in HLA mode, non-secure debugging is possible without changing the AP CSW"},{"line_number":124,"context_line":"\tif {![using_hla]} {"},{"line_number":125,"context_line":"\t\t# SPROT\u003d1\u003dNon Secure access, Priv\u003d1"},{"line_number":126,"context_line":"\t\t[[target current] cget -dap] apcsw 0x4B000000 0x4F000000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"a20ee08a_7cc8f66c","line":123,"in_reply_to":"31dde5ae_3f54faf7","updated":"2021-09-24 19:33:10.000000000","message":"Done","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000410,"name":"Oleksij Rempel","email":"linux@rempel-privat.de","username":"olerem"},"change_message_id":"fb7358f284f8ec6953e6b90f30cf92b72caa1235","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"proc ahb_ap_secure_access {} {"},{"line_number":131,"context_line":"\tif {[using_hla]} {"},{"line_number":132,"context_line":"\t\techo \"Error: The selected transport do not support debbuging this device in secure mode\""},{"line_number":133,"context_line":"\t\tshutdown"},{"line_number":134,"context_line":"\t}"},{"line_number":135,"context_line":"\t# SPROT\u003d0\u003dSecure access, Priv\u003d1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"cfa071e6_979120e0","line":132,"updated":"2021-09-17 05:53:09.000000000","message":"Some more info would be nice. Like: To access this device in the secure mode, use non-HLA JTAG/SWD adapter.","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"6e15558265e516857405999c39793d302373cdb2","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"proc ahb_ap_secure_access {} {"},{"line_number":131,"context_line":"\tif {[using_hla]} {"},{"line_number":132,"context_line":"\t\techo \"Error: The selected transport do not support debbuging this device in secure mode\""},{"line_number":133,"context_line":"\t\tshutdown"},{"line_number":134,"context_line":"\t}"},{"line_number":135,"context_line":"\t# SPROT\u003d0\u003dSecure access, Priv\u003d1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"9917a83a_626800b3","line":132,"in_reply_to":"35b7cc25_9c6c7d47","updated":"2021-09-24 19:33:10.000000000","message":"Done","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"abbcda5b3a2a343c9343db890c890a7ca8aa0f03","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"proc ahb_ap_secure_access {} {"},{"line_number":131,"context_line":"\tif {[using_hla]} {"},{"line_number":132,"context_line":"\t\techo \"Error: The selected transport do not support debbuging this device in secure mode\""},{"line_number":133,"context_line":"\t\tshutdown"},{"line_number":134,"context_line":"\t}"},{"line_number":135,"context_line":"\t# SPROT\u003d0\u003dSecure access, Priv\u003d1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"35b7cc25_9c6c7d47","line":132,"in_reply_to":"cfa071e6_979120e0","updated":"2021-09-19 19:48:27.000000000","message":"typo s/debbuging/debugging/","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"abbcda5b3a2a343c9343db890c890a7ca8aa0f03","unresolved":true,"context_lines":[{"line_number":185,"context_line":"\tif {[expr {$FLASH_OPTR \u0026 0x80000000}] \u003d\u003d 0} {"},{"line_number":186,"context_line":"\t\techo \"TZEN option bit disabled\""},{"line_number":187,"context_line":"\t\tahb_ap_non_secure_access"},{"line_number":188,"context_line":"\t} else {"},{"line_number":189,"context_line":"\t\tahb_ap_secure_access"},{"line_number":190,"context_line":"\t\techo \"TZEN option bit enabled\""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"11c6c6c8_421bcb79","line":188,"updated":"2021-09-19 19:48:27.000000000","message":"agree, adding the optional \u0027else\u0027 makes it more readable. Also \u0027then\u0027 is optional, but it doesn\u0027t add more in readability.\nMaybe it\u0027s time to add some TCL note in the coding style. The chapter is already there.","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"6e15558265e516857405999c39793d302373cdb2","unresolved":false,"context_lines":[{"line_number":185,"context_line":"\tif {[expr {$FLASH_OPTR \u0026 0x80000000}] \u003d\u003d 0} {"},{"line_number":186,"context_line":"\t\techo \"TZEN option bit disabled\""},{"line_number":187,"context_line":"\t\tahb_ap_non_secure_access"},{"line_number":188,"context_line":"\t} else {"},{"line_number":189,"context_line":"\t\tahb_ap_secure_access"},{"line_number":190,"context_line":"\t\techo \"TZEN option bit enabled\""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"acfb2a7e_9a4d9c21","line":188,"in_reply_to":"11c6c6c8_421bcb79","updated":"2021-09-24 19:33:10.000000000","message":"Ack","commit_id":"177a91d93cf774b4cc5c4a9d821cc3c7bf7836a4"}],"tcl/target/stm32x5x_common.cfg":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"b80ba15e48b65b2d1bd8a822fff6a47f55af9414","unresolved":true,"context_lines":[{"line_number":59,"context_line":"reset_config srst_nogate"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"if {[using_hla]} {"},{"line_number":62,"context_line":"\techo \"Warn : The selected adapter do not support debugging this device in secure mode\""},{"line_number":63,"context_line":"} else {"},{"line_number":64,"context_line":"\t# if srst is not fitted use SYSRESETREQ to"},{"line_number":65,"context_line":"\t# perform a soft reset"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"827a46b9_28ec97e6","line":62,"range":{"start_line":62,"start_character":35,"end_line":62,"end_character":37},"updated":"2021-11-11 21:24:46.000000000","message":"does","commit_id":"ded48a6a03c17aa9815a738ef97807c7e86724b9"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a9873fd0b548f07320be3c944bd368368712b33e","unresolved":true,"context_lines":[{"line_number":70,"context_line":"\t# read Debug Security Control and Status Register (DSCSR) and check CDS (bit 16)"},{"line_number":71,"context_line":"\tset DSCSR [mrw 0xE000EE08]"},{"line_number":72,"context_line":"\tset secure [expr {($DSCSR \u0026 (1 \u003c\u003c 16)) !\u003d 0}]"},{"line_number":73,"context_line":"\tif {$secure \u0026\u0026 [using_hla]} {"},{"line_number":74,"context_line":"\t\techo \"Error: The selected adapter do not support debugging this device in secure mode\""},{"line_number":75,"context_line":"\t\techo \"Info : To debug this device in secure mode, use non-HLA adapter\""},{"line_number":76,"context_line":"\t\tshutdown"},{"line_number":77,"context_line":"\t}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"\treturn $secure"},{"line_number":80,"context_line":"}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"0b8c7e1f_76ce04c4","line":77,"range":{"start_line":73,"start_character":1,"end_line":77,"end_character":2},"updated":"2022-03-02 15:49:33.000000000","message":"IMO this can be removed. If you feel it is important to show the message each time secure state is tested, then ok, just s/do/does/ and s/Error/Warning/\nIn any case remove shutdown","commit_id":"3dafb325627f0e30a0f1846c10002510296bf510"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a9873fd0b548f07320be3c944bd368368712b33e","unresolved":true,"context_lines":[{"line_number":91,"context_line":"\tif {[using_hla]} {"},{"line_number":92,"context_line":"\t\techo \"Error: The selected adapter do not support debugging this device in secure mode\""},{"line_number":93,"context_line":"\t\techo \"Info : To debug this device in secure mode, use non-HLA adapter\""},{"line_number":94,"context_line":"\t\tshutdown"},{"line_number":95,"context_line":"\t}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"\t# SPROT\u003d0\u003dSecure access, Priv\u003d1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"1697418c_b2e51f42","line":94,"range":{"start_line":94,"start_character":2,"end_line":94,"end_character":10},"updated":"2022-03-02 15:49:33.000000000","message":"Remove shutdown and move apcsw setting to else branch\ns/Error/Warning/\ns/do/does/","commit_id":"3dafb325627f0e30a0f1846c10002510296bf510"}]}
