)]}'
{"id":"openocd~master~Ifad8e7ef67b930edbb5421730f00eb3390812f06","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001923":{"account":{"_account_id":1001923,"name":"Andreas Sandberg","email":"andreas@sandberg.uk","username":"andysan"},"last_update":"2021-09-18 15:26:57.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifad8e7ef67b930edbb5421730f00eb3390812f06","subject":"hla: Increase HLA_MAX_USB_IDS","status":"MERGED","created":"2021-09-08 22:19:43.000000000","updated":"2021-09-18 15:26:57.000000000","submitted":"2021-09-18 15:26:57.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6554","meta_rev_id":"39c1d3e93382a46ce4b9590a676f9c18323b8d53","_number":6554,"owner":{"_account_id":1001923,"name":"Andreas Sandberg","email":"andreas@sandberg.uk","username":"andysan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-18 15:26:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-18 15:26:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-18 15:26:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-08 22:34:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-09 09:01:23.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-09-09 09:12:04.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"69c60898c85b4685695088d8a14a858db9119af6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001923,"name":"Andreas Sandberg","email":"andreas@sandberg.uk","username":"andysan"},"real_author":{"_account_id":1001923,"name":"Andreas Sandberg","email":"andreas@sandberg.uk","username":"andysan"},"date":"2021-09-08 22:19:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bf84789893505189170d70c8fb6c31ff9d0dfcc2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-08 22:34:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15210/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14435/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f404dbbbc9be2a5bba31e5f8b69b429a8f2c503d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-09 09:01:23.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"444caf27c0e51575c763f829e0e8c1202f161475","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-09 09:12:04.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f5cbed600b59551db155e3720e62602e41995200","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-18 15:26:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"39c1d3e93382a46ce4b9590a676f9c18323b8d53","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-18 15:26:57.000000000","message":"Change has been successfully cherry-picked as 00b16b294faad9102db8a56df537be443f74d18f","accounts_in_message":[],"_revision_number":2}],"current_revision":"00b16b294faad9102db8a56df537be443f74d18f","revisions":{"f58ca095cd1354f85c76c155dfb2aa742ec9b92e":{"kind":"REWORK","_number":1,"created":"2021-09-08 22:19:43.000000000","uploader":{"_account_id":1001923,"name":"Andreas Sandberg","email":"andreas@sandberg.uk","username":"andysan"},"ref":"refs/changes/54/6554/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/6554/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/1 \u0026\u0026 git checkout -b change-6554 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/6554/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Andreas Sandberg","email":"andreas@sandberg.uk","date":"2021-09-08 22:14:34.000000000","tz":60},"committer":{"name":"Andreas Sandberg","email":"andreas@sandberg.uk","date":"2021-09-08 22:18:08.000000000","tz":60},"subject":"hla: Increase HLA_MAX_USB_IDS","message":"hla: Increase HLA_MAX_USB_IDS\n\nWe are already at the limit for the number of VID/PID pairs declared\nin stlink.cfg and stlink-dap.cfg. Increase the maximum number of pairs\nfrom 8 to 16 to make room for a few more devices.\n\nSigned-off-by: Andreas Sandberg \u003candreas@sandberg.uk\u003e\nChange-Id: Ifad8e7ef67b930edbb5421730f00eb3390812f06\n"}},"00b16b294faad9102db8a56df537be443f74d18f":{"kind":"REWORK","_number":2,"created":"2021-09-18 15:26:57.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/54/6554/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/54/6554/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/2 \u0026\u0026 git checkout -b change-6554 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/54/6554/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/54/6554/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"73c64167997f9f4312767896581a57acc5b8a98f","subject":"target: do not cast NULL in assignment"}],"author":{"name":"Andreas Sandberg","email":"andreas@sandberg.uk","date":"2021-09-08 22:14:34.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-18 15:26:57.000000000","tz":0},"subject":"hla: Increase HLA_MAX_USB_IDS","message":"hla: Increase HLA_MAX_USB_IDS\n\nWe are already at the limit for the number of VID/PID pairs declared\nin stlink.cfg and stlink-dap.cfg. Increase the maximum number of pairs\nfrom 8 to 16 to make room for a few more devices.\n\nSigned-off-by: Andreas Sandberg \u003candreas@sandberg.uk\u003e\nChange-Id: Ifad8e7ef67b930edbb5421730f00eb3390812f06\nReviewed-on: https://review.openocd.org/c/openocd/+/6554\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}