)]}'
{"id":"openocd~master~I0a3df4bb4bf872b01cdb9357eb28307868d7d469","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-09-12 14:26:31.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0a3df4bb4bf872b01cdb9357eb28307868d7d469","subject":"flash/stm32l4x: fix flash programming in 64-bit hosts","status":"MERGED","created":"2021-09-09 22:47:28.000000000","updated":"2021-09-12 14:26:31.000000000","submitted":"2021-09-12 14:26:31.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6556","meta_rev_id":"c6a7da35e8059cb90cef30dae969c4f600e56b6e","_number":6556,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001922,"name":"Yestin Sun","email":"sunyi0804@gmail.com"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-12 14:26:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-12 14:26:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001922,"name":"Yestin Sun","email":"sunyi0804@gmail.com"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-12 14:26:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-12 14:26:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001922,"name":"Yestin Sun","email":"sunyi0804@gmail.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-09 22:48:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-10 19:48:31.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1001922,"name":"Yestin Sun","email":"sunyi0804@gmail.com"},"state":"CC"},{"updated":"2021-09-10 20:48:49.000000000","updated_by":{"_account_id":1001922,"name":"Yestin Sun","email":"sunyi0804@gmail.com"},"reviewer":{"_account_id":1001922,"name":"Yestin Sun","email":"sunyi0804@gmail.com"},"state":"REVIEWER"},{"updated":"2021-09-11 04:44:41.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"8fd33bec677632bf75c43192678aa328dab7c6e9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-09 22:47:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d0af4464b03a001d7b3ee91606c876252c05c5d3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-09 22:48:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"53b2436ea6255ff9ced9ebb276bce30705432979","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-09 22:48:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15214/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14439/ : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"1a08afe5b6120ea9651ce068b3359f441a320008","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-09 23:00:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15215/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14440/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"2c08a9f2313b868a4936edf69944305d4143bf47","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-10 10:11:24.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b4f2807f41adcd3848a808220b4b32cfb8b33e5e","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-10 20:05:14.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b4647226756f50ea000e0dd6ae7d85672b3de0e7","author":{"_account_id":1001922,"name":"Yestin Sun","email":"sunyi0804@gmail.com"},"real_author":{"_account_id":1001922,"name":"Yestin Sun","email":"sunyi0804@gmail.com"},"date":"2021-09-10 20:48:49.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5be521bac0202bd328d51a0f25c916fd4db466bb","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-09-11 04:44:41.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c6a7da35e8059cb90cef30dae969c4f600e56b6e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-09-12 14:26:31.000000000","message":"Change has been successfully cherry-picked as b61a280860f9ceb9bc38125c48d2f0f4d35f1c11","accounts_in_message":[],"_revision_number":3}],"current_revision":"b61a280860f9ceb9bc38125c48d2f0f4d35f1c11","revisions":{"d6e3bd8a231710131888e59f0148a4b1d0ee99e4":{"kind":"REWORK","_number":1,"created":"2021-09-09 22:47:28.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/56/6556/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/6556/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/1 \u0026\u0026 git checkout -b change-6556 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/6556/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-09-09 21:14:36.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-09-09 21:22:19.000000000","tz":60},"subject":"flash/stm32l4x: fix flash programming in 64-bit hosts","message":"flash/stm32l4x: fix flash programming in 64-bit hosts\n\nstm32l4_work_area struct is shared between the loader and stm32l4x flash driver\n\n\u0027*wp\u0027 and \u0027*rp\u0027 pointers\u0027 size is 4 bytes each since stm32l4x devices have\n32-bit processors.\n\nhowever when used in openocd code, their size depends on the host\n  if the host is 32-bit, then the size is 4 bytes each.\n  if the host is 64-bit, then the size is 8 bytes each.\n\nto avoid this size difference, change their types depending on the\nusage (pointers for the loader, and 32-bit integers in openocd code).\n\nChange-Id: I0a3df4bb4bf872b01cdb9357eb28307868d7d469\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"c9bf8966fb7d3ef5beed52f5876ab02de3898166":{"kind":"REWORK","_number":2,"created":"2021-09-09 22:48:50.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/56/6556/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/6556/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/2 \u0026\u0026 git checkout -b change-6556 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/6556/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f24a283ac7765df6f09694a4cee99150cb645ac1","subject":"flash/nor/tcl: \u0027flash list\u0027 command: add the flash bank target"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-09-09 21:14:36.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-09-09 22:47:49.000000000","tz":60},"subject":"flash/stm32l4x: fix flash programming in 64-bit hosts","message":"flash/stm32l4x: fix flash programming in 64-bit hosts\n\nstm32l4_work_area struct is shared between the loader and stm32l4x flash driver\n\n\u0027*wp\u0027 and \u0027*rp\u0027 pointers\u0027 size is 4 bytes each since stm32l4x devices have\n32-bit processors.\n\nhowever when used in openocd code, their size depends on the host\n  if the host is 32-bit, then the size is 4 bytes each.\n  if the host is 64-bit, then the size is 8 bytes each.\n\nto avoid this size difference, change their types depending on the\nusage (pointers for the loader, and 32-bit integers in openocd code).\n\nChange-Id: I0a3df4bb4bf872b01cdb9357eb28307868d7d469\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"b61a280860f9ceb9bc38125c48d2f0f4d35f1c11":{"kind":"REWORK","_number":3,"created":"2021-09-12 14:26:31.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/56/6556/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/6556/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/3 \u0026\u0026 git checkout -b change-6556 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/6556/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/6556/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f78f9a90a6c4f8abedbac8a4047631cbe3ea0e17","subject":"In SMP config, replicate watchpoints on each core"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-09-09 21:14:36.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-09-12 14:26:31.000000000","tz":0},"subject":"flash/stm32l4x: fix flash programming in 64-bit hosts","message":"flash/stm32l4x: fix flash programming in 64-bit hosts\n\nstm32l4_work_area struct is shared between the loader and stm32l4x flash driver\n\n\u0027*wp\u0027 and \u0027*rp\u0027 pointers\u0027 size is 4 bytes each since stm32l4x devices have\n32-bit processors.\n\nhowever when used in openocd code, their size depends on the host\n  if the host is 32-bit, then the size is 4 bytes each.\n  if the host is 64-bit, then the size is 8 bytes each.\n\nto avoid this size difference, change their types depending on the\nusage (pointers for the loader, and 32-bit integers in openocd code).\n\nChange-Id: I0a3df4bb4bf872b01cdb9357eb28307868d7d469\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6556\nTested-by: jenkins\nReviewed-by: Yestin Sun \u003csunyi0804@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}