)]}'
{"id":"openocd~master~I89b39b03aa03f826ed3c45793412780448940bcc","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001472":{"account":{"_account_id":1001472,"name":"Alex Crawford","email":"openocd@code.acrawford.com","username":"crawford"},"last_update":"2021-09-25 13:15:05.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-09-25 13:14:48.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I89b39b03aa03f826ed3c45793412780448940bcc","subject":"driver/linuxgpiod: add support for opendrain srst","status":"MERGED","created":"2021-09-16 17:46:28.000000000","updated":"2021-09-25 13:15:05.000000000","submitted":"2021-09-25 13:15:05.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6559","meta_rev_id":"28f42d9c6eb23d606af15509029ffe9af272b616","_number":6559,"owner":{"_account_id":1001472,"name":"Alex Crawford","email":"openocd@code.acrawford.com","username":"crawford"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-25 13:15:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-25 13:15:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-16 17:58:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-18 16:08:42.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"65d860bb48695d411a2ac25461e77dad69f62da1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001472,"name":"Alex Crawford","email":"openocd@code.acrawford.com","username":"crawford"},"real_author":{"_account_id":1001472,"name":"Alex Crawford","email":"openocd@code.acrawford.com","username":"crawford"},"date":"2021-09-16 17:46:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ae239499c8f334b99d28a641d2ebd4b2570e081a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-16 17:58:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15248/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14472/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8f944ff8717b58058e01eea609ec55780caa0ca1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-18 16:08:42.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4b45b36568e3d25fe90d2b14c5bc59e681c9b1a3","author":{"_account_id":1001472,"name":"Alex Crawford","email":"openocd@code.acrawford.com","username":"crawford"},"real_author":{"_account_id":1001472,"name":"Alex Crawford","email":"openocd@code.acrawford.com","username":"crawford"},"date":"2021-09-20 14:27:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ae207340372e90d25c413588112cf7b96b9391f8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-25 13:14:48.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"28f42d9c6eb23d606af15509029ffe9af272b616","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-25 13:15:05.000000000","message":"Change has been successfully cherry-picked as 2f424b7eb776b3d32f2b58a3ffd91ff1d5657404","accounts_in_message":[],"_revision_number":2}],"current_revision":"2f424b7eb776b3d32f2b58a3ffd91ff1d5657404","revisions":{"2f424b7eb776b3d32f2b58a3ffd91ff1d5657404":{"kind":"REWORK","_number":2,"created":"2021-09-25 13:15:05.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/59/6559/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/6559/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/2 \u0026\u0026 git checkout -b change-6559 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/6559/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5765a0ce14485aadc6b74c6e2b4f15b73df14603","subject":"Speed up remote bitbang."}],"author":{"name":"Alex Crawford","email":"openocd@code.acrawford.com","date":"2021-09-16 17:00:25.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-25 13:15:05.000000000","tz":0},"subject":"driver/linuxgpiod: add support for opendrain srst","message":"driver/linuxgpiod: add support for opendrain srst\n\nSome MCUs (e.g. the STM32F3) directly expose the internal reset line to\nan external pin. When this signal is driven by a push/pull line, it can\nactually be inhibited by the external driver. This results in a setup\nwhere the MCU cannot reset itself, for example, by a watchdog timeout or\na sysreset request. To fix this condition, support for open drain output\non the SRST line is required.\n\nNote that because `reset_config srst_open_drain` is the default, all\nusers of this adapter will switch over to an open drain output unless\nexplicitly configured otherwise.\n\nSigned-off-by: Alex Crawford \u003copenocd@code.acrawford.com\u003e\nChange-Id: I89b39b03aa03f826ed3c45793412780448940bcc\nReviewed-on: https://review.openocd.org/c/openocd/+/6559\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"deafca52ed826f710209c36ba131c2f2d85e953d":{"kind":"REWORK","_number":1,"created":"2021-09-16 17:46:28.000000000","uploader":{"_account_id":1001472,"name":"Alex Crawford","email":"openocd@code.acrawford.com","username":"crawford"},"ref":"refs/changes/59/6559/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/6559/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/1 \u0026\u0026 git checkout -b change-6559 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/6559/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/6559/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b61a280860f9ceb9bc38125c48d2f0f4d35f1c11","subject":"flash/stm32l4x: fix flash programming in 64-bit hosts"}],"author":{"name":"Alex Crawford","email":"openocd@code.acrawford.com","date":"2021-09-16 17:00:25.000000000","tz":-420},"committer":{"name":"Alex Crawford","email":"openocd@code.acrawford.com","date":"2021-09-16 17:46:00.000000000","tz":-420},"subject":"driver/linuxgpiod: add support for opendrain srst","message":"driver/linuxgpiod: add support for opendrain srst\n\nSome MCUs (e.g. the STM32F3) directly expose the internal reset line to\nan external pin. When this signal is driven by a push/pull line, it can\nactually be inhibited by the external driver. This results in a setup\nwhere the MCU cannot reset itself, for example, by a watchdog timeout or\na sysreset request. To fix this condition, support for open drain output\non the SRST line is required.\n\nNote that because `reset_config srst_open_drain` is the default, all\nusers of this adapter will switch over to an open drain output unless\nexplicitly configured otherwise.\n\nSigned-off-by: Alex Crawford \u003copenocd@code.acrawford.com\u003e\nChange-Id: I89b39b03aa03f826ed3c45793412780448940bcc\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}