)]}'
{"id":"openocd~master~If831d9159b4634c74e19c04099d041a6e2be3f2a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-09-20 16:35:11.000000000","reason":"Antonio Borneo replied on the change"},"1000859":{"account":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"last_update":"2021-09-25 13:13:10.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If831d9159b4634c74e19c04099d041a6e2be3f2a","subject":"arm_tpiu_swo: fix support for deprecated \u0027tpiu\u0027 command before \u0027init\u0027","status":"MERGED","created":"2021-09-17 17:15:37.000000000","updated":"2021-09-25 13:13:10.000000000","submitted":"2021-09-25 13:13:10.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6561","meta_rev_id":"7671e78d7f1448fccb0fe645aa7b4460857102ff","_number":6561,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-25 13:13:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-09-25 13:13:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-09-25 13:13:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-17 17:15:37.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"REVIEWER"},{"updated":"2021-09-17 17:43:33.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"227ce15e0a44a528ab1c6277b17f57c34ea95a01","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-17 17:15:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"72400c4c3cb3177fd1ed6a1076b0954c97e197c2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-17 17:43:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15251/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14476/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a140b326637cf2072d0aa523beeaae0fc51711f6","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2021-09-17 19:35:13.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5815fa4632af005fdb4cd247942c49785dbfccb1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-17 21:15:05.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d94c21dcb200daf0352f603c2b126a158a1595a7","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2021-09-20 10:07:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4fd8c4a95d7216cc975872ad8a588d1f00402ca2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-20 10:29:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cad11be24aae7b8979dd99cfb7c3f3648f4c9ab1","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2021-09-20 11:59:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"488d5d51f9c6fc68469e4a4f1d032c67922254d9","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-20 13:18:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0cb127bb9aa092311c51d138217b4e7645241cef","author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"real_author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"date":"2021-09-20 15:05:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"93e9fb43dbc4aa2d690ed903b4bc31023098ccba","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-20 16:35:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"302647a4c9718169e451e2d9278080f2388378d1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-25 13:12:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7671e78d7f1448fccb0fe645aa7b4460857102ff","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-25 13:13:10.000000000","message":"Change has been successfully cherry-picked as 7b504370f732a00d803163cab2b1750bde1927cf","accounts_in_message":[],"_revision_number":2}],"current_revision":"7b504370f732a00d803163cab2b1750bde1927cf","revisions":{"7b504370f732a00d803163cab2b1750bde1927cf":{"kind":"REWORK","_number":2,"created":"2021-09-25 13:13:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/61/6561/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/6561/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/2 \u0026\u0026 git checkout -b change-6561 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/6561/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a43137619e384bee38ea58d817a0d15876d2473","subject":"arm_adi_v5: drop ANY_ID from table dap_part_nums"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-17 16:47:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-25 13:13:10.000000000","tz":0},"subject":"arm_tpiu_swo: fix support for deprecated \u0027tpiu\u0027 command before \u0027init\u0027","message":"arm_tpiu_swo: fix support for deprecated \u0027tpiu\u0027 command before \u0027init\u0027\n\nCommit dc7b32ea4a00 (\"armv7m_trace: get rid of the old tpiu code\")\nis not handling correctly the old \u0027tpiu\u0027 command if it is run\nduring the config phase (before command \u0027init\u0027).\n\nMove the call to the old event handler \u0027trace-config\u0027 in function\njim_arm_tpiu_swo_enable(), so it is correctly executed after\n\u0027init\u0027.\n\nAdd the call to the old event handler \u0027trace-config\u0027 also during\njim_arm_tpiu_swo_disable(), to match the old behaviour.\n\nAdd more information while alerting that the event \u0027trace-config\u0027\nis deprecated.\n\nChange-Id: If831d9159b4634c74e19c04099d041a6e2be3f2a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: dc7b32ea4a00 (\"armv7m_trace: get rid of the old tpiu code\")\nReviewed-on: https://review.openocd.org/c/openocd/+/6561\nTested-by: jenkins\nReviewed-by: Karl Palsson \u003ckarlp@tweak.net.au\u003e\n"}},"f2f01bcb1f799573da2af45c3a3285c7a92a9f60":{"kind":"REWORK","_number":1,"created":"2021-09-17 17:15:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/61/6561/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/61/6561/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/1 \u0026\u0026 git checkout -b change-6561 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/61/6561/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/61/6561/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c865879eb81b6e5fca58bed8b63f6336b98ec425","subject":"doc: add a note to use \u0027stm32l4x option_load\u0027 after changing option bytes"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-17 16:47:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-17 17:13:24.000000000","tz":120},"subject":"arm_tpiu_swo: fix support for deprecated \u0027tpiu\u0027 command before \u0027init\u0027","message":"arm_tpiu_swo: fix support for deprecated \u0027tpiu\u0027 command before \u0027init\u0027\n\nCommit dc7b32ea4a00 (\"armv7m_trace: get rid of the old tpiu code\")\nis not handling correctly the old \u0027tpiu\u0027 command if it is run\nduring the config phase (before command \u0027init\u0027).\n\nMove the call to the old event handler \u0027trace-config\u0027 in function\njim_arm_tpiu_swo_enable(), so it is correctly executed after\n\u0027init\u0027.\n\nAdd the call to the old event handler \u0027trace-config\u0027 also during\njim_arm_tpiu_swo_disable(), to match the old behaviour.\n\nAdd more information while alerting that the event \u0027trace-config\u0027\nis deprecated.\n\nChange-Id: If831d9159b4634c74e19c04099d041a6e2be3f2a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nFixes: dc7b32ea4a00 (\"armv7m_trace: get rid of the old tpiu code\")\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}