)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"833bb6a3bb47091aa6c5331aad292f87810a3213","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42eaa0f4_ab6f18c3","updated":"2021-09-22 09:17:42.000000000","message":"Thanks. Just one more point","commit_id":"23ec4f98a1bf2be32709a63df72fb847c7807de6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3a08e22f7d39f84656ad966f549d2a582bf77dbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c9d29f8f_8b805542","updated":"2021-09-24 11:08:31.000000000","message":"thanks","commit_id":"b6bd5a20c960ddac6a47702ec0069311b9757549"}],"src/rtos/rtos.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"833bb6a3bb47091aa6c5331aad292f87810a3213","unresolved":true,"context_lines":[{"line_number":616,"context_line":"\t\tLOG_OUTPUT(\"\\r\\n\");"},{"line_number":617,"context_line":"#endif"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"\tint64_t new_stack_ptr;"},{"line_number":620,"context_line":"\tif (stacking-\u003ecalculate_process_stack) {"},{"line_number":621,"context_line":"\t\tnew_stack_ptr \u003d stacking-\u003ecalculate_process_stack(target,"},{"line_number":622,"context_line":"\t\t\t\tstack_data, stacking, stack_ptr);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fdc3af2f_f621ec1b","line":619,"updated":"2021-09-22 09:17:42.000000000","message":"s/int64_t/target_addr_t/","commit_id":"23ec4f98a1bf2be32709a63df72fb847c7807de6"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"43c3163d96a7a415a5520706b006e25b4402bd74","unresolved":false,"context_lines":[{"line_number":616,"context_line":"\t\tLOG_OUTPUT(\"\\r\\n\");"},{"line_number":617,"context_line":"#endif"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"\tint64_t new_stack_ptr;"},{"line_number":620,"context_line":"\tif (stacking-\u003ecalculate_process_stack) {"},{"line_number":621,"context_line":"\t\tnew_stack_ptr \u003d stacking-\u003ecalculate_process_stack(target,"},{"line_number":622,"context_line":"\t\t\t\tstack_data, stacking, stack_ptr);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a4e1add0_d0d36a16","line":619,"in_reply_to":"fdc3af2f_f621ec1b","updated":"2021-09-23 22:16:00.000000000","message":"Done","commit_id":"23ec4f98a1bf2be32709a63df72fb847c7807de6"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"833bb6a3bb47091aa6c5331aad292f87810a3213","unresolved":true,"context_lines":[{"line_number":634,"context_line":""},{"line_number":635,"context_line":"\t\tint offset \u003d stacking-\u003eregister_offsets[i].offset;"},{"line_number":636,"context_line":"\t\tif (offset \u003d\u003d -2)"},{"line_number":637,"context_line":"\t\t\tbuf_cpy(\u0026new_stack_ptr, (*reg_list)[i].value, (*reg_list)[i].size);"},{"line_number":638,"context_line":"\t\telse if (offset !\u003d -1)"},{"line_number":639,"context_line":"\t\t\tbuf_cpy(stack_data + offset, (*reg_list)[i].value, (*reg_list)[i].size);"},{"line_number":640,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6512c8fb_f63dd1f1","line":637,"updated":"2021-09-22 09:17:42.000000000","message":"Just informative, NOT to be fixed in this patch\nThis looks wrong on 64 bit big-endian PC when target register is 32 bits\nSame issue two lines below.","commit_id":"23ec4f98a1bf2be32709a63df72fb847c7807de6"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"43c3163d96a7a415a5520706b006e25b4402bd74","unresolved":false,"context_lines":[{"line_number":634,"context_line":""},{"line_number":635,"context_line":"\t\tint offset \u003d stacking-\u003eregister_offsets[i].offset;"},{"line_number":636,"context_line":"\t\tif (offset \u003d\u003d -2)"},{"line_number":637,"context_line":"\t\t\tbuf_cpy(\u0026new_stack_ptr, (*reg_list)[i].value, (*reg_list)[i].size);"},{"line_number":638,"context_line":"\t\telse if (offset !\u003d -1)"},{"line_number":639,"context_line":"\t\t\tbuf_cpy(stack_data + offset, (*reg_list)[i].value, (*reg_list)[i].size);"},{"line_number":640,"context_line":"\t}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"760238a6_04fcb8d9","line":637,"in_reply_to":"6512c8fb_f63dd1f1","updated":"2021-09-23 22:16:00.000000000","message":"Ack","commit_id":"23ec4f98a1bf2be32709a63df72fb847c7807de6"}]}
