)]}'
{"id":"openocd~master~Id3311b8a1bb0667f309a26d36b67093bfeb8380a","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-09-24 11:08:31.000000000","reason":"Antonio Borneo replied on the change"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2021-10-02 13:17:41.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id3311b8a1bb0667f309a26d36b67093bfeb8380a","subject":"uint64_t-\u003etarget_addr_t for stack pointers.","status":"MERGED","created":"2021-09-21 18:47:01.000000000","updated":"2021-10-02 13:17:41.000000000","submitted":"2021-10-02 13:17:41.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6586","meta_rev_id":"f993ebf8c5df693b434d02d05de3660f45aa222b","_number":6586,"owner":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-02 13:17:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-10-02 13:17:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-21 19:04:06.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-22 09:17:42.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2021-09-24 11:08:31.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"aa91a9669f01ab5a990b3f80cb099a9874d39171","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-09-21 18:47:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"12d71ddc83dc8ea9c50013956e7c2c666596c020","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-21 19:04:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15269/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14493/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"833bb6a3bb47091aa6c5331aad292f87810a3213","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-22 09:17:42.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"43c3163d96a7a415a5520706b006e25b4402bd74","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-09-23 22:16:00.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"273108fc00b0c6236bb016c8c625a8b10d48257d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-09-23 22:16:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9c6b632401d36d89f6a0e6e44e117be07e1a810a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-23 22:28:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15285/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14509/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"3a08e22f7d39f84656ad966f549d2a582bf77dbe","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-24 11:08:31.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9e7c109c7b9347cf80c2c9c0fb75ab415b41914a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-02 13:17:35.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f993ebf8c5df693b434d02d05de3660f45aa222b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-02 13:17:41.000000000","message":"Change has been successfully cherry-picked as e4872054108a3a18dc651b45dea679696e14ee7f","accounts_in_message":[],"_revision_number":3}],"current_revision":"e4872054108a3a18dc651b45dea679696e14ee7f","revisions":{"23ec4f98a1bf2be32709a63df72fb847c7807de6":{"kind":"REWORK","_number":1,"created":"2021-09-21 18:47:01.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/86/6586/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/6586/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/1 \u0026\u0026 git checkout -b change-6586 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/6586/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a098816a6557e5882bf088ab12a06b94934f30ce","subject":"server/telnet: add variables auto-completion"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-21 18:43:21.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-21 18:45:59.000000000","tz":-420},"subject":"uint64_t-\u003etarget_addr_t for stack pointers.","message":"uint64_t-\u003etarget_addr_t for stack pointers.\n\nThis might be incomplete. It\u0027s just a quick attempt to reduce some of\nthe difference between riscv-openocd and mainline. Other stack pointers\ncan be updated as I come across them.\n\nChange-Id: Id3311b8a1bb0667f309a26d36b67093bfeb8380a\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"b6bd5a20c960ddac6a47702ec0069311b9757549":{"kind":"REWORK","_number":2,"created":"2021-09-23 22:16:01.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/86/6586/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/6586/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/2 \u0026\u0026 git checkout -b change-6586 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/6586/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a098816a6557e5882bf088ab12a06b94934f30ce","subject":"server/telnet: add variables auto-completion"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-21 18:43:21.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-23 22:15:50.000000000","tz":-420},"subject":"uint64_t-\u003etarget_addr_t for stack pointers.","message":"uint64_t-\u003etarget_addr_t for stack pointers.\n\nThis might be incomplete. It\u0027s just a quick attempt to reduce some of\nthe difference between riscv-openocd and mainline. Other stack pointers\ncan be updated as I come across them.\n\nChange-Id: Id3311b8a1bb0667f309a26d36b67093bfeb8380a\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"e4872054108a3a18dc651b45dea679696e14ee7f":{"kind":"REWORK","_number":3,"created":"2021-10-02 13:17:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/6586/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/6586/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/3 \u0026\u0026 git checkout -b change-6586 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/6586/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/6586/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b5a24386e49ca643ab750543e3818172d37fbc54","subject":"stlink-dap: add \u0027cmd\u0027 to send arbitrary commands"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-09-21 18:43:21.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-02 13:17:41.000000000","tz":0},"subject":"uint64_t-\u003etarget_addr_t for stack pointers.","message":"uint64_t-\u003etarget_addr_t for stack pointers.\n\nThis might be incomplete. It\u0027s just a quick attempt to reduce some of\nthe difference between riscv-openocd and mainline. Other stack pointers\ncan be updated as I come across them.\n\nChange-Id: Id3311b8a1bb0667f309a26d36b67093bfeb8380a\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6586\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}