)]}'
{"id":"openocd~master~Ibe2b55a7d70597833cfa7f3d843e7c3d2407f2df","project":"openocd","branch":"master","hashtags":[],"change_id":"Ibe2b55a7d70597833cfa7f3d843e7c3d2407f2df","subject":"jtag/core: fix unused assignment","status":"MERGED","created":"2021-09-22 19:19:37.000000000","updated":"2021-10-25 16:08:41.000000000","submitted":"2021-10-25 16:08:41.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6587","meta_rev_id":"07394a22e78354add0398ab01c49e18d77f2d898","_number":6587,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-25 16:08:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-10-25 16:08:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-22 20:00:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b82a91ee998661e6cee04cce7dd7e150773bfd8d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-22 19:19:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2321bcd5943db8b233762485a067431e70f2a3b8","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-22 20:00:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15273/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14497/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"73125d6fc02fbe4e5fb89653029367ac02ab9249","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-22 20:44:40.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"43c72ac6e079864cb170dce5904faabfd0b24cab","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-17 12:53:13.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"07394a22e78354add0398ab01c49e18d77f2d898","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-25 16:08:41.000000000","message":"Change has been successfully cherry-picked as b3f052ba9d9582fe203ff8baa73fef66c02196ac","accounts_in_message":[],"_revision_number":2}],"current_revision":"b3f052ba9d9582fe203ff8baa73fef66c02196ac","revisions":{"6d7afc28d1d5c875adf6e07b6f37413dfbc8204e":{"kind":"REWORK","_number":1,"created":"2021-09-22 19:19:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/87/6587/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/6587/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/1 \u0026\u0026 git checkout -b change-6587 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/6587/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a0bd3c9924870c3b8f428648410181040dabc33c","subject":"Partially Revert \"flash/stm32l4x: introduce flash programming without loader\""}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-22 16:39:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-22 16:39:57.000000000","tz":120},"subject":"jtag/core: fix unused assignment","message":"jtag/core: fix unused assignment\n\nClang scan-build complains about a variable assigned but never\nused.\n\tAlthough the value stored to \u0027val\u0027 is used in the\n\tenclosing expression, the value is never actually read\n\tfrom \u0027val\u0027\n\nRemove the dead assignment. While there, reduce the scope of the\nvariable by declaring the variable at the point of first use.\n\nChange-Id: Ibe2b55a7d70597833cfa7f3d843e7c3d2407f2df\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"b3f052ba9d9582fe203ff8baa73fef66c02196ac":{"kind":"REWORK","_number":2,"created":"2021-10-25 16:08:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/87/6587/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/87/6587/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/2 \u0026\u0026 git checkout -b change-6587 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/87/6587/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/87/6587/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9188115296917ce74ad5b0f83451414735225ce5","subject":"gitignore: Add GNU Global tag files"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-22 16:39:57.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-25 16:08:41.000000000","tz":0},"subject":"jtag/core: fix unused assignment","message":"jtag/core: fix unused assignment\n\nClang scan-build complains about a variable assigned but never\nused.\n\tAlthough the value stored to \u0027val\u0027 is used in the\n\tenclosing expression, the value is never actually read\n\tfrom \u0027val\u0027\n\nRemove the dead assignment. While there, reduce the scope of the\nvariable by declaring the variable at the point of first use.\n\nChange-Id: Ibe2b55a7d70597833cfa7f3d843e7c3d2407f2df\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6587\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}