)]}'
{"id":"openocd~master~Iad2fdc7e6faf650e24cc086ee74c745acb0d1c73","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000675":{"account":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"last_update":"2021-10-25 16:10:04.000000000","reason":"Change was submitted"},"1000566":{"account":{"_account_id":1000566,"name":"Ivan De Cesaris","email":"ivan.de.cesaris@intel.com","username":"iva"},"last_update":"2021-10-25 16:10:04.000000000","reason":"Change was submitted"},"1000564":{"account":{"_account_id":1000564,"name":"Adrian Burns","email":"adrianburns1@gmail.com","username":"aburns"},"last_update":"2021-10-25 16:10:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iad2fdc7e6faf650e24cc086ee74c745acb0d1c73","subject":"target/lakemont: fix dead assignment","status":"MERGED","created":"2021-09-22 19:19:37.000000000","updated":"2021-10-25 16:10:04.000000000","submitted":"2021-10-25 16:10:04.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6591","meta_rev_id":"354ac66180a8a0c9369ea1b94a088f96fcadac25","_number":6591,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-25 16:10:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-10-25 16:10:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},{"_account_id":1000566,"name":"Ivan De Cesaris","email":"ivan.de.cesaris@intel.com","username":"iva"},{"_account_id":1000564,"name":"Adrian Burns","email":"adrianburns1@gmail.com","username":"aburns"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000564,"name":"Adrian Burns","email":"adrianburns1@gmail.com","username":"aburns"},{"_account_id":1000566,"name":"Ivan De Cesaris","email":"ivan.de.cesaris@intel.com","username":"iva"},{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-22 19:23:50.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000675,"name":"Felipe Balbi","email":"balbi@kernel.org","username":"felipebalbi"},"state":"REVIEWER"},{"updated":"2021-09-22 19:23:50.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000566,"name":"Ivan De Cesaris","email":"ivan.de.cesaris@intel.com","username":"iva"},"state":"REVIEWER"},{"updated":"2021-09-22 19:23:50.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000564,"name":"Adrian Burns","email":"adrianburns1@gmail.com","username":"aburns"},"state":"REVIEWER"},{"updated":"2021-09-22 20:32:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f0f03ee16daf72a1e3112dac85c1c5f36775079a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-22 19:19:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9c182d2fbbd7be89f0f8e8c37fedffa33a1b03b1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-22 19:23:50.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f2a2e6d61f2e06550e183dd3abcb580a2bb4caf2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-22 20:32:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15275/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14500/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"eccd643d4c47cb71167a321e6c8f60e255a2bff1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-17 12:53:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"354ac66180a8a0c9369ea1b94a088f96fcadac25","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-25 16:10:04.000000000","message":"Change has been successfully cherry-picked as 327040ad745300c6c2117b81c584ff868567ef83","accounts_in_message":[],"_revision_number":2}],"current_revision":"327040ad745300c6c2117b81c584ff868567ef83","revisions":{"327040ad745300c6c2117b81c584ff868567ef83":{"kind":"REWORK","_number":2,"created":"2021-10-25 16:10:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/6591/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/6591/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/2 \u0026\u0026 git checkout -b change-6591 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/6591/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"01de751025cfaebb7c1090f1d1ff00071ce39c71","subject":"armv8: fix five dead assignments"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-22 17:14:29.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-25 16:10:04.000000000","tz":0},"subject":"target/lakemont: fix dead assignment","message":"target/lakemont: fix dead assignment\n\nClang scan-build complains for a dead assignment:\n\tValue stored to \u0027tapstatus\u0027 is never read\n\nRemove the assignment and add a comment to point for a potential\nremoval of the line.\n\nChange-Id: Iad2fdc7e6faf650e24cc086ee74c745acb0d1c73\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6591\nTested-by: jenkins\n"}},"07f18e19fd0bac302ab8afa06611e7d9fcc7e663":{"kind":"REWORK","_number":1,"created":"2021-09-22 19:19:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/6591/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/6591/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/1 \u0026\u0026 git checkout -b change-6591 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/6591/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/6591/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c8df5de2b69f6976767f54ca50a145a3d0735765","subject":"armv8: fix five dead assignments"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-22 17:14:29.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-22 19:17:55.000000000","tz":120},"subject":"target/lakemont: fix dead assignment","message":"target/lakemont: fix dead assignment\n\nClang scan-build complains for a dead assignment:\n\tValue stored to \u0027tapstatus\u0027 is never read\n\nRemove the assignment and add a comment to point for a potential\nremoval of the line.\n\nChange-Id: Iad2fdc7e6faf650e24cc086ee74c745acb0d1c73\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
