)]}'
{"id":"openocd~master~Ie8dcb74b1c1aa5eea1acd06b3c45c5b44954c9e7","project":"openocd","branch":"master","hashtags":[],"change_id":"Ie8dcb74b1c1aa5eea1acd06b3c45c5b44954c9e7","subject":"mips64_pracc: fix three dead assignments","status":"MERGED","created":"2021-09-22 19:19:37.000000000","updated":"2021-10-25 16:10:16.000000000","submitted":"2021-10-25 16:10:16.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6592","meta_rev_id":"c1d7a5941b20c45e82453f737b3d4dcda09adf7c","_number":6592,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-25 16:10:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-10-25 16:10:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-22 20:21:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f61b5cc46d5d1346f71a380f85a480867aaf763f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-22 19:19:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e151aae7964bc5cd705c6894caf00a924e6ec80e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-22 20:21:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15276/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14499/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0653dfad473bb5e5621c63e526a01da6e09c74d4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-22 20:45:14.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0686deebb9746e88c5d0cee9f577631ba84faee1","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-17 12:54:06.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c1d7a5941b20c45e82453f737b3d4dcda09adf7c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-25 16:10:16.000000000","message":"Change has been successfully cherry-picked as 8f1971295b251dc13b687db493c2daa7f922e940","accounts_in_message":[],"_revision_number":2}],"current_revision":"8f1971295b251dc13b687db493c2daa7f922e940","revisions":{"8f1971295b251dc13b687db493c2daa7f922e940":{"kind":"REWORK","_number":2,"created":"2021-10-25 16:10:16.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/92/6592/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/92/6592/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/2 \u0026\u0026 git checkout -b change-6592 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/92/6592/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"327040ad745300c6c2117b81c584ff868567ef83","subject":"target/lakemont: fix dead assignment"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-22 17:21:39.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-25 16:10:16.000000000","tz":0},"subject":"mips64_pracc: fix three dead assignments","message":"mips64_pracc: fix three dead assignments\n\nClang scan-build complains for three dead assignments:\n\tAlthough the value stored to \u0027data\u0027 is used in the\n\tenclosing expression, the value is never actually read\n\tfrom \u0027data\u0027\n\n\tValue stored to \u0027address\u0027 is never read\n\nRemove the useless assignment and the variable \u0027data\u0027.\n\nChange-Id: Ie8dcb74b1c1aa5eea1acd06b3c45c5b44954c9e7\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6592\nTested-by: jenkins\n"}},"67a49749c25ed99843ab8793fbb7d063a50d411c":{"kind":"REWORK","_number":1,"created":"2021-09-22 19:19:37.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/92/6592/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/92/6592/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/1 \u0026\u0026 git checkout -b change-6592 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/92/6592/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/92/6592/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"07f18e19fd0bac302ab8afa06611e7d9fcc7e663","subject":"target/lakemont: fix dead assignment"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-22 17:21:39.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-22 19:18:29.000000000","tz":120},"subject":"mips64_pracc: fix three dead assignments","message":"mips64_pracc: fix three dead assignments\n\nClang scan-build complains for three dead assignments:\n\tAlthough the value stored to \u0027data\u0027 is used in the\n\tenclosing expression, the value is never actually read\n\tfrom \u0027data\u0027\n\n\tValue stored to \u0027address\u0027 is never read\n\nRemove the useless assignment and the variable \u0027data\u0027.\n\nChange-Id: Ie8dcb74b1c1aa5eea1acd06b3c45c5b44954c9e7\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}