)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7e88bc90e900b6f7ee68f339e0db5c9deb216a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7014cb27_9a85667d","updated":"2021-11-08 09:42:36.000000000","message":"Tarek, this change looks good.\nHowever it seems I bricked my L552 Nucleo during testing.\n\nI had TrusZone blink example (slightly modified) programmed in L5. I decided to return\nback to TZEN\u003d0 and erase the flash.\nFirst I run \u0027stm32l5x mass_erase 0\u0027\nThen I check with erase_check - the second half of flash was reported as unerased - this is secure zone, read as zeroes.\nI issued \u0027stm32l5x trustzone 0 disable\u0027\nand get error msg\n\u0027Deactivation of TZEN is only possible when the RDP is changing to level 0\u0027\nI remembered that I had problem with not-yet-merged TZ support. Unfortunately I was too lazy to look up the old comments and tried to make RDP change possible by setting RDP 1:\n\u0027stm32l5x lock 0\u0027\nYes, I admit that only idiot would lock empty flash. I did.\nNow L5 seems to refuse any access to flash registers - IMO because CPU starts with double fault?\nCan you confirm I lost the device or is there any chance to get into and finish erase?\n\nTesting the security related parts is real hell. Please update the driver with better instructions\nhow user should deactivate TZ.\n","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8c57997b2cea428f0d3b097f806e171186cc64dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b37fb7f_7651e407","updated":"2021-11-13 11:21:25.000000000","message":"two minor issues","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"85a5f559ffbd0e4b061d2b8d9a51ec2e06d8b700","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e917126f_17162961","in_reply_to":"7014cb27_9a85667d","updated":"2021-11-08 10:12:35.000000000","message":"I cannot count the parts that I already broke while testing security,\nI usually work on samples without bootloader/RSS, thus I cannot restore the device.\n\nFortunately, there is a chance to restore your device, by booting from system memory (bootloader/RSS) and connect using STM32CubeProgrammer using the bootloader interface, this will permit to change option bytes and do the trick.\n\nI hope this helps ! Meanwhile I will try to add more details/information within openocd documentation, to avoid such issues in the future.","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"b944ad6f0d6329739a338545b24ddd6cd84ad1be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4ebfb7b_76075419","in_reply_to":"e917126f_17162961","updated":"2021-11-08 10:39:41.000000000","message":"Thanks a lot, connecting BOOT0 to 3V3 was the trick I completely forget about! With boot from system memory OpenOCD managed \u0027stm32l5x trustzone 0 disable\u0027, flash is clean and accessible, TZ disabled, RDP_0","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"2f973c12d62cfbccbc72929aabe1c6a79049d99b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54ad5f80_d113cdc4","updated":"2022-02-25 12:59:06.000000000","message":"thnx, I applied your feedbacks\nalso I have renamed the common file, since there will be another stm32*5 ;)","commit_id":"402712844eefb9b766a79bd2b432403b65b865bb"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"34786b09622ce5456835f1a815daf874612f490b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f87408d_a7bcbb49","updated":"2022-02-25 14:24:59.000000000","message":"@Antonio, I\u0027m postponing the file renaming to \u0027later\u0027, to ease the review of the serie\n\u003e\u003e also I have renamed the common file, since there will be another stm32*5 ;)","commit_id":"1dc0051ef823bcb440d56404c5c30108888a0d6e"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"039150e0260657d8827e0a775e7c5b27e036894b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"24bfb8b2_40d41c08","updated":"2022-03-01 13:19:50.000000000","message":"LGTM, just cosmetic issue","commit_id":"1dc0051ef823bcb440d56404c5c30108888a0d6e"}],"tcl/target/stm32x5x_common.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8c57997b2cea428f0d3b097f806e171186cc64dd","unresolved":true,"context_lines":[{"line_number":48,"context_line":"# the safe side."},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# Note that there is a pretty wide band where things are"},{"line_number":51,"context_line":"# more or less stable, see http://openocd.zylin.com/#/c/3366/"},{"line_number":52,"context_line":"adapter speed 500"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"adapter srst delay 100"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"50cdb3d3_2828d7ce","line":51,"updated":"2021-11-13 11:21:25.000000000","message":"use the new server\u0027s URL\nhttp://review.openocd.org/3366","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"2f973c12d62cfbccbc72929aabe1c6a79049d99b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"# the safe side."},{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# Note that there is a pretty wide band where things are"},{"line_number":51,"context_line":"# more or less stable, see http://openocd.zylin.com/#/c/3366/"},{"line_number":52,"context_line":"adapter speed 500"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"adapter srst delay 100"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"2d52a008_a347fcaf","line":51,"in_reply_to":"50cdb3d3_2828d7ce","updated":"2022-02-25 12:59:06.000000000","message":"Done","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8c57997b2cea428f0d3b097f806e171186cc64dd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37c82dbf_0a019775","line":156,"updated":"2021-11-13 11:21:25.000000000","message":"remove the empty line at end of file","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"944380e5763745a54a1b97d8a40ef711dd548cad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88a582bb_ee2d86d3","line":156,"in_reply_to":"05316c82_e2aecd0c","updated":"2022-03-02 14:39:02.000000000","message":"Done","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"2f973c12d62cfbccbc72929aabe1c6a79049d99b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b577c630_587fde3c","line":156,"in_reply_to":"37c82dbf_0a019775","updated":"2022-02-25 12:59:06.000000000","message":"Done","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"039150e0260657d8827e0a775e7c5b27e036894b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05316c82_e2aecd0c","line":156,"in_reply_to":"b577c630_587fde3c","updated":"2022-03-01 13:19:50.000000000","message":"You removed too much. Please add just one new line","commit_id":"d3fcdd686cf6d5492d1c6cb6a03b7af2fcf6c425"}]}