)]}'
{"id":"openocd~master~Id46c0356ef21cead08726c044a1cd9725fd4f923","project":"openocd","branch":"master","topic":"stlink-queue","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-05 22:40:46.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"Id46c0356ef21cead08726c044a1cd9725fd4f923","subject":"stlink: check buffer size on 16 and 32 bit memory transfer","status":"MERGED","created":"2021-09-27 14:50:56.000000000","updated":"2021-11-05 22:40:54.000000000","submitted":"2021-11-05 22:40:54.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6600-stlink-queue","meta_rev_id":"3d87727d14f2579cb6b19fc07135f65aceab69e8","_number":6600,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:40:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-05 22:40:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:40:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-27 15:07:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-27 22:18:20.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"b5413ab7b3d33ca689405545cd7ef9d84974411f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 14:50:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cfc1742960613d7e689f1a7f6aeca42ad7650421","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-27 15:07:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15295/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14517/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"924beb8665fe291fba2acdf6ff84e105ea7ff8d3","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 18:20:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f8aa534d6abb5ee3fcabcfebad409bd249fb57da","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-09-27 22:18:20.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6f767e46c2bd94d538c51969553bcd2039b2c37e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:40:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3d87727d14f2579cb6b19fc07135f65aceab69e8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:40:54.000000000","message":"Change has been successfully cherry-picked as fd0b4dd15ff7217f3c70818c7fd2f0a5b88de89a","accounts_in_message":[],"_revision_number":2}],"current_revision":"fd0b4dd15ff7217f3c70818c7fd2f0a5b88de89a","revisions":{"e2084064d4a25ccc3be0d81dea7ef6a5e8857e13":{"kind":"REWORK","_number":1,"created":"2021-09-27 14:50:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/6600/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/6600/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/1 \u0026\u0026 git checkout -b change-6600 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/6600/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3993d3188da5976a64f47d4cbf4d7e5b63f0c8d","subject":"tcl/stm32wlx.cfg: comply with new jimtcl expr syntax"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-25 15:51:49.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-26 07:39:43.000000000","tz":120},"subject":"stlink: check buffer size on 16 and 32 bit memory transfer","message":"stlink: check buffer size on 16 and 32 bit memory transfer\n\nBoth HLA and ADIv5 layers limit the memory transfer within blocks\nwhose boundaries are aligned at 1024 or 4096 bytes.\nNew stlink firmware handle the ADIv5 TAR autoincrement, making\npossible to send memory transfers across the boundary of 1024 or\n4096 byte. OpenOCD doesn\u0027t use this feature yet.\n\nUse the correct buffer size in the code, even if it is not used.\nWhile there, split SWIM buffer size from JTAG/SWD case; stlink has\na dedicated command to retrieve SWIM buffer size, but currently\nnot implemented in OpenOCD.\n\nChange-Id: Id46c0356ef21cead08726c044a1cd9725fd4f923\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"fd0b4dd15ff7217f3c70818c7fd2f0a5b88de89a":{"kind":"REWORK","_number":2,"created":"2021-11-05 22:40:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/6600/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/6600/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/2 \u0026\u0026 git checkout -b change-6600 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/6600/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/6600/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7901cf2124fbaffa85d589b67c580d6ad2e9beb6","subject":"flash/nor/stm32lx: fixed writes at high adapter speeds"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-25 15:51:49.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-05 22:40:54.000000000","tz":0},"subject":"stlink: check buffer size on 16 and 32 bit memory transfer","message":"stlink: check buffer size on 16 and 32 bit memory transfer\n\nBoth HLA and ADIv5 layers limit the memory transfer within blocks\nwhose boundaries are aligned at 1024 or 4096 bytes.\nNew stlink firmware handle the ADIv5 TAR autoincrement, making\npossible to send memory transfers across the boundary of 1024 or\n4096 byte. OpenOCD doesn\u0027t use this feature yet.\n\nUse the correct buffer size in the code, even if it is not used.\nWhile there, split SWIM buffer size from JTAG/SWD case; stlink has\na dedicated command to retrieve SWIM buffer size, but currently\nnot implemented in OpenOCD.\n\nChange-Id: Id46c0356ef21cead08726c044a1cd9725fd4f923\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6600\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}