)]}'
{"src/jtag/drivers/stlink_usb.c":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"9b76d52a74c495090cde688cde64d12d2f872d97","unresolved":true,"context_lines":[{"line_number":3617,"context_line":""},{"line_number":3618,"context_line":"\t\tuint8_t buffer[4];"},{"line_number":3619,"context_line":"\t\tstlink_usb_open_ap(h, STLINK_HLA_AP_NUM);"},{"line_number":3620,"context_line":"\t\terr \u003d stlink_usb_read_mem32(h, STLINK_HLA_AP_NUM, STLINK_HLA_CSW, CPUID, 4, buffer);"},{"line_number":3621,"context_line":"\t\tif (err \u003d\u003d ERROR_OK) {"},{"line_number":3622,"context_line":"\t\t\tuint32_t cpuid \u003d le_to_h_u32(buffer);"},{"line_number":3623,"context_line":"\t\t\tint i \u003d (cpuid \u003e\u003e 4) \u0026 0xf;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bf1fa1ab_8f806f94","line":3620,"range":{"start_line":3620,"start_character":2,"end_line":3620,"end_character":86},"updated":"2021-09-28 16:20:08.000000000","message":"I agree on this, but this should fixed later.\nassuming that there is no core on AP#0 or the full AP#0 power domain is down ...\nmoreover this CPUID is mainly for cortex-m, so this should not be present since stlink now supports cortex-a via the dapdirect driver.","commit_id":"34a6cfc845af29b32a1b100976ce301a48dfb5f7"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f14cccfbf3e84f335a85959edad28ff8e24a4ee9","unresolved":false,"context_lines":[{"line_number":3617,"context_line":""},{"line_number":3618,"context_line":"\t\tuint8_t buffer[4];"},{"line_number":3619,"context_line":"\t\tstlink_usb_open_ap(h, STLINK_HLA_AP_NUM);"},{"line_number":3620,"context_line":"\t\terr \u003d stlink_usb_read_mem32(h, STLINK_HLA_AP_NUM, STLINK_HLA_CSW, CPUID, 4, buffer);"},{"line_number":3621,"context_line":"\t\tif (err \u003d\u003d ERROR_OK) {"},{"line_number":3622,"context_line":"\t\t\tuint32_t cpuid \u003d le_to_h_u32(buffer);"},{"line_number":3623,"context_line":"\t\t\tint i \u003d (cpuid \u003e\u003e 4) \u0026 0xf;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ea209519_e467163d","line":3620,"range":{"start_line":3620,"start_character":2,"end_line":3620,"end_character":86},"in_reply_to":"bf1fa1ab_8f806f94","updated":"2021-09-28 17:54:10.000000000","message":"Fully agree.\nLet me add that this is not required on new firmware of st-link.\nOld firmware have this issue that require splitting to avoid TAR autoincrement wrap-around at 1k or 4k bytes.\nNew firmware (\u003e\u003d v2j24) automatically refresh TAR every 1k, so OpenOCD can ignore the wrap-around and simply send the max sequence it can. For older firmware we can simplify and stick at 1k with minor loss in performance.\nPlus, this is a duplicated info wrt struct adiv5_ap.tar_autoincr_block, required for HLA only.","commit_id":"34a6cfc845af29b32a1b100976ce301a48dfb5f7"}]}