)]}'
{"id":"openocd~master~I6661a00d468a1591a253cba9feb3bdb3f7474f5a","project":"openocd","branch":"master","topic":"stlink-queue","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-05 22:41:35.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I6661a00d468a1591a253cba9feb3bdb3f7474f5a","subject":"stlink: detect mem_ap R/W and dequeue set TAR and CSW","status":"MERGED","created":"2021-09-27 14:50:56.000000000","updated":"2021-11-05 22:41:39.000000000","submitted":"2021-11-05 22:41:39.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6603-stlink-queue","meta_rev_id":"c0d2b11c25872de62bbf7c2ce35dab2c12382681","_number":6603,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:41:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-05 22:41:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:41:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-27 16:23:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-10-13 14:46:24.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"4e2bfb5874a19bd518e3feb8a4a2f634cecab250","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 14:50:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7cbef672f9f2bcefaae6ed58567c7d798473872e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-27 16:23:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15297/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14523/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"c681253621df0349407f61b6f247fdd83e60cf72","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 18:21:30.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"55eaf518a72863ac14ae90e2e9e7c0d94e148e3d","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-10-13 14:46:24.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b82d7e41a386a8feb0995ed7d5c6deae5254637d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:41:35.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c0d2b11c25872de62bbf7c2ce35dab2c12382681","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:41:39.000000000","message":"Change has been successfully cherry-picked as 7920110665630c8fdc42277ed17f6849597ea63e","accounts_in_message":[],"_revision_number":2}],"current_revision":"7920110665630c8fdc42277ed17f6849597ea63e","revisions":{"7920110665630c8fdc42277ed17f6849597ea63e":{"kind":"REWORK","_number":2,"created":"2021-11-05 22:41:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/6603/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/6603/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/2 \u0026\u0026 git checkout -b change-6603 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/6603/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f914cd8990435eafc85f8fc75fbecd7fbb96214","subject":"stlink: expose ap number and csw in memory r/w"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-22 21:50:33.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-05 22:41:39.000000000","tz":0},"subject":"stlink: detect mem_ap R/W and dequeue set TAR and CSW","message":"stlink: detect mem_ap R/W and dequeue set TAR and CSW\n\nBy using the stlink commands for memory read write we can gain\nsome performance, but only when TAR and/or CSW are changed.\nDuring long transfers with constant CSW and TAR auto-incremented\nthere is no gain, since the same amount of USB/TCP packet is used.\nPlus, by dropping ADIv5 packed transfers the performance is lower\non 8 and 16 bits transfers.\nThis changes opens the opportunity for collapsing memory burst\naccesses in a single stlink USB/TCP packet.\n\nInitialize the values of enum queue_cmd to easily extract the word\nsize through a macro, even if this is not used here.\n\nChange-Id: I6661a00d468a1591a253cba9feb3bdb3f7474f5a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6603\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"66e8492e9b9df2c6cc2bf64f1ba29b92a3685edc":{"kind":"REWORK","_number":1,"created":"2021-09-27 14:50:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/6603/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/6603/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/1 \u0026\u0026 git checkout -b change-6603 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/6603/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/6603/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"34a6cfc845af29b32a1b100976ce301a48dfb5f7","subject":"stlink: expose ap number and csw in memory r/w"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-22 21:50:33.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-27 08:43:41.000000000","tz":120},"subject":"stlink: detect mem_ap R/W and dequeue set TAR and CSW","message":"stlink: detect mem_ap R/W and dequeue set TAR and CSW\n\nBy using the stlink commands for memory read write we can gain\nsome performance, but only when TAR and/or CSW are changed.\nDuring long transfers with constant CSW and TAR auto-incremented\nthere is no gain, since the same amount of USB/TCP packet is used.\nPlus, by dropping ADIv5 packed transfers the performance is lower\non 8 and 16 bits transfers.\nThis changes opens the opportunity for collapsing memory burst\naccesses in a single stlink USB/TCP packet.\n\nInitialize the values of enum queue_cmd to easily extract the word\nsize through a macro, even if this is not used here.\n\nChange-Id: I6661a00d468a1591a253cba9feb3bdb3f7474f5a\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}