)]}'
{"id":"openocd~master~I3b65acbeaec3bd305f5568b9ee4bc9495b113448","project":"openocd","branch":"master","topic":"stlink-queue","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-01 11:36:22.000000000","reason":"Antonio Borneo replied on the change"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-11-05 22:42:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3b65acbeaec3bd305f5568b9ee4bc9495b113448","subject":"stlink: add support for native no_addr_incr commands","status":"MERGED","created":"2021-09-27 14:50:56.000000000","updated":"2021-11-05 22:42:15.000000000","submitted":"2021-11-05 22:42:15.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6605-stlink-queue","meta_rev_id":"7994ea69a299230bfdc96adc06b6cc26aab8fa38","_number":6605,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:42:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-05 22:42:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:42:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-27 16:00:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-01 09:25:49.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"ab8e4710a0fc1d85ab9b5e6eb35b5e4ce062bcd6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 14:50:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"737fa9996fdadd5a0b7ec06e80be1cde5136d765","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-27 16:00:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15298/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14521/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"aac7dfbff85d14598a24d06d65341cd70ebf7fd5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 18:21:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"58f27bf6db144c48bb483f0759d7691836c35eda","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-01 09:25:49.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5a7a5105623e8e3df096c80baa3066083ba9c308","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-01 11:36:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a1dab6ee5212404c28e9ce7acd12eea84d825531","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:42:02.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7994ea69a299230bfdc96adc06b6cc26aab8fa38","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:42:15.000000000","message":"Change has been successfully cherry-picked as 9a534c4bb2a88fdc2ddaf7d4356faddba59736ea","accounts_in_message":[],"_revision_number":2}],"current_revision":"9a534c4bb2a88fdc2ddaf7d4356faddba59736ea","revisions":{"9a534c4bb2a88fdc2ddaf7d4356faddba59736ea":{"kind":"REWORK","_number":2,"created":"2021-11-05 22:42:15.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/05/6605/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/05/6605/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/2 \u0026\u0026 git checkout -b change-6605 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/05/6605/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"da15f9f8c29064f0124e60ac0ac21ddd11fdcc2c","subject":"stlink: collapse consecutive mem AP r/w in a single command"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-25 21:46:55.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-05 22:42:15.000000000","tz":0},"subject":"stlink: add support for native no_addr_incr commands","message":"stlink: add support for native no_addr_incr commands\n\nFirmware versions V2J26 and V3J1 introduce the command\nSTLINK_DEBUG_WRITEMEM_32BIT_NO_ADDR_INC\nFirmware versions V2J32 and V3J2 introduce the command\nSTLINK_DEBUG_READMEM_32BIT_NO_ADDR_INC\n\nThese new commands can provide speed improvement to Cortex-A\nmemory download (its debug port use a FIFO for data transfer).\n\nAdd the low level commands and extend high level implementation.\n\nChange-Id: I3b65acbeaec3bd305f5568b9ee4bc9495b113448\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6605\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"a86aa2ab5cb81688c4046c24767d3c27d32f9157":{"kind":"REWORK","_number":1,"created":"2021-09-27 14:50:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/05/6605/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/05/6605/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/1 \u0026\u0026 git checkout -b change-6605 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/05/6605/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/05/6605/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8b19592475004a7e48e8b01eae8208a6265ba122","subject":"stlink: collapse consecutive mem AP r/w in a single command"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-25 21:46:55.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-27 14:29:10.000000000","tz":120},"subject":"stlink: add support for native no_addr_incr commands","message":"stlink: add support for native no_addr_incr commands\n\nFirmware versions V2J26 and V3J1 introduce the command\nSTLINK_DEBUG_WRITEMEM_32BIT_NO_ADDR_INC\nFirmware versions V2J32 and V3J2 introduce the command\nSTLINK_DEBUG_READMEM_32BIT_NO_ADDR_INC\n\nThese new commands can provide speed improvement to Cortex-A\nmemory download (its debug port use a FIFO for data transfer).\n\nAdd the low level commands and extend high level implementation.\n\nChange-Id: I3b65acbeaec3bd305f5568b9ee4bc9495b113448\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}