)]}'
{"id":"openocd~master~I538d257fe3c434fc97587846d759951384327f02","project":"openocd","branch":"master","topic":"stlink-queue","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-05 22:42:28.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I538d257fe3c434fc97587846d759951384327f02","subject":"stlink: dequeue CSW write only if it doesn\u0027t change csw_default","status":"MERGED","created":"2021-09-27 14:50:56.000000000","updated":"2021-11-05 22:42:33.000000000","submitted":"2021-11-05 22:42:33.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6606-stlink-queue","meta_rev_id":"b38989eaba7c27c464dd2fe06c0c05b49a075a14","_number":6606,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:42:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-05 22:42:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:42:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-27 16:11:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-01 10:17:32.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"1ef9a45deedd0e533d7924118f64fd6a7baa002a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 14:50:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c78803e35676122ff2bf0f7ae8a755281067db9d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-27 16:11:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15299/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14522/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bf74b32e4516a5976541fb83bf24fe8552426c6a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 18:22:04.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4aebcd44664729b7ea7adbf47105c880ae65d95e","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-01 10:17:32.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c18c4068d43adbebf7f9c67b159037bcb12a54a2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:42:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b38989eaba7c27c464dd2fe06c0c05b49a075a14","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:42:33.000000000","message":"Change has been successfully cherry-picked as 22c76a4fd536ba53f563d72d2b3402c45f925f85","accounts_in_message":[],"_revision_number":2}],"current_revision":"22c76a4fd536ba53f563d72d2b3402c45f925f85","revisions":{"ddc49f4dd7d90ce250543f16b6b0a2923f0d659f":{"kind":"REWORK","_number":1,"created":"2021-09-27 14:50:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/06/6606/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/06/6606/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/1 \u0026\u0026 git checkout -b change-6606 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/06/6606/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a86aa2ab5cb81688c4046c24767d3c27d32f9157","subject":"stlink: add support for native no_addr_incr commands"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-29 16:38:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-27 14:29:10.000000000","tz":120},"subject":"stlink: dequeue CSW write only if it doesn\u0027t change csw_default","message":"stlink: dequeue CSW write only if it doesn\u0027t change csw_default\n\nThe stlink commands for buffer read/write carry the associated CSW\nvalue that has to be used. We can dequeue any CSW write request\nand add the CSW in the following buffer read/write.\n\nIn preparation to next patch that uses stlink commands misc-rw\n(commands that don\u0027t handle CSW value), let\u0027s dequeue only those\nCSW write that don\u0027t change csw_default.\n\nKeep a local cache of last csw_default.\nTag the queued CSW writes that change csw_default.\nDequeue only the un-tagged CSW writes.\n\nOn buffer read/write commands, limiting the dequeued CSW write\nsurely adds a performance penalty. But csw_default is not changed\noften so the penalty is not significant.\n\nChange-Id: I538d257fe3c434fc97587846d759951384327f02\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"22c76a4fd536ba53f563d72d2b3402c45f925f85":{"kind":"REWORK","_number":2,"created":"2021-11-05 22:42:33.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/06/6606/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/06/6606/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/2 \u0026\u0026 git checkout -b change-6606 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/06/6606/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/06/6606/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9a534c4bb2a88fdc2ddaf7d4356faddba59736ea","subject":"stlink: add support for native no_addr_incr commands"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-29 16:38:20.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-05 22:42:33.000000000","tz":0},"subject":"stlink: dequeue CSW write only if it doesn\u0027t change csw_default","message":"stlink: dequeue CSW write only if it doesn\u0027t change csw_default\n\nThe stlink commands for buffer read/write carry the associated CSW\nvalue that has to be used. We can dequeue any CSW write request\nand add the CSW in the following buffer read/write.\n\nIn preparation to next patch that uses stlink commands misc-rw\n(commands that don\u0027t handle CSW value), let\u0027s dequeue only those\nCSW write that don\u0027t change csw_default.\n\nKeep a local cache of last csw_default.\nTag the queued CSW writes that change csw_default.\nDequeue only the un-tagged CSW writes.\n\nOn buffer read/write commands, limiting the dequeued CSW write\nsurely adds a performance penalty. But csw_default is not changed\noften so the penalty is not significant.\n\nChange-Id: I538d257fe3c434fc97587846d759951384327f02\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6606\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}