)]}'
{"id":"openocd~master~I8adc630cc0de733511e9d94533cbfe9f3b301a83","project":"openocd","branch":"master","topic":"stlink-queue","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-05 22:42:46.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I8adc630cc0de733511e9d94533cbfe9f3b301a83","subject":"stlink: add support for rw-misc commands","status":"MERGED","created":"2021-09-27 14:50:56.000000000","updated":"2021-11-05 22:42:55.000000000","submitted":"2021-11-05 22:42:55.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6607-stlink-queue","meta_rev_id":"dc803d70afd53f437c4e62aed3c065ee5d6f8a94","_number":6607,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:42:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-05 22:42:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:42:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-27 16:24:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-01 11:46:14.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"76bd40641acd79279052aa7b999c3db4c457f2a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 14:50:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4212fb97bfaa51037be5624ea7e9c31721560e3e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-27 16:24:24.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15300/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14524/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"828ae736b970c707c735eef1828c04e596e4f719","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 18:19:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e7df831facf61b1ddfe6aab02e02a859687759bd","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-27 18:34:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15303/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14527/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"29846c1a45a03a10060022d67432e6fde3632247","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 18:46:37.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"743ef7b49d70b67be7388d87c34ce139aca5c915","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-01 11:46:14.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f9154609fbd14cea07b7c510c5e9e9e189651395","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:42:46.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"dc803d70afd53f437c4e62aed3c065ee5d6f8a94","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:42:55.000000000","message":"Change has been successfully cherry-picked as 6df533abb89307da066335700856e9bfe8586b94","accounts_in_message":[],"_revision_number":3}],"current_revision":"6df533abb89307da066335700856e9bfe8586b94","revisions":{"883b39789d644ecd050ac632493c68600ed3c04f":{"kind":"REWORK","_number":2,"created":"2021-09-27 18:19:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/6607/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6607/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/2 \u0026\u0026 git checkout -b change-6607 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6607/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ddc49f4dd7d90ce250543f16b6b0a2923f0d659f","subject":"stlink: dequeue CSW write only if it doesn\u0027t change csw_default"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-29 15:54:31.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-27 18:18:24.000000000","tz":120},"subject":"stlink: add support for rw-misc commands","message":"stlink: add support for rw-misc commands\n\nFirmware versions V2J32 and V3J2 introduce the commands RW-MISC\nto put in a single USB packet a sequence of mem_ap read/write.\nThese commands provide a significant speed improvement while\naccessing the debug unit at scattered addresses.\n\nAdd the low level commands and extend high level implementation.\n\nSkip for the moment the command to read the max number of items\nallowed by the firmware and use some hardcoded values.\n\nChange-Id: I8adc630cc0de733511e9d94533cbfe9f3b301a83\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"6df533abb89307da066335700856e9bfe8586b94":{"kind":"REWORK","_number":3,"created":"2021-11-05 22:42:55.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/6607/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6607/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/3 \u0026\u0026 git checkout -b change-6607 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6607/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"22c76a4fd536ba53f563d72d2b3402c45f925f85","subject":"stlink: dequeue CSW write only if it doesn\u0027t change csw_default"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-29 15:54:31.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-05 22:42:55.000000000","tz":0},"subject":"stlink: add support for rw-misc commands","message":"stlink: add support for rw-misc commands\n\nFirmware versions V2J32 and V3J2 introduce the commands RW-MISC\nto put in a single USB packet a sequence of mem_ap read/write.\nThese commands provide a significant speed improvement while\naccessing the debug unit at scattered addresses.\n\nAdd the low level commands and extend high level implementation.\n\nSkip for the moment the command to read the max number of items\nallowed by the firmware and use some hardcoded values.\n\nChange-Id: I8adc630cc0de733511e9d94533cbfe9f3b301a83\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6607\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"357f80ecab1dee03c0d77f2fbd5d8f55fab2fa63":{"kind":"REWORK","_number":1,"created":"2021-09-27 14:50:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/6607/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6607/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/1 \u0026\u0026 git checkout -b change-6607 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6607/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6607/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ddc49f4dd7d90ce250543f16b6b0a2923f0d659f","subject":"stlink: dequeue CSW write only if it doesn\u0027t change csw_default"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-07-29 15:54:31.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-27 14:29:10.000000000","tz":120},"subject":"stlink: add support for rw-misc commands","message":"stlink: add support for rw-misc commands\n\nFirmware versions V2J32 and V3J2 introduce the commands RW-MISC\nto put in a single USB packet a sequence of mem_ap read/write.\nThese commands provide a significant speed improvement while\naccessing the debug unit at scattered addresses.\n\nAdd the low level commands and extend high level implementation.\n\nSkip for the moment the command to read the max number of items\nallowed by the firmware and use some hardcoded values.\n\nChange-Id: I8adc630cc0de733511e9d94533cbfe9f3b301a83\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}