)]}'
{"id":"openocd~master~I713d912a269664859c8142932a9905d24b6d3caa","project":"openocd","branch":"master","topic":"stlink-queue","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-05 22:43:07.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I713d912a269664859c8142932a9905d24b6d3caa","subject":"stlink: skip rw-misc commands with TCP server","status":"MERGED","created":"2021-09-27 14:50:56.000000000","updated":"2021-11-05 22:43:12.000000000","submitted":"2021-11-05 22:43:12.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6608-stlink-queue","meta_rev_id":"74ea2d7a9e0b422313287abff450fd8015559bbd","_number":6608,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:43:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-05 22:43:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:43:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-27 16:25:26.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-01 14:54:10.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"346edd1ca7363512fae0830f179b1cd9bbfbf05a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 14:50:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a1041e2e0ed07d9851fb34c80a3542d205b132b0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-27 16:25:26.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15301/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14525/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"ab93cb643d1f3c457a485b1c3b528f911e9eae72","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 18:19:47.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a914a69b9fb85ca2ee9abf816f86e87531ad1fc2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-09-27 18:45:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15304/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14528/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"00e1684f9b73203bb8ac0f8df079e0d62c6e7147","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-09-27 18:46:50.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"33ec9d0cbbdb57924bf6872a25f0bdcd824e19dd","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-01 14:54:10.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"04f0719ac2c565bf4e929432fc3fa3aa7d58ac2c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:43:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"74ea2d7a9e0b422313287abff450fd8015559bbd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:43:12.000000000","message":"Change has been successfully cherry-picked as bac3ef96b79ac7b7b44585f2c3a2adcd8732f7a2","accounts_in_message":[],"_revision_number":3}],"current_revision":"bac3ef96b79ac7b7b44585f2c3a2adcd8732f7a2","revisions":{"64f9e1d6b4eb89a8e69014df99021abdf74e27a7":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-09-27 18:19:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/08/6608/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/6608/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/2 \u0026\u0026 git checkout -b change-6608 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/6608/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"883b39789d644ecd050ac632493c68600ed3c04f","subject":"stlink: add support for rw-misc commands"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-14 12:48:50.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-27 18:18:24.000000000","tz":120},"subject":"stlink: skip rw-misc commands with TCP server","message":"stlink: skip rw-misc commands with TCP server\n\nThe main purpose of TCP server is to allow multiple clients to\nconnect and share the same physical stlink.\nThe commands RW MISC don\u0027t lock the communication between command\nand answer, thus cannot prevent another client to break this\nsequence. The commands are not supposed to be used in shared mode.\n\nPrevent the use of RW MISC commands on a (possibly) shared TCP\nbackend.\nThis degrades the overall performance, but the shared mode already\nadds its own overhead, so this is not really an issue.\n\nChange-Id: I713d912a269664859c8142932a9905d24b6d3caa\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"bac3ef96b79ac7b7b44585f2c3a2adcd8732f7a2":{"kind":"REWORK","_number":3,"created":"2021-11-05 22:43:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/08/6608/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/6608/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/3 \u0026\u0026 git checkout -b change-6608 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/6608/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6df533abb89307da066335700856e9bfe8586b94","subject":"stlink: add support for rw-misc commands"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-14 12:48:50.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-05 22:43:12.000000000","tz":0},"subject":"stlink: skip rw-misc commands with TCP server","message":"stlink: skip rw-misc commands with TCP server\n\nThe main purpose of TCP server is to allow multiple clients to\nconnect and share the same physical stlink.\nThe commands RW MISC don\u0027t lock the communication between command\nand answer, thus cannot prevent another client to break this\nsequence. The commands are not supposed to be used in shared mode.\n\nPrevent the use of RW MISC commands on a (possibly) shared TCP\nbackend.\nThis degrades the overall performance, but the shared mode already\nadds its own overhead, so this is not really an issue.\n\nChange-Id: I713d912a269664859c8142932a9905d24b6d3caa\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6608\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"9b7b0717e2677a2cf1540953d94806b92439282b":{"kind":"REWORK","_number":1,"created":"2021-09-27 14:50:56.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/08/6608/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/08/6608/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/1 \u0026\u0026 git checkout -b change-6608 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/08/6608/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/08/6608/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"357f80ecab1dee03c0d77f2fbd5d8f55fab2fa63","subject":"stlink: add support for rw-misc commands"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-08-14 12:48:50.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-09-27 14:29:10.000000000","tz":120},"subject":"stlink: skip rw-misc commands with TCP server","message":"stlink: skip rw-misc commands with TCP server\n\nThe main purpose of TCP server is to allow multiple clients to\nconnect and share the same physical stlink.\nThe commands RW MISC don\u0027t lock the communication between command\nand answer, thus cannot prevent another client to break this\nsequence. The commands are not supposed to be used in shared mode.\n\nPrevent the use of RW MISC commands on a (possibly) shared TCP\nbackend.\nThis degrades the overall performance, but the shared mode already\nadds its own overhead, so this is not really an issue.\n\nChange-Id: I713d912a269664859c8142932a9905d24b6d3caa\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}