)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"3da9e0fd06281ad4b548b4f9a19e1728e8b395f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a44f24a_8d86e180","updated":"2021-10-02 05:06:53.000000000","message":"Hi,\nI would appreciate a review about this. Going to +1 as previous. This is just a bunch of cleanups\nRegards,\nNishanth Menon","commit_id":"e30cff883da0f45a63d878821deb45c6b2701c25"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"f4c6a99d897e60e8dcbda0d323f93495d31c927a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f591cb8_ca9f7783","updated":"2021-10-04 15:10:35.000000000","message":"Antonio,\n\nI have fixed it in this patch and follow on ones for R5 and armv8 processors as well. Thanks for highlighting the default -attach behavior. I was\u0027nt aware of that and was scratching my head a bit.\n\nThere are additional cleanups in the updated series I just pushed as well.\n\nRegards,\nNishanth Menon","commit_id":"0c54679d6dc70b0d44e655e5444275c989f1db5e"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b69b85538ba678e974b484f955a6056b8bf953fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"61e19f8a_b90b7022","updated":"2022-03-01 09:29:54.000000000","message":"Actually it calls m3_up twice; the event definition uses \"everything\" that follows as a sequence of commands to be executed","commit_id":"66686cfb0a62187432823a50b923ec18f5928aa2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b41f46a2a1149cbaa7e981bef259cbddc15b6511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"addeb995_498ab2e1","updated":"2022-03-01 09:27:41.000000000","message":"Tarek is right. Maybe it does not trigger runtime error but it\u0027s incorrect","commit_id":"66686cfb0a62187432823a50b923ec18f5928aa2"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"5417f326a75dd67be6dec3359e8ec72fe4e6bcdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6a10d1d9_f45b5685","in_reply_to":"61e19f8a_b90b7022","updated":"2022-03-01 10:41:25.000000000","message":"sure, there is no error, but do we really mean to call it twice ?\nIf so, I prefer to see it in the body of the curly braces","commit_id":"66686cfb0a62187432823a50b923ec18f5928aa2"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"a3d29d71bd1675be6181bcb05d0da7a49be973ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8c8a3efc_5803c832","in_reply_to":"6a10d1d9_f45b5685","updated":"2022-03-01 12:36:09.000000000","message":"Arrgh.. that was a mistake. it was\u0027nt supposed to call m3_up twice.. in the follow on patch ( https://review.openocd.org/c/openocd/+/6618/4/tcl/target/ti_k3.cfg ), I cleaned it up.. but should\u0027nt have introduced it in the first place.","commit_id":"66686cfb0a62187432823a50b923ec18f5928aa2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b10037e1aa04d074ea72dca3d8eac820b683b900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7e181bd5_0eae996a","updated":"2022-03-01 14:11:13.000000000","message":"Thanks!","commit_id":"943e15e0f3f26f87308cbe605a106fccdb3bc502"}],"tcl/target/ti_k3.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"78b824fc20dffacb42d1f4976f2aa9d70b51d4ac","unresolved":true,"context_lines":[{"line_number":152,"context_line":"target create $_TARGETNAME.m3 cortex_m -dap $_CHIPNAME.dap -ap-num 7 -defer-examine"},{"line_number":153,"context_line":"$_TARGETNAME.m3 configure -event reset-assert { }"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"$_TARGETNAME.m3 configure -event gdb-attach {"},{"line_number":156,"context_line":"\t# To access M3, we need to enable the JTAG access for the same."},{"line_number":157,"context_line":"\t# Ensure Power-AP unlocked"},{"line_number":158,"context_line":"\t$::_CHIPNAME.dap apreg 3 [lindex $::_m3_ap_unlock_offsets 0] 0x00190000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"5d68a96f_8a115576","line":155,"updated":"2021-10-02 08:19:44.000000000","message":"The default gdb-attach event is \"halt 1000\". This because GDB requires the target to be halted when it attaches.\nBy using a custom gdb-attach you drop the default. This is ok, but you should keep the same behavior. Now GDB will complain that cannot attach to the target.\nAre you sure about this change?","commit_id":"e30cff883da0f45a63d878821deb45c6b2701c25"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f7b8301ee6b2faaadaef8375f379fb96906fd421","unresolved":true,"context_lines":[{"line_number":152,"context_line":"target create $_TARGETNAME.m3 cortex_m -dap $_CHIPNAME.dap -ap-num 7 -defer-examine"},{"line_number":153,"context_line":"$_TARGETNAME.m3 configure -event reset-assert { }"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"$_TARGETNAME.m3 configure -event gdb-attach {"},{"line_number":156,"context_line":"\t# To access M3, we need to enable the JTAG access for the same."},{"line_number":157,"context_line":"\t# Ensure Power-AP unlocked"},{"line_number":158,"context_line":"\t$::_CHIPNAME.dap apreg 3 [lindex $::_m3_ap_unlock_offsets 0] 0x00190000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"77486e35_0d67aeb3","line":155,"in_reply_to":"5d68a96f_8a115576","updated":"2021-10-02 08:25:39.000000000","message":"Plus, what about ignoring GDB and using OpenOCD from telnet interface?\nWith this change we loose the possibility to access the core.\nIt\u0027s better keeping the proc and calling it in the gdb-attach event","commit_id":"e30cff883da0f45a63d878821deb45c6b2701c25"},{"author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"change_message_id":"f4c6a99d897e60e8dcbda0d323f93495d31c927a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"target create $_TARGETNAME.m3 cortex_m -dap $_CHIPNAME.dap -ap-num 7 -defer-examine"},{"line_number":153,"context_line":"$_TARGETNAME.m3 configure -event reset-assert { }"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"$_TARGETNAME.m3 configure -event gdb-attach {"},{"line_number":156,"context_line":"\t# To access M3, we need to enable the JTAG access for the same."},{"line_number":157,"context_line":"\t# Ensure Power-AP unlocked"},{"line_number":158,"context_line":"\t$::_CHIPNAME.dap apreg 3 [lindex $::_m3_ap_unlock_offsets 0] 0x00190000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"104460d5_173cf854","line":155,"in_reply_to":"77486e35_0d67aeb3","updated":"2021-10-04 15:10:35.000000000","message":"Ack","commit_id":"e30cff883da0f45a63d878821deb45c6b2701c25"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"4634a9fa094a68d54ae209051c002dd237629d6f","unresolved":true,"context_lines":[{"line_number":161,"context_line":"\t$::_TARGETNAME.m3 arp_examine"},{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"$_TARGETNAME.m3 configure -event gdb-attach m3_up {"},{"line_number":165,"context_line":"\tm3_up"},{"line_number":166,"context_line":"\t# gdb-attach default rule"},{"line_number":167,"context_line":"\thalt 1000"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"4c55bdbd_275598a7","line":164,"range":{"start_line":164,"start_character":44,"end_line":164,"end_character":49},"updated":"2022-03-01 09:23:41.000000000","message":"maybe I\u0027m missing stgh, but why m3_up appears here ?","commit_id":"66686cfb0a62187432823a50b923ec18f5928aa2"}]}