)]}'
{"id":"openocd~master~I3259b7c3ae4c71b06d921edfaefe17c03bb673dc","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-01 00:15:24.000000000","reason":"removed on reply"},"1000859":{"account":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"last_update":"2022-03-12 09:41:04.000000000","reason":"Change was submitted"},"1001678":{"account":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"last_update":"2022-03-12 09:41:04.000000000","reason":"Change was submitted"},"1001836":{"account":{"_account_id":1001836,"name":"Vignesh Raghavendra","username":"r-vignesh"},"last_update":"2022-03-12 09:41:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3259b7c3ae4c71b06d921edfaefe17c03bb673dc","subject":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function","status":"MERGED","created":"2021-10-02 05:01:55.000000000","updated":"2022-03-12 09:41:04.000000000","submitted":"2022-03-12 09:41:04.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6616","meta_rev_id":"bac3f5a8207685d1dea0fb81fc9b543fb94cbd62","_number":6616,"owner":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-12 09:41:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-12 09:41:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"_account_id":1001836,"name":"Vignesh Raghavendra","username":"r-vignesh"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},{"_account_id":1001836,"name":"Vignesh Raghavendra","username":"r-vignesh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-02 05:07:35.000000000","updated_by":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"REVIEWER"},{"updated":"2021-10-02 05:07:35.000000000","updated_by":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"reviewer":{"_account_id":1001836,"name":"Vignesh Raghavendra","username":"r-vignesh"},"state":"REVIEWER"},{"updated":"2021-10-02 05:07:35.000000000","updated_by":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-10-02 05:59:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e1143957483bb9890c57841d7c089fffc71c7206","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2021-10-02 05:01:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1d4a5d3d073083fe9c99e2044278d1db6884ae86","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2021-10-02 05:07:35.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0adcbde1baee89ce00c28387afe5f73481471c33","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-02 05:59:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15341/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14568/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"80c7405dc37f2274b9bd49229ad1a5b38867693c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2021-10-04 15:06:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"925d2c54815e18756ff3bad05e4e41ff7ae9e008","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-04 16:12:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15376/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14595/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"86655b4d2ae2a7e80ccd5f87b2487bee697f5699","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-01-03 19:29:07.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"ebdab23f3eadefceba45e48aac8feed89f678e83","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-03 21:29:52.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15745/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14962/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"447d8096037a656d87579617b5282e5f29962f5b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-02-08 01:16:45.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"c915423f5d060430ea976fb520deaec820198c45","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-08 03:04:50.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15853/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15065/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"9dbb60e8fbbdf598dad31b4f472c9edb4f942570","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-01 00:15:24.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"033574fb0baa0c251582c258343d73563ad61aae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-03-01 12:42:04.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"9316f461ef2c57436a93646d614265e1d9a64489","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-01 14:31:52.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"0d8d16986f6289de00e365e597d7a2be58df3300","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-01 14:57:38.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15919/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15131/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"ed4836084684e677234a2bdfa8cabde9dade27f3","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-03-01 15:08:03.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"a1442a0e6dfaa6a675a720bb28538e801ed3b328","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-03-01 15:13:58.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"9b3c6a19f81004991cf7c9cf09f1e2001c7043b3","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-03-01 15:15:50.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"fbc11a3af9e00cc292683547eeeb0c8e0df7c2e9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-01 15:57:49.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15925/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15135/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"aac4ac1766c3922a8e83142df6391131ec63b7ab","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-01 22:13:12.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"bac3f5a8207685d1dea0fb81fc9b543fb94cbd62","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-12 09:41:04.000000000","message":"Change has been successfully cherry-picked as 4ea21b95f9562ae13ef200461180bc72bbad8926","accounts_in_message":[],"_revision_number":7}],"current_revision":"4ea21b95f9562ae13ef200461180bc72bbad8926","revisions":{"20865f4f2a14c9c2f8949bbb26ae840f416439e5":{"kind":"REWORK","_number":1,"created":"2021-10-02 05:01:55.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/16/6616/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6616/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/1 \u0026\u0026 git checkout -b change-6616 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6616/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e30cff883da0f45a63d878821deb45c6b2701c25","subject":"tcl/target/ti_k3: Remove m3/m4_up using gdb-attach event hook"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-02 03:52:36.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-02 05:01:20.000000000","tz":-300},"subject":"tcl/target/ti_k3: Remove a53/a72_up using gdb-attach event hook","message":"tcl/target/ti_k3: Remove a53/a72_up using gdb-attach event hook\n\nDrop the _up command since we can depend on gdb-attach event in a\nmuch cleaner fashion.\n\nWhile at it, fix a minor type of s/are/as in \"Set Default target are\ncore 0\".\n\nSince we can detect the type of target as well, make the attach\nfunction name generic for the follow on cleanup patch on R5 to use as\nwell.\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I3259b7c3ae4c71b06d921edfaefe17c03bb673dc\n"}},"b0ef5131b90ca6f57e6dd6766355d253f6dab58b":{"kind":"REWORK","_number":2,"created":"2021-10-04 15:06:40.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/16/6616/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6616/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/2 \u0026\u0026 git checkout -b change-6616 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6616/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ffe11bd05135bddd7f2a45591a611e56ce47af1a","subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 15:01:45.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 15:05:21.000000000","tz":-300},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function\n\nSince we can detect the type of target as well, reuse the _cpu_no_smp_up\nfunction name and use the target name to simplify the _up function and\nmaintain consistency with what we introduced for r5.\n\nLets introduce gdb-attach event in a much cleaner fashion.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nWhile at it, fix a minor type of s/are/as in \"Set Default target are\ncore 0\".\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I3259b7c3ae4c71b06d921edfaefe17c03bb673dc\n"}},"92e9974420c7c9edea102f2148bbbbf1d9d85e71":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-01-03 19:29:07.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/16/6616/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6616/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/3 \u0026\u0026 git checkout -b change-6616 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6616/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3a61c46a29f88583acf2831905d2b72e6f195f3d","subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 15:01:45.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-01-03 19:28:58.000000000","tz":-360},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function\n\nSince we can detect the type of target as well, reuse the _cpu_no_smp_up\nfunction name and use the target name to simplify the _up function and\nmaintain consistency with what we introduced for r5.\n\nLets introduce gdb-attach event in a much cleaner fashion.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nWhile at it, fix a minor type of s/are/as in \"Set Default target are\ncore 0\".\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I3259b7c3ae4c71b06d921edfaefe17c03bb673dc\n"}},"33b2af8d83d56e22570a4fe8c9681dcddd4c9246":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-02-08 01:16:45.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/16/6616/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6616/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/4 \u0026\u0026 git checkout -b change-6616 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6616/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"357b6be88ccfe14261433a691b9a69133a8c1fbb","subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 15:01:45.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-02-08 01:10:14.000000000","tz":-360},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function\n\nSince we can detect the type of target as well, reuse the _cpu_no_smp_up\nfunction name and use the target name to simplify the _up function and\nmaintain consistency with what we introduced for r5.\n\nLets introduce gdb-attach event in a much cleaner fashion.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nWhile at it, fix a minor type of s/are/as in \"Set Default target are\ncore 0\".\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I3259b7c3ae4c71b06d921edfaefe17c03bb673dc\n"}},"7c5acdec2c882b8f05c32b64489f462eef45cef7":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2022-03-01 12:42:04.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/16/6616/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6616/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/5 \u0026\u0026 git checkout -b change-6616 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6616/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"48b2be5a3ac0e09965f234e9b20b6305332cfdfb","subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 15:01:45.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-03-01 12:39:56.000000000","tz":-360},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function\n\nSince we can detect the type of target as well, reuse the _cpu_no_smp_up\nfunction name and use the target name to simplify the _up function and\nmaintain consistency with what we introduced for r5.\n\nLets introduce gdb-attach event in a much cleaner fashion.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nWhile at it, fix a minor type of s/are/as in \"Set Default target are\ncore 0\".\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I3259b7c3ae4c71b06d921edfaefe17c03bb673dc\n"}},"7223eb725d6e7f8023c1e11e14756599b1743753":{"kind":"REWORK","_number":6,"created":"2022-03-01 15:13:58.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/16/6616/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6616/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/6 \u0026\u0026 git checkout -b change-6616 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6616/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f203a75fcfab6a31b47e165fd471bea94cbc83a1","subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-03-01 15:09:55.000000000","tz":-360},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-03-01 15:12:03.000000000","tz":-360},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function\n\nSince we can detect the type of target as well, reuse the _cpu_no_smp_up\nfunction name and use the target name to simplify the _up function and\nmaintain consistency with what we introduced for r5.\n\nLets introduce gdb-attach event in a much cleaner fashion.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nWhile at it, fix a minor type of s/are/as in \"Set Default target are\ncore 0\" and simplify the foreach usage.\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I3259b7c3ae4c71b06d921edfaefe17c03bb673dc\n"}},"4ea21b95f9562ae13ef200461180bc72bbad8926":{"kind":"REWORK","_number":7,"created":"2022-03-12 09:41:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/16/6616/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6616/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/7 \u0026\u0026 git checkout -b change-6616 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6616/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6616/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3ba2b515b528094b43d5be5056b9e52f1dc33969","subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-03-01 15:09:55.000000000","tz":-360},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-12 09:41:04.000000000","tz":0},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function\n\nSince we can detect the type of target as well, reuse the _cpu_no_smp_up\nfunction name and use the target name to simplify the _up function and\nmaintain consistency with what we introduced for r5.\n\nLets introduce gdb-attach event in a much cleaner fashion.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nWhile at it, fix a minor type of s/are/as in \"Set Default target are\ncore 0\" and simplify the foreach usage.\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I3259b7c3ae4c71b06d921edfaefe17c03bb673dc\nReviewed-on: https://review.openocd.org/c/openocd/+/6616\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}