)]}'
{"id":"openocd~master~I31506bb2b86e63638082640eb72aa7c4c9575e93","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-03-01 00:14:02.000000000","reason":"removed on reply"},"1000859":{"account":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"last_update":"2022-03-12 09:40:53.000000000","reason":"Change was submitted"},"1001678":{"account":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"last_update":"2022-03-12 09:40:53.000000000","reason":"Change was submitted"},"1001836":{"account":{"_account_id":1001836,"name":"Vignesh Raghavendra","username":"r-vignesh"},"last_update":"2022-03-12 09:40:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I31506bb2b86e63638082640eb72aa7c4c9575e93","subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function","status":"MERGED","created":"2021-10-02 05:01:55.000000000","updated":"2022-03-12 09:40:53.000000000","submitted":"2022-03-12 09:40:53.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6617","meta_rev_id":"e2cc69548fdf51b2f5fdc230a151b72b056230be","_number":6617,"owner":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-03-12 09:40:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-03-12 09:40:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"_account_id":1001836,"name":"Vignesh Raghavendra","username":"r-vignesh"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},{"_account_id":1001836,"name":"Vignesh Raghavendra","username":"r-vignesh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-02 05:07:53.000000000","updated_by":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"reviewer":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"state":"REVIEWER"},{"updated":"2021-10-02 05:07:53.000000000","updated_by":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"reviewer":{"_account_id":1001836,"name":"Vignesh Raghavendra","username":"r-vignesh"},"state":"REVIEWER"},{"updated":"2021-10-02 05:07:53.000000000","updated_by":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-10-02 05:21:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b53e74fbabaf342ea09fc0ec81e76ecbf7eebf36","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2021-10-02 05:01:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"909124d865bffb5e2140f7e2eb883b3cf99adbec","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2021-10-02 05:07:53.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c7685a6d201df02b77b0673fd4de1df48cbfa0ac","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-02 05:21:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15342/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14565/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0f8ba62001f25e67d635217f878878e52930ef56","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2021-10-04 15:06:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5a0eea7bc2d0e2438b45987b259615f04e6a51e4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-04 16:00:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15377/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14594/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a0ecae74357e80d3f9dd766bf0f9761f4a61a5ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-01-03 19:29:07.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"9a31164a89d1ce52b3081c26b238e893faeb4213","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-03 21:13:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15744/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14961/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"50af0e5eaed01c6e98e28457c0da6c2987b1deeb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-02-08 01:16:45.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"d14a15755311f6057a28997f8bbed140ddccf626","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-08 03:17:43.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15854/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15066/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"97d91212a8befa13f671a416213ddb8a9f88815b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-01 00:14:02.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"a550c78643b58c1717a0e1d38f4fff8fc9c25b67","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-03-01 12:42:04.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"67d0e77f0a09bf0496aa3360f7495d312c4bdc1b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-01 14:24:29.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"74b93f237ec1c0a9dfe40f3ebde5f0c652b45163","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-01 14:43:59.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15918/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15130/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"89893113698ed4f889cde82de7cd853d16be6bc6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-03-01 15:13:58.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"eb5684955589f18e58eab20cd8e2ef28817ffd9b","author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"real_author":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"date":"2022-03-01 15:15:39.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"a533d5d740a5e367b2cbd2e2a5703e81d34819b5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-03-01 15:39:26.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15924/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15134/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"1b9868ccad554b979429f1421c2cd28554d09b09","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-01 22:13:25.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"e2cc69548fdf51b2f5fdc230a151b72b056230be","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-12 09:40:53.000000000","message":"Change has been successfully cherry-picked as 3ba2b515b528094b43d5be5056b9e52f1dc33969","accounts_in_message":[],"_revision_number":7}],"current_revision":"3ba2b515b528094b43d5be5056b9e52f1dc33969","revisions":{"357b6be88ccfe14261433a691b9a69133a8c1fbb":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-02-08 01:16:45.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/17/6617/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6617/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/4 \u0026\u0026 git checkout -b change-6617 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6617/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ea3677b4def3ed419467f3eeed39f6448991e5fe","subject":"tcl/target/ti_k3: Rename R5 targets to be more descriptive"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 14:20:34.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-02-08 01:10:14.000000000","tz":-360},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function\n\nSince we can detect the type of target as well, make the attach\nfunction name generic for the follow on cleanup patch on armv8 to use\nas well.\n\nLets introduce gdb-attach event in a much cleaner fashion. We can\nintroduce a simpler r5_up function since we now have more descriptive\ncore names making the individual descriptive procs redundant.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I31506bb2b86e63638082640eb72aa7c4c9575e93\n"}},"48b2be5a3ac0e09965f234e9b20b6305332cfdfb":{"kind":"REWORK","_number":5,"created":"2022-03-01 12:42:04.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/17/6617/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6617/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/5 \u0026\u0026 git checkout -b change-6617 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6617/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8fa6bffd041a473a360761e86ed1f4f29f769403","subject":"tcl/target/ti_k3: Rename R5 targets to be more descriptive"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 14:20:34.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-03-01 12:39:56.000000000","tz":-360},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function\n\nSince we can detect the type of target as well, make the attach\nfunction name generic for the follow on cleanup patch on armv8 to use\nas well.\n\nLets introduce gdb-attach event in a much cleaner fashion. We can\nintroduce a simpler r5_up function since we now have more descriptive\ncore names making the individual descriptive procs redundant.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I31506bb2b86e63638082640eb72aa7c4c9575e93\n"}},"f203a75fcfab6a31b47e165fd471bea94cbc83a1":{"kind":"REWORK","_number":6,"created":"2022-03-01 15:13:58.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/17/6617/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6617/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/6 \u0026\u0026 git checkout -b change-6617 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6617/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8fa6bffd041a473a360761e86ed1f4f29f769403","subject":"tcl/target/ti_k3: Rename R5 targets to be more descriptive"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 14:20:34.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-03-01 15:06:24.000000000","tz":-360},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function\n\nSince we can detect the type of target as well, make the attach\nfunction name generic for the follow on cleanup patch on armv8 to use\nas well.\n\nLets introduce gdb-attach event in a much cleaner fashion. We can\nintroduce a simpler r5_up function since we now have more descriptive\ncore names making the individual descriptive procs redundant.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I31506bb2b86e63638082640eb72aa7c4c9575e93\n"}},"3ba2b515b528094b43d5be5056b9e52f1dc33969":{"kind":"REWORK","_number":7,"created":"2022-03-12 09:40:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/6617/7","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6617/7","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/7 \u0026\u0026 git checkout -b change-6617 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6617/7","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4b12c9e8c507a1ba748de32c9ab9f3e7654c22b4","subject":"tcl/target/ti_k3: Rename R5 targets to be more descriptive"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 14:20:34.000000000","tz":-300},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-03-12 09:40:53.000000000","tz":0},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function\n\nSince we can detect the type of target as well, make the attach\nfunction name generic for the follow on cleanup patch on armv8 to use\nas well.\n\nLets introduce gdb-attach event in a much cleaner fashion. We can\nintroduce a simpler r5_up function since we now have more descriptive\ncore names making the individual descriptive procs redundant.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I31506bb2b86e63638082640eb72aa7c4c9575e93\nReviewed-on: https://review.openocd.org/c/openocd/+/6617\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"f9efa407f03ca74cda6cb70cd69853fb17b0296c":{"kind":"REWORK","_number":1,"created":"2021-10-02 05:01:55.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/17/6617/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6617/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/1 \u0026\u0026 git checkout -b change-6617 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6617/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20865f4f2a14c9c2f8949bbb26ae840f416439e5","subject":"tcl/target/ti_k3: Remove a53/a72_up using gdb-attach event hook"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-02 03:59:01.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-02 05:01:25.000000000","tz":-300},"subject":"tcl/target/ti_k3: Remove *_r5_up using gdb-attach event hook","message":"tcl/target/ti_k3: Remove *_r5_up using gdb-attach event hook\n\nDrop the _up command since we can depend on gdb-attach event in a much\ncleaner fashion. This also does a major cleanup of now-un-necessary\nvariables from the cfg file.\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I31506bb2b86e63638082640eb72aa7c4c9575e93\n"}},"ffe11bd05135bddd7f2a45591a611e56ce47af1a":{"kind":"REWORK","_number":2,"created":"2021-10-04 15:06:40.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/17/6617/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6617/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/2 \u0026\u0026 git checkout -b change-6617 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6617/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"02554428ce0239c4404e5fce0707f723d4e966e6","subject":"tcl/target/ti_k3: Rename R5 targets to be more descriptive"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 14:20:34.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 14:20:34.000000000","tz":-300},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function\n\nSince we can detect the type of target as well, make the attach\nfunction name generic for the follow on cleanup patch on armv8 to use\nas well.\n\nLets introduce gdb-attach event in a much cleaner fashion. We can\nintroduce a simpler r5_up function since we now have more descriptive\ncore names making the individual descriptive procs redundant.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I31506bb2b86e63638082640eb72aa7c4c9575e93\n"}},"3a61c46a29f88583acf2831905d2b72e6f195f3d":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-01-03 19:29:07.000000000","uploader":{"_account_id":1001678,"name":"Nishanth Menon","email":"nm@ti.com","username":"nmenon"},"ref":"refs/changes/17/6617/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6617/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/3 \u0026\u0026 git checkout -b change-6617 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6617/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6617/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d45a525e02f7fb09ae0802bf2e3495fe95028350","subject":"tcl/target/ti_k3: Rename R5 targets to be more descriptive"}],"author":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2021-10-04 14:20:34.000000000","tz":-300},"committer":{"name":"Nishanth Menon","email":"nm@ti.com","date":"2022-01-03 19:28:58.000000000","tz":-360},"subject":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function","message":"tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function\n\nSince we can detect the type of target as well, make the attach\nfunction name generic for the follow on cleanup patch on armv8 to use\nas well.\n\nLets introduce gdb-attach event in a much cleaner fashion. We can\nintroduce a simpler r5_up function since we now have more descriptive\ncore names making the individual descriptive procs redundant.\n\nNOTE: we add a halt 1000 to retain the default gdb-attach hook behavior\n\nSigned-off-by: Nishanth Menon \u003cnm@ti.com\u003e\nChange-Id: I31506bb2b86e63638082640eb72aa7c4c9575e93\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}