)]}'
{"id":"openocd~master~I4d288e6536ebe7110a184db6540223fc67361ec3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-10-25 16:13:03.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4d288e6536ebe7110a184db6540223fc67361ec3","subject":"hla: improve readability of struct hl_interface_s initialization","status":"MERGED","created":"2021-10-08 17:02:28.000000000","updated":"2021-10-25 16:13:03.000000000","submitted":"2021-10-25 16:13:03.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6636","meta_rev_id":"626e79a4fd08908a81726ebeca8fb0f0ce5ab714","_number":6636,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-10-25 16:13:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-10-25 16:13:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-08 17:47:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-10-09 07:55:35.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"2b7afefa7b6624b2de18b9fbc02906a7ba35c0eb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-08 17:02:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5cf8c9c299e5d96685e026a70aa0f215049f1076","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-08 17:47:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15405/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14624/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4fe81c428211abc6fc83f28edca6066c50e468d5","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-10-09 07:55:35.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"626e79a4fd08908a81726ebeca8fb0f0ce5ab714","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-25 16:13:03.000000000","message":"Change has been successfully cherry-picked as 69190094ad209b2d9091d7c2ca90ac7d49382d61","accounts_in_message":[],"_revision_number":2}],"current_revision":"69190094ad209b2d9091d7c2ca90ac7d49382d61","revisions":{"822c6745d62fd44e6e3ce270f06f397b2e697e6c":{"kind":"REWORK","_number":1,"created":"2021-10-08 17:02:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/6636/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/6636/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/1 \u0026\u0026 git checkout -b change-6636 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/6636/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9b0c33d1ae21a7fcdf87ed7880d1e4d33f1d98f3","subject":"riscv: use relative path to include contrib\u0027s data"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-09-16 08:50:04.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-08 16:59:53.000000000","tz":120},"subject":"hla: improve readability of struct hl_interface_s initialization","message":"hla: improve readability of struct hl_interface_s initialization\n\nThe initialization is barely readable, while actually only few\nfields are set with value nor zero nor NULL.\n\nRewrite the initialization using C99 struct designations.\n\nChange-Id: I4d288e6536ebe7110a184db6540223fc67361ec3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"69190094ad209b2d9091d7c2ca90ac7d49382d61":{"kind":"REWORK","_number":2,"created":"2021-10-25 16:13:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/36/6636/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/36/6636/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/2 \u0026\u0026 git checkout -b change-6636 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/36/6636/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/36/6636/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0fb131c23a1cba9ea128db9c72fcd6479e508513","subject":"riscv: use relative path to include contrib\u0027s data"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2019-09-16 08:50:04.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-25 16:13:03.000000000","tz":0},"subject":"hla: improve readability of struct hl_interface_s initialization","message":"hla: improve readability of struct hl_interface_s initialization\n\nThe initialization is barely readable, while actually only few\nfields are set with value nor zero nor NULL.\n\nRewrite the initialization using C99 struct designations.\n\nChange-Id: I4d288e6536ebe7110a184db6540223fc67361ec3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6636\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}