)]}'
{"id":"openocd~master~I1b1c54d3b36d7b60390985d787c8449432788141","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-13 10:46:15.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I1b1c54d3b36d7b60390985d787c8449432788141","subject":"jtag/core: get rid of variable \u0027jtag\u0027","status":"MERGED","created":"2021-10-08 17:02:28.000000000","updated":"2021-11-13 10:46:25.000000000","submitted":"2021-11-13 10:46:25.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6639","meta_rev_id":"7ab162a7339eb7b424e7c2eb9ebefc510762a026","_number":6639,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:46:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-13 10:46:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:46:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-08 18:00:27.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-02 10:50:05.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"9b825e39cf0259190c01acf1cb34d1800facc7e4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-08 17:02:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fcc46578d1df9adc99956532e768fe5262b3992d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-08 18:00:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15409/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14625/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"7e5276c873a95e7f44012aca4b7336098ebcf2cf","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-18 10:03:11.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"64691e2c92f11efdcc163289bf730a20af679747","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-02 10:50:05.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2fafd9438068c0db528d8f27739ea35ffe6c205a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-13 10:46:15.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7ab162a7339eb7b424e7c2eb9ebefc510762a026","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-13 10:46:25.000000000","message":"Change has been successfully cherry-picked as a9d0386411d1e372bf4d2187ff7b843bb5e9bfc6","accounts_in_message":[],"_revision_number":2}],"current_revision":"a9d0386411d1e372bf4d2187ff7b843bb5e9bfc6","revisions":{"a9d0386411d1e372bf4d2187ff7b843bb5e9bfc6":{"kind":"REWORK","_number":2,"created":"2021-11-13 10:46:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/6639/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/6639/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/2 \u0026\u0026 git checkout -b change-6639 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/6639/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"be57b0ab847e8246b354ca9203024737cdec403b","subject":"Update jtagspi driver for 1-, 2- and 4-byte addresses"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-07 08:37:06.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-13 10:46:25.000000000","tz":0},"subject":"jtag/core: get rid of variable \u0027jtag\u0027","message":"jtag/core: get rid of variable \u0027jtag\u0027\n\nThe variable \u0027jtag\u0027 is set to \u0027adapter_driver\u0027 during adapter\ninitialization and is used:\n- to check if adapter has been initialized;\n- as local copy of adapter_driver.\n\nIntroduce a static flag to check if the adapter has been already\ninitialized and a convenience test function.\nUse the test function and the original value of adapter_driver in\nthe code and drop the variable \u0027jtag\u0027.\n\nChange-Id: I1b1c54d3b36d7b60390985d787c8449432788141\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6639\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"b97813b615b90d0bc5e2a3b824d83b485c7b71c8":{"kind":"REWORK","_number":1,"created":"2021-10-08 17:02:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/39/6639/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/39/6639/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/1 \u0026\u0026 git checkout -b change-6639 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/39/6639/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/39/6639/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d50ea342e52f24d9631c83b4981f36bfb20bb523","subject":"jtag/core: remove unused variable"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-07 08:37:06.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-08 16:59:53.000000000","tz":120},"subject":"jtag/core: get rid of variable \u0027jtag\u0027","message":"jtag/core: get rid of variable \u0027jtag\u0027\n\nThe variable \u0027jtag\u0027 is set to \u0027adapter_driver\u0027 during adapter\ninitialization and is used:\n- to check if adapter has been initialized;\n- as local copy of adapter_driver.\n\nIntroduce a static flag to check if the adapter has been already\ninitialized and a convenience test function.\nUse the test function and the original value of adapter_driver in\nthe code and drop the variable \u0027jtag\u0027.\n\nChange-Id: I1b1c54d3b36d7b60390985d787c8449432788141\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}