)]}'
{"id":"openocd~master~I4fe0d32991a8a30e315807180688035ae9ee01ce","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-13 10:46:56.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I4fe0d32991a8a30e315807180688035ae9ee01ce","subject":"jtag/adapter: move \u0027usb location\u0027 code in adapter.c","status":"MERGED","created":"2021-10-08 17:02:28.000000000","updated":"2021-11-13 10:47:02.000000000","submitted":"2021-11-13 10:47:02.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6640","meta_rev_id":"2e20bb3e231261645915dfa980818f3bb9f8b538","_number":6640,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:47:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-13 10:47:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:47:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-08 18:41:02.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-02 11:37:33.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"da24faf3590cef9cb450fbbb583386f6511a98a5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-08 17:02:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9fab688eb4fca6465327836c731638f80125c046","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-08 18:41:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15410/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14628/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"00fe8e0fe4b58ebf86ddec72c98d6ce70bee9c09","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-18 10:03:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e13e568638665876dde769199d4a2a2880db7e46","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-02 11:37:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4984f57ecb9d5efdd6f05e6bd2f93f86eeacd3b4","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-13 10:46:56.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2e20bb3e231261645915dfa980818f3bb9f8b538","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-13 10:47:02.000000000","message":"Change has been successfully cherry-picked as 4cb3c9fae2a6a6cb5cf2c664179edace22abf5f6","accounts_in_message":[],"_revision_number":2}],"current_revision":"4cb3c9fae2a6a6cb5cf2c664179edace22abf5f6","revisions":{"4cb3c9fae2a6a6cb5cf2c664179edace22abf5f6":{"kind":"REWORK","_number":2,"created":"2021-11-13 10:47:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/6640/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/6640/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/2 \u0026\u0026 git checkout -b change-6640 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/6640/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a9d0386411d1e372bf4d2187ff7b843bb5e9bfc6","subject":"jtag/core: get rid of variable \u0027jtag\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-06 21:17:30.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-13 10:47:02.000000000","tz":0},"subject":"jtag/adapter: move \u0027usb location\u0027 code in adapter.c","message":"jtag/adapter: move \u0027usb location\u0027 code in adapter.c\n\nThe configuration code for adapter parameters is spread around.\n\nAdd a struct in adapter.c aimed at containing all the adapter\u0027s\nconfiguration data.\nMove in adapter.c the code related to configuring \u0027usb location\u0027\nand the copyright tag.\nAdd adapter.h to export the functions.\nWhile there:\n- rework the copyright and the SPDX tag;\n- rename the \u0027usb location\u0027 functions;\n- remove the JTAG_SRC variable in Makefile.am.\n\nChange-Id: I4fe0d32991a8a30e315807180688035ae9ee01ce\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6640\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"5aeae6ece9a655e60a61d9151ab7b20b43600409":{"kind":"REWORK","_number":1,"created":"2021-10-08 17:02:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/40/6640/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/40/6640/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/1 \u0026\u0026 git checkout -b change-6640 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/40/6640/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/40/6640/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b97813b615b90d0bc5e2a3b824d83b485c7b71c8","subject":"jtag/core: get rid of variable \u0027jtag\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-06 21:17:30.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-08 16:59:53.000000000","tz":120},"subject":"jtag/adapter: move \u0027usb location\u0027 code in adapter.c","message":"jtag/adapter: move \u0027usb location\u0027 code in adapter.c\n\nThe configuration code for adapter parameters is spread around.\n\nAdd a struct in adapter.c aimed at containing all the adapter\u0027s\nconfiguration data.\nMove in adapter.c the code related to configuring \u0027usb location\u0027\nand the copyright tag.\nAdd adapter.h to export the functions.\nWhile there:\n- rework the copyright and the SPDX tag;\n- rename the \u0027usb location\u0027 functions;\n- remove the JTAG_SRC variable in Makefile.am.\n\nChange-Id: I4fe0d32991a8a30e315807180688035ae9ee01ce\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}