)]}'
{"id":"openocd~master~I2b38975a0cd2e74d3d2de6c56ea17818ff225fd8","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-13 10:47:17.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I2b38975a0cd2e74d3d2de6c56ea17818ff225fd8","subject":"jtag: move adapter init/quit and speed to adapter.c","status":"MERGED","created":"2021-10-08 17:02:28.000000000","updated":"2021-11-13 10:47:23.000000000","submitted":"2021-11-13 10:47:23.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6641","meta_rev_id":"6ed16ebe72ffb07fea30e251ffaf4177f4270c90","_number":6641,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:47:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-13 10:47:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:47:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-08 19:10:27.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-02 11:43:54.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"67c5be81f4e93aad8bb2ec95e45a22c79c11934d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-08 17:02:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"416dac3d98fc86a3b71a78f22a42338441570239","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-08 19:10:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15411/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14630/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4ffd105d72ca7921fe4fa0209a22f0435e599fda","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-18 10:03:40.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"bbf4ba80f4e71b4cb4b8bc1149217593399a02c5","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-02 11:43:54.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f5b91c0d497b4af0437ab7b250cba305e340e892","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-13 10:47:17.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6ed16ebe72ffb07fea30e251ffaf4177f4270c90","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-13 10:47:23.000000000","message":"Change has been successfully cherry-picked as b8ec1d4e7ddcb4cc3993a2d31225fd17527f267d","accounts_in_message":[],"_revision_number":2}],"current_revision":"b8ec1d4e7ddcb4cc3993a2d31225fd17527f267d","revisions":{"b8ec1d4e7ddcb4cc3993a2d31225fd17527f267d":{"kind":"REWORK","_number":2,"created":"2021-11-13 10:47:23.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/41/6641/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/6641/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/2 \u0026\u0026 git checkout -b change-6641 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/6641/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4cb3c9fae2a6a6cb5cf2c664179edace22abf5f6","subject":"jtag/adapter: move \u0027usb location\u0027 code in adapter.c"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-07 10:13:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-13 10:47:23.000000000","tz":0},"subject":"jtag: move adapter init/quit and speed to adapter.c","message":"jtag: move adapter init/quit and speed to adapter.c\n\nThe configuration code for adapter parameters is spread around.\n\nMove in adapter.c the code that handles the configuration of\nadapter speed.\nFor convenience, move also the functions adapter_init() and\nadapter_quit(), that anyway have no reason to be in file core.c\n\nTo simplify the review, the code moved is not modified. It will be\ncleaned and adapted in the following changes.\n\nChange-Id: I2b38975a0cd2e74d3d2de6c56ea17818ff225fd8\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6641\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"2d4068304ca2e30ff466fe3d96d47ad4cc9fd6f9":{"kind":"REWORK","_number":1,"created":"2021-10-08 17:02:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/41/6641/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/6641/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/1 \u0026\u0026 git checkout -b change-6641 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/6641/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/6641/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5aeae6ece9a655e60a61d9151ab7b20b43600409","subject":"jtag/adapter: move \u0027usb location\u0027 code in adapter.c"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-07 10:13:28.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-08 16:59:53.000000000","tz":120},"subject":"jtag: move adapter init/quit and speed to adapter.c","message":"jtag: move adapter init/quit and speed to adapter.c\n\nThe configuration code for adapter parameters is spread around.\n\nMove in adapter.c the code that handles the configuration of\nadapter speed.\nFor convenience, move also the functions adapter_init() and\nadapter_quit(), that anyway have no reason to be in file core.c\n\nTo simplify the review, the code moved is not modified. It will be\ncleaned and adapted in the following changes.\n\nChange-Id: I2b38975a0cd2e74d3d2de6c56ea17818ff225fd8\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}