)]}'
{"id":"openocd~master~I38909918079b2c1797ad85ebec2fea1b33743606","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-28 10:59:23.000000000","reason":"Change was submitted"},"1001390":{"account":{"_account_id":1001390,"name":"Edward Fewell","email":"mezcalaficiando@gmail.com"},"last_update":"2021-10-10 20:45:01.000000000","reason":"Edward Fewell replied on the change"}},"hashtags":[],"change_id":"I38909918079b2c1797ad85ebec2fea1b33743606","subject":"jtag/xds110: switch to command \u0027adapter serial\u0027","status":"MERGED","created":"2021-10-08 17:02:28.000000000","updated":"2021-11-28 10:59:23.000000000","submitted":"2021-11-28 10:59:23.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6655","meta_rev_id":"477bc084ef923b9141d3cfeee925e138c74ff566","_number":6655,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-28 10:59:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001390,"name":"Edward Fewell","email":"mezcalaficiando@gmail.com"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-28 10:59:23.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-28 10:59:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001390,"name":"Edward Fewell","email":"mezcalaficiando@gmail.com"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001390,"name":"Edward Fewell","email":"mezcalaficiando@gmail.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-08 22:14:14.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-10-09 09:10:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001390,"name":"Edward Fewell","email":"mezcalaficiando@gmail.com"},"state":"REVIEWER"},{"updated":"2021-11-03 17:07:40.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2021-11-22 00:07:21.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"c42a179ccd9e9449f857d1f704ce3cd52daeb5cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-08 17:02:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6528f78664465647b44092b35ce110c0f300b725","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-08 22:14:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15424/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14644/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a6f34616e525970a94e240341fafa4e33f4e6f56","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-09 09:10:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3f495eb31f63a418216019982ca7cc617cf756a5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-09 09:11:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e1e4ba8fa6fc6bd904195f0f098d0927b08cc532","author":{"_account_id":1001390,"name":"Edward Fewell","email":"mezcalaficiando@gmail.com"},"real_author":{"_account_id":1001390,"name":"Edward Fewell","email":"mezcalaficiando@gmail.com"},"date":"2021-10-10 20:45:01.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"39da8fd3fe82e4dd9e9b68b11907367aeaf0c11c","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-03 17:07:40.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"610c4898c4dd8959e2ce5c8bf88a310aea79f483","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-21 21:40:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9f9f09a7fd78b47291174e0eee08617203f1cbda","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-21 21:49:15.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ec847c55a0e7e5a14e459e9a53661bfa2b17c421","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-22 00:07:21.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c96a29012f319de9e118fef16d4674193b12f44e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-22 00:42:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15607/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14824/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"477bc084ef923b9141d3cfeee925e138c74ff566","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-28 10:59:23.000000000","message":"Change has been successfully cherry-picked as 61a2f3284b984abee0ffd1166ecd79a0ea82976e","accounts_in_message":[],"_revision_number":3}],"current_revision":"61a2f3284b984abee0ffd1166ecd79a0ea82976e","revisions":{"0359bd8d52a2561ce65a251760db7f41adaa2e6c":{"kind":"REWORK","_number":2,"created":"2021-11-21 21:40:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/55/6655/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/6655/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/2 \u0026\u0026 git checkout -b change-6655 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/6655/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"be31be6dd5172c583e37104d32f1813730e1c2ac","subject":"jtag/vsllink: switch to command \u0027adapter serial\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-07 21:03:23.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-21 21:27:08.000000000","tz":60},"subject":"jtag/xds110: switch to command \u0027adapter serial\u0027","message":"jtag/xds110: switch to command \u0027adapter serial\u0027\n\nThe driver xds110 defines the command \u0027xds110 serial\u0027 to specify\nthe serial string of the adapter.\n\nRemove and deprecate the driver command, and use \u0027adapter serial\u0027.\n\nNote: the original command \u0027xds110 serial\u0027 used a complex and\nundocumented conversion of the serial number through multibyte\nstring, wide-character string and C cast. The XDS110 I can access\nand the lsusb dumps available through Google don\u0027t show any\nexotic USB serial that require such conversion. The original\ndeveloper doesn\u0027t remember any constraint that mandates such\nconversion (see comments in https://review.openocd.org/4322/).\nThe conversion is removed by this patch.\n\nChange-Id: I38909918079b2c1797ad85ebec2fea1b33743606\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"61a2f3284b984abee0ffd1166ecd79a0ea82976e":{"kind":"REWORK","_number":3,"created":"2021-11-28 10:59:23.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/55/6655/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/6655/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/3 \u0026\u0026 git checkout -b change-6655 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/6655/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"271e5416af975b52d4cd0e2ced65a4cbda9d041f","subject":"jtag/vsllink: switch to command \u0027adapter serial\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-07 21:03:23.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-28 10:59:23.000000000","tz":0},"subject":"jtag/xds110: switch to command \u0027adapter serial\u0027","message":"jtag/xds110: switch to command \u0027adapter serial\u0027\n\nThe driver xds110 defines the command \u0027xds110 serial\u0027 to specify\nthe serial string of the adapter.\n\nRemove and deprecate the driver command, and use \u0027adapter serial\u0027.\n\nNote: the original command \u0027xds110 serial\u0027 used a complex and\nundocumented conversion of the serial number through multibyte\nstring, wide-character string and C cast. The XDS110 I can access\nand the lsusb dumps available through Google don\u0027t show any\nexotic USB serial that require such conversion. The original\ndeveloper doesn\u0027t remember any constraint that mandates such\nconversion (see comments in https://review.openocd.org/4322/).\nThe conversion is removed by this patch.\n\nChange-Id: I38909918079b2c1797ad85ebec2fea1b33743606\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6655\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nTested-by: jenkins\n"}},"a4b2084d3c2aebcbc3c863e6c85d0104895553a8":{"kind":"REWORK","_number":1,"created":"2021-10-08 17:02:28.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/55/6655/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/55/6655/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/1 \u0026\u0026 git checkout -b change-6655 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/55/6655/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/55/6655/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3494c9b679611a56439c9a1e7ea54d0a21451673","subject":"jtag/vsllink: switch to command \u0027adapter serial\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-07 21:03:23.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-08 17:02:07.000000000","tz":120},"subject":"jtag/xds110: switch to command \u0027adapter serial\u0027","message":"jtag/xds110: switch to command \u0027adapter serial\u0027\n\nThe driver xds110 defines the command \u0027xds110 serial\u0027 to specify\nthe serial string of the adapter.\n\nRemove and deprecate the driver command, and use \u0027adapter serial\u0027.\n\nNote: the original command \u0027xds110 serial\u0027 used a complex and\nundocumented conversion of the serial number through multibyte\nstring, wide-character string and C cast. The XDS110 I can access\nand the lsusb dumps available through Google don\u0027t show any\nexotic USB serial that require such conversion. The original\ndeveloper doesn\u0027t remember any constraint that mandates such\nconversion (see comments in https://review.openocd.org/4322/).\nThe conversion is removed by this patch.\n\nChange-Id: I38909918079b2c1797ad85ebec2fea1b33743606\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}