)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"5e79e051f7c89cafdeb4919eb69ae2c83ebdc37e","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Remove and deprecate the driver command, and use \u0027adapter serial\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: in former code the commands \u0027jlink serial\u0027 and \u0027jlink usb\u0027"},{"line_number":15,"context_line":"were mutually exclusive; running one of them would invalidate the"},{"line_number":16,"context_line":"effect of a previous execution of the other. The new code gives"},{"line_number":17,"context_line":"priority to \u0027adapter serial\u0027, even if executed before \u0027jlink usb\u0027."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I920b0c136716f459b6fd6f7da8a01a7fa1ed389f"},{"line_number":20,"context_line":"Signed-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f8c08236_c818f125","line":17,"range":{"start_line":14,"start_character":0,"end_line":17,"end_character":64},"updated":"2021-10-18 21:25:30.000000000","message":"What is the advantage here? Why would somebody provide both? The \u0027jlink usb\u0027 command is only for legacy reasons anyway.","commit_id":"0363ddf87996d65fb41a19d9e734ff053c096664"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4a59fa19df9e8065145ec7ba6bd753f0f79f49c2","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Remove and deprecate the driver command, and use \u0027adapter serial\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: in former code the commands \u0027jlink serial\u0027 and \u0027jlink usb\u0027"},{"line_number":15,"context_line":"were mutually exclusive; running one of them would invalidate the"},{"line_number":16,"context_line":"effect of a previous execution of the other. The new code gives"},{"line_number":17,"context_line":"priority to \u0027adapter serial\u0027, even if executed before \u0027jlink usb\u0027."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I920b0c136716f459b6fd6f7da8a01a7fa1ed389f"},{"line_number":20,"context_line":"Signed-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"56559163_0b3467a7","line":17,"range":{"start_line":14,"start_character":0,"end_line":17,"end_character":64},"in_reply_to":"c2676a7b_6a3d6ed3","updated":"2021-11-28 11:00:48.000000000","message":"Done","commit_id":"0363ddf87996d65fb41a19d9e734ff053c096664"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6395d23cb564d651a335a8ac103eddf7dc4430b4","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Remove and deprecate the driver command, and use \u0027adapter serial\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: in former code the commands \u0027jlink serial\u0027 and \u0027jlink usb\u0027"},{"line_number":15,"context_line":"were mutually exclusive; running one of them would invalidate the"},{"line_number":16,"context_line":"effect of a previous execution of the other. The new code gives"},{"line_number":17,"context_line":"priority to \u0027adapter serial\u0027, even if executed before \u0027jlink usb\u0027."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I920b0c136716f459b6fd6f7da8a01a7fa1ed389f"},{"line_number":20,"context_line":"Signed-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c2676a7b_6a3d6ed3","line":17,"range":{"start_line":14,"start_character":0,"end_line":17,"end_character":64},"in_reply_to":"f8c08236_c818f125","updated":"2021-10-18 22:27:32.000000000","message":"The advantage is in centralizing the command and the code for \u0027serial\u0027. It would be moved, later, in jtag_usb_common.c so every adapter will use it for free.\nHere I\u0027m just reporting the behavioral change after this patch. It\u0027s not an advantage, just a different behavior. I don\u0027t think anyone will try to use both commands in the same configuration.","commit_id":"0363ddf87996d65fb41a19d9e734ff053c096664"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"17e866079d54f57afdf44a034d2a5ec3b2b19c31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c671af6e_bf7fb5d4","updated":"2021-10-09 09:12:21.000000000","message":"Tested on J-Link clone","commit_id":"0363ddf87996d65fb41a19d9e734ff053c096664"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6395d23cb564d651a335a8ac103eddf7dc4430b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4caeec6e_ed992480","updated":"2021-10-18 22:27:32.000000000","message":"Thanks for the review","commit_id":"0363ddf87996d65fb41a19d9e734ff053c096664"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"c4f3756329cc91e82ec1bb13f189fe1178b6d1a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3eb5b328_79574665","updated":"2021-11-06 09:43:50.000000000","message":"It\u0027s on my TODO list already, probably next week :)","commit_id":"adb42959be862d6dd39119a1f7e87c80d3ce5e0b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6e1c03735aeb23e47c77236d7b488a81f8adcf93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b708a383_3c569ecc","updated":"2021-11-05 23:25:59.000000000","message":"Marc, would you mind reviewing this again?","commit_id":"adb42959be862d6dd39119a1f7e87c80d3ce5e0b"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e96064d4c33bfa0293f6eef1ee76c21ea9ab37ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df971983_8ea7a01c","updated":"2021-11-08 21:59:26.000000000","message":"Works as expected now, thanks!","commit_id":"adb42959be862d6dd39119a1f7e87c80d3ce5e0b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"4a59fa19df9e8065145ec7ba6bd753f0f79f49c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93c84acc_86db775e","updated":"2021-11-28 11:00:48.000000000","message":"gerrit shows merge conflict. Try to solve it with a comment","commit_id":"11fb22a6b4f5eaef365d096a645e2a10fc4c1e5b"}],"src/jtag/drivers/jlink.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"5e79e051f7c89cafdeb4919eb69ae2c83ebdc37e","unresolved":true,"context_lines":[{"line_number":673,"context_line":"\tif (serial) {"},{"line_number":674,"context_line":"\t\tret \u003d jaylink_parse_serial_number(serial, \u0026serial_number);"},{"line_number":675,"context_line":"\t\tif (ret \u003d\u003d JAYLINK_ERR) {"},{"line_number":676,"context_line":"\t\t\tLOG_WARNING(\"Invalid serial number: %s. Ignore it\", serial);"},{"line_number":677,"context_line":"\t\t} else if (ret !\u003d JAYLINK_OK) {"},{"line_number":678,"context_line":"\t\t\tLOG_WARNING(\"jaylink_parse_serial_number() failed: %s\", jaylink_strerror(ret));"},{"line_number":679,"context_line":"\t\t\tjaylink_exit(jayctx);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cecd0e77_ad7263a2","line":676,"range":{"start_line":676,"start_character":0,"end_line":676,"end_character":7},"updated":"2021-10-18 21:25:30.000000000","message":"Why do you ignore invalid serial numbers? I don\u0027t think we should use a \"random\" adapter if the user explicitly provides a serial number (with a typo). In worst case you access the wrong device and something bad happens.","commit_id":"0363ddf87996d65fb41a19d9e734ff053c096664"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6395d23cb564d651a335a8ac103eddf7dc4430b4","unresolved":false,"context_lines":[{"line_number":673,"context_line":"\tif (serial) {"},{"line_number":674,"context_line":"\t\tret \u003d jaylink_parse_serial_number(serial, \u0026serial_number);"},{"line_number":675,"context_line":"\t\tif (ret \u003d\u003d JAYLINK_ERR) {"},{"line_number":676,"context_line":"\t\t\tLOG_WARNING(\"Invalid serial number: %s. Ignore it\", serial);"},{"line_number":677,"context_line":"\t\t} else if (ret !\u003d JAYLINK_OK) {"},{"line_number":678,"context_line":"\t\t\tLOG_WARNING(\"jaylink_parse_serial_number() failed: %s\", jaylink_strerror(ret));"},{"line_number":679,"context_line":"\t\t\tjaylink_exit(jayctx);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"58c8546b_cb599557","line":676,"range":{"start_line":676,"start_character":0,"end_line":676,"end_character":7},"in_reply_to":"cecd0e77_ad7263a2","updated":"2021-10-18 22:27:32.000000000","message":"Ack\nWill send a v2","commit_id":"0363ddf87996d65fb41a19d9e734ff053c096664"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"e96064d4c33bfa0293f6eef1ee76c21ea9ab37ba","unresolved":true,"context_lines":[{"line_number":673,"context_line":"\tif (serial) {"},{"line_number":674,"context_line":"\t\tret \u003d jaylink_parse_serial_number(serial, \u0026serial_number);"},{"line_number":675,"context_line":"\t\tif (ret \u003d\u003d JAYLINK_ERR) {"},{"line_number":676,"context_line":"\t\t\tLOG_ERROR(\"Invalid serial number: %s. Ignore it\", serial);"},{"line_number":677,"context_line":"\t\t\tjaylink_exit(jayctx);"},{"line_number":678,"context_line":"\t\t\treturn ERROR_JTAG_INIT_FAILED;"},{"line_number":679,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"264f6bc7_cbb2e7ff","line":676,"range":{"start_line":676,"start_character":39,"end_line":676,"end_character":50},"updated":"2021-11-08 21:59:26.000000000","message":"Please remove this","commit_id":"adb42959be862d6dd39119a1f7e87c80d3ce5e0b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e4fc3448430e90389be15a119bd635c507e8af05","unresolved":false,"context_lines":[{"line_number":673,"context_line":"\tif (serial) {"},{"line_number":674,"context_line":"\t\tret \u003d jaylink_parse_serial_number(serial, \u0026serial_number);"},{"line_number":675,"context_line":"\t\tif (ret \u003d\u003d JAYLINK_ERR) {"},{"line_number":676,"context_line":"\t\t\tLOG_ERROR(\"Invalid serial number: %s. Ignore it\", serial);"},{"line_number":677,"context_line":"\t\t\tjaylink_exit(jayctx);"},{"line_number":678,"context_line":"\t\t\treturn ERROR_JTAG_INIT_FAILED;"},{"line_number":679,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"933beba6_86157530","line":676,"range":{"start_line":676,"start_character":39,"end_line":676,"end_character":50},"in_reply_to":"08bc9960_37988328","updated":"2021-11-21 21:49:38.000000000","message":"Done","commit_id":"adb42959be862d6dd39119a1f7e87c80d3ce5e0b"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"336d5a2e8c8e3b5b6e12f577bdc1cd670cdcf30f","unresolved":true,"context_lines":[{"line_number":673,"context_line":"\tif (serial) {"},{"line_number":674,"context_line":"\t\tret \u003d jaylink_parse_serial_number(serial, \u0026serial_number);"},{"line_number":675,"context_line":"\t\tif (ret \u003d\u003d JAYLINK_ERR) {"},{"line_number":676,"context_line":"\t\t\tLOG_ERROR(\"Invalid serial number: %s. Ignore it\", serial);"},{"line_number":677,"context_line":"\t\t\tjaylink_exit(jayctx);"},{"line_number":678,"context_line":"\t\t\treturn ERROR_JTAG_INIT_FAILED;"},{"line_number":679,"context_line":"\t\t}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"08bc9960_37988328","line":676,"range":{"start_line":676,"start_character":39,"end_line":676,"end_character":50},"in_reply_to":"264f6bc7_cbb2e7ff","updated":"2021-11-08 22:37:30.000000000","message":"Ooops!","commit_id":"adb42959be862d6dd39119a1f7e87c80d3ce5e0b"}]}