)]}'
{"id":"openocd~master~Ib3b5864afb3b972d952f9b74665201cd93924959","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000160":{"account":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"last_update":"2021-11-05 22:44:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib3b5864afb3b972d952f9b74665201cd93924959","subject":"jtag: drivers: bcm2835gpio: don\u0027t allow GPIOs \u003e 31","status":"MERGED","created":"2021-10-09 20:40:54.000000000","updated":"2021-11-05 22:44:47.000000000","submitted":"2021-11-05 22:44:47.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6658","meta_rev_id":"daa7b3b5e1848ae3a23e78445e3f1b846dfdf090","_number":6658,"owner":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:44:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-05 22:44:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-09 20:53:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-10-09 20:58:45.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"d6d77fd047ba7a348649e9aa0f1cf6dd6c2a53bc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"real_author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"date":"2021-10-09 20:40:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9017eb0922e5ddc6123e2e00cb6dffba571a2cd7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-09 20:53:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15428/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14646/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"75d8385d149b13e414660cb4d44599d02409af11","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-09 20:58:45.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ed5e9a07bd1b5a7f242193a3deeee05380f0d337","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:44:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"daa7b3b5e1848ae3a23e78445e3f1b846dfdf090","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:44:47.000000000","message":"Change has been successfully cherry-picked as da434d7d5975c1c7ebae8e35eb71b6d2d6ad062e","accounts_in_message":[],"_revision_number":2}],"current_revision":"da434d7d5975c1c7ebae8e35eb71b6d2d6ad062e","revisions":{"da434d7d5975c1c7ebae8e35eb71b6d2d6ad062e":{"kind":"REWORK","_number":2,"created":"2021-11-05 22:44:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/58/6658/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/58/6658/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/2 \u0026\u0026 git checkout -b change-6658 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/58/6658/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4afd8852bb320deea553504161bd2c79c434bb1b","subject":"Remove remaining references to FTD2XX driver"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2021-10-09 20:32:01.000000000","tz":180},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-05 22:44:47.000000000","tz":0},"subject":"jtag: drivers: bcm2835gpio: don\u0027t allow GPIOs \u003e 31","message":"jtag: drivers: bcm2835gpio: don\u0027t allow GPIOs \u003e 31\n\nCurrent code assumes all the GPIO signals are manipulated via a single\n32-bit register so using higher GPIOs silently fails.\n\nFix the check instead of trying to handle additional GPIOs (available on\nRaspberry Pi Compute Modules) as that would slow the driver down.\n\nChange-Id: Ib3b5864afb3b972d952f9b74665201cd93924959\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6658\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"a1db10432c09f38375fd95880e0e822820b26426":{"kind":"REWORK","_number":1,"created":"2021-10-09 20:40:54.000000000","uploader":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"ref":"refs/changes/58/6658/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/58/6658/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/1 \u0026\u0026 git checkout -b change-6658 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/58/6658/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/58/6658/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9188115296917ce74ad5b0f83451414735225ce5","subject":"gitignore: Add GNU Global tag files"}],"author":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2021-10-09 20:32:01.000000000","tz":180},"committer":{"name":"Paul Fertser","email":"fercerpav@gmail.com","date":"2021-10-09 20:32:01.000000000","tz":180},"subject":"jtag: drivers: bcm2835gpio: don\u0027t allow GPIOs \u003e 31","message":"jtag: drivers: bcm2835gpio: don\u0027t allow GPIOs \u003e 31\n\nCurrent code assumes all the GPIO signals are manipulated via a single\n32-bit register so using higher GPIOs silently fails.\n\nFix the check instead of trying to handle additional GPIOs (available on\nRaspberry Pi Compute Modules) as that would slow the driver down.\n\nChange-Id: Ib3b5864afb3b972d952f9b74665201cd93924959\nSigned-off-by: Paul Fertser \u003cfercerpav@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
