)]}'
{"id":"openocd~master~Ibf660134d9900173f6592407d5cc2203654a4a1b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-05 22:45:08.000000000","reason":"removed on reply"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2021-11-05 22:45:13.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibf660134d9900173f6592407d5cc2203654a4a1b","subject":"rtos: use struct member names instead of comments","status":"MERGED","created":"2021-10-11 16:57:48.000000000","updated":"2021-11-05 22:45:13.000000000","submitted":"2021-11-05 22:45:13.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6659","meta_rev_id":"0bcafc08d3e3212d800f1f91c17c48b084af69cc","_number":6659,"owner":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:45:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-05 22:45:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:45:13.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-05 22:45:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-11 17:13:45.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-10-16 10:37:18.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2021-10-18 22:43:56.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-10-19 21:18:26.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"d2bc699500be6f4af10bdd13c2c6886701879e5a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-10-11 16:57:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d43782d4931633dc3f31b88c9f477c482c9799c1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-11 17:13:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15429/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14647/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"39333e26fd2b01e3ad814f452beec8e929c41089","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-16 10:37:18.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"9b0c48610850f2ca4aa9e3d28e62568dd21b285b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-10-18 16:17:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"19182693ca8e210c7b9bb97c8805fa57cb6a73b5","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-10-18 16:18:08.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9b199bc4856309eb140023b16d04dbc93a5c3bb5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-18 16:31:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15432/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14650/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"eb5be232a124da80585ed957137453e08d1b3939","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-18 22:43:56.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"03f1ce7b9cb9289f412c4f1bbca03323fa001bf8","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-10-19 17:14:26.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bf8365bc9ad8c39a27a8ab5c040e3f47c9ccdeef","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-10-19 21:18:26.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d082c30e7fde5bcc1446aa3451523ae230d23c06","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-19 22:50:16.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1a772d9170f0d821372b9d7d7b6f889f32f00af9","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-10-20 15:43:33.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"0c0432c7188c4c495a703bdaead727fdb2e9f031","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-10-20 15:44:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"cc4b4c73182638923b37dd2bc50fdc176ede2c9c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:45:08.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0bcafc08d3e3212d800f1f91c17c48b084af69cc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 22:45:13.000000000","message":"Change has been successfully cherry-picked as 5148a1324aeef62d85aaeaa1c061df8e874e4c12","accounts_in_message":[],"_revision_number":3}],"current_revision":"5148a1324aeef62d85aaeaa1c061df8e874e4c12","revisions":{"cb107284d393223c7c53c9fefc4784b4ea0250c9":{"kind":"REWORK","_number":1,"created":"2021-10-11 16:57:48.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/59/6659/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/6659/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/1 \u0026\u0026 git checkout -b change-6659 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/6659/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9188115296917ce74ad5b0f83451414735225ce5","subject":"gitignore: Add GNU Global tag files"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-10-11 16:56:39.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-10-11 16:57:42.000000000","tz":-420},"subject":"rtos: use struct member names instead of comments","message":"rtos: use struct member names instead of comments\n\nThis is more readable, and as a bonus the compiler will help out if the\ndefinition of the struct changes.\n\nChange-Id: Ibf660134d9900173f6592407d5cc2203654a4a1b\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"5148a1324aeef62d85aaeaa1c061df8e874e4c12":{"kind":"REWORK","_number":3,"created":"2021-11-05 22:45:13.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/59/6659/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/6659/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/3 \u0026\u0026 git checkout -b change-6659 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/6659/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"da434d7d5975c1c7ebae8e35eb71b6d2d6ad062e","subject":"jtag: drivers: bcm2835gpio: don\u0027t allow GPIOs \u003e 31"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-10-11 16:56:39.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-05 22:45:13.000000000","tz":0},"subject":"rtos: use struct member names instead of comments","message":"rtos: use struct member names instead of comments\n\nThis is more readable, and as a bonus the compiler will help out if the\ndefinition of the struct changes.\n\nChange-Id: Ibf660134d9900173f6592407d5cc2203654a4a1b\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6659\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"eff66ece72c4c9efadbca19116f14b5ba995aec8":{"kind":"REWORK","_number":2,"created":"2021-10-18 16:17:54.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/59/6659/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/6659/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/2 \u0026\u0026 git checkout -b change-6659 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/6659/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/6659/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9188115296917ce74ad5b0f83451414735225ce5","subject":"gitignore: Add GNU Global tag files"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-10-11 16:56:39.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-10-18 16:17:47.000000000","tz":-420},"subject":"rtos: use struct member names instead of comments","message":"rtos: use struct member names instead of comments\n\nThis is more readable, and as a bonus the compiler will help out if the\ndefinition of the struct changes.\n\nChange-Id: Ibf660134d9900173f6592407d5cc2203654a4a1b\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}