)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8b1ce9393dbc60cd38eb007f65a5e45e9baf8a2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32347183_66b0755b","updated":"2021-10-16 10:23:48.000000000","message":"riscv only uses target_run_algorithm(), so the fix looks ok.\n\nBut there are also target_start_algorithm(), target_wait_algorithm(), target_run_flash_async_algorithm() and target_run_read_async_algorithm that have the same problem.\n\nTomas, Tarek, all these functions are mainly used for MCU flashing. Would be possible for you to test this change from Tim on a target that uses target_run_algorithm()? What about changing the other functions too?","commit_id":"85032f4c7b5a802ec4d9d962a8fa7c5476e30a85"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"03982c4fdb028541f924d30839d0b29a51df9c41","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4325f52_d4ac971e","in_reply_to":"32347183_66b0755b","updated":"2021-11-06 00:02:33.000000000","message":"Unfortunately I don\u0027t have a 64-bit target to test with. I\u0027m sure there is no problem with 32-bit devices as target_type.h definitions of run_algorithm, start_algorithm and wait_algorithm already use target_addr_t\n\nPlease extend this change to all wrappers, so change target_start_algorithm(), target_wait_algorithm() too.\n\nasync_algos would need more work, they work with buffer pointers.","commit_id":"85032f4c7b5a802ec4d9d962a8fa7c5476e30a85"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"0edeeae21f5995ed4372559b0f583fb685d148ee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b784b51a_7007d5d7","in_reply_to":"a3ee5bf2_ec5cd281","updated":"2021-11-09 18:16:52.000000000","message":"\u003e Please extend this change to all wrappers, so change target_start_algorithm(), target_wait_algorithm() too.\n\nI agree that would be better, but I\u0027m already behind in my upstreaming of changes. Can we agree that this change makes the code better than it was, and those other changes will happen in the future?","commit_id":"85032f4c7b5a802ec4d9d962a8fa7c5476e30a85"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f45d6040c8f876c9b7252d818a27db252372a8eb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3ee5bf2_ec5cd281","in_reply_to":"b4325f52_d4ac971e","updated":"2021-11-06 00:20:24.000000000","message":"BTW Are you aware of any 64-bit target capable to r/w memory directly on running target? Async algos cannot run without it.","commit_id":"85032f4c7b5a802ec4d9d962a8fa7c5476e30a85"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"3e31a96e4e603b180eb5c157f936a3bbf6ebdf0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b363bc52_baff2ce9","updated":"2021-11-15 09:47:11.000000000","message":"Tim, is it ok with you?","commit_id":"ad613c9c2a2513f227a5d51f4a0e428c65afcbad"}]}