)]}'
{"id":"openocd~master~I75b3482d38f8ed3418329f3106c5e8b689fd460b","project":"openocd","branch":"master","hashtags":[],"change_id":"I75b3482d38f8ed3418329f3106c5e8b689fd460b","subject":"drivers: call adapter_get_required_serial() in jtag_libusb_open()","status":"MERGED","created":"2021-10-22 09:23:20.000000000","updated":"2021-11-28 11:01:32.000000000","submitted":"2021-11-28 11:01:32.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6663","meta_rev_id":"649d7722cef18cf103f9dc60898ba0c6d10d857c","_number":6663,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-28 11:01:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-28 11:01:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-22 09:51:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4f3f576cab60f577fe8ea69f141d42b86c41832c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-22 09:23:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c3adfa4da1dda8b321fdd3187e52d2db7b0958a1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-22 09:51:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15436/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14654/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"0e4781a5caef32bac5ade20a4964c60212d51f24","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-22 10:44:23.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6b15e1c3a3c966a28ae0c02e16ad3910e8020eac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-25 16:31:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"442d22c49b3c5ad1a9a6abd7af9c3ba2e9d4f157","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-10-25 16:44:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15438/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14656/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"30d00707988c91ec329a82552bd6bc5c24cbdb41","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-10-25 18:04:56.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d8faa9eeeb601598b49f4e4e2a428e1204e43ac4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-21 21:40:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5dac9489dad917b17d59c6266ddd47c1940b7f4a","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-21 21:50:48.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"e0ea3478fe88f37b233218730516d85bfc863931","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-22 01:01:34.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15609/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14825/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"bbac34c5efb49a5ad66d83f01911d4d95501ce64","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-28 11:01:26.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"649d7722cef18cf103f9dc60898ba0c6d10d857c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-28 11:01:32.000000000","message":"Change has been successfully cherry-picked as 1d1386e31ed47dcdd9b433b810b27a0f28928bc7","accounts_in_message":[],"_revision_number":4}],"current_revision":"1d1386e31ed47dcdd9b433b810b27a0f28928bc7","revisions":{"8b6f218ef26113c6f7d73fc8a38124b883c46878":{"kind":"REWORK","_number":1,"created":"2021-10-22 09:23:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/6663/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/6663/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/1 \u0026\u0026 git checkout -b change-6663 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/6663/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c4a0ae9243d09bb0c868b35081ddd9d89cf34190","subject":"jtag/hla, jtag/stlink: switch to command \u0027adapter serial\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-19 11:09:25.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-19 11:09:25.000000000","tz":120},"subject":"drivers: extend jtag_libusb_open() to use the adapter serial","message":"drivers: extend jtag_libusb_open() to use the adapter serial\n\nNow that adapter serial is handled independently from the adapter\ndriver, move it inside jtag_libusb_open() so every adapter that\nuses libusb will automagically get USB serial support.\n\nExtend the documentation to list the adapters involved.\n\nChange-Id: I75b3482d38f8ed3418329f3106c5e8b689fd460b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"a42f036340abad0bebc55a195f9d7e89e69d5ef6":{"kind":"REWORK","_number":2,"created":"2021-10-25 16:31:39.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/6663/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/6663/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/2 \u0026\u0026 git checkout -b change-6663 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/6663/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c4a0ae9243d09bb0c868b35081ddd9d89cf34190","subject":"jtag/hla, jtag/stlink: switch to command \u0027adapter serial\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-19 11:09:25.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-25 16:28:13.000000000","tz":120},"subject":"drivers: call adapter_get_serial() in jtag_libusb_open()","message":"drivers: call adapter_get_serial() in jtag_libusb_open()\n\nNow that adapter serial is handled independently from the adapter\ndrivers, move inside jtag_libusb_open() the call to\nadapter_get_serial(), so every adapter that uses libusb will\nautomagically get USB serial support.\n\nExtend the documentation to list the adapters involved.\n\nChange-Id: I75b3482d38f8ed3418329f3106c5e8b689fd460b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9d2c01cff9952e599062d9ec552121898aa625f9":{"kind":"REWORK","_number":3,"created":"2021-11-21 21:40:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/6663/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/6663/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/3 \u0026\u0026 git checkout -b change-6663 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/6663/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"df8811bcafe258c9dceff4f3aa0787cc93eb5a19","subject":"jtag/hla, jtag/stlink: switch to command \u0027adapter serial\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-19 11:09:25.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-21 21:31:02.000000000","tz":60},"subject":"drivers: call adapter_get_required_serial() in jtag_libusb_open()","message":"drivers: call adapter_get_required_serial() in jtag_libusb_open()\n\nNow that adapter serial is handled independently from the adapter\ndrivers, move inside jtag_libusb_open() the call to\nadapter_get_required_serial(), so every adapter that uses libusb\nwill automagically get USB serial support.\n\nExtend the documentation to list the adapters involved.\n\nChange-Id: I75b3482d38f8ed3418329f3106c5e8b689fd460b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"1d1386e31ed47dcdd9b433b810b27a0f28928bc7":{"kind":"REWORK","_number":4,"created":"2021-11-28 11:01:32.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/63/6663/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/63/6663/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/4 \u0026\u0026 git checkout -b change-6663 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/63/6663/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/63/6663/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c6460ea36d7eeaf4a0fe4fb1a4c65bb21547afbe","subject":"jtag/hla, jtag/stlink: switch to command \u0027adapter serial\u0027"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-10-19 11:09:25.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-28 11:01:32.000000000","tz":0},"subject":"drivers: call adapter_get_required_serial() in jtag_libusb_open()","message":"drivers: call adapter_get_required_serial() in jtag_libusb_open()\n\nNow that adapter serial is handled independently from the adapter\ndrivers, move inside jtag_libusb_open() the call to\nadapter_get_required_serial(), so every adapter that uses libusb\nwill automagically get USB serial support.\n\nExtend the documentation to list the adapters involved.\n\nChange-Id: I75b3482d38f8ed3418329f3106c5e8b689fd460b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6663\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}