)]}'
{"id":"openocd~master~I6166565fc9040b03d3fca5c3aa44a1ccbcf96ad2","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2021-11-09 10:50:43.000000000","reason":"Jan Matyas replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-05 15:25:25.000000000","reason":"Antonio Borneo replied on the change"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2021-11-01 16:14:16.000000000","reason":"Tim Newsome replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-13 10:51:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6166565fc9040b03d3fca5c3aa44a1ccbcf96ad2","subject":"helper/log: Add macros for target-related errors/warnings/...","status":"MERGED","created":"2021-11-01 14:33:39.000000000","updated":"2021-11-13 10:51:52.000000000","submitted":"2021-11-13 10:51:52.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6667","meta_rev_id":"710a7ef6bcf74c1793dc35215711027349d4870d","_number":6667,"owner":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:51:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-13 10:51:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:51:52.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:51:52.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:51:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-01 14:36:22.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2021-11-01 14:36:22.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-11-01 14:41:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-03 20:52:38.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2021-11-03 21:54:55.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"31dbd345f0f93bfb4ca45108bebf2c9f2acaea65","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-01 14:33:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ba2997de3b3b8b030ea10566489d495376cc7f9a","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-01 14:36:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"97bdf5db1a5ed49008bdd25fb8f66fdd582266f7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-01 14:41:18.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"c419825a3d1422a2cc431cbc57d2ef48ed02a0b4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-01 14:41:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/14662/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/15444/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8e23d2e9aa556334453ce239315ea0b3513dd019","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-01 15:00:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15445/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14663/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"5fa43e3ab960b5ba6a49ebe941aeaf450c326b61","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-11-01 16:14:16.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9bd7248fe0b2e74119701d3b30ca1d16a2923862","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-03 20:52:38.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"60a4b775c992299d371458ca7a25c83f280cb252","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-03 21:54:55.000000000","message":"Patch Set 2: Code-Review+1\n\nI love this, it\u0027s solving nightmares in multicore and jtag chain cases","accounts_in_message":[],"_revision_number":2},{"id":"c61fe341dfce71fe9bb820e4411b25df61fc747e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 15:25:25.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"27ebff1332b3d2b00e4c2abb3e020b9073737064","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-08 06:16:55.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bbea03a2338808bcf2acc33b6ef862464c010a17","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-08 06:58:25.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"335f45d4fd6cc7a0368ae43aba4aa54b6deb6b8b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-09 10:41:55.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b19b64b6938f08d5a12eceedcdbeb4182e4a6ef9","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2021-11-09 10:50:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"710a7ef6bcf74c1793dc35215711027349d4870d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-13 10:51:52.000000000","message":"Change has been successfully cherry-picked as a4f8bf7a9041eb37cf5b8df441935664809f13ac","accounts_in_message":[],"_revision_number":3}],"current_revision":"a4f8bf7a9041eb37cf5b8df441935664809f13ac","revisions":{"a4f8bf7a9041eb37cf5b8df441935664809f13ac":{"kind":"REWORK","_number":3,"created":"2021-11-13 10:51:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/6667/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6667/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/3 \u0026\u0026 git checkout -b change-6667 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6667/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e9a569aa18230766ae0bb6dd1a6dc843eb8c087b","subject":"jtag/adapter: fix memory leak on usb location"}],"author":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-11-01 14:28:28.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-13 10:51:52.000000000","tz":0},"subject":"helper/log: Add macros for target-related errors/warnings/...","message":"helper/log: Add macros for target-related errors/warnings/...\n\nThis commit introduces macros for target related log entries\n(error, warning, ...) which is a very common operation in OpenOCD:\n\n* LOG_TARGET_ERROR\n* LOG_TARGET_WARNING\n* LOG_TARGET_INFO\n* LOG_TARGET_DEBUG\n* LOG_TARGET_DEBUG_IO\n\nThe goal is to have one macro for this common operation and to\nmake such log entries look the same way - to make it more readable\nfor humans as well easier for parsing via scripts.\n\nChange-Id: I6166565fc9040b03d3fca5c3aa44a1ccbcf96ad2\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6667\nTested-by: jenkins\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d83525a630087321b00115ef4f2435b62f63a60a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-11-01 14:41:18.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/67/6667/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6667/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/2 \u0026\u0026 git checkout -b change-6667 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6667/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"97db87c22eec204edfebd55973ee1211a1dba6d3","subject":"jtag/core: remove unused variable"}],"author":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-11-01 14:28:28.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-11-01 14:40:42.000000000","tz":60},"subject":"helper/log: Add macros for target-related errors/warnings/...","message":"helper/log: Add macros for target-related errors/warnings/...\n\nThis commit introduces macros for target related log entries\n(error, warning, ...) which is a very common operation in OpenOCD:\n\n* LOG_TARGET_ERROR\n* LOG_TARGET_WARNING\n* LOG_TARGET_INFO\n* LOG_TARGET_DEBUG\n* LOG_TARGET_DEBUG_IO\n\nThe goal is to have one macro for this common operation and to\nmake such log entries look the same way - to make it more readable\nfor humans as well easier for parsing via scripts.\n\nChange-Id: I6166565fc9040b03d3fca5c3aa44a1ccbcf96ad2\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}},"a379182aae4ab84187558d7c8a820d05e4f78048":{"kind":"REWORK","_number":1,"created":"2021-11-01 14:33:39.000000000","uploader":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"ref":"refs/changes/67/6667/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6667/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/1 \u0026\u0026 git checkout -b change-6667 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6667/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6667/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"97db87c22eec204edfebd55973ee1211a1dba6d3","subject":"jtag/core: remove unused variable"}],"author":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-11-01 14:28:28.000000000","tz":60},"committer":{"name":"Jan Matyas","email":"matyas@codasip.com","date":"2021-11-01 14:28:28.000000000","tz":60},"subject":"helper/log: Add macros for target-related errors/warnings/...","message":"helper/log: Add macros for target-related errors/warnings/...\n\nThis commit introduces macros for a target related log entries\n(error, warning, ...) which is a very common operation in OpenOCD:\n\n* LOG_TARGET_ERROR\n* LOG_TARGET_WARNING\n* LOG_TARGET_INFO\n* LOG_TARGET_DEBUG\n* LOG_TARGET_DEBUG_IO\n\nThe goal is to have one macro for this common operation and to\nmake such log entries look the same way - to make it more readable\nfor humans as well easier for parsing via scripts.\n\nChange-Id: I6166565fc9040b03d3fca5c3aa44a1ccbcf96ad2\nSigned-off-by: Jan Matyas \u003cmatyas@codasip.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}