)]}'
{"id":"openocd~master~I46cc60c231b4cc52f150ead268f843bc60c41149","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-05 15:14:04.000000000","reason":"Antonio Borneo replied on the change"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-11-13 10:52:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I46cc60c231b4cc52f150ead268f843bc60c41149","subject":"stlink (tcp): manage scattered stlink-server responses","status":"MERGED","created":"2021-11-05 14:40:51.000000000","updated":"2021-11-13 10:52:25.000000000","submitted":"2021-11-13 10:52:25.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6671","meta_rev_id":"3f448858abdbedcc0bfc0e0a1efc8035fcf7191b","_number":6671,"owner":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:52:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-13 10:52:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-13 10:52:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-05 14:43:14.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-11-05 14:54:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"db6d2be229780038f64e30166d4248200a10b7b6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-05 14:40:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f2c31833c54690fc626bad52659681e43c693cbb","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-05 14:54:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15450/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14668/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"cceb014a294f3ce60d752f31549ab840235745ad","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-05 15:14:04.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c03ab3705778e8ce3e03325b81c16ab387e1122a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-11 22:59:22.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"52c08da12ff9eaa077ee38edeadc9d4aaa1ef74d","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-11 23:05:35.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8cb0d0b0ee3329c35418bdc410b8306ac21e5fc2","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-11 23:16:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15505/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14723/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"cc37bb542411f55a1796db5d8e17058cd6e60be5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-13 10:52:19.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3f448858abdbedcc0bfc0e0a1efc8035fcf7191b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-13 10:52:25.000000000","message":"Change has been successfully cherry-picked as 3f778c7c63cbd293c30144a88c041f845f1eb46d","accounts_in_message":[],"_revision_number":3}],"current_revision":"3f778c7c63cbd293c30144a88c041f845f1eb46d","revisions":{"86a836fc0d9eaefc9f6dadb34e25cd6fec4276ce":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-11-11 22:59:22.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/71/6671/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6671/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/2 \u0026\u0026 git checkout -b change-6671 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6671/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2ab2241f20fd3da11c92f8edde4639ab8ce996f","subject":"jimtcl: revert temporary workaround for memory leak in jimtcl 0.80"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-11-03 15:22:22.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-11-11 20:45:23.000000000","tz":60},"subject":"stlink (tcp): manage scattered stlink-server responses","message":"stlink (tcp): manage scattered stlink-server responses\n\ndetected in ubuntu 20.04\nsometimes, the stlink-server response could be segmented on multiple\npackets.\n\nthis causes stlink_tcp_send_cmd to fail with the following msg:\nError: failed to receive USB CMD response\nbecause the received_size \u003c expected size\n\nto fix the issue, do recv in a loop till all data is received\nor timeout is reached.\n\nChange-Id: I46cc60c231b4cc52f150ead268f843bc60c41149\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"3f778c7c63cbd293c30144a88c041f845f1eb46d":{"kind":"REWORK","_number":3,"created":"2021-11-13 10:52:25.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/6671/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6671/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/3 \u0026\u0026 git checkout -b change-6671 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6671/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a4f8bf7a9041eb37cf5b8df441935664809f13ac","subject":"helper/log: Add macros for target-related errors/warnings/..."}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-11-03 15:22:22.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-13 10:52:25.000000000","tz":0},"subject":"stlink (tcp): manage scattered stlink-server responses","message":"stlink (tcp): manage scattered stlink-server responses\n\ndetected in ubuntu 20.04\nsometimes, the stlink-server response could be segmented on multiple\npackets.\n\nthis causes stlink_tcp_send_cmd to fail with the following msg:\nError: failed to receive USB CMD response\nbecause the received_size \u003c expected size\n\nto fix the issue, do recv in a loop till all data is received\nor timeout is reached.\n\nChange-Id: I46cc60c231b4cc52f150ead268f843bc60c41149\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6671\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"586e2e1faa9a74d88e7ec83744057138c97a1c53":{"kind":"REWORK","_number":1,"created":"2021-11-05 14:40:51.000000000","uploader":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"ref":"refs/changes/71/6671/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6671/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/1 \u0026\u0026 git checkout -b change-6671 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6671/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6671/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"64f9e1d6b4eb89a8e69014df99021abdf74e27a7","subject":"stlink: skip rw-misc commands with TCP server"}],"author":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-11-03 15:22:22.000000000","tz":60},"committer":{"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","date":"2021-11-05 14:40:22.000000000","tz":60},"subject":"stlink (tcp): manage scattered stlink-server responses","message":"stlink (tcp): manage scattered stlink-server responses\n\ndetected in ubuntu 20.04\nsometimes, the stlink-server response could be segmented on multiple\npackets.\n\nthis causes stlink_tcp_send_cmd to fail with the following msg:\nError: failed to receive USB CMD response\nbecause the received_size \u003c expected size\n\nto fix the issue, do recv in a loop till all data is received\nor timeout is reached.\n\nChange-Id: I46cc60c231b4cc52f150ead268f843bc60c41149\nSigned-off-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}