)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"4259beaa0ab4ecd01d4ff1c1007c4841efb8164f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80733627_064eaf42","updated":"2021-11-11 15:54:22.000000000","message":"Checked visually, looks all right.","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"7afae74c13d13aa4dd579fc08ac1cd3d9df559a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b65e9bd8_48068ba4","updated":"2021-11-11 17:58:15.000000000","message":"any thought regarding these empty debug messages ?","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"63e18e34d514945a74aa61598e8339257eed3c78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"46303987_8d34a065","updated":"2021-11-05 15:15:30.000000000","message":"applying this change could be heavy on target files, and could cause several conflicts with ongoing changes.","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"0eb57a49fde0e5e933ec815b30e93595008d95c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a4b2c79_4aa3feb8","updated":"2022-02-25 16:06:37.000000000","message":"rebased, considering the new logs introduced in the fast reg RW series","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"d090f7de0d2c6c6c7adeda66cd1b89288d4512e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb2935bf_a928c45a","in_reply_to":"1896d5f9_dcf48a5f","updated":"2021-11-08 09:24:02.000000000","message":"If I think about the 0.12.0 I would be interested to get have these cortex_m patches:\n\n  6180: target/cortex_m: cumulate DHCSR sticky bits | \n        https://review.openocd.org/c/openocd/+/6180\n  5319: cortex_m: poll S_REGRDY on register r/w | \n        https://review.openocd.org/c/openocd/+/5319\n  5321: target/cortex_m: faster reading of all CPU registers | \n        https://review.openocd.org/c/openocd/+/5321\n\nI will restore my +1 on this change, and see how it goes for the others as they need a rework anyway.","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"033fc6f15fc78f51c46dd47825321907e2823c02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1896d5f9_dcf48a5f","in_reply_to":"46303987_8d34a065","updated":"2021-11-05 15:29:42.000000000","message":"gerrit show only 16 changes in conflict and some are really old and does not apply anymore on HEAD.\nMaybe you could check what is still relevant and propose this patch to be applied after them.","commit_id":"6fd613a32846cf069bd40b66b051935910126588"}],"src/target/cortex_m.c":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"7afae74c13d13aa4dd579fc08ac1cd3d9df559a4","unresolved":true,"context_lines":[{"line_number":318,"context_line":"\t\t\tDBGKEY | C_MASKINTS | C_STEP | C_DEBUGEN);"},{"line_number":319,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":320,"context_line":"\t\treturn retval;"},{"line_number":321,"context_line":"\tLOG_TARGET_DEBUG(target, \" \");"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"\t/* restore dhcsr reg */"},{"line_number":324,"context_line":"\tcortex_m_clear_halt(target);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fb6a4e95_80694d4a","line":321,"range":{"start_line":321,"start_character":1,"end_line":321,"end_character":31},"updated":"2021-11-11 17:58:15.000000000","message":"can we remove this ?","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"0eb57a49fde0e5e933ec815b30e93595008d95c1","unresolved":false,"context_lines":[{"line_number":318,"context_line":"\t\t\tDBGKEY | C_MASKINTS | C_STEP | C_DEBUGEN);"},{"line_number":319,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":320,"context_line":"\t\treturn retval;"},{"line_number":321,"context_line":"\tLOG_TARGET_DEBUG(target, \" \");"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"\t/* restore dhcsr reg */"},{"line_number":324,"context_line":"\tcortex_m_clear_halt(target);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5b0278a7_dd47b38e","line":321,"range":{"start_line":321,"start_character":1,"end_line":321,"end_character":31},"in_reply_to":"758c83e4_fa3ac7eb","updated":"2022-02-25 16:06:37.000000000","message":"Done","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2325d4a2a94878dfcfe9fc90d243689cf99c93e0","unresolved":true,"context_lines":[{"line_number":318,"context_line":"\t\t\tDBGKEY | C_MASKINTS | C_STEP | C_DEBUGEN);"},{"line_number":319,"context_line":"\tif (retval !\u003d ERROR_OK)"},{"line_number":320,"context_line":"\t\treturn retval;"},{"line_number":321,"context_line":"\tLOG_TARGET_DEBUG(target, \" \");"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"\t/* restore dhcsr reg */"},{"line_number":324,"context_line":"\tcortex_m_clear_halt(target);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"758c83e4_fa3ac7eb","line":321,"range":{"start_line":321,"start_character":1,"end_line":321,"end_character":31},"in_reply_to":"fb6a4e95_80694d4a","updated":"2021-11-11 21:21:53.000000000","message":"Very old stuff present in original cortex_m3 code from 2007.\nDon\u0027t remove - it shows function name which is self-explaining here - useful for orientation in log.\nWe can replace empty msg by some text like \"single step\"","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"7afae74c13d13aa4dd579fc08ac1cd3d9df559a4","unresolved":true,"context_lines":[{"line_number":548,"context_line":"\tstruct arm *arm \u003d \u0026armv7m-\u003earm;"},{"line_number":549,"context_line":"\tstruct reg *r;"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"\tLOG_TARGET_DEBUG(target, \" \");"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"\t/* Do this really early to minimize the window where the MASKINTS erratum"},{"line_number":554,"context_line":"\t * can pile up pending interrupts. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d952b3ea_e19d1098","line":551,"range":{"start_line":551,"start_character":1,"end_line":551,"end_character":31},"updated":"2021-11-11 17:58:15.000000000","message":"this too ?","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"0eb57a49fde0e5e933ec815b30e93595008d95c1","unresolved":false,"context_lines":[{"line_number":548,"context_line":"\tstruct arm *arm \u003d \u0026armv7m-\u003earm;"},{"line_number":549,"context_line":"\tstruct reg *r;"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"\tLOG_TARGET_DEBUG(target, \" \");"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"\t/* Do this really early to minimize the window where the MASKINTS erratum"},{"line_number":554,"context_line":"\t * can pile up pending interrupts. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9fc764a5_bbe6693b","line":551,"range":{"start_line":551,"start_character":1,"end_line":551,"end_character":31},"in_reply_to":"60e777ce_c2f87a6f","updated":"2022-02-25 16:06:37.000000000","message":"Ack","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2325d4a2a94878dfcfe9fc90d243689cf99c93e0","unresolved":true,"context_lines":[{"line_number":548,"context_line":"\tstruct arm *arm \u003d \u0026armv7m-\u003earm;"},{"line_number":549,"context_line":"\tstruct reg *r;"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"\tLOG_TARGET_DEBUG(target, \" \");"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"\t/* Do this really early to minimize the window where the MASKINTS erratum"},{"line_number":554,"context_line":"\t * can pile up pending interrupts. */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"60e777ce_c2f87a6f","line":551,"range":{"start_line":551,"start_character":1,"end_line":551,"end_character":31},"in_reply_to":"d952b3ea_e19d1098","updated":"2021-11-11 21:21:53.000000000","message":"Don\u0027t remove","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"7afae74c13d13aa4dd579fc08ac1cd3d9df559a4","unresolved":true,"context_lines":[{"line_number":702,"context_line":"\t\t\ttarget_call_event_callbacks(target, TARGET_EVENT_HALTED);"},{"line_number":703,"context_line":"\t\t}"},{"line_number":704,"context_line":"\t\tif (prev_target_state \u003d\u003d TARGET_DEBUG_RUNNING) {"},{"line_number":705,"context_line":"\t\t\tLOG_TARGET_DEBUG(target, \" \");"},{"line_number":706,"context_line":"\t\t\tretval \u003d cortex_m_debug_entry(target);"},{"line_number":707,"context_line":"\t\t\tif (retval !\u003d ERROR_OK)"},{"line_number":708,"context_line":"\t\t\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"91a19a6e_bbae0f5d","line":705,"range":{"start_line":705,"start_character":3,"end_line":705,"end_character":33},"updated":"2021-11-11 17:58:15.000000000","message":"and this ?","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"0eb57a49fde0e5e933ec815b30e93595008d95c1","unresolved":false,"context_lines":[{"line_number":702,"context_line":"\t\t\ttarget_call_event_callbacks(target, TARGET_EVENT_HALTED);"},{"line_number":703,"context_line":"\t\t}"},{"line_number":704,"context_line":"\t\tif (prev_target_state \u003d\u003d TARGET_DEBUG_RUNNING) {"},{"line_number":705,"context_line":"\t\t\tLOG_TARGET_DEBUG(target, \" \");"},{"line_number":706,"context_line":"\t\t\tretval \u003d cortex_m_debug_entry(target);"},{"line_number":707,"context_line":"\t\t\tif (retval !\u003d ERROR_OK)"},{"line_number":708,"context_line":"\t\t\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"aa9cd2b6_6649556e","line":705,"range":{"start_line":705,"start_character":3,"end_line":705,"end_character":33},"in_reply_to":"2db7c8ca_cc2421ee","updated":"2022-02-25 16:06:37.000000000","message":"Ack","commit_id":"6fd613a32846cf069bd40b66b051935910126588"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"2325d4a2a94878dfcfe9fc90d243689cf99c93e0","unresolved":true,"context_lines":[{"line_number":702,"context_line":"\t\t\ttarget_call_event_callbacks(target, TARGET_EVENT_HALTED);"},{"line_number":703,"context_line":"\t\t}"},{"line_number":704,"context_line":"\t\tif (prev_target_state \u003d\u003d TARGET_DEBUG_RUNNING) {"},{"line_number":705,"context_line":"\t\t\tLOG_TARGET_DEBUG(target, \" \");"},{"line_number":706,"context_line":"\t\t\tretval \u003d cortex_m_debug_entry(target);"},{"line_number":707,"context_line":"\t\t\tif (retval !\u003d ERROR_OK)"},{"line_number":708,"context_line":"\t\t\t\treturn retval;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2db7c8ca_cc2421ee","line":705,"range":{"start_line":705,"start_character":3,"end_line":705,"end_character":33},"in_reply_to":"91a19a6e_bbae0f5d","updated":"2021-11-11 21:21:53.000000000","message":"I think you can remove this one","commit_id":"6fd613a32846cf069bd40b66b051935910126588"}]}