)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5b41bb4c06b289d009ff6bce80c47ad0c396ec57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c0b6c05_b5dee3f9","updated":"2021-11-08 15:39:55.000000000","message":"More info on the STM32MP13 in\nhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm/stm32/stm32mp13-overview.rst","commit_id":"e0e0665c656802dc7c2367a25de548719c14ad14"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"2f800bf4824a5715be22445362916481accf2807","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e632210_aa97e4ba","updated":"2021-11-09 08:41:26.000000000","message":"thanks !","commit_id":"82d7d17198c492847e20ab6ee2cc5abea5b04e38"}],"tcl/target/stm32mp13x.cfg":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"d082f7c2f517e142644a76e811bc9ec8d1417d83","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# HLA does not support custom CSW nor AP other than 0"},{"line_number":5,"context_line":"if { [using_hla] } {"},{"line_number":6,"context_line":"\techo \"ERROR: HLA transport cannot work with this target.\""},{"line_number":7,"context_line":"\techo \"ERROR: To use STLink switch to DAP mode, as in \\\"board/stm32mp13x_dk.cfg\\\".\""},{"line_number":8,"context_line":"\tshutdown"},{"line_number":9,"context_line":"}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3e23abbc_7c1012b3","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":83},"updated":"2021-11-08 15:27:00.000000000","message":"Just nitpicking:\n\nwhat if the user is using a different hla_layout (icdi|nulink)\nI agree this does not make sense.\n\nbut let\u0027s assume that, in that case the second message is not needed.\nand the first one is sufficient.","commit_id":"e0e0665c656802dc7c2367a25de548719c14ad14"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"98e8d206e24edc6f5683de9d6a367d18b02aa158","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# HLA does not support custom CSW nor AP other than 0"},{"line_number":5,"context_line":"if { [using_hla] } {"},{"line_number":6,"context_line":"\techo \"ERROR: HLA transport cannot work with this target.\""},{"line_number":7,"context_line":"\techo \"ERROR: To use STLink switch to DAP mode, as in \\\"board/stm32mp13x_dk.cfg\\\".\""},{"line_number":8,"context_line":"\tshutdown"},{"line_number":9,"context_line":"}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"649cdd8a_761cfdff","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":83},"in_reply_to":"3e23abbc_7c1012b3","updated":"2021-11-08 15:47:02.000000000","message":"Humm, the first line states that HLA will not work. The second line gives a hint on how to use STLink; it does not assumes STLink is used.\nSame code as in targets/stm32mp15x.cfg","commit_id":"e0e0665c656802dc7c2367a25de548719c14ad14"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"d082f7c2f517e142644a76e811bc9ec8d1417d83","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"proc dbgmcu_enable_debug {} {"},{"line_number":78,"context_line":"\t# keep clock enabled in low-power"},{"line_number":79,"context_line":"#\tcatch {$::_CHIPNAME.ap1 mww 0xe0081004 0x00000004}"},{"line_number":80,"context_line":"\t# freeze watchdog 1 and 2 on core halted"},{"line_number":81,"context_line":"\tcatch {$::_CHIPNAME.ap1 mww 0xe008102c 0x00000004}"},{"line_number":82,"context_line":"\tcatch {$::_CHIPNAME.ap1 mww 0xe008104c 0x00000008}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"0edb365b_f30311ce","line":79,"updated":"2021-11-08 15:27:00.000000000","message":"please fix this indentation","commit_id":"e0e0665c656802dc7c2367a25de548719c14ad14"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"98e8d206e24edc6f5683de9d6a367d18b02aa158","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"proc dbgmcu_enable_debug {} {"},{"line_number":78,"context_line":"\t# keep clock enabled in low-power"},{"line_number":79,"context_line":"#\tcatch {$::_CHIPNAME.ap1 mww 0xe0081004 0x00000004}"},{"line_number":80,"context_line":"\t# freeze watchdog 1 and 2 on core halted"},{"line_number":81,"context_line":"\tcatch {$::_CHIPNAME.ap1 mww 0xe008102c 0x00000004}"},{"line_number":82,"context_line":"\tcatch {$::_CHIPNAME.ap1 mww 0xe008104c 0x00000008}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"251f3fb8_162d7a11","line":79,"in_reply_to":"0edb365b_f30311ce","updated":"2021-11-08 15:47:02.000000000","message":"I did it on purpose to discriminate comment from potential useful line, but you are right","commit_id":"e0e0665c656802dc7c2367a25de548719c14ad14"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"d082f7c2f517e142644a76e811bc9ec8d1417d83","unresolved":true,"context_lines":[{"line_number":88,"context_line":"\t$::_CHIPNAME.ap1 mww 0xe00d0fa4 1"},{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# FIXME: most of handler below will be removed once reset framework get merged"},{"line_number":92,"context_line":"$_CHIPNAME.ap1 configure -event reset-deassert-pre  {adapter deassert srst deassert trst;catch {dap init};catch {$::_CHIPNAME.dap apid 1}}"},{"line_number":93,"context_line":"$_CHIPNAME.cpu configure -event reset-deassert-pre  {$::_CHIPNAME.cpu arp_examine}"},{"line_number":94,"context_line":"$_CHIPNAME.cpu configure -event reset-deassert-post {toggle_cpu_dbg_claim0;dbgmcu_enable_debug}"},{"line_number":95,"context_line":"$_CHIPNAME.ap1 configure -event examine-start       {dap init}"},{"line_number":96,"context_line":"$_CHIPNAME.ap1 configure -event examine-end         {dbgmcu_enable_debug}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"a5543715_f933188d","line":96,"range":{"start_line":91,"start_character":0,"end_line":96,"end_character":73},"updated":"2021-11-08 15:27:00.000000000","message":"I may different style opinion:\n - line 92, could be splitted\n - I prefer to have a white space after the semicolon \n\nbut since we don\u0027t have a style guide for TCL scripts, I don\u0027t expect to have a common style applied everywhere.","commit_id":"e0e0665c656802dc7c2367a25de548719c14ad14"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"98e8d206e24edc6f5683de9d6a367d18b02aa158","unresolved":true,"context_lines":[{"line_number":88,"context_line":"\t$::_CHIPNAME.ap1 mww 0xe00d0fa4 1"},{"line_number":89,"context_line":"}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# FIXME: most of handler below will be removed once reset framework get merged"},{"line_number":92,"context_line":"$_CHIPNAME.ap1 configure -event reset-deassert-pre  {adapter deassert srst deassert trst;catch {dap init};catch {$::_CHIPNAME.dap apid 1}}"},{"line_number":93,"context_line":"$_CHIPNAME.cpu configure -event reset-deassert-pre  {$::_CHIPNAME.cpu arp_examine}"},{"line_number":94,"context_line":"$_CHIPNAME.cpu configure -event reset-deassert-post {toggle_cpu_dbg_claim0;dbgmcu_enable_debug}"},{"line_number":95,"context_line":"$_CHIPNAME.ap1 configure -event examine-start       {dap init}"},{"line_number":96,"context_line":"$_CHIPNAME.ap1 configure -event examine-end         {dbgmcu_enable_debug}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"abc35b22_aa330f80","line":96,"range":{"start_line":91,"start_character":0,"end_line":96,"end_character":73},"in_reply_to":"a5543715_f933188d","updated":"2021-11-08 15:47:02.000000000","message":"yes, we don\u0027t have specific coding style but line 92 exceeds 120 chars. Will fix it","commit_id":"e0e0665c656802dc7c2367a25de548719c14ad14"}]}