)]}'
{"id":"openocd~master~I9ef05ce88a9dce42e1d3d5404a4fe87ec86b5fe8","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-09 10:03:12.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I9ef05ce88a9dce42e1d3d5404a4fe87ec86b5fe8","subject":"cortex_m: use cortex_m_write_debug_halt_mask() in cortex_m_single_step_core()","status":"MERGED","created":"2021-11-08 16:02:57.000000000","updated":"2021-11-18 21:07:27.000000000","submitted":"2021-11-18 21:07:27.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6676","meta_rev_id":"00f5b55895eb6c6a9d427cf32daf198af7ca2d3a","_number":6676,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-18 21:07:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-18 21:07:27.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-18 21:07:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-18 21:07:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-08 17:13:25.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-08 21:51:31.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-11-09 08:43:28.000000000","updated_by":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"c5a24fadb54b9970a65a5b69dfefc90673ea7b23","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-08 16:02:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1f44c4b9faf4450248e62cc94db91cd79f87f78d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-08 17:13:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15461/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14679/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a1d76c982eeb4809e7f7274a9d6537a8d6a4e366","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-08 21:51:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"060d3f610d5a9c7f0bdf756df9375dcb6f9adac1","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2021-11-09 08:43:28.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"87cf0f73c53cde8bc763abf5458af9e319d49b5a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-09 10:03:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"00f5b55895eb6c6a9d427cf32daf198af7ca2d3a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 21:07:27.000000000","message":"Change has been successfully cherry-picked as b502947a1427aabe9c4e9ab0b3dd9e45f51e5b62","accounts_in_message":[],"_revision_number":2}],"current_revision":"b502947a1427aabe9c4e9ab0b3dd9e45f51e5b62","revisions":{"b502947a1427aabe9c4e9ab0b3dd9e45f51e5b62":{"kind":"REWORK","_number":2,"created":"2021-11-18 21:07:27.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/76/6676/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/6676/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/2 \u0026\u0026 git checkout -b change-6676 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/6676/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa8a79809ef9e6b97d45da60508d902da0e3270e","subject":"flash/nor/at91samd: Add SAMR35J18B support"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-08 13:24:33.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-18 21:07:27.000000000","tz":0},"subject":"cortex_m: use cortex_m_write_debug_halt_mask() in cortex_m_single_step_core()","message":"cortex_m: use cortex_m_write_debug_halt_mask() in cortex_m_single_step_core()\n\ncortex_m_single_step_core() used mem_ap_write_atomic_u32() to manipulate\ndhcsr bits unlike the rest of code, where a specialized function\ncortex_m_write_debug_halt_mask() takes place.\n\nUnify setting of dhcsr bits and use cortex_m_write_debug_halt_mask() here as well.\n\nExtracted from [1].\n\n[1] Antonio Borneo: 6207: cortex_m: rework handling of dcb_dhcsr\n\nLink: https://review.openocd.org/c/openocd/+/6207\nChange-Id: I9ef05ce88a9dce42e1d3d5404a4fe87ec86b5fe8\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6676\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"996a54fae6c4568d5896a6f5356e7d2e2c940635":{"kind":"REWORK","_number":1,"created":"2021-11-08 16:02:57.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/76/6676/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/76/6676/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/1 \u0026\u0026 git checkout -b change-6676 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/76/6676/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/76/6676/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2ab2241f20fd3da11c92f8edde4639ab8ce996f","subject":"jimtcl: revert temporary workaround for memory leak in jimtcl 0.80"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-08 13:24:33.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-08 15:58:36.000000000","tz":60},"subject":"cortex_m: use cortex_m_write_debug_halt_mask() in cortex_m_single_step_core()","message":"cortex_m: use cortex_m_write_debug_halt_mask() in cortex_m_single_step_core()\n\ncortex_m_single_step_core() used mem_ap_write_atomic_u32() to manipulate\ndhcsr bits unlike the rest of code, where a specialized function\ncortex_m_write_debug_halt_mask() takes place.\n\nUnify setting of dhcsr bits and use cortex_m_write_debug_halt_mask() here as well.\n\nExtracted from [1].\n\n[1] Antonio Borneo: 6207: cortex_m: rework handling of dcb_dhcsr\n\nLink: https://review.openocd.org/c/openocd/+/6207\nChange-Id: I9ef05ce88a9dce42e1d3d5404a4fe87ec86b5fe8\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}